You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Expensify Card - Device back button on confirm page does not return to 4th step after editing #80405
Version Number: 9.3.8-0 Reproducible in staging?: Yes Reproducible in production?: No If this was caught during regression testing, add the test name, ID and link from BrowserStack:#78266 Email or phone of affected tester (no customers):applausetester+snjoidnjios@applause.expensifail.com Issue reported by: Applause Internal Team Bug source: Exploratory - Significant User Experience Deterioration Device used: Mac 26.1 / Chrome App Component: Money Requests
Action Performed:
Precondition:
User is assigned a physical Expensify card.
Go to staging.new.expensify.com
Go to workspace chat.
Click Add shipping details.
Proceed to confirm page.
On confirm page, click Legal name.
Click Confirm.
Click RHP back button on confirm page.
→ RHP returns to the 4th step which is the phone number step.
Click Next.
On confirm page, click Legal name.
Click Confirm.
Click browser or device back button on confirm page.
Expected Result:
RHP will return to the 4th step which is the phone number step.
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
Identify the pull request that introduced this issue and revert it.
Classification: Frontend bug Causing PR: #78266 - "Feat: use sub page hook" by @MrMuzyk (High confidence) Related Issues: None
Recommendation: REVERT
The bug is caused by how the new useSubPage hook handles navigation history in edit mode. When users navigate to a previous step for editing, the hook pushes a new entry to the navigation history stack instead of replacing it. This causes the browser/device back button to navigate to duplicate entries in the history stack rather than the expected previous page.
Labels: No label changes needed - keeping DeployBlockerCash as this is a Frontend (App) bug
The navigateToPage function calls Navigation.navigate() which pushes a new entry to the navigation history stack.
Navigation flow that causes the bug:
User is on confirm page
User clicks "Legal name" to edit → moveTo(0) pushes missing-personal-details/legal-name/edit to history
User clicks RHP back button → Navigation.goBack() pops to confirm page
User clicks "Legal name" again → moveTo(0) pushes anothermissing-personal-details/legal-name/edit to history
User clicks browser back button → pops to the duplicate legal-name/edit entry from step 2 (not to confirm page or phone number page)
Expected behavior: The browser back button should follow the same logic as the RHP back button - return to the confirmation page when in edit mode, or return to the previous step (phone number) when navigating normally.
Fix approach: The moveTo function should use Navigation.navigate(..., {forceReplace: true}) when entering edit mode to replace the current history entry instead of pushing a new one. Alternatively, implement proper browser back button handling that respects the edit mode state.
This behaviour is actually intended and Im not sure whether we want to change it.
Unless user is editing a field from confirmations screen then pressing on `back arrow' from the header should move him back to previous step.
Activity
melvin-bot commentedon Jan 24, 2026
@arosiclair recently merged #78266, but they are OOO right now, so I'll auto-assign someone else.
melvin-bot commentedon Jan 24, 2026
Triggered auto assignment to @twisterdotcom (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.melvin-bot commentedon Jan 24, 2026
Triggered auto assignment to @MarioExpensify (
DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.melvin-bot commentedon Jan 24, 2026
💬 A slack conversation has been started in #expensify-open-source
github-actions commentedon Jan 24, 2026
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
OSBotify commentedon Jan 24, 2026
🔍 Investigation Summary
Classification: Frontend bug
Causing PR: #78266 - "Feat: use sub page hook" by @MrMuzyk (High confidence)
Related Issues: None
Recommendation: REVERT
The bug is caused by how the new
useSubPagehook handles navigation history in edit mode. When users navigate to a previous step for editing, the hook pushes a new entry to the navigation history stack instead of replacing it. This causes the browser/device back button to navigate to duplicate entries in the history stack rather than the expected previous page.Labels: No label changes needed - keeping
DeployBlockerCashas this is a Frontend (App) bug📋 Detailed Analysis
Evidence
Verification
The bug affects the Missing Personal Details flow at:
/home/runner/work/App/App/src/pages/MissingPersonalDetails/MissingPersonalDetailsContent.tsx/home/runner/work/App/App/src/hooks/useSubPage/index.tsxPR #78266 introduced the new
useSubPagehook and refactored the MissingPersonalDetails component to use it. The PR modified these exact files.Root Cause
The issue is in the
moveTofunction (line 87-94 ofsrc/hooks/useSubPage/index.tsx):The
navigateToPagefunction callsNavigation.navigate()which pushes a new entry to the navigation history stack.Navigation flow that causes the bug:
moveTo(0)pushesmissing-personal-details/legal-name/editto historyNavigation.goBack()pops to confirm pagemoveTo(0)pushes anothermissing-personal-details/legal-name/editto historylegal-name/editentry from step 2 (not to confirm page or phone number page)Expected behavior: The browser back button should follow the same logic as the RHP back button - return to the confirmation page when in edit mode, or return to the previous step (phone number) when navigating normally.
Fix approach: The
moveTofunction should useNavigation.navigate(..., {forceReplace: true})when entering edit mode to replace the current history entry instead of pushing a new one. Alternatively, implement proper browser back button handling that respects the edit mode state.4 remaining items
MrMuzyk commentedon Jan 26, 2026
On it
MrMuzyk commentedon Jan 27, 2026
This behaviour is actually intended and Im not sure whether we want to change it.
Unless user is editing a field from confirmations screen then pressing on `back arrow' from the header should move him back to previous step.
@arosiclair wdyt?
arosiclair commentedon Jan 27, 2026
Yeah I think this behavior is fine for now. Let's close this out