You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Submit button shown when delayed submissions & approvals are disabled #70925
Version Number: 9.2.16-0 Reproducible in staging?: Yes Reproducible in production?: No
**If this was caught during regression testing, add the test name, ID and link from TestRail:**Exploarory around #70720 Email or phone of affected tester (no customers): N/A Issue reported by: Applause Internal Team Device used: Windows 11, Chrome App Component: Other
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
Identify the pull request that introduced this issue and revert it.
we check Report is open and instant submit is enabled and it’s a submit & closed isInstantSubmitEnabled is true we disable Delay submissions, making this second condition true
What changes do you think we should make in order to solve the problem?
What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?
N/A
What alternative solutions did you explore? (Optional)
Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.
Before, when a workspace had Instant + no approvals + no payments, using Create report would create a closed report and expenses couldn't be added to it.
It’s in active development to be changed with the ASAP submit rollout/changes, and we’ve completed the part that will now create an open draft report in this flow instead, such that expenses can be added to it. As such, it's expected the Submit button will show in this case. The next step will be to auto-submit the report if the expense(s) added to it are violation free, but that part isn’t done yet.
**If this was caught during regression testing, add the test name, ID and link from TestRail:**Exploarory around #70720
Given that, I see this was "exploratory", but if there is a specific test case for using Create report on a workspace configured for "Instant + no approvals + no payments", can you update it to not recreate this bug report? Thanks!
Activity
melvin-bot commentedon Sep 20, 2025
Triggered auto assignment to @heyjennahay (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.melvin-bot commentedon Sep 20, 2025
Triggered auto assignment to @srikarparsi (
DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.melvin-bot commentedon Sep 20, 2025
💬 A slack conversation has been started in #expensify-open-source
github-actions commentedon Sep 20, 2025
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
samranahm commentedon Sep 20, 2025
Proposal
Please re-state the problem that we are trying to solve in this issue.
Submit button shown when delayed submissions & approvals are disabled
What is the root cause of that problem?
Here
App/src/libs/ReportUtils.ts
Lines 1857 to 1859 in d8ce56d
we check Report is open and instant submit is enabled and it’s a submit & closed
isInstantSubmitEnabledis true we disable Delay submissions, making this second condition trueWhat changes do you think we should make in order to solve the problem?
we should use
!isInstantSubmitEnabledso that if
isInstantSubmitEnabledtrue, we return false fromrequiresManualSubmissionfunction hereApp/src/libs/ReportUtils.ts
Lines 1854 to 1859 in d8ce56d
What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?
N/A
What alternative solutions did you explore? (Optional)
Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.
srikarparsi commentedon Sep 22, 2025
Discussing in this thread
trjExpensify commentedon Sep 22, 2025
@jponikarchuk this is expected.
Create reportwould create aclosedreport and expenses couldn't be added to it.opendraft report in this flow instead, such that expenses can be added to it. As such, it's expected theSubmitbutton will show in this case. The next step will be to auto-submit the report if the expense(s) added to it are violation free, but that part isn’t done yet.Given that, I see this was "exploratory", but if there is a specific test case for using
Create reporton a workspace configured for "Instant + no approvals + no payments", can you update it to not recreate this bug report? Thanks!srikarparsi commentedon Sep 22, 2025
Closing this issue as it is expected behavior right now