Repository navigation
fix: reject navigation issue - #70720
Conversation
|
@mananjadhav Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
|
@truph01 Can you link the issues correctly prefixing |
|
@mananjadhav I updated |
mananjadhav
left a comment
There was a problem hiding this comment.
@lakchote Can you trigger adhoc build for this one?
|
🚧 @lakchote has triggered a test Expensify/App build. You can view the workflow run here. |
|
Btw, I encountered an issue when building Android app from my side, so I can't test it in this platform. I will update the video later |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, Desktop, and Web. Happy testing! 🧪🧪
|
|
@truph01 I don't see the video for the second test case. Can you please upload? And before we do, I think the expected behavior is incorrect. I think if you're opening the expense report from "Reports" screen, after rejection it should land on "Reports" screen only and not go to the expense report in the inbox. web-reject-from-reports-screen.movAlso raised it on Slack here |
Discussing it here: https://expensify.enterprise.slack.com/archives/C094PPQTDM4 |
Screenshots/VideosAndroid: HybridAppandroid-reports-reject-back.movandroid-reject-single.movAndroid: mWeb Chromemweb-chrome.-reject-back.movmweb-chrome-reject-single.moviOS: HybridAppios-reports-reject-back.movios-reject-single.moviOS: mWeb Safarimweb-safari-reports-reject-back.movmweb-safari-reject-single.movMacOS: Chrome / Safariweb-reports-reject-back.movweb-reject-single.movMacOS: Desktopdesktop-reports-reject-back.mov |
|
Tested for the first bug. Clarifying for the second bug. |
|
@mananjadhav I just updated author checklist to include video for test 1 + test 2 in mobile platforms. Also, I just pushed a commit to handle the case:
|
Reviewer Checklist
Screenshots uploaded here |
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🚀 Deployed to staging by https://github.com/lakchote in version: 9.2.16-0 🚀
|
|
🚀 Deployed to production by https://github.com/roryabraham in version: 9.2.16-14 🚀
|
Explanation of Change
Fixed Issues
$ #70586
$ #70600
PROPOSAL:
Tests
Test case 1:
Test case 2
Prerequisite: Account has at least one workspace available.
Prerequisite 2: Delayed submissions and approvals disabled.
Offline tests
QA Steps
// TODO: These must be filled out, or the issue title must include "[No QA]."
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectioncanBeMissingparam foruseOnyxtoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
Test 1
Screen.Recording.2025-09-18.at.09.25.15.mov
Test 2
Screen.Recording.2025-09-18.at.09.27.35.mov
iOS: Native
Test 1
Screen.Recording.2025-09-17.at.11.55.41.mov
Test 2
Screen.Recording.2025-09-18.at.09.36.34.mov
iOS: mWeb Safari
Test 1
Screen.Recording.2025-09-18.at.09.32.20.mov
Test 2
Screen.Recording.2025-09-17.at.11.57.23.mov
MacOS: Chrome / Safari
Screen.Recording.2025-09-17.at.11.47.12.mov
MacOS: Desktop
Screen.Recording.2025-09-17.at.11.53.13.mov