Skip to content

Deploy Checklist: New Expensify 2022-01-12 #7144

Closed

Description

@OSBotify

Release Version: 1.1.29-5
Compare Changes: production...staging

This release contains changes from the following pull requests:

Deploy Blockers:

cc @Expensify/applauseleads

Activity

  1. roryabraham commented on Jan 12, 2022

    @roryabraham
    Contributor

    As a reminder, please do not lock this checklist – we will do it as part of the QA of #6906

  2. roryabraham commented on Jan 12, 2022

    @roryabraham
    Contributor

    However, I do notice that #7112, which was CP'd in the last checklist, is not present in this checklist. This is a good sign that #4977 may at long last be fixed. 🤞

  3. mvtglobally commented on Jan 12, 2022

    @mvtglobally

    @roryabraham It is late, we will start QA tomorrow. Should I wait for your Green light or we can start anytime?

  4. roryabraham commented on Jan 12, 2022

    @roryabraham
    Contributor

    Please wait for me to lock the checklist. Once I do that, feel free to begin QA. It will be tomorrow morning hopefully

  5. mvtglobally commented on Jan 12, 2022

    @mvtglobally

    @roryabraham We are on standby, whenever you are ready

  6. Jag96 commented on Jan 12, 2022

    @Jag96
    Contributor

    Locking the checklist to bump the version to fix the deploy issues so we can test #6906 (comment)

  7. added and removed on Jan 12, 2022
  8. Jag96 commented on Jan 12, 2022

    @Jag96
  9. roryabraham commented on Jan 12, 2022

    @roryabraham
    Contributor

    @mvtglobally Belay that last comment – we'll ping you again when you're good to begin QA (not quite yet)

  10. roryabraham commented on Jan 12, 2022

    @roryabraham
    Contributor

    @mvtglobally Feel free to begin QA when ready

  11. mvtglobally commented on Jan 12, 2022

    @mvtglobally

    Starting QA in few

  12. roryabraham commented on Jan 12, 2022

    @roryabraham
  13. roryabraham commented on Jan 12, 2022

    @roryabraham
  14. mvtglobally commented on Jan 13, 2022

    @mvtglobally

    Checking off #6659 (comment)
    #6903 is failing #7188
    #7028 is failing due to #7055 is not fixed for Web and mWeb
    Checking off #7101 as #7183 is closed.
    #7132 is failing due to 7189
    #7136 was reverted, Checking off

  15. Jag96 commented on Jan 13, 2022

    @Jag96
    Contributor

    Left a comment regarding #7188 here, I think we can pass QA for #6903 because the core issue exists on production and wasn't introduced by that PR.

  16. Jag96 commented on Jan 13, 2022

    @Jag96
    Contributor

    I also think we can remove #7201 (comment) from the deploy blocker list per that comment

  17. Jag96 commented on Jan 13, 2022

    @Jag96
    Contributor

    Looks like #7181 and #7055 had the Deploy blocker label removed as well, so taking those off the checklist

  18. Jag96 commented on Jan 13, 2022

    @Jag96
    Contributor

    Also removing #7182 from the checklist per #7182 (comment).

  19. mvtglobally commented on Jan 14, 2022

    @mvtglobally

    Checking off #6903 based on #7144 (comment)
    Checking off #6978. As per steps it needs URL change. We validated on Web and It can't be QA-ed on Android app
    Checking off #7028 as #7055 is not a blocker
    Checking off #7132 as #7189 was fixed
    Checking off #7149 as #7187 not a blocker

  20. mvtglobally commented on Jan 14, 2022

    @mvtglobally

    Only need to confirm #6567 to close this checklist.
    Team was able to QA every platform but Desktop. Can someone check Desktop internally or we can check it off?

  21. Jag96 commented on Jan 14, 2022

    @Jag96
    Contributor

    @mvtglobally I can test it on desktop! Once that is done is accessibility the only thing we're waiting on? Is that still being tested?

  22. Jag96 commented on Jan 14, 2022

    @Jag96
    Contributor

    Great, #6567 passed QA on desktop so going to check off all the Accessibility boxes and close this!

  23. Jag96 commented on Jan 14, 2022

    @Jag96
    Contributor

    :shipit:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions