Skip to content

[Due for payment 2025-10-28] [$125] [Translation Migration] Fix split or incomplete translations in workspace.accounting #72045

Closed

Description

@roryabraham

Problem

This batch contains incomplete translations that need to be migrated to use translation parameters instead of split keys or trailing spaces.

Translation Keys to Fix

  • workspace.accounting.needAnotherAccounting
    • Current value: "Need another accounting software? "
  • workspace.accounting.chooseReconciliationAccount.accountMatches
    • Current value: "Make sure this account matches your "
  • workspace.accounting.chooseReconciliationAccount.settlementAccount
    • Current value: "Expensify Card settlement account "

Example PRs

See these PRs for examples of how to perform this migration:

More examples can be found in the tracking issue: #62808

Migration Steps

  1. Identify where these translation keys are used in the codebase
  2. Combine split translations (keys containing "part") into single translation strings with parameters
  3. Remove trailing spaces from translation values and combine them properly with whatever rich text content is displayed after them in the app
  4. Update the code to pass the appropriate parameters to the translation function, usually wrapping rich text with react-native-render-html as seen in the example PRs
  5. Test the changes to ensure the translations render correctly
Issue OwnerCurrent Issue Owner: @
Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~021975732334914657889
  • Upwork Job ID: 1975732334914657889
  • Last Price Increase: 2025-10-08
  • Automatic offers:
    • twilight2294 | Contributor | 109101269
Issue OwnerCurrent Issue Owner: @bfitzexpensify

Activity

  1. added
    ExternalAdded to denote the issue can be worked on by a contributor
    BugSomething is broken. Auto assigns a BugZero manager.
    on Oct 8, 2025
  2. added
    Help WantedApply this label when an issue is open to proposals by contributors
    on Oct 8, 2025
  3. melvin-bot commented on Oct 8, 2025

    @melvin-bot

    Triggered auto assignment to Contributor-plus team member for initial proposal review - @hoangzinh (External)

  4. melvin-bot commented on Oct 8, 2025

    @melvin-bot

    Triggered auto assignment to @bfitzexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  5. added
    ExternalAdded to denote the issue can be worked on by a contributor
    and removed
    ExternalAdded to denote the issue can be worked on by a contributor
    on Oct 8, 2025
  6. changed the title [-][Translation Migration] Fix split or incomplete translations in workspace.accounting[/-] [+][$250] [Translation Migration] Fix split or incomplete translations in workspace.accounting[/+] on Oct 8, 2025
  7. melvin-bot commented on Oct 8, 2025

    @melvin-bot
  8. melvin-bot commented on Oct 8, 2025

    @melvin-bot

    Current assignee @hoangzinh is eligible for the External assigner, not assigning anyone new.

  9. changed the title [-][$250] [Translation Migration] Fix split or incomplete translations in workspace.accounting[/-] [+][$125] [Translation Migration] Fix split or incomplete translations in workspace.accounting[/+] on Oct 8, 2025
  10. 30 remaining items

  11. changed the title [-][$125] [Translation Migration] Fix split or incomplete translations in workspace.accounting[/-] [+][Due for payment 2025-10-28] [$125] [Translation Migration] Fix split or incomplete translations in workspace.accounting[/+] on Oct 21, 2025
  12. melvin-bot commented on Oct 21, 2025

    @melvin-bot

    Reviewing label has been removed, please complete the "BugZero Checklist".

  13. melvin-bot commented on Oct 21, 2025

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 9.2.35-4 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2025-10-28. 🎊

    For reference, here are some details about the assignees on this issue:

  14. melvin-bot commented on Oct 21, 2025

    @melvin-bot

    @hoangzinh @bfitzexpensify The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

  15. bfitzexpensify commented on Oct 28, 2025

    @bfitzexpensify
    Contributor

    Payment complete to @twilight2294

    @hoangzinh, please complete the BZ checklist

  16. hoangzinh commented on Oct 29, 2025

    @hoangzinh
    Contributor

    @bfitzexpensify this issue is an enhancement task, so we don't need a BZ checklist for this issue.

  17. bfitzexpensify commented on Oct 29, 2025

    @bfitzexpensify
    Contributor

    Payment summary:

    @hoangzinh due $250 via NewDot Manual Requests

  18. hoangzinh commented on Oct 29, 2025

    @hoangzinh
    Contributor

    @bfitzexpensify, it should be $125

  19. twisterdotcom commented on Oct 30, 2025

    @twisterdotcom
    Contributor

    @hoangzinh has submitted payment for this report on ND here.

    SO: https://stackoverflowteams.com/c/expensify/questions/7582

    • Vendor found in VML: True. Status: Active
    • Amount requested: $125.00
    • I, @twisterdotcom am not already the BZ assignee. I have approved this payment.
    Zapier Logs Run ID: 00040eee-4db1-a32c-bb07-94c365916151
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2ExternalAdded to denote the issue can be worked on by a contributor

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions