Skip to content

[Due for payment 2025-11-21] [$250] [Translation Migration] Fix split or incomplete translations in contacts #72051

Closed

Description

@roryabraham

Problem

This batch contains incomplete translations that need to be migrated to use translation parameters instead of split keys or trailing spaces.

Translation Keys to Fix

  • contacts.helpTextBeforeEmail
    • Current value: "Add more ways for people to find you, and forward receipts to "

Example PRs

See these PRs for examples of how to perform this migration:

More examples can be found in the tracking issue: #62808

Migration Steps

  1. Identify where these translation keys are used in the codebase
  2. Combine split translations (keys containing "part") into single translation strings with parameters
  3. Remove trailing spaces from translation values and combine them properly with whatever rich text content is displayed after them in the app
  4. Update the code to pass the appropriate parameters to the translation function, usually wrapping rich text with react-native-render-html as seen in the example PRs
  5. Test the changes to ensure the translations render correctly
Issue OwnerCurrent Issue Owner: @
Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~021975732612474707182
  • Upwork Job ID: 1975732612474707182
  • Last Price Increase: 2025-10-25
  • Automatic offers:
    • situchan | Contributor | 109137139
Issue OwnerCurrent Issue Owner: @VictoriaExpensify
Issue OwnerCurrent Issue Owner: @VictoriaExpensify

Activity

  1. added
    ExternalAdded to denote the issue can be worked on by a contributor
    BugSomething is broken. Auto assigns a BugZero manager.
    on Oct 8, 2025
  2. added
    Help WantedApply this label when an issue is open to proposals by contributors
    on Oct 8, 2025
  3. melvin-bot commented on Oct 8, 2025

    @melvin-bot

    Triggered auto assignment to Contributor-plus team member for initial proposal review - @mananjadhav (External)

  4. melvin-bot commented on Oct 8, 2025

    @melvin-bot

    Triggered auto assignment to @VictoriaExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  5. added
    ExternalAdded to denote the issue can be worked on by a contributor
    and removed
    ExternalAdded to denote the issue can be worked on by a contributor
    on Oct 8, 2025
  6. melvin-bot commented on Oct 8, 2025

    @melvin-bot
  7. changed the title [-][Translation Migration] Fix split or incomplete translations in contacts[/-] [+][$250] [Translation Migration] Fix split or incomplete translations in contacts[/+] on Oct 8, 2025
  8. melvin-bot commented on Oct 8, 2025

    @melvin-bot

    Current assignee @mananjadhav is eligible for the External assigner, not assigning anyone new.

  9. changed the title [-][$250] [Translation Migration] Fix split or incomplete translations in contacts[/-] [+][$125] [Translation Migration] Fix split or incomplete translations in contacts[/+] on Oct 8, 2025
  10. 63 remaining items

  11. changed the title [-][$250] [Translation Migration] Fix split or incomplete translations in contacts[/-] [+][Due for payment 2025-11-21] [$250] [Translation Migration] Fix split or incomplete translations in contacts[/+] on Nov 14, 2025
  12. melvin-bot commented on Nov 14, 2025

    @melvin-bot

    Reviewing label has been removed, please complete the "BugZero Checklist".

  13. melvin-bot commented on Nov 14, 2025

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 9.2.58-3 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2025-11-21. 🎊

    For reference, here are some details about the assignees on this issue:

  14. melvin-bot commented on Nov 14, 2025

    @melvin-bot

    @situchan @VictoriaExpensify The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

  15. VictoriaExpensify commented on Nov 23, 2025

    @VictoriaExpensify
    Contributor

    Payment summary:
    C: @TaduJR paid $250 via Upwork
    C+ @situchan owed $250 via NewDot

    ^^Wrong

  16. TaduJR commented on Nov 30, 2025

    @TaduJR
    Contributor

    Hey @VictoriaExpensify

    I think you accidentally closed it.

    C: @TaduJR paid $250 via Upwork

    Offer Not Received, and not paid.

    Could you please re-open?

  17. VictoriaExpensify commented on Dec 3, 2025

    @VictoriaExpensify
    Contributor

    Oh wow, I'm so sorry @TaduJR! Let me get an offer to you.

  18. TaduJR commented on Dec 3, 2025

    @TaduJR
    Contributor

    No Problem, @VictoriaExpensify

    It happen sometimes.

    Thank you!

  19. VictoriaExpensify commented on Dec 3, 2025

    @VictoriaExpensify
    Contributor

    Updated payment summary:

    C: @TaduJR paid $250 via Upwork
    C+ @situchan paid $250 via Upwork

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2ExternalAdded to denote the issue can be worked on by a contributor

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions