You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[Due for payment 2026-04-14][$250] Hold Expense - Reply link is shown after deleting an expense #73390
Version Number: v9.2.37-6 Reproducible in staging?: Yes Reproducible in production?: Yes If this was caught during regression testing, add the test name, ID and link from BrowserStack:#73379 Email or phone of affected tester (no customers):agexptest+pr2310@gmail.com Issue reported by: Applause Internal Team Device used: Windows 11/ Chrome, Samsung S23FE/ Android 15, iPhone 13 Mini/ iOS 18.5 App Component: Money Requests
Action Performed:
Go to staging.new.expensify.com
Create 2 expenses in a 1:1 conversation DM
Click on the report created
Click on an expense
Put it on hold with a comment
Click on the header of the same expense > Delete the expense
Go to the 1:1 conversation DM
Expected Result:
The "Reply" hyperlink below the expense preview is not shown.
Actual Result:
The "Reply" hyperlink below the expense preview is shown.
What changes do you think we should make in order to solve the problem?
In prepareToCleanUpMoneyRequest, we need to update childVisibleActionCount and childCommenterCount using a helper similar to getOptimisticDataForParentReportAction.
We can’t use it directly because getOptimisticDataForParentReportAction is currently designed to handle adding a single action or deleting a single comment — meaning it only accounts for one removable action. In our case, the number of visible actions being deleted could be greater than one.
This will ensure correct behavior in offline mode. Additionally, we need to update the backend to return childVisibleActionCount and childCommenterCount for the correct action.
What alternative solutions did you explore? (Optional)
changed the title [-]Hold Expense - Reply link is shown after deleting an expense[/-][+][$250] Hold Expense - Reply link is shown after deleting an expense[/+]on Oct 28, 2025
[Contributor] The offending PR and associated issue have been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.
[Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.
Link to discussion: N/A
[Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.
[BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.
Activity
melvin-bot commentedon Oct 24, 2025
Triggered auto assignment to @mallenexpensify (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.hasib711 commentedon Oct 24, 2025
Proposal
Please re-state the problem that we are trying to solve in this issue.
The "Reply" hyperlink below the expense preview is not shown.
What is the root cause of that problem?
On the report page, the display of replies is determined by the childCommenterCount and childVisibleActionCount of the selected report action.
App/blob/main/src/pages/home/report/PureReportActionItem.tsx
App/blob/main/src/pages/home/report/PureReportActionItem.tsx
App/blob/main/src/libs/ReportUtils.ts
However, when an expense is deleted, the process didn't update the childCommenterCount and childVisibleActionCount of the action.
App/blob/main/src/libs/actions/IOU.ts
What changes do you think we should make in order to solve the problem?
We need to update the childCommenterCount and childVisibleActionCount of the action.
App/src/libs/actions/Report.ts
What alternative solutions did you explore? (Optional)
dmkt9 commentedon Oct 24, 2025
Proposal
Please re-state the problem that we are trying to solve in this issue.
The "Reply" hyperlink below the expense preview is shown.
What is the root cause of that problem?
After deleting an expense,
childVisibleActionCountandchildCommenterCountare not decremented, so thread replies are still shown.App/src/pages/home/report/PureReportActionItem.tsx
Lines 1483 to 1485 in 302280e
App/src/pages/home/report/PureReportActionItem.tsx
Lines 1524 to 1526 in 302280e
deleteMoneyRequestusesprepareToCleanUpMoneyRequestto generate theupdatedReportPreviewAction.App/src/libs/actions/IOU.ts
Lines 8633 to 8645 in 302280e
However,
prepareToCleanUpMoneyRequestonly updateschildMoneyRequestCountandmessageforupdatedReportPreviewAction.App/src/libs/actions/IOU.ts
Lines 8350 to 8366 in 302280e
What changes do you think we should make in order to solve the problem?
In
prepareToCleanUpMoneyRequest, we need to updatechildVisibleActionCountandchildCommenterCountusing a helper similar togetOptimisticDataForParentReportAction.App/src/libs/ReportUtils.ts
Lines 10214 to 10247 in 302280e
We can’t use it directly because
getOptimisticDataForParentReportActionis currently designed to handle adding a single action or deleting a single comment — meaning it only accounts for one removable action. In our case, the number of visible actions being deleted could be greater than one.This will ensure correct behavior in offline mode. Additionally, we need to update the backend to return
childVisibleActionCountandchildCommenterCountfor the correct action.What alternative solutions did you explore? (Optional)
N/A
melvin-bot commentedon Oct 27, 2025
@mallenexpensify Whoops! This issue is 2 days overdue. Let's get this updated quick!
melvin-bot commentedon Oct 28, 2025
Job added to Upwork: https://www.upwork.com/jobs/~021983277787564040184
[-]Hold Expense - Reply link is shown after deleting an expense[/-][+][$250] Hold Expense - Reply link is shown after deleting an expense[/+]melvin-bot commentedon Oct 28, 2025
Triggered auto assignment to Contributor-plus team member for initial proposal review - @dukenv0307 (
External)87 remaining items
luacmartins commentedon Apr 10, 2026
@dukenv0307 #84551 was a follow up for a known issue of #74186, right?
dukenv0307 commentedon Apr 13, 2026
@luacmartins that's right
luacmartins commentedon Apr 13, 2026
Ok, in that case I think $500 for both PRs is ok, since we merged the first one with the known issue.
melvin-bot commentedon Apr 14, 2026
Payment Summary
Upwork Job
BugZero Checklist (@mallenexpensify)
mallenexpensify commentedon Apr 16, 2026
Payment Summary
Contributor: @dmkt9 oaud $500 via Upwork
Contributor+: @dukenv0307 due $500 via NewDot
@dmkt9 can you please accept the job below? Please reply here and tag me once you have.
https://www.upwork.com/jobs/~022044855461933875738
@dukenv0307 plz complete the BZ checklist and tag me in a post once you have. Thx
dukenv0307 commentedon Apr 17, 2026
BugZero Checklist:
[Contributor] The offending PR and associated issue have been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.
Link to the comment on the PR: https://github.com/Expensify/App/pull/79648/changes#r3098755854
[Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.
Link to discussion: N/A
[Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.
[BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.
Link to issue: https://github.com/Expensify/Expensify/issues/625436
Regression Test Proposal
Precondition:
Test:
Do we agree 👍 or 👎
Zapier Logs
Run ID: 00040eee-8205-a28d-473c-b8a5883102e4dukenv0307 commentedon Apr 17, 2026
@mallenexpensify Done
dmkt9 commentedon Apr 17, 2026
@mallenexpensify Thanks. I've accepted the offer, and I noticed that the amount is $250
mallenexpensify commentedon Apr 17, 2026
@dmkt9 paid, summary updated above. Thx. Thx for the reminder that it's $500.
^ Test case created
quinthar commentedon Apr 21, 2026
Approved $500 to @dukenv0307