Repository navigation
Fix/73390 - The "Reply" hyperlink below the expense preview is shown - #74186
Conversation
|
@dukenv0307 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
|
LGTM |
Codecov Report✅ Changes either increased or maintained existing code coverage, great job!
|
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppScreen.Recording.2025-11-04.at.21.55.46.movAndroid: mWeb ChromeScreen.Recording.2025-11-04.at.21.51.56.moviOS: HybridAppScreen.Recording.2025-11-04.at.22.00.57.moviOS: mWeb SafariScreen.Recording.2025-11-04.at.21.50.30.movMacOS: Chrome / SafariScreen.Recording.2025-11-04.at.21.46.55.movMacOS: DesktopScreen.Recording.2025-11-04.at.21.57.17.mov |
|
@luacmartins It worked well in offline mode, can you please make a BE change as mentioned in the proposal?
|
joekaufmanexpensify
left a comment
There was a problem hiding this comment.
Change seems fine from a product perspective
|
@dmkt9 @dukenv0307 it seems like we need to update the PR with the result of these comments #73390 (comment) |
Thanks for the reminder. It seems that the expected behavior aligns with what this PR is addressing. I think we can continue to wait for the changes from the BE side #74186 (comment) |
|
Ok, I'm ooo for the next week. I'll get to this when I'm back on Dec 1 |
|
@luacmartins is this still on hold? |
|
@luacmartins is this still held? |
|
I put up a BE PR to completely delete the transaction thread if it has comments, as discussed #73390 (comment). @dmkt9 I think we need to update the FE code to do the same. We want to completely delete the transaction thread and the reportActions in it for the deleted transaction. The flows I had to update in the BE were:
|
|
Let's just fix the failing TS checks and get this reviewed again |
|
@codex review |
|
Codex Review: Didn't find any major issues. Breezy! ℹ️ About Codex in GitHubCodex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback". |
Got it, thanks. I’ve removed the changes to SplitTransaction in this PR, and it’s ready for review again. |
|
on it now |
|
@dmkt9 In this PR, we just need to verify the DeleteMoneyRequest API, right? |
@dukenv0307 With the original issue, that’s correct. But we also have additional requirements for a few other APIs, so in this PR I think we need to verify these three APIs:
|
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppScreen.Recording.2026-02-05.at.23.34.10.movAndroid: mWeb ChromeScreen.Recording.2026-02-05.at.23.25.07.moviOS: HybridAppScreen.Recording.2026-02-05.at.23.35.00.moviOS: mWeb SafariScreen.Recording.2026-02-05.at.23.26.21.movMacOS: Chrome / SafariScreen.Recording.2026-02-05.at.23.19.58.movScreen.Recording.2026-02-05.at.23.21.21.mov |
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: f22676bfbc
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
|
🚀 Deployed to staging by https://github.com/luacmartins in version: 9.3.16-0 🚀
|
|
@dmkt9 this PR is failing the offline scenario for Android when getting back online in the end. Bug7073443_1770720953334.Screenrecorder-2026-02-10-16-22-08-832.mp4 |
|
🚀 Deployed to production by https://github.com/lakchote in version: 9.3.16-9 🚀
|
@nlemma Thank you. @luacmartins @dukenv0307 Hi, I think the
|
|
Thanks! Left a comment in the main issue. I'll investigate. |

Explanation of Change
Fixed Issues
$ #73390
PROPOSAL: #73390 (comment)
Tests
Same as QA Steps
Offline tests
QA Steps
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectioncanBeMissingparam foruseOnyxtoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
android.native.mp4
Android: mWeb Chrome
android.chrome.mp4
iOS: Native
ios.native.mp4
iOS: mWeb Safari
ios.safari.mp4
MacOS: Chrome / Safari
mac.safari.mp4
MacOS: Desktop
mac.desktop.mp4