Skip to content

Remove Onyx.connect() for the key: ONYXKEYS.CONCIERGE_REPORT_ID in src/libs/actions/Report.ts #73649

Closed

Description

@tgolen

This is part of deprecating Onyx.connect. Parent Issue

Details

Be sure to refactor methods using test driven development:

  1. Create a unit test for methods before refactoring
  2. Refactor the methods
  3. Ensure the unit test still runs after refactoring
  4. Reinforce the unit testing with a functional test and a QA test
  5. Once you are done, decrease the number of allowable ESLint warnings here to equal the number of Onyx.connect references remaining in the code
Issue OwnerCurrent Issue Owner: @JmillsExpensify

Activity

  1. self-assigned this
    on Oct 28, 2025
  2. tgolen commented on Oct 28, 2025

    @tgolen
    ContributorAuthor

    Warning

    DO NOT POST PROPOSALS ON THIS ISSUE!!

    Bug-Zero Instructions

    • This issue is CLOSED for proposals
    • It is a special issue and part of a bigger project
    • A contributor will be manually assigned to work on this issue and they do not need to submit a proposal
    • The bug-zero person only needs to take care of payments to the contributor for the PR and the C+ for reviews
    • There do not need to be any regression tests added or updated since this is only refactoring and shouldn't change any existing functionality
  3. added
    ImprovementItem broken or needs improvement.
    BugSomething is broken. Auto assigns a BugZero manager.
    on Oct 28, 2025
  4. melvin-bot commented on Oct 28, 2025

    @melvin-bot

    Triggered auto assignment to @garrettmknight (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  5. added and removed on Oct 28, 2025
  6. melvin-bot commented on Nov 11, 2025

    @melvin-bot

    @tgolen @garrettmknight this issue was created 2 weeks ago. Are we close to a solution? Let's make sure we're treating this as a top priority. Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

  7. 38 remaining items

  8. dukenv0307 commented on Feb 23, 2026

    @dukenv0307
    Contributor

    will raise other PR soon

  9. changed the title [-][Due for payment 2026-02-17] [Due for payment 2026-02-03] Remove `Onyx.connect()` for the key: `ONYXKEYS.CONCIERGE_REPORT_ID` in `src/libs/actions/Report.ts`[/-] [+]Remove `Onyx.connect()` for the key: `ONYXKEYS.CONCIERGE_REPORT_ID` in `src/libs/actions/Report.ts`[/+] on Feb 23, 2026
  10. JmillsExpensify commented on Feb 23, 2026

    @JmillsExpensify
    Contributor

    Updated the issue title to avoid confusion.

  11. dukenv0307 commented on Mar 10, 2026

    @dukenv0307
    Contributor

    @JmillsExpensify It's ready for payment. Here is the PR list:

    #79428
    #81139
    #81137
    #83172

    cc @tgolen @parasharrajat

  12. JmillsExpensify commented on Mar 10, 2026

    @JmillsExpensify
    Contributor

    Ok so based on a standard payout per PR, the summary is:

  13. JmillsExpensify commented on Mar 10, 2026

    @JmillsExpensify
    Contributor

    Should be all set here, so going to close this out.

  14. parasharrajat commented on Mar 19, 2026

    @parasharrajat
    Member

    Payment requested as per #73649 (comment)

  15. twisterdotcom commented on Mar 19, 2026

    @twisterdotcom
    Contributor

    @parasharrajat has submitted payment for this report on ND here.

    SO: https://stackoverflowteams.com/c/expensify/questions/7582

    Zapier Logs Run ID: 00040eee-d12f-aa29-970c-3c48a72a37e4
  16. quinthar commented on May 21, 2026

    @quinthar
    Contributor

    Approved $1000 to @dukenv0307

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.EngineeringImprovementItem broken or needs improvement.ReviewingHas a PR in reviewWeeklyKSv2

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions