Repository navigation
Refactor navigateToConciergeChat to use conciergeReportID from useOnyx - #79428
Conversation
Codecov Report✅ Changes either increased or maintained existing code coverage, great job!
|
|
@parasharrajat Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: b6303b52be
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
|
@parasharrajat It's ready for review again |
| height="100%" | ||
| width="100%" | ||
| seamless | ||
| // eslint-disable-next-line @typescript-eslint/no-deprecated |
| setInitialUrl(url as Route); | ||
| if (url) { | ||
| openReportFromDeepLink(url, currentOnboardingPurposeSelected, currentOnboardingCompanySize, onboardingInitialPath, allReports, isAuthenticated); | ||
| openReportFromDeepLink(url, currentOnboardingPurposeSelected, currentOnboardingCompanySize, onboardingInitialPath, allReports, isAuthenticated, conciergeReportID); |
There was a problem hiding this comment.
Chances of conciergeReportID being undefined here when this function is called is high...
There was a problem hiding this comment.
- Looks good on web dev version.
parasharrajat
left a comment
There was a problem hiding this comment.
Reviewer Checklist
- I have verified the author checklist is complete (all boxes are checked off).
- I verified the correct issue is linked in the
### Fixed Issuessection above - I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the
Testssection - I verified the steps for Staging and/or Production testing are in the
QA stepssection - I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
- I verified the steps for local testing are in the
- I checked that screenshots or videos are included for tests on all platforms
- I included screenshots or videos for tests on all platforms
- I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
- If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
- I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e.
toggleReportand notonIconClick). - I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g.
myBool && <MyComponent />. - I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to
src/languages/*files and using the translation method - I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the
Waiting for Copylabel for a copy review on the original GH to get the correct copy. - I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in
STYLE.md) were followed
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e.
- If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
- I verified that this PR follows the guidelines as stated in the Review Guidelines
- I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like
Avatar, I verified the components usingAvatarhave been tested & I retested again) - I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
- I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
- If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a
/** comment above it */ - The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to
thisproperly so there are no scoping issues (i.e. foronClick={this.submit}the methodthis.submitshould be bound tothisin the constructor) - Any internal methods bound to
thisare necessary to be bound (i.e. avoidthis.submit = this.submit.bind(this);ifthis.submitis never passed to a component event handler likeonClick) - All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
- If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
- If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e.
StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
- If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
- If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like
Avataris modified, I verified thatAvataris working as expected in all cases) - If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
- If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
- If the PR modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added
Designlabel so the design team can review the changes.
- If a new page is added, I verified it's using the
ScrollViewcomponent to make it scrollable when more elements are added to the page. - If the
mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps. - I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.
18.01.2026_19.20.36_REC.mp4
🎀 👀 🎀 C+ reviewed
|
We did not find an internal engineer to review this PR, trying to assign a random engineer to #73649 as well as to this PR... Please reach out for help on Slack if no one gets assigned! |
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 516134f62a
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| // Open chat report from a deep link (only mobile native) | ||
| linkingChangeListener.current = Linking.addEventListener('url', (state) => { | ||
| const isCurrentlyAuthenticated = hasAuthToken(); | ||
| openReportFromDeepLink(state.url, currentOnboardingPurposeSelected, currentOnboardingCompanySize, onboardingInitialPath, allReports, isCurrentlyAuthenticated); | ||
| openReportFromDeepLink(state.url, currentOnboardingPurposeSelected, currentOnboardingCompanySize, onboardingInitialPath, allReports, isCurrentlyAuthenticated, conciergeReportID); | ||
| }); |
There was a problem hiding this comment.
Avoid capturing stale conciergeReportID in deep link handler
This deep‑link listener is registered in a startup effect that intentionally does not rerun, so it closes over the initial conciergeReportID value. If Onyx hydration hasn’t populated that key yet (common during app start), every subsequent deep link in this session will still pass undefined to openReportFromDeepLink, which forces the concierge fallback to go through navigateToAndOpenReport instead of navigating to the known concierge report ID. That can lead to extra OpenReport calls or even a duplicate concierge chat when the report collection isn’t hydrated yet. Consider reading the concierge ID from Onyx inside the handler or keeping it in a ref that updates.
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
I don't know how legitimate the concern is. I get it in theory, but in practice, does it ever happen? We could add a log if conciergeReportID is ever undefined, and then after the log has been in the code for a couple of weeks, we could see how often it is logged and determine if we want to do anything about it.
As an alternative, what about adding the conciergeReportID to the effect's dependency array?
There was a problem hiding this comment.
Or, we could move it to it's own effect. This effect is really big already, so it's not separating concerns very well.
There was a problem hiding this comment.
Thanks @tgolen for chiming in!
Or, we could move it to it's own effect.
I like that approach, cc @dukenv0307 @parasharrajat
|
@parasharrajat It's ready for review again |
|
^ cc @parasharrajat, thanks! |
|
Conflicts @dukenv0307 |
|
@parasharrajat @tgolen I merged main, we're good to merge now |
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Lines 283 to 284 in 0fbe7df
The bootstrapping effect now runs unconditionally and clears notifications whenever isAuthenticated is false. Because useIsAuthenticated() is driven by ONYXKEYS.SESSION, it can be false during Onyx hydration even for users who are already signed in. On a cold start this means PushNotification.clearNotifications() can run for authenticated users, wiping their notifications. The previous isLoadingOnyxValue(sessionMetadata) guard avoided that; consider restoring a guard or otherwise waiting for session state to load before clearing.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| if (CONFIG.IS_HYBRID_APP) { | ||
| HybridAppModule.onURLListenerAdded(); |
There was a problem hiding this comment.
Defer hybrid URL readiness until listener is attached
In Expensify.tsx, the mount effect now calls HybridAppModule.onURLListenerAdded() immediately, but the actual JS URL listener (Linking.addEventListener('url', ...)) is only registered later in the deep-link effect after sessionMetadata finishes loading. On Hybrid App cold starts, native can emit the launch URL as soon as it sees onURLListenerAdded, and with no listener attached yet the event can be dropped, so deep links may not open. Consider moving onURLListenerAdded() back to after the listener is registered or gating it with the same readiness checks.
Useful? React with 👍 / 👎.
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🚀 Deployed to staging by https://github.com/tgolen in version: 9.3.9-0 🚀
|
|
🚀 Deployed to production by https://github.com/roryabraham in version: 9.3.9-2 🚀
|
Explanation of Change
Refactor navigateToConciergeChat to use conciergeReportID from useOnyx
Fixed Issues
$ #73649
PROPOSAL:
Tests
Report a bugOffline tests
QA Steps
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectioncanBeMissingparam foruseOnyxtoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Screen.Recording.2026-01-13.at.18.12.55.mov
Android: mWeb Chrome
Screen.Recording.2026-01-13.at.18.11.53.mov
iOS: Native
Screen.Recording.2026-01-13.at.18.13.11.mov
iOS: mWeb Safari
Screen.Recording.2026-01-13.at.18.11.41.mov
MacOS: Chrome / Safari
Screen.Recording.2026-01-13.at.18.10.42.mov