Skip to content

[Due for payment 2025-11-26] [$250] Report - 'Comments' sub-header not shown in the chat #73686

Closed

Description

@vincdargento

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: v9.2.39-2
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught during regression testing, add the test name, ID and link from BrowserStack: https://test-management.browserstack.com/projects/2219752/folder/13176730/test-cases/41237110
Email or phone of affected tester (no customers): N/A
Issue reported by: Applause Internal Team
Device used: Windows 11, Chrome
App Component: Other

Action Performed:

Precondition: User has a workspace.

  1. Go to https://staging.new.expensify.com/
  2. Create a report
  3. Send a message in the report chat.

Expected Result:

When a report includes comments, the chat should display a 'Comments' sub-header to clearly separate and label that section.

Actual Result:

The 'Comments' sub-header is missing in the chat view.

Workaround:

Unknown

Platforms:

  • Android: App
  • Android: mWeb Chrome
  • iOS: App
  • iOS: mWeb Safari
  • iOS: mWeb Chrome
  • Windows: Chrome
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

bug.mp4
Image

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~021983395431269974507
  • Upwork Job ID: 1983395431269974507
  • Last Price Increase: 2025-10-29
Issue OwnerCurrent Issue Owner: @kadiealexander

Activity

  1. added
    BugSomething is broken. Auto assigns a BugZero manager.
    on Oct 28, 2025
  2. melvin-bot commented on Oct 28, 2025

    @melvin-bot

    Triggered auto assignment to @kadiealexander (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  3. nkdengineer commented on Oct 28, 2025

    @nkdengineer
    Contributor

    Proposal

    Please re-state the problem that we are trying to solve in this issue.

    The 'Comments' sub-header is missing in the chat view.

    What is the root cause of that problem?

    The Comments sub-header is removed here

    What changes do you think we should make in order to solve the problem?

    1. We should bring the sub-header change back from here in MoneyRequestReportTotalSpend and only display it if the report has no transactions

    2. Now we have Add expense button, then if we still want Comments sub-header. We need to update the UI accordingly and we can discuss about this with design team in the PR.

    What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

    None

    What alternative solutions did you explore? (Optional)

    Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

  4. added
    ExternalAdded to denote the issue can be worked on by a contributor
    on Oct 29, 2025
  5. melvin-bot commented on Oct 29, 2025

    @melvin-bot
  6. changed the title [-]Report - 'Comments' sub-header not shown in the chat[/-] [+][$250] Report - 'Comments' sub-header not shown in the chat[/+] on Oct 29, 2025
  7. moved this to Bugs and Follow Up Issues in #expensify-bugson Oct 29, 2025
  8. added
    Help WantedApply this label when an issue is open to proposals by contributors
    on Oct 29, 2025
  9. melvin-bot commented on Oct 29, 2025

    @melvin-bot

    Triggered auto assignment to Contributor-plus team member for initial proposal review - @suneox (External)

  10. suneox commented on Oct 30, 2025

    @suneox
    Contributor

    Proposal from @nkdengineer LGTM

    🎀 👀 🎀 C+ reviewed

  11. 14 remaining items

  12. changed the title [-][$250] Report - 'Comments' sub-header not shown in the chat[/-] [+][Due for payment 2025-11-26] [$250] Report - 'Comments' sub-header not shown in the chat[/+] on Nov 19, 2025
  13. melvin-bot commented on Nov 19, 2025

    @melvin-bot

    Reviewing label has been removed, please complete the "BugZero Checklist".

  14. melvin-bot commented on Nov 19, 2025

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 9.2.59-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2025-11-26. 🎊

    For reference, here are some details about the assignees on this issue:

    • @suneox requires payment through NewDot Manual Requests
    • @nkdengineer requires payment through NewDot Manual Requests
  15. melvin-bot commented on Nov 19, 2025

    @melvin-bot

    @suneox @kadiealexander The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

  16. suneox commented on Nov 25, 2025

    @suneox
    Contributor

    BugZero Checklist:

    • [Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.

      Link to comment: I think there won’t be any PR specifically responsible for this issue because the refactoring in PR fix: Add the "Add expense" button to two areas of the product. #71267 was primarily focused on adding "Add expense" button functionality to money request reports. During this process, the existing logic that displayed the "Comments" sub-header for reports containing chat messages was also removed on the UI mockup

    • [Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.

      Link to discussion: N/A

    • [Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.

      N/A: It isn't an impactful bug

  17. kadiealexander commented on Nov 28, 2025

    @kadiealexander
    Contributor

    Payment Summary

  18. moved this from Bugs and Follow Up Issues to Done in #expensify-bugson Nov 28, 2025
  19. garrettmknight commented on Dec 18, 2025

    @garrettmknight
    Contributor

    $250 approved for @suneox

  20. twisterdotcom commented on Mar 11, 2026

    @twisterdotcom
    Contributor

    @nkdengineer has submitted payment for this report on ND here.

    SO: https://stackoverflowteams.com/c/expensify/questions/7582

    Zapier Logs Run ID: 00040eee-b177-a65d-8a38-27301fe63ba4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2ExternalAdded to denote the issue can be worked on by a contributor

Type

No type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions