You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[Payment 2025-12-15] [$250] Onboarding – Continue button not responding after back from work email verification #75863
Version Number: v9.2.62-2 Reproducible in staging?: Yes Reproducible in production?: Yes If this was caught during regression testing, add the test name, ID and link from BrowserStack: KI retest #74295 Email or phone of affected tester (no customers): Amy new gmail account Issue reported by: Applause Internal Team Device used: Mac / Safari App Component: Search
Action Performed:
Sign up with a new Gmail account.
Add your work email when prompted — the verification page will appear.
Click the back arrow.
Enter any name and click Continue.
Expected Result:
Name should be accepted, next page should be displayed
Please re-state the problem that we are trying to solve in this issue.
Onboarding – Continue button not responding after back from work email verification
What is the root cause of that problem?
When navigating back from the work email verification page to the personal details page, onboardingPurposeSelected value is undefined. When the user clicks Continue, the handleSubmit function calls completeOnboarding, which returns early if onboardingPurposeSelected is undefined
What changes do you think we should make in order to solve the problem?
We can check if onboardingPurposeSelected is undefined before calling completeOnboarding, and if it is, we can navigate to the purpose page to allow the user to select a purpose
Please re-state the problem that we are trying to solve in this issue.
User cannot continue after back from onboarding work email verification. Instead of going back to the previous page, it redirects to the Personal Details page.
What is the root cause of that problem?
I think the page flow, when the user presses the Back button on the Validate Work Email page, should return to the Work Email onboarding page.
After the user presses the Back button on the email validation page, the navigation goes to ONBOARDING_PERSONAL_DETAILS. I believe this is incorrect; it should go back to the work-email page.
What changes do you think we should make in order to solve the problem?
Change the destination to ONBOARDING_WORK_EMAIL page.
After setting it, we also need to change some Onyx onboarding values so the page won’t automatically redirect to the validation page because of this useEffect:
resetOnboardingMergeAccountStepValue(onboardingValues) to make the isMergeAccountStepCompleted to be undefined.
Then also check on the onboarding work email validation page.
Result:test_d.mp4
What alternative solutions did you explore? (Optional)
Instead of using isMergeAccountStepCompleted as a boolean, we could change it to an enum type (for example, InsertEmailStep and ValidateEmailStep) to make the merge account steps clearer.
Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.
changed the title [-]Onboarding – Continue button not responding after back from work email verification[/-][+][$250] Onboarding – Continue button not responding after back from work email verification[/+]on Nov 26, 2025
During onboarding, if the user adds a work email and is taken to the verification screen, then uses the back arrow and fills in the “What’s your name?” step, the Continue button no longer responds.
This suggests the onboarding modal visually moved to the name step, but the internal state that drives the CTA is still tied to the previous “verify work email” step or to a pending verification state, so the Continue handler is disabled or short-circuited.
Root cause hypothesis
Based on this flow and similar onboarding/back issues:
Onboarding uses a shared state (likely stored in Onyx) to track:
Current step (work email → verify work email → name → …)
Pending actions like work email verification
Flags that control whether the primary button is enabled and what it does.
When the user:
Signs up with a public email (Gmail)
Adds a work email and navigates to the verification page
Presses the back arrow
Ends up on the “What’s your name?” modal and clicks Continue
the modal route changes, but one or more of these things is not reset:
The “verify work email” step is still considered active or required
A “submit in progress / waiting for verification” flag remains true
The resolver that decides the CTA behaviour still expects the verification step before allowing the name step to continue
As a result, the Continue button on the name step either:
Remains disabled because the guard condition never becomes valid
Or fires a handler that immediately returns because it thinks the prerequisite (work email verification) is incomplete or in a blocking state.
This explains why the UI shows the name modal but the button does nothing across all platforms.
Implementation plan
Audit the onboarding step state and CTA enabling logic
Locate the onboarding modal component that drives:
“What’s your work email?”
“Verify your work email”
“What’s your name?”
Identify:
The enum or constants used for the current step
The state/Onyx keys that represent “waiting for work email verification” or similar
The function that decides:
Which handler is used by the primary button for each step
When the button is enabled or disabled
Goal: clearly see what is supposed to happen when moving from “verify work email” back to the “name” step.
Make the back action from the verification screen reset blocking flags
Update the back handler on the “verify your work email” screen so that, in addition to changing the visible step, it also clears any verification-specific blocking state.
For example (pseudocode):
When navigating back from the verification page:
Set currentOnboardingStep = NAME_STEP
Reset flags like:
isVerifyingWorkEmail = false
pendingWorkEmailVerification = null (if present)
Any “must complete this verification before proceeding” flag that influences the CTA
This ensures the onboarding “state machine” is aligned with what the user sees: after pressing back, we are on the name step and are not blocked by a stale verification state.
Decouple the “name” step CTA from the verification state
In the logic that defines whether the Continue button is enabled on the “What’s your name?” modal:
Ensure the button enabled state depends only on:
Name fields being valid (non-empty, trimmed, etc.)
No local submit in progress for the name itself
Avoid tying the name step’s CTA enablement directly to a flag that says “verification page is active” or “waiting for work email verification to finish”.
Concretely:
For the name step:
Primary button handler should always:
Save the name details
Advance to the next onboarding step
isDisabled for the CTA on this step should not depend on verification-only flags.
If there is a global guard that says “don’t advance until the work email state is consistent”, scope that guard so it does not affect the name step in this specific back-from-verification scenario.
Ensure step transitions are symmetrical
When going forward:
Work email → verify work email → name
When going backward:
Verify work email → name should:
Set currentStep = NAME
Clear any “verify page” locks
If there is a shared navigation helper for onboarding steps, add explicit handling for the path:
VERIFICATION_STEP → NAME_STEP
Add inline comments near this logic to explain:
Why we reset verification flags when going back
That the name step must always have a responsive CTA once the user sees it
This reduces the chance of reintroducing similar bugs if new onboarding rules are added.
Testing plan
I will test on staging with the exact steps from the report and some extra variations:
Repro flow (all platforms)
Sign up with a new Gmail account.
Add a work email when prompted.
On the verification page, click the back arrow.
Enter any name on the “What’s your name?” modal.
Click Continue.
Confirm:
Continue responds immediately.
The next onboarding page appears.
The button does not get stuck or become unresponsive.
Control flow without going back
Sign up with a new Gmail account.
Add a work email and complete the verification.
Continue through the name step as usual.
Confirm there are no regressions in the standard onboarding path.
Flow with skipping work email (if applicable)
Sign up with a new Gmail account.
Skip adding a work email if that option is present.
Go through the name step and subsequent steps.
Confirm the CTA behaves normally.
Cross-platform checks
Repeat the repro flow on:
MacOS: Safari and Chrome
Windows: Chrome
iOS: App and mWeb (Safari/Chrome)
Android: App and mWeb Chrome
For each platform, verify:
The Continue button on “What’s your name?” responds as expected after backing out of the verification page.
There is no unexpected jump back to earlier onboarding steps.
If this proposal is approved, I’ll implement the changes in a fork, open a PR with code, attach a short test matrix with the platforms I verified, and include any relevant screenshots of the fixed onboarding flow.
Please re-state the problem that we are trying to solve in this issue.
Continue button not responding after back from work email verification
What is the root cause of that problem?
I believe this issue originates from this PR: #73823.
Before this PR, when going back from the private domain onboarding flow, the modal would close. This is because we now use replace with forceReplace: true.
I think navigating to the personal onboarding screen here is not correct in the private domain case.
What changes do you think we should make in order to solve the problem?
We should restore the original back-navigation behavior for the private domain flow. Instead of navigating to the personal onboarding screen, the back action should simply close the modal or return to the previous step.
Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.
@tsa321 Thanks for the question. We will ask the product team during the PR phase. If they agree with changing this behavior, we will update it. It seems that @KocaPepsi has added a solution to handle the case of navigating back to the Add Work Email screen, which looks correct and doesn't require introducing new optimistic data.
[Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.
Link to discussion: N/A
[Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.
Yes
Regression Test Proposal Template
[BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.
changed the title [-][$250] Onboarding – Continue button not responding after back from work email verification[/-][+][Payment 2025-12-15] [$250] Onboarding – Continue button not responding after back from work email verification[/+]on Dec 15, 2025
Activity
melvin-bot commentedon Nov 24, 2025
Triggered auto assignment to @strepanier03 (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.ryntgh commentedon Nov 24, 2025
Proposal
Please re-state the problem that we are trying to solve in this issue.
Onboarding – Continue button not responding after back from work email verification
What is the root cause of that problem?
When navigating back from the work email verification page to the personal details page,
onboardingPurposeSelectedvalue is undefined. When the user clicks Continue, thehandleSubmitfunction callscompleteOnboarding, which returns early ifonboardingPurposeSelectedis undefinedApp/src/pages/OnboardingPersonalDetails/BaseOnboardingPersonalDetails.tsx
Lines 67 to 71 in 5375071
App/src/pages/OnboardingPersonalDetails/BaseOnboardingPersonalDetails.tsx
Lines 90 to 112 in 5375071
What changes do you think we should make in order to solve the problem?
We can check if
onboardingPurposeSelectedis undefined before callingcompleteOnboarding, and if it is, we can navigate to the purpose page to allow the user to select a purposeApp/src/pages/OnboardingPersonalDetails/BaseOnboardingPersonalDetails.tsx
Lines 105 to 112 in 5375071
What alternative solutions did you explore? (Optional)
We can navigate to
ROUTES.ONBOARDING_PURPOSEwhen going back from the work email verification pageApp/src/libs/actions/Welcome/index.ts
Lines 141 to 149 in 5375071
tsa321 commentedon Nov 25, 2025
Proposal
Please re-state the problem that we are trying to solve in this issue.
User cannot continue after back from onboarding work email verification. Instead of going back to the previous page, it redirects to the Personal Details page.
What is the root cause of that problem?
I think the page flow, when the user presses the Back button on the Validate Work Email page, should return to the Work Email onboarding page.
In here:
App/src/pages/OnboardingPrivateDomain/BaseOnboardingPrivateDomain.tsx
Lines 76 to 78 in a414faa
After the user presses the Back button on the email validation page, the navigation goes to ONBOARDING_PERSONAL_DETAILS. I believe this is incorrect; it should go back to the work-email page.
What changes do you think we should make in order to solve the problem?
Change the destination to ONBOARDING_WORK_EMAIL page.
After setting it, we also need to change some Onyx onboarding values so the page won’t automatically redirect to the validation page because of this useEffect:
App/src/pages/OnboardingWorkEmail/BaseOnboardingWorkEmail.tsx
Lines 67 to 95 in a414faa
The code forces the private-domain/email validation page to be displayed,
so we need to change some Onyx onboarding values.
When user addWorkMail:
App/src/libs/actions/Session/index.ts
Lines 1322 to 1330 in a414faa
on the success data we need to add:
Then add condition in here:
App/src/pages/OnboardingWorkEmail/BaseOnboardingWorkEmail.tsx
Line 88 in a414faa
and reset/remove the
isMergeAccountStepCompletedto be undefined when user press the goBack button in the email validation page:App/src/pages/OnboardingPrivateDomain/BaseOnboardingPrivateDomain.tsx
Line 77 in a414faa
resetOnboardingMergeAccountStepValue(onboardingValues)to make the isMergeAccountStepCompleted to be undefined.Then also check on the onboarding work email validation page.
Result:
test_d.mp4
What alternative solutions did you explore? (Optional)
Instead of using
isMergeAccountStepCompletedas a boolean, we could change it to an enum type (for example,InsertEmailStepandValidateEmailStep) to make the merge account steps clearer.Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.
strepanier03 commentedon Nov 26, 2025
Able to repro, moving forward.
[-]Onboarding – Continue button not responding after back from work email verification[/-][+][$250] Onboarding – Continue button not responding after back from work email verification[/+]melvin-bot commentedon Nov 26, 2025
Job added to Upwork: https://www.upwork.com/jobs/~021993528272484606590
melvin-bot commentedon Nov 26, 2025
Triggered auto assignment to Contributor-plus team member for initial proposal review - @huult (
External)AlbadawiDev commentedon Nov 26, 2025
Hi, here is my proposal for fixing this issue.
Summary
During onboarding, if the user adds a work email and is taken to the verification screen, then uses the back arrow and fills in the “What’s your name?” step, the Continue button no longer responds.
This suggests the onboarding modal visually moved to the name step, but the internal state that drives the CTA is still tied to the previous “verify work email” step or to a pending verification state, so the Continue handler is disabled or short-circuited.
Root cause hypothesis
Based on this flow and similar onboarding/back issues:
Onboarding uses a shared state (likely stored in Onyx) to track:
Current step (work email → verify work email → name → …)
Pending actions like work email verification
Flags that control whether the primary button is enabled and what it does.
When the user:
Signs up with a public email (Gmail)
Adds a work email and navigates to the verification page
Presses the back arrow
Ends up on the “What’s your name?” modal and clicks Continue
the modal route changes, but one or more of these things is not reset:
The “verify work email” step is still considered active or required
A “submit in progress / waiting for verification” flag remains true
The resolver that decides the CTA behaviour still expects the verification step before allowing the name step to continue
As a result, the Continue button on the name step either:
Remains disabled because the guard condition never becomes valid
Or fires a handler that immediately returns because it thinks the prerequisite (work email verification) is incomplete or in a blocking state.
This explains why the UI shows the name modal but the button does nothing across all platforms.
Implementation plan
Locate the onboarding modal component that drives:
“What’s your work email?”
“Verify your work email”
“What’s your name?”
Identify:
The enum or constants used for the current step
The state/Onyx keys that represent “waiting for work email verification” or similar
The function that decides:
Which handler is used by the primary button for each step
When the button is enabled or disabled
Goal: clearly see what is supposed to happen when moving from “verify work email” back to the “name” step.
Update the back handler on the “verify your work email” screen so that, in addition to changing the visible step, it also clears any verification-specific blocking state.
For example (pseudocode):
When navigating back from the verification page:
Set currentOnboardingStep = NAME_STEP
Reset flags like:
isVerifyingWorkEmail = false
pendingWorkEmailVerification = null (if present)
Any “must complete this verification before proceeding” flag that influences the CTA
This ensures the onboarding “state machine” is aligned with what the user sees: after pressing back, we are on the name step and are not blocked by a stale verification state.
In the logic that defines whether the Continue button is enabled on the “What’s your name?” modal:
Ensure the button enabled state depends only on:
Name fields being valid (non-empty, trimmed, etc.)
No local submit in progress for the name itself
Avoid tying the name step’s CTA enablement directly to a flag that says “verification page is active” or “waiting for work email verification to finish”.
Concretely:
For the name step:
Primary button handler should always:
Save the name details
Advance to the next onboarding step
isDisabled for the CTA on this step should not depend on verification-only flags.
If there is a global guard that says “don’t advance until the work email state is consistent”, scope that guard so it does not affect the name step in this specific back-from-verification scenario.
When going forward:
Work email → verify work email → name
When going backward:
Verify work email → name should:
Set currentStep = NAME
Clear any “verify page” locks
If there is a shared navigation helper for onboarding steps, add explicit handling for the path:
VERIFICATION_STEP → NAME_STEP
Add inline comments near this logic to explain:
Why we reset verification flags when going back
That the name step must always have a responsive CTA once the user sees it
This reduces the chance of reintroducing similar bugs if new onboarding rules are added.
Testing plan
I will test on staging with the exact steps from the report and some extra variations:
Repro flow (all platforms)
Sign up with a new Gmail account.
Add a work email when prompted.
On the verification page, click the back arrow.
Enter any name on the “What’s your name?” modal.
Click Continue.
Confirm:
Continue responds immediately.
The next onboarding page appears.
The button does not get stuck or become unresponsive.
Control flow without going back
Sign up with a new Gmail account.
Add a work email and complete the verification.
Continue through the name step as usual.
Confirm there are no regressions in the standard onboarding path.
Flow with skipping work email (if applicable)
Sign up with a new Gmail account.
Skip adding a work email if that option is present.
Go through the name step and subsequent steps.
Confirm the CTA behaves normally.
Cross-platform checks
Repeat the repro flow on:
MacOS: Safari and Chrome
Windows: Chrome
iOS: App and mWeb (Safari/Chrome)
Android: App and mWeb Chrome
For each platform, verify:
The Continue button on “What’s your name?” responds as expected after backing out of the verification page.
There is no unexpected jump back to earlier onboarding steps.
If this proposal is approved, I’ll implement the changes in a fork, open a PR with code, attach a short test matrix with the platforms I verified, and include any relevant screenshots of the fixed onboarding flow.
KocaPepsi commentedon Nov 26, 2025
Proposal
Please re-state the problem that we are trying to solve in this issue.
Continue button not responding after back from work email verification
What is the root cause of that problem?
I believe this issue originates from this PR: #73823.
Before this PR, when going back from the private domain onboarding flow, the modal would close. This is because we now use replace with
forceReplace: true.App/src/pages/OnboardingWorkEmail/BaseOnboardingWorkEmail.tsx
Lines 89 to 92 in 2f55ceb
and Before this PR, we only used
Navigation.goBack().After applying this PR (#73823), the flow was changed so that it now navigates to the personal onboarding screen to handle other cases
App/src/pages/OnboardingPrivateDomain/BaseOnboardingPrivateDomain.tsx
Lines 76 to 79 in 2f55ceb
I think navigating to the personal onboarding screen here is not correct in the private domain case.
What changes do you think we should make in order to solve the problem?
We should restore the original back-navigation behavior for the private domain flow. Instead of navigating to the personal onboarding screen, the back action should simply close the modal or return to the previous step.
App/src/pages/OnboardingPrivateDomain/BaseOnboardingPrivateDomain.tsx
Lines 76 to 79 in 2f55ceb
replace to:
What alternative solutions did you explore? (Optional)
If we want to go back to the Add Workspace Email screen, then we should handle it like this.
App/src/pages/OnboardingPrivateDomain/BaseOnboardingPrivateDomain.tsx
Lines 76 to 79 in 2f55ceb
replace to:
Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.
Video demo after the issue is resolved.
1_1.mp4
11 remaining items
KocaPepsi commentedon Nov 27, 2025
I have updated proposal
Onboarding – Continue button not responding after back from work emai…
huult commentedon Nov 27, 2025
@tsa321 Thanks for the question. We will ask the product team during the PR phase. If they agree with changing this behavior, we will update it. It seems that @KocaPepsi has added a solution to handle the case of navigating back to the Add Work Email screen, which looks correct and doesn't require introducing new optimistic data.
@KocaPepsi could you provide an ETA for your PR?
KocaPepsi commentedon Dec 2, 2025
Hi @strepanier03, @flodnv
It seems Upwork is unable to create a contract for me. I don’t see any Upwork contract on my side on the Upwork page
huult commentedon Dec 6, 2025
This was deployed to production already, and the payout date must be updated.
huult commentedon Dec 11, 2025
@strepanier03 This issue is ready for payment.
huult commentedon Dec 15, 2025
BugZero Checklist:
[Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.
Link to comment: https://github.com/Expensify/App/pull/73823/changes#r2617727489
[Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.
Link to discussion: N/A
[Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.
Yes
Regression Test Proposal Template
[BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.
Link to issue:
Regression Test Proposal
Precondition:
Test:
Do we agree 👍 or 👎
strepanier03 commentedon Dec 15, 2025
Payment Summary
[-][$250] Onboarding – Continue button not responding after back from work email verification[/-][+][Payment 2025-12-15] [$250] Onboarding – Continue button not responding after back from work email verification[/+]huult commentedon Dec 17, 2025
I accepted your offer.
strepanier03 commentedon Dec 18, 2025
Nice, all set. I paid and closed the contract.