Repository navigation
fix: refreshing verify your email page lead to what's your name page - #73823
Conversation
Codecov Report❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.
|
|
@ZhenjaHorbach Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
|
LGTM 👍 Thank you for your hard work! |
Reviewer Checklist
Screenshots/VideosAndroid: HybridApp2025-11-12.12.09.40.movAndroid: mWeb Chrome2025-11-12.12.04.58.moviOS: HybridApp2025-11-12.12.00.20.moviOS: mWeb Safari2025-11-12.12.00.20.movMacOS: Chrome / Safari2025-11-12.11.56.22.movMacOS: Desktop2025-11-12.11.56.22.mov |
|
We have a broken navigation after reloading 2025-11-03.09.47.21.mov |
|
And I suppose after reloading native app we also want to see a verification screen 2025-11-03.09.51.21.mov |
@ZhenjaHorbach i updated |
@ZhenjaHorbach when you use ios simulator and use devtools to reload the app, it always goes to the home page (initial route) (you can try with other pages) |
joekaufmanexpensify
left a comment
There was a problem hiding this comment.
Fine from a product perspective
|
friendly bump here @ZhenjaHorbach |
Sorry for the delay |
|
LGTM! |
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🚀 Deployed to staging by https://github.com/Gonals in version: 9.2.55-3 🚀
|
|
🚀 Deployed to staging by https://github.com/Gonals in version: 9.2.57-0 🚀
|
|
🚀 Deployed to production by https://github.com/cristipaval in version: 9.2.57-4 🚀
|
| onBackButtonPress={Navigation.goBack} | ||
| onBackButtonPress={() => { | ||
| const routeToNavigate = (route.params?.backTo as Route) ?? ROUTES.ONBOARDING_PERSONAL_DETAILS.getRoute(); | ||
| Navigation.goBack(routeToNavigate); |
There was a problem hiding this comment.
This comes from #75863. We didn’t handle the private domain case, which caused navigation to go to the wrong page.
Explanation of Change
Refreshing verify your email page lead to what's your name page, so we need to change the logic in
getOnboardingInitialPathfunction to return the true init routeFixed Issues
$ #73199
PROPOSAL: #73199 (comment)
Tests
Offline tests
Same as tests
QA Steps
Same as tests
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectioncanBeMissingparam foruseOnyxtoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
android-mweb.mov
iOS: Native
iOS: mWeb Safari
ios-mweb.mov
MacOS: Chrome / Safari
web.mov
MacOS: Desktop
desktop.mov