Skip to content

[$250] Onboarding - Refresh when on the accounting software modal doesn't remain on the same page #75649

Closed

Description

@nlemma

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: v9.2.61-1
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught during regression testing, add the test name, ID and link from BrowserStack: https://test-management.browserstack.com/projects/2219752/folder/13176677/test-cases/41237662
Email or phone of affected tester (no customers): private domain account
Issue reported by: Applause Internal Team
Device used: Windows 11 / Chrome, Chrome / Xiaomi Poco F5, macOS 14.5 / MacBook Air 2020
App Component: Other

Action Performed:

  1. Go to staging.new.expensify.com
  2. Create new account using a private domain email that is associated with existing accounts (e.g., xyz+anything@futebr.com)
  3. Fill any name > Continue
  4. Click Skip on the Verify your email modal
  5. Select the option "Manage my team's expenses"
  6. Select the option of "1-10 employees" and click Continue
  7. In "Do you use any accounting software?" modal, try to refresh the page

Expected Result:

User should remain in the "Do you use any accounting software?" page after refreshing the page

Actual Result:

Refreshing the page when on the accounting software modal doesn't remain on the same page
Note:

  • User will be redirected to the personal details modal, and the "What features are you interested in?" modal will be skipped
  • This issue does not reproduce when register using a Gmail account
  • This issue does not reproduce on native app (Android/iOS)

Workaround:

Unknown

Platforms:

  • Android: App
  • Android: mWeb Chrome
  • iOS: App
  • iOS: mWeb Safari
  • iOS: mWeb Chrome
  • Windows: Chrome
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Bug7002481_1763015753449.74958_-_Onboarding_-_Refresh_when_on_the_accounting_software_modal_doesn_t_remain_on_the_same_page.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~021991576602783556222
  • Upwork Job ID: 1991576602783556222
  • Last Price Increase: 2025-12-04
Issue OwnerCurrent Issue Owner: @neil-marcellini

Activity

  1. added
    BugSomething is broken. Auto assigns a BugZero manager.
    on Nov 20, 2025
  2. melvin-bot commented on Nov 20, 2025

    @melvin-bot

    Triggered auto assignment to @Christinadobrzyn (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  3. melvin-bot commented on Nov 20, 2025

    @melvin-bot

    📣 @sven-100ws6! 📣
    Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
    Please follow these steps:

    1. Make sure you've read and understood the contributing guidelines.
    2. Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
    3. Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
    4. Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.
      Screen Shot 2022-11-16 at 4 42 54 PM
      Format:
    Contributor details
    Your Expensify account email: <REPLACE EMAIL HERE>
    Upwork Profile Link: <REPLACE LINK HERE>
    
  4. nkdengineer commented on Nov 20, 2025

    @nkdengineer
    Contributor

    Proposal

    Please re-state the problem that we are trying to solve in this issue.

    Refreshing the page when on the accounting software modal doesn't remain on the same page
    Note:

    What is the root cause of that problem?

    For the private domain, we only navigate to the onboardingInitialPath page if it's the private domain step or personal detail step

    if (onboardingInitialPath.includes(ROUTES.ONBOARDING_PRIVATE_DOMAIN.route) || onboardingInitialPath.includes(ROUTES.ONBOARDING_PERSONAL_DETAILS.route)) {

    What changes do you think we should make in order to solve the problem?

    We should always navigate to the onboardingInitialPath if it exists

    if (onboardingInitialPath) {
                return onboardingInitialPath;
            }
    

    if (onboardingInitialPath.includes(ROUTES.ONBOARDING_PRIVATE_DOMAIN.route) || onboardingInitialPath.includes(ROUTES.ONBOARDING_PERSONAL_DETAILS.route)) {

    What alternative solutions did you explore? (Optional)

    Or we can add a new case for employee step/accounting step or other steps if needed

    if (onboardingInitialPath.includes(ROUTES.ONBOARDING_PRIVATE_DOMAIN.route) || onboardingInitialPath.includes(ROUTES.ONBOARDING_PERSONAL_DETAILS.route) || onboardingInitialPath.includes(ROUTES.ONBOARDING_EMPLOYEES.route) ||  onboardingInitialPath.includes(ROUTES.ONBOARDING_ACCOUNTING.route)) {
                return onboardingInitialPath;
            }
    

    if (onboardingInitialPath.includes(ROUTES.ONBOARDING_PRIVATE_DOMAIN.route) || onboardingInitialPath.includes(ROUTES.ONBOARDING_PERSONAL_DETAILS.route)) {

    Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

  5. samranahm commented on Nov 20, 2025

    @samranahm
    Contributor

    Potential regression from #73823

  6. lorretheboy commented on Nov 20, 2025

    @lorretheboy
    Contributor

    Possibly dup with #75605

    Same solution from #75605 can fix this issue

  7. added
    ExternalAdded to denote the issue can be worked on by a contributor
    on Nov 20, 2025
  8. changed the title [-]Onboarding - Refresh when on the accounting software modal doesn't remain on the same page[/-] [+][$250] Onboarding - Refresh when on the accounting software modal doesn't remain on the same page[/+] on Nov 20, 2025
  9. melvin-bot commented on Nov 20, 2025

    @melvin-bot
  10. added
    Help WantedApply this label when an issue is open to proposals by contributors
    on Nov 20, 2025
  11. melvin-bot commented on Nov 20, 2025

    @melvin-bot

    Triggered auto assignment to Contributor-plus team member for initial proposal review - @FitseTLT (External)

  12. Christinadobrzyn commented on Nov 20, 2025

    @Christinadobrzyn
    Contributor

    Thanks so much for the input @lorretheboy and @samranahm! Adding a C+ to help determine if we should just close this as a dupe or Hold for #73823

    @FitseTLT can you help with the best next steps?

  13. 24 remaining items

  14. melvin-bot commented on Dec 9, 2025

    @melvin-bot

    Triggered auto assignment to @neil-marcellini, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

  15. neil-marcellini commented on Dec 9, 2025

    @neil-marcellini
    Contributor

    @nkdengineer 's Proposal LGTM

    🎀 👀 🎀 C+ reviewed

    I would like to know why that logic was added in the first place. Was there a good reason for it? Removing it won't create any regressions right?

  16. neil-marcellini commented on Dec 12, 2025

    @neil-marcellini
    Contributor

    Not overdue, waiting for @nkdengineer to reply

  17. nkdengineer commented on Dec 12, 2025

    @nkdengineer
    Contributor

    @neil-marcellini It's fixed here #75605. We can close this one.

  18. mvtglobally commented on Dec 13, 2025

    @mvtglobally

    Issue not reproducible during KI retests. (First week)

  19. melvin-bot commented on Dec 16, 2025

    @melvin-bot

    @neil-marcellini Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

BugSomething is broken. Auto assigns a BugZero manager.DailyKSv2ExternalAdded to denote the issue can be worked on by a contributorHelp WantedApply this label when an issue is open to proposals by contributors

Type

No type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions