Skip to content

[Due for payment 2026-06-17] Remove deprecated report name functions in ReportUtils #76852

Closed

Description

@neil-marcellini

Problem

In this PR we moved a bunch of functions to a ReportNameUtils file, made some modifications to make them pure functions and we marked the original source functions from ReportUtils as deprecated.

We did that as part of this issue Refactor getReportName to prepare for formula computation which was the first step of this larger refactor - [HOLD 72613] Refactor optimistic custom report names to use Onyx derived values

Overall we didn't get too far before deciding to abandon this approach due to low ROI. Now we need to clean up the code.

Solution

Remove the deprecated functions. We might also want to rename the function computeReportName in ReportNameUtils to computeReportNameWithoutFormula or something similar to make its use more clear.

Issue OwnerCurrent Issue Owner: @neil-marcellini

Activity

  1. added
    ExternalAdded to denote the issue can be worked on by a contributor
    on Dec 5, 2025
  2. added
    Help WantedApply this label when an issue is open to proposals by contributors
    on Dec 5, 2025
  3. melvin-bot commented on Dec 5, 2025

    @melvin-bot

    Triggered auto assignment to Contributor-plus team member for initial proposal review - @eVoloshchak (External)

  4. lorretheboy commented on Dec 5, 2025

    @lorretheboy
    Contributor

    I can help to open PR based on solution in OP if needed

  5. neil-marcellini commented on Dec 5, 2025

    @neil-marcellini
    ContributorAuthor

    Sure thanks, go for it!

  6. removed
    Help WantedApply this label when an issue is open to proposals by contributors
    on Dec 5, 2025
  7. lorretheboy commented on Dec 8, 2025

    @lorretheboy
    Contributor

    Daily update: The PR is almost ready, the PR is larger than I estimated, there are still several places of getReportName need to be updated to use new method (this func call is a complex than others). I expect it is ready for review tomorrow

    Or maybe we can separate to handle the getReportName into another PR for easier to review and testing? What do you think? @neil-marcellini @eVoloshchak

    Here is the current PR (WIP)

  8. 165 remaining items

  9. changed the title [-]Remove deprecated report name functions in ReportUtils[/-] [+][Due for payment 2026-06-17] Remove deprecated report name functions in ReportUtils[/+] on Jun 10, 2026
  10. melvin-bot commented on Jun 10, 2026

    @melvin-bot

    Reviewing label has been removed, please complete the "BugZero Checklist".

  11. melvin-bot commented on Jun 10, 2026

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 9.4.4-3 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2026-06-17. 🎊

    For reference, here are some details about the assignees on this issue:

    • @sosek108 does not require payment (Contractor)
    • @eVoloshchak requires payment through NewDot Manual Requests
  12. mallenexpensify commented on Jun 18, 2026

    @mallenexpensify
    Contributor

    @eVoloshchak if you're due payment here, please comment and tag me.

  13. eVoloshchak commented on Aug 3, 2026

    @eVoloshchak
    Contributor

    @mallenexpensify, this is ready for payment
    The updated list of PR's is at #76852 (comment)

  14. mallenexpensify commented on Aug 4, 2026

    @mallenexpensify
    Contributor

    @neil-marcellini 👀 on the payment comment above to propose what payment should be. Thx

  15. neil-marcellini commented on Aug 4, 2026

    @neil-marcellini
    ContributorAuthor

    @neil-marcellini 👀 on the payment comment above to propose what payment should be. Thx

    Looks like @eVoloshchak did good C+ work on all of those PRs listed in the comment, except for 1 which was merged elsewhere as noted. So I suggest paying 6x whatever the normal C+ PR review payment is. I think 6 x 250 = 1500?

  16. melvin-bot commented on Aug 4, 2026

    @melvin-bot

    Current assignee @mallenexpensify is eligible for the Awaiting Payment assigner, not assigning anyone new.

  17. mallenexpensify commented on Aug 5, 2026

    @mallenexpensify
    Contributor

    Payment Summary

    Contributor+: @eVoloshchak due $1500 via NewDot

    Thanks @neil-marcellini !

  18. JmillsExpensify commented on Aug 5, 2026

    @JmillsExpensify
    Contributor

    $1,500 approved for @eVoloshchak

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionDailyKSv2ExternalAdded to denote the issue can be worked on by a contributor

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions