You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[Due for payment 2026-06-17] Remove deprecated report name functions in ReportUtils #76852
In this PR we moved a bunch of functions to a ReportNameUtils file, made some modifications to make them pure functions and we marked the original source functions from ReportUtils as deprecated.
Overall we didn't get too far before deciding to abandon this approach due to low ROI. Now we need to clean up the code.
Solution
Remove the deprecated functions. We might also want to rename the function computeReportName in ReportNameUtils to computeReportNameWithoutFormula or something similar to make its use more clear.
Daily update: The PR is almost ready, the PR is larger than I estimated, there are still several places of getReportName need to be updated to use new method (this func call is a complex than others). I expect it is ready for review tomorrow
Or maybe we can separate to handle the getReportName into another PR for easier to review and testing? What do you think? @neil-marcellini@eVoloshchak
changed the title [-]Remove deprecated report name functions in ReportUtils[/-][+][Due for payment 2026-06-17] Remove deprecated report name functions in ReportUtils[/+]on Jun 10, 2026
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.4.4-3 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
Looks like @eVoloshchak did good C+ work on all of those PRs listed in the comment, except for 1 which was merged elsewhere as noted. So I suggest paying 6x whatever the normal C+ PR review payment is. I think 6 x 250 = 1500?
Activity
melvin-bot commentedon Dec 5, 2025
Triggered auto assignment to Contributor-plus team member for initial proposal review - @eVoloshchak (
External)lorretheboy commentedon Dec 5, 2025
I can help to open PR based on solution in OP if needed
neil-marcellini commentedon Dec 5, 2025
Sure thanks, go for it!
lorretheboy commentedon Dec 8, 2025
Daily update: The PR is almost ready, the PR is larger than I estimated, there are still several places of
getReportNameneed to be updated to use new method (this func call is a complex than others). I expect it is ready for review tomorrowOr maybe we can separate to handle the
getReportNameinto another PR for easier to review and testing? What do you think? @neil-marcellini @eVoloshchakHere is the current PR (WIP)
165 remaining items
[-]Remove deprecated report name functions in ReportUtils[/-][+][Due for payment 2026-06-17] Remove deprecated report name functions in ReportUtils[/+]melvin-bot commentedon Jun 10, 2026
Reviewinglabel has been removed, please complete the "BugZero Checklist".melvin-bot commentedon Jun 10, 2026
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.4.4-3 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2026-06-17. 🎊
For reference, here are some details about the assignees on this issue:
mallenexpensify commentedon Jun 18, 2026
@eVoloshchak if you're due payment here, please comment and tag me.
eVoloshchak commentedon Aug 3, 2026
@mallenexpensify, this is ready for payment
The updated list of PR's is at #76852 (comment)
mallenexpensify commentedon Aug 4, 2026
@neil-marcellini 👀 on the payment comment above to propose what payment should be. Thx
neil-marcellini commentedon Aug 4, 2026
Looks like @eVoloshchak did good C+ work on all of those PRs listed in the comment, except for 1 which was merged elsewhere as noted. So I suggest paying 6x whatever the normal C+ PR review payment is. I think 6 x 250 = 1500?
melvin-bot commentedon Aug 4, 2026
Current assignee @mallenexpensify is eligible for the Awaiting Payment assigner, not assigning anyone new.
mallenexpensify commentedon Aug 5, 2026
Payment Summary
Contributor+: @eVoloshchak due $1500 via NewDot
Thanks @neil-marcellini !
JmillsExpensify commentedon Aug 5, 2026
$1,500 approved for @eVoloshchak