Skip to content

[Due for payment 2026-04-30] [Due for payment 2026-04-20] [$250] Screen Reader: Workspace-Workflow: Disabled 'Next' button is not announced as such #76908

Closed

Description

@nbhardwaj-del

Action Performed:

Prerequisite:
User is logged in
User has created at least one workspace

  1. Using JAWS + Chrome, open the page https://new.expensify.com/workspaces
  2. Navigate using TAB to any workspace created, press enter to activate
  3. Navigate using TAB to 'Workflows' located in the middle navigation column, press enter to activate
  4. Navigate using TAB to the 'Add Approval Workflow' button, press enter to activate
  5. Navigate using TAB to the disabled 'Next' button at the bottom of the menu
  6. Observe the announcement

Expected Result:

When users navigate to the disabled 'Next' button will announced as disabled to users
Expected announcement:
-"Next, disabled, button"

Actual Result:

When users navigate to the disabled 'Next' button in the 'Expenses from' menu, the screen reader does not announced its state as disabled, The screen reader only announces 'Next, button', thus indicating the button is active and available for interaction. Hence the screen reader will not be aware of the state of the button.

Next

Area issue was found in:

Workspace Workflow

Failed WCAG checkpoints

WCAG 4.1.2 Name, Role, Value
https://www.w3.org/WAI/WCAG22/Understanding/name-role-value

User impact:

Providing role, state, and value information on all user interface components enables compatibility with assistive technology, such as screen readers, screen magnifiers, and speech recognition software, used by people with disabilities.

Suggested resolution:

Use aria-disabled attribute and set its value to true to announce to users when the button is disabled

Refer:
https://developer.mozilla.org/en-US/docs/Web/Accessibility/ARIA/Reference/Attributes/aria-disabled

Environment(s)

Windows Windows 10 - Chrome

Screenshots/Videos

Bug6996252_1762448957565.Disabled_next_button_not_announced_as_such.mp4
Image

Version Number: NA
Reproducible in staging?: NA
Reproducible in production?: Yes
Email or phone of affected tester (no customers): NA
Logs: https://stackoverflow.com/c/expensify/questions/4856 NA
Notes/Photos/Videos: Any additional supporting documentation Yes
Expensify/Expensify Issue URL: https://platform.applause.com/company/12102/products/36605/community-issues/6996252
Issue reported by: NA
Slack conversation: NA

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~022013150999572026570
  • Upwork Job ID: 2013150999572026570
  • Last Price Increase: 2026-01-26
Issue OwnerCurrent Issue Owner: @Krishna2323

Activity

  1. mavrickdeveloper commented on Dec 7, 2025

    @mavrickdeveloper
    Contributor

    PROPOSAL

    Please re-state the problem that we are trying to solve in this issue.

    When users navigate to the disabled 'Next' button in the 'Expenses from' menu, the screen reader does not announced its state as disabled, The screen reader only announces 'Next, button', thus indicating the button is active and available for interaction. Hence the screen reader will not be aware of the state of the button.

    What is the root cause of that problem?

    1-WorkspaceWorkflowsApprovalsExpensesFromPage.tsx Uses FormAlertWithSubmitButton with isDisabled prop

    let buttonText = isInitialCreationFlow ? translate('common.next') : translate('common.save');
    if (shouldShowListEmptyContent) {
    buttonText = translate('common.buttonConfirm');
    }
    return (
    <FormAlertWithSubmitButton
    isDisabled={!shouldShowListEmptyContent && !selectedMembers.length}
    buttonText={buttonText}
    onSubmit={shouldShowListEmptyContent ? () => Navigation.goBack() : nextStep}
    containerStyles={[styles.flexReset, styles.flexGrow0, styles.flexShrink0, styles.flexBasisAuto]}
    enabledWhenOffline
    />
    );

    2-FormAlertWithSubmitButton.tsx / Passes isDisabled to Button

    ) : (
    <Button
    ref={buttonRef}
    success
    shouldBlendOpacity={shouldBlendOpacity}
    pressOnEnter={pressOnEnter}
    enterKeyEventListenerPriority={enterKeyEventListenerPriority}
    text={buttonText}
    style={style}
    onPress={onSubmit}
    isDisabled={isDisabled}
    isLoading={isLoading}
    danger={isSubmitActionDangerous}
    medium={useSmallerSubmitButtonSize}
    large={!useSmallerSubmitButtonSize}
    onMouseDown={shouldPreventDefaultFocusOnPress ? (e) => e.preventDefault() : undefined}
    />

    3-BaseGenericPressable.tsx / The core issue location

    accessibilityState={{
    disabled: isDisabled,
    ...rest.accessibilityState,
    }}
    aria-disabled={isDisabled}
    aria-keyshortcuts={keyboardShortcut && `${keyboardShortcut.modifiers.join('')}+${keyboardShortcut.shortcutKey}`}
    // ios-only form of inputs
    onMagicTap={!isDisabled ? voidOnPressHandler : undefined}
    onAccessibilityTap={!isDisabled ? voidOnPressHandler : undefined}
    accessible={accessible}
    fsClass={forwardedFSClass}
    // eslint-disable-next-line react/jsx-props-no-spreading
    {...rest}

    aria-disabled={isDisabled} is set at line 179, but {...rest} is spread AFTER at line 187. This means:
    If any parent component passes props that could affect aria-disabled or accessibilityState, those values from {...rest} would override our explicit accessibility settings
    In JSX, when the same prop is set multiple times, the last one wins
    The accessibility props should be set AFTER the rest spread to ensure they always take precedence

    What changes do you think we should make in order to solve the problem?

    BEFORE (problematic):

    accessibilityState={{ disabled: isDisabled, ...rest.accessibilityState }}
    aria-disabled={isDisabled}
    accessible={accessible}
    // ...
    {...rest}  // <----- Could override accessibility props

    AFTER (FIX):

    {...rest}  // ← Spread first
    // accessibility props - placed after {...rest} to ensure they take precedence
    accessibilityState={{
        ...rest.accessibilityState,
        disabled: isDisabled,  // <-----  Our value wins (comes last)
    }}
    aria-disabled={isDisabled}  // <-----  Always correctly set
    accessible={accessible}

    With that ,The accessibility props now come after {...rest}, ensuring aria-disabled={isDisabled} always reflects the computed disabled state and screen readers will properly announce "disabled" for disabled buttons.

  2. melvin-bot commented on Dec 17, 2025

    @melvin-bot

    Now this issue is 8 days overdue. Are you sure this should be a Daily? Feel free to change it!

  3. melvin-bot commented on Dec 18, 2025

    @melvin-bot

    10 days overdue. Is anyone even seeing these? Hello?

  4. melvin-bot commented on Dec 24, 2025

    @melvin-bot

    This issue has not been updated in over 14 days. eroding to Weekly issue.

  5. added a commit that references this issue on Jan 8, 2026
    c073d9c
  6. added
    ReviewingHas a PR in review
    and removed on Jan 8, 2026
  7. 98 remaining items

  8. mallenexpensify commented on Apr 21, 2026

    @mallenexpensify
    Contributor

    @Krishna2323 @truph01 is payment due here? If so, how much? Looks like there was a revert

    @truph01 PR was reverted here: #87647

  9. truph01 commented on Apr 23, 2026

    @truph01
    Contributor

    @mallenexpensify The PR was reverted due to a backend issue. The API is expected to return a boolean value, but it is currently returning a string instead. Although the crash did not occur prior to that PR, I don’t think this should be classified as a regression from the frontend PR.

    cc @chuckdries for additional technical insight

  10. chuckdries commented on Apr 23, 2026

    @chuckdries
    Contributor

    It was definitely a weird edge case, made even weirder by the fact that I could reliably repro the crash when I did the revert, but not after. I think we can call it a fluke and pay out full here

  11. changed the title [-][Due for payment 2026-04-20] [$250] Screen Reader: Workspace-Workflow: Disabled 'Next' button is not announced as such[/-] [+][Due for payment 2026-04-30] [Due for payment 2026-04-20] [$250] Screen Reader: Workspace-Workflow: Disabled 'Next' button is not announced as such[/+] on Apr 23, 2026
  12. melvin-bot commented on Apr 23, 2026

    @melvin-bot

    Reviewing label has been removed, please complete the "BugZero Checklist".

  13. melvin-bot commented on Apr 23, 2026

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 9.3.61-4 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2026-04-30. 🎊

    For reference, here are some details about the assignees on this issue:

    • @Krishna2323 requires payment through NewDot Manual Requests
    • @truph01 requires payment through NewDot Manual Requests
  14. melvin-bot commented on Apr 23, 2026

    @melvin-bot

    @Krishna2323 / @truph01 @mallenexpensify The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

  15. mallenexpensify commented on Apr 24, 2026

    @mallenexpensify
    Contributor

    Payment Summary

    Contributor+: @Krishna2323 due $250 via NewDot
    Contributor+: @truph01 due $250 via NewDot

    Thx

  16. garrettmknight commented on May 10, 2026

    @garrettmknight
    Contributor

    $250 approved for @truph01

  17. Krishna2323 commented on May 15, 2026

    @Krishna2323
    Contributor

    Requested in ND.

  18. laurenreidexpensify commented on May 19, 2026

    @laurenreidexpensify
    Contributor

    $250 approved for @Krishna2323

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

AccessibilityIssues affecting WACG accessibility on any platform.Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2ExternalAdded to denote the issue can be worked on by a contributor

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions