Repository navigation
Description
Action Performed:
Prerequisite:
User is logged in
User has created at least one workspace
- Using JAWS + Chrome, open the page https://new.expensify.com/workspaces
- Navigate using TAB to any workspace created, press enter to activate
- Navigate using TAB to 'Workflows' located in the middle navigation column, press enter to activate
- Navigate using TAB to the 'Add Approval Workflow' button, press enter to activate
- Navigate using TAB to the disabled 'Next' button at the bottom of the menu
- Observe the announcement
Expected Result:
When users navigate to the disabled 'Next' button will announced as disabled to users
Expected announcement:
-"Next, disabled, button"
Actual Result:
When users navigate to the disabled 'Next' button in the 'Expenses from' menu, the screen reader does not announced its state as disabled, The screen reader only announces 'Next, button', thus indicating the button is active and available for interaction. Hence the screen reader will not be aware of the state of the button.
Area issue was found in:
Workspace Workflow
Failed WCAG checkpoints
WCAG 4.1.2 Name, Role, Value
https://www.w3.org/WAI/WCAG22/Understanding/name-role-value
User impact:
Providing role, state, and value information on all user interface components enables compatibility with assistive technology, such as screen readers, screen magnifiers, and speech recognition software, used by people with disabilities.
Suggested resolution:
Use aria-disabled attribute and set its value to true to announce to users when the button is disabled
Refer:
https://developer.mozilla.org/en-US/docs/Web/Accessibility/ARIA/Reference/Attributes/aria-disabled
Environment(s)
Windows Windows 10 - Chrome
Screenshots/Videos
Bug6996252_1762448957565.Disabled_next_button_not_announced_as_such.mp4
Version Number: NA
Reproducible in staging?: NA
Reproducible in production?: Yes
Email or phone of affected tester (no customers): NA
Logs: https://stackoverflow.com/c/expensify/questions/4856 NA
Notes/Photos/Videos: Any additional supporting documentation Yes
Expensify/Expensify Issue URL: https://platform.applause.com/company/12102/products/36605/community-issues/6996252
Issue reported by: NA
Slack conversation: NA
Upwork Automation - Do Not Edit
- Upwork Job URL: https://www.upwork.com/jobs/~022013150999572026570
- Upwork Job ID: 2013150999572026570
- Last Price Increase: 2026-01-26
Activity
mavrickdeveloper commentedon Dec 7, 2025
PROPOSAL
Please re-state the problem that we are trying to solve in this issue.
When users navigate to the disabled 'Next' button in the 'Expenses from' menu, the screen reader does not announced its state as disabled, The screen reader only announces 'Next, button', thus indicating the button is active and available for interaction. Hence the screen reader will not be aware of the state of the button.
What is the root cause of that problem?
1-
WorkspaceWorkflowsApprovalsExpensesFromPage.tsxUsesFormAlertWithSubmitButtonwithisDisabledpropApp/src/pages/workspace/workflows/approvals/WorkspaceWorkflowsApprovalsExpensesFromPage.tsx
Lines 140 to 154 in d34df44
2-
FormAlertWithSubmitButton.tsx/ PassesisDisabledto ButtonApp/src/components/FormAlertWithSubmitButton.tsx
Lines 139 to 155 in d34df44
3-
BaseGenericPressable.tsx/ The core issue locationApp/src/components/Pressable/GenericPressable/implementation/BaseGenericPressable.tsx
Lines 175 to 187 in d34df44
aria-disabled={isDisabled}is set at line 179, but {...rest} is spread AFTER at line 187. This means:If any parent component passes props that could affect
aria-disabledoraccessibilityState, those values from {...rest} would override our explicit accessibility settingsIn JSX, when the same prop is set multiple times, the last one wins
The accessibility props should be set AFTER the rest spread to ensure they always take precedence
What changes do you think we should make in order to solve the problem?
BEFORE (problematic):
AFTER (FIX):
With that ,The accessibility props now come after {...rest}, ensuring
aria-disabled={isDisabled}always reflects the computed disabled state and screen readers will properly announce "disabled" for disabled buttons.melvin-bot commentedon Dec 17, 2025
Now this issue is 8 days overdue. Are you sure this should be a Daily? Feel free to change it!
melvin-bot commentedon Dec 18, 2025
10 days overdue. Is anyone even seeing these? Hello?
melvin-bot commentedon Dec 24, 2025
This issue has not been updated in over 14 days. eroding to Weekly issue.
Fix Expensify#76908: Fix disabled state announcement order in pressables
98 remaining items
mallenexpensify commentedon Apr 21, 2026
@Krishna2323 @truph01 is payment due here? If so, how much? Looks like there was a revert
truph01 commentedon Apr 23, 2026
@mallenexpensify The PR was reverted due to a backend issue. The API is expected to return a boolean value, but it is currently returning a string instead. Although the crash did not occur prior to that PR, I don’t think this should be classified as a regression from the frontend PR.
cc @chuckdries for additional technical insight
chuckdries commentedon Apr 23, 2026
It was definitely a weird edge case, made even weirder by the fact that I could reliably repro the crash when I did the revert, but not after. I think we can call it a fluke and pay out full here
[-][Due for payment 2026-04-20] [$250] Screen Reader: Workspace-Workflow: Disabled 'Next' button is not announced as such[/-][+][Due for payment 2026-04-30] [Due for payment 2026-04-20] [$250] Screen Reader: Workspace-Workflow: Disabled 'Next' button is not announced as such[/+]melvin-bot commentedon Apr 23, 2026
Reviewinglabel has been removed, please complete the "BugZero Checklist".melvin-bot commentedon Apr 23, 2026
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.3.61-4 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2026-04-30. 🎊
For reference, here are some details about the assignees on this issue:
melvin-bot commentedon Apr 23, 2026
@Krishna2323 / @truph01 @mallenexpensify The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]
mallenexpensify commentedon Apr 24, 2026
Payment Summary
Contributor+: @Krishna2323 due $250 via NewDot
Contributor+: @truph01 due $250 via NewDot
Thx
garrettmknight commentedon May 10, 2026
$250 approved for @truph01
Krishna2323 commentedon May 15, 2026
Requested in ND.
laurenreidexpensify commentedon May 19, 2026
$250 approved for @Krishna2323