Skip to content

fix: Disabled 'Next' button is not announced - #86888

Merged
inimaga merged 10 commits into
Expensify:mainfrom
truph01:fix/76908
Apr 9, 2026
Merged

inimaga merged 10 commits into
Expensify:mainfrom
truph01:fix/76908

Conversation

@truph01

@truph01 truph01 commented Apr 1, 2026 •

Copy link
Copy Markdown
Contributor

Explanation of Change

  • Root cause: React Native's Pressable always overwrites accessibilityState from its disabled prop, see this:
_accessibilityState =
    disabled != null ? {..._accessibilityState, disabled} : _accessibilityState;

, and react-native-web's Pressable always overwrites aria-disabled the same way, see this:

      aria-disabled={disabled}

— In both platforms, disabled depends on fullDisabled

, which defaults to false, discarding the isDisabled state computed by BaseGenericPressable.

  • Fix (native): Changed disabled={fullDisabled} → disabled={fullDisabled || undefined} in BaseGenericPressable. When not fully disabled, undefined skips the native override, letting accessibilityState={{disabled: isDisabled}} flow through intact.

  • Fix (web): Added a useLayoutEffect in index.tsx (web) that imperatively sets/removes aria-disabled on the DOM element after react-native-web renders, since RNW's Pressable always derives aria-disabled from its own disabled prop and cannot be overridden declaratively.

Fixed Issues

$ #76908
PROPOSAL:

Tests

  • Verify that no errors appear in the JS console

Offline tests

QA Steps

// TODO: These must be filled out, or the issue title must include ""[No QA].""

  1. Using JAWS + Chrome, open the page https://new.expensify.com/workspaces
  2. Navigate using TAB to any workspace created, press enter to activate
  3. Navigate using TAB to 'Workflows' located in the middle navigation column, press enter to activate
  4. Navigate using TAB to the 'Add Approval Workflow' button, press enter to activate
  5. Navigate using TAB to the disabled 'Next' button at the bottom of the menu
  6. Verify the announcement: It should announce that the button is disabled, the announcement can be:
...button, dimmed
...button, disabled

based on the platform.

  • Verify that no errors appear in the JS console

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I verified there are no new alerts related to the canBeMissing param for useOnyx
  • I followed proper code patterns (see Reviewing the code)
    • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained ""why"" the code was doing something instead of only explaining ""what"" the code was doing.
    • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
      • If any non-english text was added/modified, I used JaimeGPT to get English > Spanish translation. I then posted it in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
    • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
    • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named ""index.js"". All platform-specific files are named for the platform the code supports as outlined in the README.
    • I verified the JSDocs style guidelines (in STYLE.md) were followed
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I followed the guidelines as stated in the Review Guidelines
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
  • I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
  • I verified that if a function's arguments changed that all usages have also been updated correctly
  • If any new file was added I verified that:
    • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
  • If new assets were added or existing ones were modified, I verified that:
    • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
    • The assets load correctly across all supported platforms.
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
  • I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native
Screen.Recording.2026-04-01.at.22.31.40.mov
Android: mWeb Chrome
Screen.Recording.2026-04-01.at.22.32.17.mov
iOS: Native
Screen.Recording.2026-04-01.at.22.37.23.mov
iOS: mWeb Safari
MacOS: Chrome / Safari
Screen.Recording.2026-04-01.at.22.30.23.mov

@truph01
truph01 marked this pull request as ready for review April 1, 2026 15:26
@truph01
truph01 requested review from a team as code owners April 1, 2026 15:26
@melvin-bot
melvin-bot Bot requested review from Krishna2323 and heyjennahay and removed request for a team April 1, 2026 15:26
@melvin-bot

melvin-bot Bot commented Apr 1, 2026

Copy link
Copy Markdown

@Krishna2323 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@melvin-bot
melvin-bot Bot removed the request for review from a team April 1, 2026 15:26

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 8f616e635d

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

@codecov

codecov Bot commented Apr 1, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ Changes either increased or maintained existing code coverage, great job!

Files with missing lines Coverage Δ
...cPressable/implementation/BaseGenericPressable.tsx 78.07% <100.00%> (+0.19%) ⬆️
...ressable/GenericPressable/implementation/index.tsx 0.00% <0.00%> (ø)
... and 23 files with indirect coverage changes

@truph01

truph01 commented Apr 1, 2026 •

Copy link
Copy Markdown
Contributor Author

Note: The announcement differs slightly between IOS/MacOS and Android. On IOS/MacOS, the element is announced as "dimmed", whereas on Android, it is announced as "disabled".

See https://www.a11y-101.com/development/aria-disabled for more details:

With aria-disabled the screen reader will get the fact that there is a button - by navigating through the page with the tabulator - and it will tell the user that it's dimmed (VoiceOver) or disabled (ChromeVox). So there is a button!

@Krishna2323

Copy link
Copy Markdown
Contributor

@truph01 whats the behaviour on desktop? The disabled button should be skipped in the tab order.

@truph01

truph01 commented Apr 1, 2026

Copy link
Copy Markdown
Contributor Author

@truph01 whats the behaviour on desktop? The disabled button should be skipped in the tab order.

@Krishna2323, could you share the discussion or reference that mentions this behavior? I may have missed it.

Based on the Expected Behavior section in the original post, it seems the intended interaction is different:

When users navigate to the disabled 'Next' button will announced as disabled to users
Expected announcement:
-"Next, disabled, button"

@Krishna2323

Copy link
Copy Markdown
Contributor

@truph01 #82673 (comment)

I think we should just skip focusing in the disabled button (only on desktop). I tested with disabled "Comment" button when we post on GH. Try focusing on the "Comment" button without any text.

@github-actions

github-actions Bot commented Apr 1, 2026

Copy link
Copy Markdown
Contributor

🚧 @luacmartins has triggered a test Expensify/App build. You can view the workflow run here.

@github-actions

This comment has been minimized.

@truph01

truph01 commented Apr 1, 2026

Copy link
Copy Markdown
Contributor Author

I think we should just skip focusing in the disabled button (only on desktop).

@Krishna2323 I think skipping focus on the disabled button (on desktop) would change the currently documented expected behavior in OP.

Before moving forward with that approach, it would be good to get confirmation from the design or internal team.

@rushatgabhane Could you help confirm?

@Krishna2323

Krishna2323 commented Apr 1, 2026 •

Copy link
Copy Markdown
Contributor

@truph01 it was confirmed by @dubielzyk-expensify but I couldn't find the thread. Let me check again.

Here it is: https://expensify.slack.com/archives/C01GTK53T8Q/p1773791808243639?thread_ts=1773326208.540469&cid=C01GTK53T8Q

@truph01

truph01 commented Apr 1, 2026

Copy link
Copy Markdown
Contributor Author

@Krishna2323 I left a comment on that thread.

@dubielzyk-expensify

Copy link
Copy Markdown
Contributor

Jon replied :)

@truph01

truph01 commented Apr 2, 2026

Copy link
Copy Markdown
Contributor Author

@Krishna2323 Could you continue reviewing this PR?

@Krishna2323

Copy link
Copy Markdown
Contributor

Reviewing...

// overriding any explicit aria-disabled we pass. We pass fullDisabled (not isDisabled) to
// preserve interaction/focus behavior, so we must set aria-disabled imperatively instead.
const internalRef = useRef<View>(null);
const isAriaDisabled = props.fullDisabled ?? props.disabled ?? props.accessibilityState?.disabled;

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should be using || here instead of nullish coalescing.

@Krishna2323

Copy link
Copy Markdown
Contributor

@truph01 have you tested the changes on physical iOS device? I can't do that but tried with Xcode Accessibility Inspector. Here’s what gets announced across platforms:

Platform Announcement Status
Web (JAWS + Chrome) "unavailable" Working
macOS (VoiceOver + Chrome/Safari) "dimmed" Working
iOS Native (Xcode Accessibility Inspector, not physical device) "Not Enabled" Working
iOS mWeb Safari (Xcode Accessibility Inspector, not physical device) "Not Enabled" Working
Android Native (TalkBack) "disabled" Working
Android mWeb Chrome "disabled" Working

@Krishna2323

Copy link
Copy Markdown
Contributor

Reviewer Checklist

  • I have verified the author checklist is complete (all boxes are checked off).
  • I verified the correct issue is linked in the ### Fixed Issues section above
  • I verified testing steps are clear and they cover the changes made in this PR
    • I verified the steps for local testing are in the Tests section
    • I verified the steps for Staging and/or Production testing are in the QA steps section
    • I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • I checked that screenshots or videos are included for tests on all platforms
  • I included screenshots or videos for tests on all platforms
  • I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
  • I verified tests pass on all platforms & I tested again on:
    • Android: HybridApp
    • Android: mWeb Chrome
    • iOS: HybridApp
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
    • MacOS: Desktop
  • If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
  • I verified there are no new alerts related to the canBeMissing param for useOnyx
  • I verified proper code patterns were followed (see Reviewing the code)
    • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
    • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
    • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
    • I verified the JSDocs style guidelines (in STYLE.md) were followed
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I verified that this PR follows the guidelines as stated in the Review Guidelines
  • I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
  • I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
  • I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
  • If a new component is created I verified that:
    • A similar component doesn't exist in the codebase
    • All props are defined accurately and each prop has a /** comment above it */
    • The file is named correctly
    • The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
    • The only data being stored in the state is data necessary for rendering and nothing else
    • For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
    • Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
    • All JSX used for rendering exists in the render method
    • The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
  • If any new file was added I verified that:
    • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
  • For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
  • I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp
android_hybrid.mp4
Android: mWeb Chrome
android_chrome.mp4
iOS: HybridApp
ios_hybrid.mp4
iOS: mWeb Safari
ios_safari.mp4
MacOS: Chrome / Safari
web_chrome_jaws.mp4
web_chrome_voiceover.mp4

@luacmartins
luacmartins requested a review from Krishna2323 April 2, 2026 14:52

@Krishna2323 Krishna2323 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@melvin-bot
melvin-bot Bot requested a review from inimaga April 2, 2026 17:16
@Krishna2323

Copy link
Copy Markdown
Contributor

Failing check doesn't seem related.

@Krishna2323

Copy link
Copy Markdown
Contributor

@truph01 conflicts 🤷🏻

@Krishna2323

Copy link
Copy Markdown
Contributor

@inimaga friendly bump

@inimaga

inimaga commented Apr 8, 2026

Copy link
Copy Markdown
Contributor

@truph01 Is this PR still needed if the issue is no longer reproducible on main as per the comment here?

@inimaga
inimaga merged commit a719263 into Expensify:main Apr 9, 2026
31 checks passed
@github-actions

github-actions Bot commented Apr 9, 2026

Copy link
Copy Markdown
Contributor

🚧 @inimaga has triggered a test Expensify/App build. You can view the workflow run here.

@OSBotify

OSBotify commented Apr 9, 2026

Copy link
Copy Markdown
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@OSBotify OSBotify mentioned this pull request Apr 10, 2026
87 tasks done
@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to staging by https://github.com/inimaga in version: 9.3.58-0 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

Bundle Size Analysis (Sentry):

@MelvinBot

Copy link
Copy Markdown
Contributor

No help site changes are required.

This PR fixes a low-level accessibility bug in the internal GenericPressable component so that screen readers correctly announce disabled buttons. It does not change any user-facing feature names, settings, workflows, or product behavior — only the underlying aria-disabled attribute handling on web and native platforms.

Nothing in App/docs/articles references the internal accessibility implementation of Pressable components, so no documentation updates are needed.

@Krishna2323

Copy link
Copy Markdown
Contributor

@truph01 PR was reverted here: #87647

@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to production by https://github.com/AndrewGable in version: 9.3.58-9 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 failure ❌

@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to production by https://github.com/AndrewGable in version: 9.3.58-9 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants