You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[Due for payment 2026-04-23] [Due for payment 2026-04-20] Profile - App crashed when tap on Timezone. #87629
Version Number: 9.3.58-0 Reproducible in staging?: Yes Reproducible in production?: No If this was caught during regression testing, add the test name, ID and link from BrowserStack:https://test-management.browserstack.com/projects/2219752/folder/13177019/test-cases/41237777 Email or phone of affected tester (no customers):rybkina+040926@gmail.com Issue reported by: Applause Internal Team Bug source: Regression TC Execution Device used: iPhone 17 Pro /26.4 App Component: User Settings
Action Performed:
Launch App in offline mode
Navigate to Profile
Tap om Timezone
Expected Result:
Your timezone is shown on your profile page should be open
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
Identify the pull request that introduced this issue and revert it.
Classification: Frontend bug (App crash on mobile navigation - staging only, offline only)
Causing PR: Unable to identify with confidence - see detailed analysis below
Related Issues: None identified
Recommendation: NEEDS INVESTIGATION
The crash is reproducible on staging (9.3.58-0) but not production, in offline mode on both iOS and Android native when navigating to Profile > Timezone. No staging PR directly modifies the Timezone-related files. The root cause could be in one of the navigation-related PRs or in a Mobile-Expensify submodule update.
Assigned: @chuckdries (auto-assigned), @mitarachim (issue author)
Labels: No label changes made - keeping both DeployBlockerCash and DeployBlocker due to low confidence in root cause
Evidence
The bug report says:
Version: 9.3.58-0 (staging only, not production)
Steps: Launch App in offline mode, Navigate to Profile, Tap on Timezone
src/pages/settings/Profile/ProfilePage.tsx - renders the Timezone menu item that navigates to ROUTES.SETTINGS_TIMEZONE
src/pages/settings/Profile/TimezoneInitialPage.tsx - the destination screen, uses withCurrentUserPersonalDetails
src/components/withCurrentUserPersonalDetails.tsx - HOC that uses useCurrentUserPersonalDetails
src/components/CurrentUserPersonalDetailsProvider.tsx - provides personal details via useOnyx
src/libs/Navigation/AppNavigator/ModalStackNavigators/index.tsx - registers the Timezone screen
PRs Reviewed
All staging PRs were reviewed. None directly modify Timezone-related files.
Potential candidates:
PR 85120 "Implement parameters handling in dynamic routes" - Modified navigation utilities including getStateFromPath.ts, getAdaptedStateFromPath.ts, and findMatchingDynamicSuffix.ts. Changes to how dynamic route suffixes are matched could affect navigation state for settings routes including the timezone select route.
PR 86888 "fix: Disabled Next button is not announced" - Modified BaseGenericPressable.tsx changing disabled to undefined when false. This change affects how the Timezone menu item in ProfilePage interacts with the Pressable component on native.
PR 86414 "[NoQA] fix: add default forwardedFSClass unmask in ScreenWrapperContainer" - Added a default fsClass="fs-unmask" to ALL ScreenWrapper usages that previously had undefined. The FullStory native module is used on mobile, and this now applies to every screen including TimezoneInitialPage. If the FullStory native module behaves differently when fsClass is explicitly set vs undefined, this could cause a crash on mobile.
Mobile-Expensify submodule updates - The staging deploy includes updates from 9.3.55-1 through 9.3.58-0. These submodule changes are in a separate repository. Given the crash is mobile-native only and not web, a submodule change is also a candidate.
Recommended Next Steps
Check Sentry crash logs for 9.3.58-0 to identify the exact stack trace
Try reverting PR 86414 first - smallest change, affects all ScreenWrapper usages via the FullStory native module
If not resolved, try reverting PR 85120 - navigation utility changes that affect route matching
Check Mobile-Expensify submodule changes between 9.3.57-1 and 9.3.58-0
Verify if other Profile sub-pages (Pronouns, Display Name, etc.) also crash offline - if so, it narrows to a shared component issue
Updated 2026-04-11: Corrected based on feedback from truph01 — timezone.automatic is always a boolean or undefined, not a string.
Issue Analysis
Root Cause: PR #86888 (merged April 9) changed disabled={fullDisabled} to disabled={fullDisabled || undefined} in BaseGenericPressable.tsx:180. Previously, React Native's Pressable always set accessibilityState.disabled to the boolean value from its disabled prop. After the change, when fullDisabled is false, disabled={undefined} causes the native Pressable to skip setting accessibilityState.disabled, allowing the raw aria-disabled value to reach the native View in an unexpected state — causing the crash on mobile in offline mode.
Recommended Fix: The fix was applied via cherry-pick to staging (confirmed not reproducible on 9.3.58-1).
Investigation details
Crash log evidence
Exception in HostFunction: Value is a string, expected a boolean
You're right — I was wrong about that. timezone.automatic is typed as boolean | undefined in PersonalDetails.ts:13, and there's no evidence it ever comes back as a string. Thanks for the correction.
The crash identification (PR #86888 changing disabled to disabled || undefined) is still valid, but my explanation claiming the value was a string from the backend was inaccurate.
BaseGenericPressable.tsx passes three disability-related props to React Native's Pressable:
// line 180
disabled={fullDisabled}
// line 198-201
accessibilityState={{disabled: isDisabled, ...accessibilityState}}
// line 202
aria-disabled={isDisabled}
Inside RN's Pressable.js, the native accessibility state is built in two steps:
// Step 1 (line 230): build from aria-disabled or accessibilityState_accessibilityState={disabled: ariaDisabled??accessibilityState?.disabled,// ...};// Step 2 (line 235-236): override with disabled prop if present_accessibilityState=disabled!=null ? {..._accessibilityState, disabled} : _accessibilityState;
The != null check is the key. It distinguishes false from undefined:
Before the PR (disabled={fullDisabled}): When fullDisabled is false, step 2 fires because false != null is true. The disabled prop (a clean boolean false) overwrites _accessibilityState.disabled, guaranteeing the native View always receives a boolean.
After the PR (disabled={fullDisabled || undefined}): When fullDisabled is false, JS evaluates false || undefined → undefined. Now step 2 is skipped because undefined != null is false. The native View receives whatever step 1 produced — which relies on ariaDisabled and accessibilityState flowing through correctly.
The crash happens because skipping step 2 removes a safety net. When disabled is undefined, React Native's Pressable no longer normalizes the accessibility state, and whatever raw value reaches the native <View> must already be a clean boolean. If any intermediate component or the native bridge produces a non-boolean during this path (e.g., the accessibilityState prop spread at line 200 introduces an unexpected value, or the native bridge serializes undefined differently than false), it crashes with "Value is a string, expected a boolean".
In short: passing disabled={false} acts as a normalizer at the RN Pressable level, guaranteeing the native View gets a boolean. Passing disabled={undefined} removes that guarantee and exposes the native layer to whatever flows through the accessibility state chain.
After the PR (disabled={fullDisabled || undefined}): When fullDisabled is false, JS evaluates false || undefined → undefined. Now step 2 is skipped because undefined != null is false. The native View receives whatever step 1 produced — which relies on ariaDisabled and accessibilityState flowing through correctly.
Does this mean the crash would consistently occur when fullDisabled is false?
No — the crash would not consistently occur on every Pressable where fullDisabled is false.
After the PR change, when fullDisabled is false, React Native Pressable skips overwriting _accessibilityState.disabled (Pressable.js:235-236). But the value it retains (ariaDisabled ?? accessibilityState?.disabled from line 230) is still isDisabled — a boolean — which is valid. So the PR change alone doesn't cause a crash.
The PR is a necessary condition (confirmed by chuckdries's revert test), but there's an additional factor specific to the Timezone page or offline state that produces the actual type mismatch. Given your correction that timezone.automatic is always boolean, I don't have full certainty on what that additional factor is.
changed the title [-]Profile - App crashed when tap on Timezone.[/-][+][Due for payment 2026-04-20] Profile - App crashed when tap on Timezone.[/+]on Apr 13, 2026
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.3.58-9 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
@chuckdries The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.3.59-4 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
changed the title [-][Due for payment 2026-04-20] Profile - App crashed when tap on Timezone.[/-][+][Due for payment 2026-04-23] [Due for payment 2026-04-20] Profile - App crashed when tap on Timezone.[/+]on Apr 16, 2026
@chuckdries The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]
Activity
melvin-bot commentedon Apr 10, 2026
Triggered auto assignment to @chuckdries (
DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.melvin-bot commentedon Apr 10, 2026
💬 A slack conversation has been started in #expensify-open-source
github-actions commentedon Apr 10, 2026
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
OSBotify commentedon Apr 10, 2026
Investigation Summary
Classification: Frontend bug (App crash on mobile navigation - staging only, offline only)
Causing PR: Unable to identify with confidence - see detailed analysis below
Related Issues: None identified
Recommendation: NEEDS INVESTIGATION
The crash is reproducible on staging (9.3.58-0) but not production, in offline mode on both iOS and Android native when navigating to Profile > Timezone. No staging PR directly modifies the Timezone-related files. The root cause could be in one of the navigation-related PRs or in a Mobile-Expensify submodule update.
Assigned: @chuckdries (auto-assigned), @mitarachim (issue author)
Labels: No label changes made - keeping both DeployBlockerCash and DeployBlocker due to low confidence in root cause
Evidence
The bug report says:
Files Involved
The Timezone navigation path involves:
PRs Reviewed
All staging PRs were reviewed. None directly modify Timezone-related files.
Potential candidates:
PR 85120 "Implement parameters handling in dynamic routes" - Modified navigation utilities including getStateFromPath.ts, getAdaptedStateFromPath.ts, and findMatchingDynamicSuffix.ts. Changes to how dynamic route suffixes are matched could affect navigation state for settings routes including the timezone select route.
PR 86888 "fix: Disabled Next button is not announced" - Modified BaseGenericPressable.tsx changing disabled to undefined when false. This change affects how the Timezone menu item in ProfilePage interacts with the Pressable component on native.
PR 86414 "[NoQA] fix: add default forwardedFSClass unmask in ScreenWrapperContainer" - Added a default fsClass="fs-unmask" to ALL ScreenWrapper usages that previously had undefined. The FullStory native module is used on mobile, and this now applies to every screen including TimezoneInitialPage. If the FullStory native module behaves differently when fsClass is explicitly set vs undefined, this could cause a crash on mobile.
Mobile-Expensify submodule updates - The staging deploy includes updates from 9.3.55-1 through 9.3.58-0. These submodule changes are in a separate repository. Given the crash is mobile-native only and not web, a submodule change is also a candidate.
Recommended Next Steps
MelvinBot commentedon Apr 10, 2026
Updated 2026-04-11: Corrected based on feedback from
truph01—timezone.automaticis always a boolean orundefined, not a string.Issue Analysis
Root Cause: PR #86888 (merged April 9) changed
disabled={fullDisabled}todisabled={fullDisabled || undefined}inBaseGenericPressable.tsx:180. Previously, React Native'sPressablealways setaccessibilityState.disabledto the boolean value from itsdisabledprop. After the change, whenfullDisabledis false,disabled={undefined}causes the nativePressableto skip settingaccessibilityState.disabled, allowing the rawaria-disabledvalue to reach the native View in an unexpected state — causing the crash on mobile in offline mode.Recommended Fix: The fix was applied via cherry-pick to staging (confirmed not reproducible on 9.3.58-1).
Investigation details
Crash log evidence
Component stack:
RCTView > View > Pressable > GenericPressable > NativeGenericPressableIntroducing PR
#86888 — "fix: Disabled 'Next' button is not announced" (merged 2026-04-09)
Verification
Confirmed by
chuckdries: reverting #86888 fixes the crash. Fix CP'd to staging and verified not reproducible on 9.3.58-1.Next Steps: Reply with
@MelvinBot implement thisto create a draft PR, or@MelvinBot <your feedback>to refine this analysis.chuckdries commentedon Apr 10, 2026
I can confirm Melvin's analysis: reverting #86888 fixes the crash. I'm going to raise a revert PR
6 remaining items
truph01 commentedon Apr 11, 2026
@MelvinBot In your analysis above:
I checked the data, and
timezone.automaticis always a boolean (orundefined). There shouldn’t be any case where it is a string value.MelvinBot commentedon Apr 11, 2026
You're right — I was wrong about that.
timezone.automaticis typed asboolean | undefinedinPersonalDetails.ts:13, and there's no evidence it ever comes back as a string. Thanks for the correction.The crash identification (PR #86888 changing
disabledtodisabled || undefined) is still valid, but my explanation claiming the value was a string from the backend was inaccurate.truph01 commentedon Apr 11, 2026
@MelvinBot Could you explain in more detail why:
causes this bug?
MelvinBot commentedon Apr 11, 2026
Here's the mechanism step by step.
BaseGenericPressable.tsxpasses three disability-related props to React Native'sPressable:Inside RN's
Pressable.js, the native accessibility state is built in two steps:The
!= nullcheck is the key. It distinguishesfalsefromundefined:Before the PR (
disabled={fullDisabled}): WhenfullDisabledisfalse, step 2 fires becausefalse != nullistrue. Thedisabledprop (a clean booleanfalse) overwrites_accessibilityState.disabled, guaranteeing the native View always receives a boolean.After the PR (
disabled={fullDisabled || undefined}): WhenfullDisabledisfalse, JS evaluatesfalse || undefined→undefined. Now step 2 is skipped becauseundefined != nullisfalse. The native View receives whatever step 1 produced — which relies onariaDisabledandaccessibilityStateflowing through correctly.The crash happens because skipping step 2 removes a safety net. When
disabledisundefined, React Native's Pressable no longer normalizes the accessibility state, and whatever raw value reaches the native<View>must already be a clean boolean. If any intermediate component or the native bridge produces a non-boolean during this path (e.g., theaccessibilityStateprop spread at line 200 introduces an unexpected value, or the native bridge serializesundefineddifferently thanfalse), it crashes with"Value is a string, expected a boolean".In short: passing
disabled={false}acts as a normalizer at the RN Pressable level, guaranteeing the native View gets a boolean. Passingdisabled={undefined}removes that guarantee and exposes the native layer to whatever flows through the accessibility state chain.truph01 commentedon Apr 11, 2026
@MelvinBot You said:
Does this mean the crash would consistently occur when
fullDisabledisfalse?MelvinBot commentedon Apr 11, 2026
No — the crash would not consistently occur on every Pressable where
fullDisabledisfalse.After the PR change, when
fullDisabledis false, React Native Pressable skips overwriting_accessibilityState.disabled(Pressable.js:235-236). But the value it retains (ariaDisabled ?? accessibilityState?.disabledfrom line 230) is stillisDisabled— a boolean — which is valid. So the PR change alone doesn't cause a crash.The PR is a necessary condition (confirmed by
chuckdries's revert test), but there's an additional factor specific to the Timezone page or offline state that produces the actual type mismatch. Given your correction thattimezone.automaticis always boolean, I don't have full certainty on what that additional factor is.[-]Profile - App crashed when tap on Timezone.[/-][+][Due for payment 2026-04-20] Profile - App crashed when tap on Timezone.[/+]melvin-bot commentedon Apr 13, 2026
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.3.58-9 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2026-04-20. 🎊
melvin-bot commentedon Apr 13, 2026
@chuckdries The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]
melvin-bot commentedon Apr 16, 2026
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.3.59-4 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2026-04-23. 🎊
[-][Due for payment 2026-04-20] Profile - App crashed when tap on Timezone.[/-][+][Due for payment 2026-04-23] [Due for payment 2026-04-20] Profile - App crashed when tap on Timezone.[/+]melvin-bot commentedon Apr 16, 2026
@chuckdries The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]