You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[$250] Login - "All caught up" and skeleton loading in Inbox after logging with magic link and 2FA #79389
Version Number: 9.2.99-5 Reproducible in staging?: Yes Reproducible in production?: Yes If this was caught during regression testing, add the test name, ID and link from BrowserStack:https://test-management.browserstack.com/projects/2219752/folder/13176924/test-cases/41237550 Email or phone of affected tester (no customers): N/A Issue reported by: Applause Internal Team Bug source: Regression TC Execution Device used: MacBook Air 15.7.3 Chrome App Component: Other
Action Performed:
Preconditions: use an account with 2FA enabled
Navigate to ND, on Sign in page enter an account from the preconditions, click continue
Verify you're asked for the magic code
Navigate to email and locate the magic link
Change the link to staging, paste the link in the new tab
Navigate to the link - the 2FA code is asked
On the main page enter the correct 2FA code in the code field
Navigate from Home to Inbox
Expected Result:
Inbox page loads successfully
Actual Result:
"All caught up" is displayed in LHN, skeleton loading is shown in the Inbox
changed the title [-]Login - "All caught up" and skeleton loading in Inbox after logging with magic link and 2FA[/-][+][$250] Login - "All caught up" and skeleton loading in Inbox after logging with magic link and 2FA[/+]on Jan 15, 2026
The NVP_PREFERRED_LOCALE dependency uses ARE_TRANSLATIONS_LOADING with initWithStoredValues: false. In multi-tab scenarios, translations may already be loaded before OnyxDerived.init() runs. Since initWithStoredValues: false only fires on changes, the callback never fires, the locale dependency never initializes, and areAllConnectionsSet stays false forever.
What changes do you think we should make in order to solve the problem?
If translations are already loaded, initWithStoredValues: true ensures the callback fires immediately with the stored false value, initializing the dependency.
What alternative solutions did you explore? (Optional)
@ahmedGaber93 Based on my previous comment, the issue is not reproducible on InboxPage. It is reproducible on HomePage in ForYouSection/index.tsx. As I defined in the preconditions of the draft PR, we need a couple of reports to reproduce it on the HomePage.
Previous debugging video is here but it is outdated. Because todos logic has been refactored recently in this PR and race condition appears to have been resolved as well. Proposal's Issue 3 is not valid anymore.
Rendering Skeleton View logic was also refactored in the same PR. As a result, Proposal's Issue 2 is not valid anymore.
In summary, Proposal's Issue 1, 2, and 3 are no longer valid. Proposal is outdated completely.
There is nothing to solve from OP. However, ForYouSection still has a reproducible bug on latest main:
If you have a proposal for it, I think we can fix it here.
@ahmedGaber93 I am not sure if we can fix it here because the bug is no longer reproducible exactly as before on the latest main. I think a recent PR affected it, but the behavior is still inconsistent (e.g., some reports are still not displaying correctly).
@justinpersaud The original issue in the OP is completely fixed on the main branch.
The remaining bug (#79389 (comment)) may be related to the test steps (logging in with a 2FA code using two tabs in the same browser), but it doesn't appear to have the same root cause.
We don't have a clear root cause for this right now. While we could wait for proposals, I think we should consider closing the issue because:
It appears to be a very minor bug.
Not reproduced consistently.
It isn't a typical user flow:
Logging in with a 2FA code using two tabs in the same browser.
Clicking "Open Expensify" from the security code email, which opens a new tab with the 2FA form, and then going back to the first tab to enter the code instead of simply completing the login in the new tab.
While it's still a valid bug, I'm leaning toward closing the issue. WDYT?
Activity
melvin-bot commentedon Jan 12, 2026
Triggered auto assignment to @kadiealexander (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.[-]Login - "All caught up" and skeleton loading in Inbox after logging with magic link and 2FA[/-][+][$250] Login - "All caught up" and skeleton loading in Inbox after logging with magic link and 2FA[/+]melvin-bot commentedon Jan 15, 2026
Job added to Upwork: https://www.upwork.com/jobs/~022011668237611239662
melvin-bot commentedon Jan 15, 2026
Triggered auto assignment to Contributor-plus team member for initial proposal review - @ShridharGoel (
External)cosmicvulpes commentedon Jan 15, 2026
Proposal
Please re-state the problem that we are trying to solve in this issue.
After 2FA login, LHN shows "All caught up" despite reports existing in Onyx. Refreshing fixes it.
What is the root cause of that problem?
reportAttributes.compute()returns{reports: {}}whenareAllConnectionsSetisfalse.The
NVP_PREFERRED_LOCALEdependency usesARE_TRANSLATIONS_LOADINGwithinitWithStoredValues: false. In multi-tab scenarios, translations may already be loaded beforeOnyxDerived.init()runs. SinceinitWithStoredValues: falseonly fires on changes, the callback never fires, the locale dependency never initializes, andareAllConnectionsSetstaysfalseforever.What changes do you think we should make in order to solve the problem?
In
src/libs/actions/OnyxDerived/index.ts, dynamically setinitWithStoredValuesbased on whether translations are already loaded:If translations are already loaded,
initWithStoredValues: trueensures the callback fires immediately with the storedfalsevalue, initializing the dependency.What alternative solutions did you explore? (Optional)
N/A
ShridharGoel commentedon Jan 15, 2026
Able to repro even after trying the above proposal
cosmicvulpes commentedon Jan 16, 2026
@ShridharGoel Updated the proposal. The fix is working fine now, verified on my dev instance. Please take a look again.
131 remaining items
mmsumer commentedon Jul 4, 2026
@ahmedGaber93 Based on my previous comment, the issue is not reproducible on
InboxPage. It is reproducible onHomePageinForYouSection/index.tsx. As I defined in the preconditions of the draft PR, we need a couple of reports to reproduce it on theHomePage.Previous debugging video is here but it is outdated. Because todos logic has been refactored recently in this PR and race condition appears to have been resolved as well. Proposal's Issue 3 is not valid anymore.
Rendering Skeleton View logic was also refactored in the same PR. As a result, Proposal's Issue 2 is not valid anymore.
In summary, Proposal's Issue 1, 2, and 3 are no longer valid. Proposal is outdated completely.
There is nothing to solve from
OP. However,ForYouSectionstill has a reproducible bug on latest main:bug.mov
cc @mallenexpensify
ahmedGaber93 commentedon Jul 7, 2026
@mmsumer could you please share the full steps to reproduce this bug?
mmsumer commentedon Jul 9, 2026
@ahmedGaber93 here you go:
Preconditions:
Expected Result:
ForYouSection displays todos reports correctly
Actual Result:
ForYouSection displays empty state message
Still able to reproduce on latest main:
bug.mov
melvin-bot commentedon Jul 10, 2026
@ahmedGaber93 Whoops! This issue is 2 days overdue. Let's get this updated quick!
melvin-bot commentedon Jul 14, 2026
@ahmedGaber93 6 days overdue. This is scarier than being forced to listen to Vogon poetry!
melvin-bot commentedon Jul 16, 2026
@ahmedGaber93 Now this issue is 8 days overdue. Are you sure this should be a Daily? Feel free to change it!
ahmedGaber93 commentedon Jul 19, 2026
@mmsumer Ah, I am able to reporduce now.
If you have a proposal for it, I think we can fix it here.
mmsumer commentedon Jul 22, 2026
@ahmedGaber93 I am not sure if we can fix it here because the bug is no longer reproducible exactly as before on the latest main. I think a recent PR affected it, but the behavior is still inconsistent (e.g., some reports are still not displaying correctly).
Here is a video showing the current behavior:
bug.mov
ahmedGaber93 commentedon Jul 22, 2026
Ah, thanks for retesting this, @mmsumer!
ahmedGaber93 commentedon Jul 22, 2026
@justinpersaud The original issue in the OP is completely fixed on the main branch.
The remaining bug (#79389 (comment)) may be related to the test steps (logging in with a 2FA code using two tabs in the same browser), but it doesn't appear to have the same root cause.
We don't have a clear root cause for this right now. While we could wait for proposals, I think we should consider closing the issue because:
It appears to be a very minor bug.
Not reproduced consistently.
It isn't a typical user flow:
While it's still a valid bug, I'm leaning toward closing the issue. WDYT?
melvin-bot commentedon Jul 27, 2026
@ahmedGaber93 Huh... This is 4 days overdue. Who can take care of this?
ahmedGaber93 commentedon Jul 29, 2026
@justinpersaud WDYT #79389 (comment)?
melvin-bot commentedon Aug 3, 2026
@ahmedGaber93 Huh... This is 4 days overdue. Who can take care of this?
ahmedGaber93 commentedon Aug 4, 2026
Bump @justinpersaud on slack https://expensify.slack.com/archives/C01GTK53T8Q/p1785837919950299
justinpersaud commentedon Aug 4, 2026
Yeah, lets close this then