Repository navigation
[WIP] fix: prevent race condition during Onyx derived data initialization - #88719
Closed
mmsumer wants to merge 8 commits into
Conversation
mmsumer
force-pushed
the
fix/79389-login-all-caught-up-and-skeleton-loading-in-inbox-after-logging-with-magic-link-and-2fa
branch
from
April 28, 2026 13:52
fba72e0 to
7ecd993
Compare
…oading-in-inbox-after-logging-with-magic-link-and-2fa
2 of 7 tasks
Contributor
Author
|
I'm closing this PR based on the latest updates. |
mmsumer
deleted the
fix/79389-login-all-caught-up-and-skeleton-loading-in-inbox-after-logging-with-magic-link-and-2fa
branch
July 4, 2026 17:59
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation of Change
Enabled cache check in setDerivedValue to prevent race condition and added client leadership check in openApp to avoid UI flickering on the HomePage.
Fixed Issues
$ #79389
PROPOSAL: #79389 (comment)
Tests
Preconditions:
Offline tests
Same as Tests
QA Steps
Same as Tests
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari