Skip to content

[Tracking] Rules follow up #81133

Closed
Closed

Description

@situchan

Backend:

Frontend:

Activity

  1. added
    InternalRequires API changes or must be handled by Expensify staff
    on Feb 2, 2026
  2. melvin-bot commented on Feb 2, 2026

    @melvin-bot

    Triggered auto assignment to @JS00001 (AutoAssignerNewDotQuality)

  3. melvin-bot commented on Feb 2, 2026

    @melvin-bot

    Triggered auto assignment to @chiragsalian (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

  4. melvin-bot commented on Feb 2, 2026

    @melvin-bot

    💬 A slack conversation has been started in #expensify-open-source

  5. github-actions commented on Feb 2, 2026

    @github-actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  6. pecanoro commented on Feb 2, 2026

    @pecanoro
    Contributor

    Adding the blocker label so we don't deploy something that is not working to production.

  7. OSBotify commented on Feb 2, 2026

    @OSBotify
    Contributor

    Investigation Summary

    Classification: Tracking Issue (not a specific bug)
    Causing PR: #80853 - "Remove dev lock from merchant rules" by @luacmartins (High confidence)
    Related Issues: This issue tracks 15 individual bugs (10 backend, 5 frontend) discovered after enabling the Rules feature in staging

    Recommendation: REMOVE DeployBlockerCash LABEL

    This is a tracking/meta issue that aggregates multiple individual bug reports. Tracking issues should not have deploy blocker labels - only the specific bugs they track should be labeled as blockers.

    Why this is safe:

    1. Feature is locked in production: The Rules feature has multiple layers of protection:

      • Merchant Rules: Explicitly hidden in production via isProduction check (line 103 of MerchantRulesSection.tsx)
      • All Rules: Gated behind policy.areRulesEnabled feature flag (not widely enabled)
    2. Feature is NEW: All tracked bugs state "N/A - new feature, doesn't exist in prod" - these bugs cannot affect production users

    3. Individual bugs already have blocker labels: For example:

    4. Timeline confirms this: PR Remove dev lock from merchant rules #80853 merged Jan 30 (enabled in staging), this tracking issue created Feb 2 (after bugs discovered)

    Labels: Removing DeployBlockerCash from this tracking issue. The individual bugs it references should retain their appropriate blocker labels.

    Detailed Analysis

    Evidence

    PR #80853 changed MerchantRulesSection.tsx:

    - if (!isDevelopment) {
    + if (isProduction) {
          return null;
      }

    This enabled Merchant Rules in staging/dev but kept them hidden in production. All the bugs listed in this tracking issue were discovered during staging testing after this change.

    Verification

    Confirmed that:

    Root Cause

    This is not a bug itself - it's a project management tracking issue created to organize the follow-up work needed for the newly-enabled Rules feature. The actual bugs are tracked individually and have their own deploy blocker labels as appropriate.

  8. situchan commented on Feb 2, 2026

    @situchan
    ContributorAuthor

    Adding the blocker label so we don't deploy something that is not working to production.

    We're not releasing this feature to production yet so it's fine to demote.

    if (isProduction) {
    return null;
    }

  9. pecanoro commented on Feb 2, 2026

    @pecanoro
    Contributor

    Got it! I added it just in case so the project leaders can take a look and make sure it's fine. Better be safe than sorry!

  10. JS00001 commented on Feb 9, 2026

    @JS00001
    Contributor

    Going to close this tracking issue out, theres one PR left in review

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

AutoAssignerNewDotQualityUsed to assign quality issues to engineersDailyKSv2EngineeringInternalRequires API changes or must be handled by Expensify staff

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions