Repository navigation
Closed
Labels
AutoAssignerNewDotQualityUsed to assign quality issues to engineersUsed to assign quality issues to engineersDailyKSv2KSv2EngineeringInternalRequires API changes or must be handled by Expensify staffRequires API changes or must be handled by Expensify staff
Description
Backend:
- 1. Rules - "Apply to existing unsubmitted expenses" does not apply rules to existing expenses #81091
- 2. Merchant rules - Reimbursable in merchant rule does not apply to new expenses #81098
- 4. Rules - Rules are not applied to all merchants after saving merchant with an asterisk (*) #81107
- 5. Expense rules - Tax rate does not update when expense rule is applied #81117
- 6. [$250] New report is created in default workspace when expense rule is applied to nondefault workspace #81118
- 7. Rules - Merchant rule is still applied when Rules are disabled #81119
- 8. Expense is added to existing report and a new report is created when expense rule is applied #81121
- 10. https://github.com/Expensify/Expensify/issues/595147
Frontend:
- 10. Merchant rules - No duplicate warning when Merchant is the same with different match type #81090
- 11. [$250] Rules - Multi tag is not applied to expenses when tag is not from the first level #81094
- 12. [$250] Expense - Merchant can be made empty by using Expense as Merchant in expense rule #81122
- 13. Rules - "Merchant" rule created on workspace, is applied on track expense on Self DM. #81135
- 14. Rules-Merchant Rule created in offline is not greyed out & strikethrough when deleted #81138
- 15. Rules - Merchant Rule with special characters saved without error but disappeared later #81140
- 16. Expense-Using merchant rule url is not shown as link in expense details #81145
- 3. Report - Invisible report created if submitting track expense to WS with "Create report" rule #81103 (possible FE bug)
- 9. [$250] Expense - Expense rules apply sequentially with partial match #81219 (possible FE bug)
cc: @luacmartins @JS00001 @cead22
Metadata
Metadata
Assignees
Labels
AutoAssignerNewDotQualityUsed to assign quality issues to engineersUsed to assign quality issues to engineersDailyKSv2KSv2EngineeringInternalRequires API changes or must be handled by Expensify staffRequires API changes or must be handled by Expensify staff
Activity
melvin-bot commentedon Feb 2, 2026
Triggered auto assignment to @JS00001 (
AutoAssignerNewDotQuality)melvin-bot commentedon Feb 2, 2026
Triggered auto assignment to @chiragsalian (
DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.melvin-bot commentedon Feb 2, 2026
💬 A slack conversation has been started in #expensify-open-source
github-actions commentedon Feb 2, 2026
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
pecanoro commentedon Feb 2, 2026
Adding the blocker label so we don't deploy something that is not working to production.
OSBotify commentedon Feb 2, 2026
Investigation Summary
Classification: Tracking Issue (not a specific bug)
Causing PR: #80853 - "Remove dev lock from merchant rules" by @luacmartins (High confidence)
Related Issues: This issue tracks 15 individual bugs (10 backend, 5 frontend) discovered after enabling the Rules feature in staging
Recommendation: REMOVE DeployBlockerCash LABEL
This is a tracking/meta issue that aggregates multiple individual bug reports. Tracking issues should not have deploy blocker labels - only the specific bugs they track should be labeled as blockers.
Why this is safe:
Feature is locked in production: The Rules feature has multiple layers of protection:
isProductioncheck (line 103 ofMerchantRulesSection.tsx)policy.areRulesEnabledfeature flag (not widely enabled)Feature is NEW: All tracked bugs state "N/A - new feature, doesn't exist in prod" - these bugs cannot affect production users
Individual bugs already have blocker labels: For example:
DeployBlocker(backend)DeployBlockerCash(frontend)Timeline confirms this: PR Remove dev lock from merchant rules #80853 merged Jan 30 (enabled in staging), this tracking issue created Feb 2 (after bugs discovered)
Labels: Removing
DeployBlockerCashfrom this tracking issue. The individual bugs it references should retain their appropriate blocker labels.Detailed Analysis
Evidence
PR #80853 changed
MerchantRulesSection.tsx:This enabled Merchant Rules in staging/dev but kept them hidden in production. All the bugs listed in this tracking issue were discovered during staging testing after this change.
Verification
Confirmed that:
MerchantRulesSection.tsxcontains production lock (line 103-105)PolicyRulesPage.tsxrequiresCONST.POLICY.MORE_FEATURES.ARE_RULES_ENABLEDfeature flagRoot Cause
This is not a bug itself - it's a project management tracking issue created to organize the follow-up work needed for the newly-enabled Rules feature. The actual bugs are tracked individually and have their own deploy blocker labels as appropriate.
situchan commentedon Feb 2, 2026
We're not releasing this feature to production yet so it's fine to demote.
App/src/pages/workspace/rules/MerchantRulesSection.tsx
Lines 103 to 105 in b584a9d
pecanoro commentedon Feb 2, 2026
Got it! I added it just in case so the project leaders can take a look and make sure it's fine. Better be safe than sorry!
JS00001 commentedon Feb 9, 2026
Going to close this tracking issue out, theres one PR left in review