You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Expense - Wrong tax total when unreported expense is added offline #81943
Version Number: 9.3.16-0 Reproducible in staging?: Yes Reproducible in production?: N/A - new feature, doesn't exist in prod If this was caught during regression testing, add the test name, ID and link from BrowserStack:#80079 Email or phone of affected tester (no customers):sjiondjsondjoisjsojdos@gmail.com Issue reported by: Applause Internal Team Bug source: Exploratory - Significant User Experience Deterioration Device used: Mac 26.2 / Chrome App Component: Money Requests
Action Performed:
Precondition:
Taxes are enabled.
Go to staging.new.expensify.com
Go to self DM.
Create an expense with non-zero tax rate.
Go to workspace chat.
Create an expense with different amount non-zero tax rate.
Open the report.
Go offline.
Click More > Add expenses > Add unreported expense.
Select the self DM expense from Step 3 and click Add unreported expense.
Expected Result:
Tax total will be the sum of tax from workspace expense and self DM expense.
Actual Result:
Tax total is not the sum of tax from workspace expense and self DM expense.
It only updates to the correct sum after returning online.
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
Identify the pull request that introduced this issue and revert it.
Classification: Frontend bug Causing PR: #80079 - "feat: Add Billable and Tax subtotals to the report view" by @nkdengineer (High confidence) Related Issues: #78927 (original feature request)
Recommendation: REVERT
PR #80079 introduced a bug in the offline calculation of tax totals. The getBillableAndTaxTotal function uses convertedTaxAmount which is not available when offline, causing incorrect tax totals until the user goes back online.
Labels: Removing DeployBlocker label as this is a frontend bug that requires changes in App, not the backend. Keeping DeployBlockerCash to block the App deploy.
📋 Detailed Analysis
Evidence
The issue specifically states:
Tax total is incorrect when adding unreported expenses offline (step 7-9)
It only updates to the correct sum after returning online
PR #80079 was explicitly mentioned in the issue as the source, and melvin-bot auto-assigned it based on this PR.
The Problem: When a transaction has a different currency than the report, the function relies on convertedTaxAmount. This value is populated by the backend API after currency conversion. When offline, this field is undefined, so it defaults to 0 (via the ?? 0 operator), resulting in an incorrect tax total calculation.
The same issue exists for billable amounts with convertedAmount on lines 4380-4384.
When the user goes back online, the API returns the convertedTaxAmount value, which updates the tax total to the correct amount.
Activity
melvin-bot commentedon Feb 10, 2026
You have been assigned to this deploy blocker because you recently merged this PR: #80079
melvin-bot commentedon Feb 10, 2026
💬 A slack conversation has been started in #expensify-open-source
melvin-bot commentedon Feb 10, 2026
Triggered auto assignment to @JmillsExpensify (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.github-actions commentedon Feb 10, 2026
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
OSBotify commentedon Feb 10, 2026
🔍 Investigation Summary
Classification: Frontend bug
Causing PR: #80079 - "feat: Add Billable and Tax subtotals to the report view" by @nkdengineer (High confidence)
Related Issues: #78927 (original feature request)
Recommendation: REVERT
PR #80079 introduced a bug in the offline calculation of tax totals. The
getBillableAndTaxTotalfunction usesconvertedTaxAmountwhich is not available when offline, causing incorrect tax totals until the user goes back online.Labels: Removing
DeployBlockerlabel as this is a frontend bug that requires changes in App, not the backend. KeepingDeployBlockerCashto block the App deploy.📋 Detailed Analysis
Evidence
The issue specifically states:
PR #80079 was explicitly mentioned in the issue as the source, and melvin-bot auto-assigned it based on this PR.
Verification
PR #80079 modified the following key files:
src/libs/ReportUtils.ts- AddedgetBillableAndTaxTotalfunctionsrc/components/MoneyRequestReportView/MoneyRequestReportTransactionList.tsx- Uses the new functionsrc/components/ReportActionItem/MoneyReportView.tsx- Uses the new functionsrc/types/onyx/Transaction.ts- AddedconvertedTaxAmountfieldThe merge date was 2026-02-06, which aligns with this being in the 9.3.16-0 staging release.
Root Cause
In
src/libs/ReportUtils.tslines 4386-4391, thegetBillableAndTaxTotalfunction calculates tax totals:The Problem: When a transaction has a different currency than the report, the function relies on
convertedTaxAmount. This value is populated by the backend API after currency conversion. When offline, this field isundefined, so it defaults to0(via the?? 0operator), resulting in an incorrect tax total calculation.The same issue exists for billable amounts with
convertedAmounton lines 4380-4384.When the user goes back online, the API returns the
convertedTaxAmountvalue, which updates the tax total to the correct amount.nkdengineer commentedon Feb 10, 2026
@mjasikowski Let me know if you want to revert or add a quick fix for blockers related to #78927
melvin-bot commentedon Feb 10, 2026
If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.
If a regression has occurred and you are the assigned CM follow the instructions here.
If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.
mjasikowski commentedon Feb 10, 2026
@nkdengineer we'll revert so we have more time to test the fixes
nkdengineer commentedon Feb 10, 2026
@mjasikowski Got it. Please help to create a revert, I will create another PR.
mjasikowski commentedon Feb 10, 2026
PR reverted, removed blocker label. Closing the issue.