You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Expense - Tax total is still shown when Taxes are disabled #81944
Version Number: 9.3.16-0 Reproducible in staging?: Yes Reproducible in production?: N/A - new feature, doesn't exist in prod If this was caught during regression testing, add the test name, ID and link from BrowserStack:#80079 Email or phone of affected tester (no customers):soidjniosjdosjosidj@gmail.com Issue reported by: Applause Internal Team Bug source: Exploratory - Significant User Experience Deterioration Device used: Mac 26.2 / Chrome App Component: Money Requests
Action Performed:
Precondition:
Taxes are enabled.
Go to staging.new.expensify.com
2.Go to workspace chat.
Create two expenses with non-zero tax rate.
Go to workspace settings > More features.
Disable Taxes.
Go back to workspace chat and open the expense report.
Expected Result:
Tax total should be hidden when Taxes are disabled because Tax fields are also hidden in expense details.
Actual Result:
Tax total is still shown when Taxes are disabled and Tax fields are hidden in expense details.
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
Identify the pull request that introduced this issue and revert it.
Classification: Frontend bug Causing PR: #80079 - "feat: Add Billable and Tax subtotals to the report view" by @nkdengineer (High confidence) Related Issues: None
Recommendation: REVERT
PR #80079 added the ability to display billable and tax subtotals in expense reports. However, the implementation shows the tax total whenever transactions have tax amounts, without checking if taxes are currently enabled in the workspace settings. This creates an inconsistency where the tax total is displayed in the report breakdown even though individual expense tax fields are hidden when taxes are disabled.
Labels: Keeping DeployBlockerCash (Frontend bug blocks App deploy). Removing DeployBlocker if present (no backend changes needed).
📋 Detailed Analysis
Evidence
The issue states that when:
Taxes are enabled and expenses are created with non-zero tax rates
Taxes are then disabled in workspace settings (More features > Taxes)
The tax total still appears in the expense report breakdown
But individual expense tax fields are correctly hidden
This behavior was introduced in PR #80079, which merged on 2026-02-06.
MoneyReportView.tsx - Added tax total display logic
MoneyRequestReportTransactionList.tsx - Added tax total display logic
ReportUtils.ts - Added getBillableAndTaxTotal() function
Root Cause
The getBillableAndTaxTotal() function in ReportUtils.ts calculates the tax total from all transactions without checking if taxes are currently enabled in the policy. The display logic then shows the tax breakdown whenever taxTotal > 0:
// Line 235 in MoneyReportView.tsx{label: 'common.tax',value: formattedTaxAmount,show: !!taxTotal},
The correct logic should check policy?.tax?.trackingEnabled before displaying the tax total, similar to how individual expense tax fields are hidden when taxes are disabled. The function should either:
Accept a policy parameter and check policy?.tax?.trackingEnabled before calculating tax totals, OR
The display logic should check the policy setting before showing the tax line item
Activity
melvin-bot commentedon Feb 10, 2026
You have been assigned to this deploy blocker because you recently merged this PR: #80079
melvin-bot commentedon Feb 10, 2026
💬 A slack conversation has been started in #expensify-open-source
melvin-bot commentedon Feb 10, 2026
Triggered auto assignment to @dylanexpensify (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.github-actions commentedon Feb 10, 2026
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
OSBotify commentedon Feb 10, 2026
🔍 Investigation Summary
Classification: Frontend bug
Causing PR: #80079 - "feat: Add Billable and Tax subtotals to the report view" by @nkdengineer (High confidence)
Related Issues: None
Recommendation: REVERT
PR #80079 added the ability to display billable and tax subtotals in expense reports. However, the implementation shows the tax total whenever transactions have tax amounts, without checking if taxes are currently enabled in the workspace settings. This creates an inconsistency where the tax total is displayed in the report breakdown even though individual expense tax fields are hidden when taxes are disabled.
Labels: Keeping
DeployBlockerCash(Frontend bug blocks App deploy). RemovingDeployBlockerif present (no backend changes needed).📋 Detailed Analysis
Evidence
The issue states that when:
This behavior was introduced in PR #80079, which merged on 2026-02-06.
Verification
Files affected by the bug:
/home/runner/_work/App/App/src/components/ReportActionItem/MoneyReportView.tsx(lines 82-89, 235)/home/runner/_work/App/App/src/components/MoneyRequestReportView/MoneyRequestReportTransactionList.tsx(lines 182-186, 635)/home/runner/_work/App/App/src/libs/ReportUtils.ts(lines 4368-4397)Confirmed that PR #80079 modifies these files:
getBillableAndTaxTotal()functionRoot Cause
The
getBillableAndTaxTotal()function in ReportUtils.ts calculates the tax total from all transactions without checking if taxes are currently enabled in the policy. The display logic then shows the tax breakdown whenevertaxTotal > 0:The correct logic should check
policy?.tax?.trackingEnabledbefore displaying the tax total, similar to how individual expense tax fields are hidden when taxes are disabled. The function should either:policy?.tax?.trackingEnabledbefore calculating tax totals, ORdylanexpensify commentedon Feb 10, 2026
@nkdengineer please review
nkdengineer commentedon Feb 10, 2026
Discussing here for the next step.
IuliiaHerets commentedon Feb 10, 2026
@mjasikowski Chrome / v9.3.16-3
No Tax field under Total in expense report not before, not after Tax disabling
Screen.Recording.2026-02-10.at.3.02.50.PM.mp4
mjasikowski commentedon Feb 10, 2026
PR reverted, removed blocker label. Closing the issue.