Skip to content

Expense - Tax total is still shown when Taxes are disabled #81944

Closed

Description

@jponikarchuk

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 9.3.16-0
Reproducible in staging?: Yes
Reproducible in production?: N/A - new feature, doesn't exist in prod
If this was caught during regression testing, add the test name, ID and link from BrowserStack: #80079
Email or phone of affected tester (no customers): soidjniosjdosjosidj@gmail.com
Issue reported by: Applause Internal Team
Bug source: Exploratory - Significant User Experience Deterioration
Device used: Mac 26.2 / Chrome
App Component: Money Requests

Action Performed:

Precondition:

  • Taxes are enabled.
  1. Go to staging.new.expensify.com
    2.Go to workspace chat.
  2. Create two expenses with non-zero tax rate.
  3. Go to workspace settings > More features.
  4. Disable Taxes.
  5. Go back to workspace chat and open the expense report.

Expected Result:

Tax total should be hidden when Taxes are disabled because Tax fields are also hidden in expense details.

Actual Result:

Tax total is still shown when Taxes are disabled and Tax fields are hidden in expense details.

Workaround:

Unknown

Platforms:

  • Android: App
  • Android: mWeb Chrome
  • iOS: App
  • iOS: mWeb Safari
  • iOS: mWeb Chrome
  • Windows: Chrome
  • MacOS: Chrome / Safari

Screenshots/Videos

1.mp4

View all open jobs on GitHub

Activity

  1. added
    BugSomething is broken. Auto assigns a BugZero manager.
    on Feb 10, 2026
  2. melvin-bot commented on Feb 10, 2026

    @melvin-bot

    You have been assigned to this deploy blocker because you recently merged this PR: #80079

  3. melvin-bot commented on Feb 10, 2026

    @melvin-bot

    💬 A slack conversation has been started in #expensify-open-source

  4. melvin-bot commented on Feb 10, 2026

    @melvin-bot

    Triggered auto assignment to @dylanexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  5. github-actions commented on Feb 10, 2026

    @github-actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  6. OSBotify commented on Feb 10, 2026

    @OSBotify
    Contributor

    🔍 Investigation Summary

    Classification: Frontend bug
    Causing PR: #80079 - "feat: Add Billable and Tax subtotals to the report view" by @nkdengineer (High confidence)
    Related Issues: None

    Recommendation: REVERT

    PR #80079 added the ability to display billable and tax subtotals in expense reports. However, the implementation shows the tax total whenever transactions have tax amounts, without checking if taxes are currently enabled in the workspace settings. This creates an inconsistency where the tax total is displayed in the report breakdown even though individual expense tax fields are hidden when taxes are disabled.

    Labels: Keeping DeployBlockerCash (Frontend bug blocks App deploy). Removing DeployBlocker if present (no backend changes needed).

    📋 Detailed Analysis

    Evidence

    The issue states that when:

    1. Taxes are enabled and expenses are created with non-zero tax rates
    2. Taxes are then disabled in workspace settings (More features > Taxes)
    3. The tax total still appears in the expense report breakdown
    4. But individual expense tax fields are correctly hidden

    This behavior was introduced in PR #80079, which merged on 2026-02-06.

    Verification

    Files affected by the bug:

    • /home/runner/_work/App/App/src/components/ReportActionItem/MoneyReportView.tsx (lines 82-89, 235)
    • /home/runner/_work/App/App/src/components/MoneyRequestReportView/MoneyRequestReportTransactionList.tsx (lines 182-186, 635)
    • /home/runner/_work/App/App/src/libs/ReportUtils.ts (lines 4368-4397)

    Confirmed that PR #80079 modifies these files:

    • MoneyReportView.tsx - Added tax total display logic
    • MoneyRequestReportTransactionList.tsx - Added tax total display logic
    • ReportUtils.ts - Added getBillableAndTaxTotal() function

    Root Cause

    The getBillableAndTaxTotal() function in ReportUtils.ts calculates the tax total from all transactions without checking if taxes are currently enabled in the policy. The display logic then shows the tax breakdown whenever taxTotal > 0:

    // Line 235 in MoneyReportView.tsx
    {label: 'common.tax', value: formattedTaxAmount, show: !!taxTotal},

    The correct logic should check policy?.tax?.trackingEnabled before displaying the tax total, similar to how individual expense tax fields are hidden when taxes are disabled. The function should either:

    1. Accept a policy parameter and check policy?.tax?.trackingEnabled before calculating tax totals, OR
    2. The display logic should check the policy setting before showing the tax line item
  7. dylanexpensify commented on Feb 10, 2026

    @dylanexpensify
    Contributor

    @nkdengineer please review

  8. nkdengineer commented on Feb 10, 2026

    @nkdengineer
    Contributor

    Discussing here for the next step.

  9. IuliiaHerets commented on Feb 10, 2026

    @IuliiaHerets

    @mjasikowski Chrome / v9.3.16-3
    No Tax field under Total in expense report not before, not after Tax disabling

    Screen.Recording.2026-02-10.at.3.02.50.PM.mp4
  10. added and removed
    DeployBlockerCashThis issue or pull request should block deployment
    on Feb 10, 2026
  11. mjasikowski commented on Feb 10, 2026

    @mjasikowski
    Contributor

    PR reverted, removed blocker label. Closing the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

BugSomething is broken. Auto assigns a BugZero manager.EngineeringReviewingHas a PR in reviewWeeklyKSv2

Type

No type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions