Repository navigation
Deploy Checklist: New Expensify 2022-03-24 #8305
Description
Release Version: 1.1.46-3
Compare Changes: production...staging
This release contains changes from the following pull requests:
-
New line indicator working fine #6764
- QA
- Accessibility
-
Implement Archived Workspace Chat UI #7831
- QA
- Accessibility
-
IOU Invalid Phone number error handled #8019
- QA
- Accessibility
-
add settlement frequency link complete #8050
- QA
- Accessibility
-
Bump Onyx version to help with IndexedDB slow writes #8053
- QA
- Accessibility
-
Use GH CLI instead of community actions #8063
- QA
- Accessibility
-
[No QA] Remove throw in registerNetworkResponseHandler. Clean up IOU actions file. #8087
- QA
- Accessibility
-
Handle Wallet Onfido flow #8093
- QA
- Accessibility
-
Build Desktop for x64 and arm64 only #8160
- QA
- Accessibility
-
Fix: Modal freezing issue on Payments page #8173
- QA
- Accessibility
-
- QA
- Accessibility
-
- QA
- Accessibility
-
Block Buttons from firing callbacks on background screens #8196
- QA
- Accessibility
-
[Feat] Add Image loading indicator #8203
- QA
- Accessibility
-
Exit to the proper page when transitioning #8204
- QA
- Accessibility
-
Update debit card balance transfer error when current balance != available balance #8205
- QA
- Accessibility
-
Press On Enter in Button with Dropdown #8206
- QA
- Accessibility
-
[No QA] Fix deploy announce in slack #8211
- QA
- Accessibility
-
[Fix] Add original filename when downloading a file #8223
- QA
- Accessibility
-
Make workspace chat instantly available on workspace creation and when users are invited #8226
- QA
- Accessibility
-
[No QA] update PR checklist #8231
- QA
- Accessibility
-
Revert "[Feat] Add Image loading indicator" #8242
- QA
- Accessibility
-
Increase the decimal point number to three in track distance rate #8253
- QA
- Accessibility
-
Remove unused expensify-cash URL schema #8254
- QA
- Accessibility
-
Sign in, out, or navigate on transition mount #8257
- QA
- Accessibility
-
Add myself as a "code owner" for some files in need of review #8258
- QA
- Accessibility
-
[No QA] update PR checklist #8262
- QA
- Accessibility
-
Fix storybok config to exclude extra files. #8265
- QA
- Accessibility
-
Tweak timeout for starting GH Action to ten minutes #8266
- QA
- Accessibility
-
Add createOnReadyTask. Fix broken growls triggered before init. #8271
- QA
- Accessibility
-
IOU - Fix Infinite loading spinner on split bill with invalid phone number #8314
- QA
- Accessibility
-
Fix blank screen when signing in with Expensifail account #8322
- QA
- Accessibility
-
[No QA] Fix policyExpenseChat beta not being applied correctly #8343
- QA
- Accessibility
Internal QA:
Deploy Blockers:
- IOU - Infinite loading spinner appears when split bill with invalid phone number #8308
- Blank screen is displayed after log in with new expensifail account #8320
cc @Expensify/applauseleads
Activity
OSBotify commentedon Mar 24, 2022
🚀 All staging deploys are complete, @Expensify/applauseleads please begin QA on version https://github.com/Expensify/App/releases/tag/1.1.46-0 🚀
roryabraham commentedon Mar 24, 2022
YOOO I am unable to reproduce #8308 – can you retest please? It worked as expected me on
1.1.46-0mvtglobally commentedon Mar 25, 2022
Desktop build is still 1.1.44-4. We tried to download from URL as well and it is not updating. Pls let us know if anything can be pushed there - RESOLVED
OSBotify commentedon Mar 25, 2022
👏 Heads up @Expensify/applauseleads 👏
A new pull request has been 🍒 cherry-picked 🍒 to staging, and will be deployed to staging in version
1.1.46-1🚀OSBotify commentedon Mar 25, 2022
🎉 All set?…You bet! @Expensify/applauseleads https://github.com/Expensify/App/releases/tag/1.1.46-1 has been deployed to staging 🎉
OSBotify commentedon Mar 25, 2022
👏 Heads up @Expensify/applauseleads 👏
A new pull request has been 🍒 cherry-picked 🍒 to staging, and will be deployed to staging in version
1.1.46-2🚀OSBotify commentedon Mar 26, 2022
🎉 All set?…You bet! @Expensify/applauseleads https://github.com/Expensify/App/releases/tag/1.1.46-2 has been deployed to staging 🎉
mvtglobally commentedon Mar 28, 2022
#8160 (comment)
#8205 (comment)
#8226 (comment)
#8265 (comment) - can we check it off?
Deploy blocker #8019 failing due to #8308 we are retesting
#8173 is failing this, App is freezing, should we treat it as deploy blocker? #8173 (comment)
#8174 is failing #8313, checking off as repro in PROD
#8195 is failing due to #8311. Its a new feature, do we want to treat is as Blocker?
#8257 is failing due to #8295. Not blocker checking off
#8063 - InternalQA
#8204 is a PR from previous deploy. Can I just check it off as it wasn't deployed again and not in PROD yet
roryabraham commentedon Mar 28, 2022
#8160 was verified by a number of people on both x64 and arm. Checking it off.
roryabraham commentedon Mar 28, 2022
@mvtglobally Does that mean that #8308 is still reproducible?
mvtglobally commentedon Mar 28, 2022
@roryabraham Checking off #8308. Its not repro
mvtglobally commentedon Mar 29, 2022
@roryabraham @timszot Just few things pending on this checklist. Can we close it off today
Deploy blocker #8019 fix is pass, checking off
#8063 - InternalQA - Can someone validate and checkoff?
#8205 (comment) - InternalQA - Can someone validate and checkoff?
#8173 is failing this, App is freezing, should we treat it as deploy blocker?
#8195 is failing due to #8311. Its a new feature, do we want to treat is as Blocker?
#8204 is a PR from previous deploy. Can I just check it off as it wasn't deployed again and not in PROD yet
#8226 - we are retesting and will check off
#8265 (comment) - can we check it off?
timszot commentedon Mar 29, 2022
OK, I'm going through all of these.
Checked off, there's a comment saying it worked.
Pinged in the PR and in internal Slack channels.
Asked in PR to confirm my thoughts, but no, I don't think we need to block on this.
I would say no it's not worth blocker for since there is a new issue opened to track the bug and it doesn't break any functionality, it's just a copy change.
Checked off.
Looks like we can, doing it!
OSBotify commentedon Mar 29, 2022
👏 Heads up @Expensify/applauseleads 👏
A new pull request has been 🍒 cherry-picked 🍒 to staging, and will be deployed to staging in version
1.1.46-3🚀OSBotify commentedon Mar 29, 2022
🎉 All set?…You bet! @Expensify/applauseleads https://github.com/Expensify/App/releases/tag/1.1.46-3 has been deployed to staging 🎉
mvtglobally commentedon Mar 29, 2022
Checking off 8226, #8195
@timszot We are down to #8173 and #8205 (comment)
timszot commentedon Mar 29, 2022
Checking off #8173
Only InternalQA for #8205 left
mvtglobally commentedon Mar 30, 2022
@timszot any update on the last PR? hoping for a new Deploy today
neil-marcellini commentedon Mar 30, 2022
I'm doing the QA now, the engineers tagged are outside the US, and the currency was IP based, so they couldn't QA it.
neil-marcellini commentedon Mar 30, 2022
QA passed for #8205! Wow, quite a struggle to test that one. I had to use my own bank account and debit card for testing.
timszot commentedon Mar 30, 2022
SumitDiyora commentedon Apr 15, 2022
Checked all PRs on Production / Staging and created accessibility issues for all PRs where accessibility issues were found.
The non-applicable PRs are - #6764, #7831, #8050, #8053, #8063, #8087, #8160, #8174, #8181, #8203, #8204, #8205, #8211, #8231, #8242, #8254, #8257, #8258, #8262, #8265, #8266, #8271
Logged Issues - #8398, #8395, #8393, #8392, #8430, #8616, #8432, #8577, #8575, #8417, #8392, #8654, #8554, #8413, #8432, #8433, #8434, #8558, #8559, #8392, #8393, #8395, #8398, #8408, #8403, #8392, #8465, #8398, #8633, #8465, #8402, #8651, #8432, #8430, #8463, #8403, #8402, #8401
Note: After client confirmation PR #8093 has no QA steps, and can be skipped