Repository navigation
[Due for payment 2026-04-30] LHN - Completed task is highlighted when opening #admins room #85659
Description
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Version Number: 9.3.40-0
Reproducible in staging?: Yes
Reproducible in production?: N/A - new feature, doesn't exist in prod
If this was caught during regression testing, add the test name, ID and link from BrowserStack: #85192
Email or phone of affected tester (no customers): sjodinjsonjinodisjniod@gmail.com
Issue reported by: Applause Internal Team
Bug source: Exploratory - Significant User Experience Deterioration
Device used: Mac 26.2 / Chrome
App Component: Chat Report View
Action Performed:
- Go to staging.new.expensify.com
- Create a new Gmail account.
- Complete onboarding with Something else intent.
- Create a workspace.
- Go to workspace chat.
- Go to #admins room.
Expected Result:
The first incomplete task will be highlighted.
Actual Result:
The completed task will be highlighted.
Workaround:
Unknown
Platforms:
- Android: App
- Android: mWeb Chrome
- iOS: App
- iOS: mWeb Safari
- iOS: mWeb Chrome
- Windows: Chrome
- MacOS: Chrome / Safari
Screenshots/Videos
Video.mp4
Issue Owner
Current Issue Owner: @hoangzinhMetadata
Metadata
Assignees
Type
Projects
- Status
Activity
melvin-bot commentedon Mar 18, 2026
You have been assigned to this deploy blocker because you recently merged this PR: #85192
melvin-bot commentedon Mar 18, 2026
💬 A slack conversation has been started in #expensify-open-source
github-actions commentedon Mar 18, 2026
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
OSBotify commentedon Mar 18, 2026
Investigation Summary
Classification: Frontend bug
Causing PR: #85192 - "feat: deep link to report preview or message that caused GBR/RBR" by @aimane-chnaif (High confidence)
Related Issues: None
Recommendation: REVERT
The PR introduces a feature to deep-link to specific report actions when clicking LHN rows. The feature is intentionally disabled in production via an
isProductiongate but enabled on staging. The bug is caused by incorrect logic that selects the wrong task to highlight.Labels: No label changes needed - this is a frontend bug in the App repo, so
DeployBlockerCashshould remain.Detailed Analysis
Evidence
The PR #85192 was merged on 2026-03-18 at 12:28:55Z and is included in version 9.3.40-0, matching the affected version in this issue. The bot (melvin-bot) also identified this PR as the cause.
Verification
The bug occurs in the #admins room where tasks are displayed. I verified the PR modifies:
src/libs/ReportUtils.ts- AddsactionTargetReportActionIDlogicsrc/pages/inbox/sidebar/SidebarLinks.tsx- Uses the new deep-linking with production gatesrc/libs/SidebarUtils.ts- Updates report action selection logicThe PR description explicitly states: "I intentionally disabled this feature in production yet to avoid PR being reverted."
Root Cause
In
src/libs/ReportUtils.tsat line 4333, when determining which report action to deep-link to for tasks, the code uses:This returns the first task found during object iteration, which has no guaranteed order. When there are multiple tasks (both completed and incomplete), this can select a completed task instead of the first incomplete task that should be highlighted.
The issue manifests on staging because:
SidebarLinks.tsx:isProduction ? undefined : option.actionTargetReportActionIDisProduction = false), the buggyactionTargetReportActionIDis usedisProduction = true), the feature is disabled entirelyWhy REVERT?
aimane-chnaif commentedon Mar 18, 2026
Let me investigate. Btw let's demote this as feature is only available in staging
29 remaining items
lanitochka17 commentedon Apr 22, 2026
Deploy Blocker ##88544 was identified to be related to the PR ##87166 that attempted to fix this issue.
melvin-bot commentedon Apr 23, 2026
If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.
If a regression has occurred and you are the assigned CM follow the instructions here.
If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.
melvin-bot commentedon Apr 23, 2026
Reviewinglabel has been removed, please complete the "BugZero Checklist".[-]LHN - Completed task is highlighted when opening #admins room[/-][+][Due for payment 2026-04-30] LHN - Completed task is highlighted when opening #admins room[/+]melvin-bot commentedon Apr 23, 2026
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.3.61-4 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2026-04-30. 🎊
For reference, here are some details about the assignees on this issue:
melvin-bot commentedon Apr 23, 2026
@hoangzinh / @aimane-chnaif The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]
hoangzinh commentedon Apr 24, 2026
@aimane-chnaif, should we close this issue?
aimane-chnaif commentedon Apr 24, 2026
@MelvinBot close this issue