Skip to content

[$250] [Due for payment 2026-04-30] Action Badge: Fix deep link regression #86062

Closed

Description

@quinthar

Context

This is a follow-up to the Action Badge feature (expanding GBR/RBR with action badges in the Inbox/LHN). Two issues need to be addressed:

Fix deep link regression

Clicking on the LHN action badge is no longer correctly deep-linking to the report/action that triggered the badge. This was previously working but has regressed.

Expected behavior: Clicking the Inbox LHN should:

  1. If there is an action badge, deep link to the oldest actionable report (ie, the cause of the action badge)
    • Note: Expense threads can have a Fix action badge when there is a violation to resolve. This doesn't have a corresponding reportActionID, so can't be deep linked to directly. In this case, when clicking Fix on an expense with a violation, just open the report scrolled to the top so the expense is visible.
  2. Otherwise, if there are unread messages, deep link to the oldest unread message
  3. Otherwise, link to the bottom of the report

Note: This behavior is a little inconsistent due to a bunch of old historical decisions that predate the "super-wide report modal". Please verify that this behavior works correctly and consistently for all report types, including expense reports, expense threads, single-expense reports, etc.

Reference: Slack thread with details
https://github.com/user-attachments/assets/c114fdea-4267-4413-9877-c8210b537c62

Issue OwnerCurrent Issue Owner: @mallenexpensify
Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~022050321669937443025
  • Upwork Job ID: 2050321669937443025
  • Last Price Increase: 2026-05-01

Activity

  1. melvin-bot commented on Mar 26, 2026

    @melvin-bot

    @aimane-chnaif Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

  2. melvin-bot commented on Mar 30, 2026

    @melvin-bot

    @aimane-chnaif 6 days overdue. This is scarier than being forced to listen to Vogon poetry!

  3. melvin-bot commented on Mar 30, 2026

    @melvin-bot

    @aimane-chnaif 6 days overdue. This is scarier than being forced to listen to Vogon poetry!

  4. melvin-bot commented on Mar 30, 2026

    @melvin-bot

    @aimane-chnaif 6 days overdue. This is scarier than being forced to listen to Vogon poetry!

  5. melvin-bot commented on Apr 1, 2026

    @melvin-bot

    @aimane-chnaif 8 days overdue is a lot. Should this be a Weekly issue? If so, feel free to change it!

  6. melvin-bot commented on Apr 3, 2026

    @melvin-bot

    @aimane-chnaif 10 days overdue. Is anyone even seeing these? Hello?

  7. melvin-bot commented on Apr 8, 2026

    @melvin-bot

    This issue has not been updated in over 14 days. @aimane-chnaif eroding to Weekly issue.

  8. 20 remaining items

  9. aimane-chnaif commented on May 1, 2026

    @aimane-chnaif
    Contributor

    Not regression.
    The linked blockers are not directly caused by my PR.
    Reasoning:
    For #87166 (comment): #88456 (comment)
    For #87166 (comment): #88544 (comment)

  10. aimane-chnaif commented on May 1, 2026

    @aimane-chnaif
    Contributor

    BugZero Checklist:

    • [Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.

      Link to comment: new feature

    • [Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.

      Link to discussion:

    • [Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.

    • [BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.

      Link to issue: https://github.com/Expensify/Expensify/issues/632340

    Regression Test Proposal

    Test:

    1. Go to workspace chat with no unsettled expense.
    2. Create an expense.
    3. Click on the workspace chat on LHN.
    4. Verify that deep linking occurs while user is on workspace chat.

    Do we agree 👍 or 👎

    Zapier Logs Run ID: 00040eee-38ae-a20a-caa2-a5b5ec73db74
  11. added
    ExternalAdded to denote the issue can be worked on by a contributor
    on May 1, 2026
  12. added
    Help WantedApply this label when an issue is open to proposals by contributors
    on May 1, 2026
  13. melvin-bot commented on May 1, 2026

    @melvin-bot

    Current assignee @aimane-chnaif is eligible for the External assigner, not assigning anyone new.

  14. changed the title [-][Due for payment 2026-04-30] Action Badge: Fix deep link regression[/-] [+][$250] [Due for payment 2026-04-30] Action Badge: Fix deep link regression[/+] on May 1, 2026
  15. melvin-bot commented on May 1, 2026

    @melvin-bot
  16. removed
    Help WantedApply this label when an issue is open to proposals by contributors
    on May 1, 2026
  17. mallenexpensify commented on May 1, 2026

    @mallenexpensify
    Contributor

    @aimane-chnaif can you please accept the job below? Please reply here and tag me once you have.
    https://www.upwork.com/jobs/~022050321669937443025

  18. aimane-chnaif commented on May 4, 2026

    @aimane-chnaif
    Contributor

    @mallenexpensify accepted offer

  19. mallenexpensify commented on May 4, 2026

    @mallenexpensify
    Contributor

    Payment Summary

    Contributor+: @aimane-chnaif paid $250 via Upwork

    ^ Test case created

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionDailyKSv2ExternalAdded to denote the issue can be worked on by a contributorImprovementItem broken or needs improvement.

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions