You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[$250] [Due for payment 2026-04-30] Action Badge: Fix deep link regression #86062
This is a follow-up to the Action Badge feature (expanding GBR/RBR with action badges in the Inbox/LHN). Two issues need to be addressed:
Fix deep link regression
Clicking on the LHN action badge is no longer correctly deep-linking to the report/action that triggered the badge. This was previously working but has regressed.
Expected behavior: Clicking the Inbox LHN should:
If there is an action badge, deep link to the oldest actionable report (ie, the cause of the action badge)
Note: Expense threads can have a Fix action badge when there is a violation to resolve. This doesn't have a corresponding reportActionID, so can't be deep linked to directly. In this case, when clicking Fix on an expense with a violation, just open the report scrolled to the top so the expense is visible.
Otherwise, if there are unread messages, deep link to the oldest unread message
Otherwise, link to the bottom of the report
Note: This behavior is a little inconsistent due to a bunch of old historical decisions that predate the "super-wide report modal". Please verify that this behavior works correctly and consistently for all report types, including expense reports, expense threads, single-expense reports, etc.
[Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.
Link to comment: new feature
[Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.
Link to discussion:
[Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.
[BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.
changed the title [-][Due for payment 2026-04-30] Action Badge: Fix deep link regression[/-][+][$250] [Due for payment 2026-04-30] Action Badge: Fix deep link regression[/+]on May 1, 2026
Activity
melvin-bot commentedon Mar 26, 2026
@aimane-chnaif Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!
melvin-bot commentedon Mar 30, 2026
@aimane-chnaif 6 days overdue. This is scarier than being forced to listen to Vogon poetry!
melvin-bot commentedon Mar 30, 2026
@aimane-chnaif 6 days overdue. This is scarier than being forced to listen to Vogon poetry!
melvin-bot commentedon Mar 30, 2026
@aimane-chnaif 6 days overdue. This is scarier than being forced to listen to Vogon poetry!
melvin-bot commentedon Apr 1, 2026
@aimane-chnaif 8 days overdue is a lot. Should this be a Weekly issue? If so, feel free to change it!
melvin-bot commentedon Apr 3, 2026
@aimane-chnaif 10 days overdue. Is anyone even seeing these? Hello?
melvin-bot commentedon Apr 8, 2026
This issue has not been updated in over 14 days. @aimane-chnaif eroding to Weekly issue.
20 remaining items
aimane-chnaif commentedon May 1, 2026
Not regression.
The linked blockers are not directly caused by my PR.
Reasoning:
For #87166 (comment): #88456 (comment)
For #87166 (comment): #88544 (comment)
aimane-chnaif commentedon May 1, 2026
BugZero Checklist:
[Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.
Link to comment: new feature
[Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.
Link to discussion:
[Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.
[BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.
Link to issue: https://github.com/Expensify/Expensify/issues/632340
Regression Test Proposal
Test:
Do we agree 👍 or 👎
Zapier Logs
Run ID: 00040eee-38ae-a20a-caa2-a5b5ec73db74melvin-bot commentedon May 1, 2026
Current assignee @aimane-chnaif is eligible for the External assigner, not assigning anyone new.
[-][Due for payment 2026-04-30] Action Badge: Fix deep link regression[/-][+][$250] [Due for payment 2026-04-30] Action Badge: Fix deep link regression[/+]melvin-bot commentedon May 1, 2026
Job added to Upwork: https://www.upwork.com/jobs/~022050321669937443025
mallenexpensify commentedon May 1, 2026
@aimane-chnaif can you please accept the job below? Please reply here and tag me once you have.
https://www.upwork.com/jobs/~022050321669937443025
aimane-chnaif commentedon May 4, 2026
@mallenexpensify accepted offer
mallenexpensify commentedon May 4, 2026
Payment Summary
Contributor+: @aimane-chnaif paid $250 via Upwork
^ Test case created