Skip to content

[Due for payment 2026-04-20] iOS FullStory redaction is too aggressive (regression) #86103

Closed

Description

@MelvinBot

Description

iOS FullStory redaction is too aggressive, making it very hard to follow what's happening in session replays.

FullStory session: https://app.fullstory.com/ui/o-1WN56P-na1/session/3880343674057054005:592018401610831014:1773882467570

Context

This appears to be a regression — redaction was previously toned down but has become overly aggressive again.

Expected Behavior

FullStory session replays on iOS should have minimal redaction so that sessions are easy to follow and debug.

Actual Behavior

Excessive redaction in iOS FullStory sessions makes it very difficult to understand user flows.

Issue OwnerCurrent Issue Owner: @fabioh8010

Activity

  1. LukasMod commented on Mar 26, 2026

    @LukasMod
    Contributor

    Hi, I am Łukasz from Callstack, an expert agency and I can work on this issue

  2. LukasMod commented on Mar 26, 2026

    @LukasMod
    Contributor

    I prepared a few tests and reapplied the default value to ScreenWrapperContainer (UNMASK).

    I know there was a commit a few months ago that tried and reverted this change, likely because it introduced some bugs when using masks in child components: d9b91c6
    (part of #69606). I tested the flows and did not find anything wrong this time. Maybe with the newer version/sdk, the previous issues no longer exist.

    I found that the problem occurs because when mobile (iOS) uses Presentation.TRANSPARENT_MODAL, it renders in a separate UIViewController and does not inherit the root fs-unmask from App.ts. When tested with Presentation.CARD, the content was unmasked as expected. I also tested with the default UNMASK prop in ScreenWrapper and directly applied MASK to the firstName input to verify that the mask correctly overrides unmask. This worked as expected: https://app.fullstory.com/ui/o-1WN56P-na1/session/1969698075856184818:5287275656602069721!6912389704850519546

    I didn’t find any issues with setting a default for ScreenWrapper. It is already set in App.ts for the entire app, but because this is a modal, it likely does not take it into account properly (separate UIViewController).

    * Looks like Android does not show modals at all. I don’t think this is a new issue (I also saw it in a replay from 25.02
    ). It would require a separate issue to investigate. Android seems to be a bit buggy in those replays. Could be sdk issue.

    Fix PR: #86414

  3. LukasMod commented on Mar 27, 2026

    @LukasMod
    Contributor

    @fabioh8010
    I checked flows again. No new issues (diff) with masking vs current version. I checked web and iOS. Mask seems to be respected as before.

    iOS:

    1. https://app.fullstory.com/ui/o-1WN56P-na1/session/1969698075856184818:5287275656602069721!7405209503783871243
    2. https://app.fullstory.com/ui/o-1WN56P-na1/session/1969698075856184818:5287275656602069721!8705051037119566703

    Web:

    1. https://app.fullstory.com/ui/o-1WN56P-na1/session/1969698075856184818:7828810331578303333!8784226245251266481

    I saw only one issue in one test try, quite random or I moved too fast between screens. One of address field was not masked (street), but in next test rounds it was. I checked that property MASK is set there correctly in our code.
    Not working street address (version with fix): https://fsty.io/v/SX5MEabG
    Working street address (same fixed version): https://fsty.io/v/hXTaVbpS

    I guess its just not super stable feature for native mobile like on web

  4. LukasMod commented on Apr 8, 2026

    @LukasMod
    Contributor

    @dylanexpensify Could you assign another reviewer to unblock this one? #86414

  5. mkhutornyi commented on Apr 8, 2026

    @mkhutornyi
    Contributor

    I can review

  6. 4 remaining items

  7. changed the title [-]iOS FullStory redaction is too aggressive (regression)[/-] [+][Due for payment 2026-04-20] iOS FullStory redaction is too aggressive (regression)[/+] on Apr 13, 2026
  8. melvin-bot commented on Apr 13, 2026

    @melvin-bot

    Reviewing label has been removed, please complete the "BugZero Checklist".

  9. melvin-bot commented on Apr 13, 2026

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 9.3.58-9 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2026-04-20. 🎊

    For reference, here are some details about the assignees on this issue:

  10. LukasMod commented on Apr 16, 2026

    @LukasMod
    Contributor

    Looks fine, example session where self dm is hidden and onboarding is visible: https://fsty.io/v/eLGpAbsN

  11. melvin-bot commented on Apr 16, 2026

    @melvin-bot

    @fabioh8010 Whoops! This issue is 2 days overdue. Let's get this updated quick!

  12. melvin-bot commented on Apr 19, 2026

    @melvin-bot

    Triggered auto assignment to @mallenexpensify (Awaiting Payment)

  13. mkhutornyi commented on Apr 20, 2026

    @mkhutornyi
    Contributor

    As performance issue, we can skip regression test.

  14. melvin-bot commented on Apr 20, 2026

    @melvin-bot

    Skipping the payment summary for this issue since all the assignees are employees or vendors. If this is incorrect, please manually add the payment summary SO.

  15. mallenexpensify commented on Apr 21, 2026

    @mallenexpensify
    Contributor

    Payment Summary

    Contributor+: @mkhutornyi due $250 via NewDot

  16. trjExpensify commented on May 6, 2026

    @trjExpensify
    Contributor

    approved $250 for @mkhutornyi

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionDailyKSv2Task

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions