You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[Due for payment 2026-04-20] iOS FullStory redaction is too aggressive (regression) #86103
I prepared a few tests and reapplied the default value to ScreenWrapperContainer (UNMASK).
I know there was a commit a few months ago that tried and reverted this change, likely because it introduced some bugs when using masks in child components: d9b91c6
(part of #69606). I tested the flows and did not find anything wrong this time. Maybe with the newer version/sdk, the previous issues no longer exist.
I found that the problem occurs because when mobile (iOS) uses Presentation.TRANSPARENT_MODAL, it renders in a separate UIViewController and does not inherit the root fs-unmask from App.ts. When tested with Presentation.CARD, the content was unmasked as expected. I also tested with the default UNMASK prop in ScreenWrapper and directly applied MASK to the firstName input to verify that the mask correctly overrides unmask. This worked as expected: https://app.fullstory.com/ui/o-1WN56P-na1/session/1969698075856184818:5287275656602069721!6912389704850519546
I didn’t find any issues with setting a default for ScreenWrapper. It is already set in App.ts for the entire app, but because this is a modal, it likely does not take it into account properly (separate UIViewController).
* Looks like Android does not show modals at all. I don’t think this is a new issue (I also saw it in a replay from 25.02
). It would require a separate issue to investigate. Android seems to be a bit buggy in those replays. Could be sdk issue.
I saw only one issue in one test try, quite random or I moved too fast between screens. One of address field was not masked (street), but in next test rounds it was. I checked that property MASK is set there correctly in our code.
Not working street address (version with fix): https://fsty.io/v/SX5MEabG
Working street address (same fixed version): https://fsty.io/v/hXTaVbpS
I guess its just not super stable feature for native mobile like on web
changed the title [-]iOS FullStory redaction is too aggressive (regression)[/-][+][Due for payment 2026-04-20] iOS FullStory redaction is too aggressive (regression)[/+]on Apr 13, 2026
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.3.58-9 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
Skipping the payment summary for this issue since all the assignees are employees or vendors. If this is incorrect, please manually add the payment summary SO.
Activity
LukasMod commentedon Mar 26, 2026
Hi, I am Łukasz from Callstack, an expert agency and I can work on this issue
LukasMod commentedon Mar 26, 2026
I prepared a few tests and reapplied the default value to ScreenWrapperContainer (UNMASK).
I know there was a commit a few months ago that tried and reverted this change, likely because it introduced some bugs when using masks in child components: d9b91c6
(part of #69606). I tested the flows and did not find anything wrong this time. Maybe with the newer version/sdk, the previous issues no longer exist.
I found that the problem occurs because when mobile (iOS) uses Presentation.TRANSPARENT_MODAL, it renders in a separate UIViewController and does not inherit the root
fs-unmaskfromApp.ts. When tested with Presentation.CARD, the content was unmasked as expected. I also tested with the default UNMASK prop in ScreenWrapper and directly applied MASK to the firstName input to verify that the mask correctly overrides unmask. This worked as expected: https://app.fullstory.com/ui/o-1WN56P-na1/session/1969698075856184818:5287275656602069721!6912389704850519546I didn’t find any issues with setting a default for ScreenWrapper. It is already set in App.ts for the entire app, but because this is a modal, it likely does not take it into account properly (separate UIViewController).
* Looks like Android does not show modals at all. I don’t think this is a new issue (I also saw it in a replay from 25.02
). It would require a separate issue to investigate. Android seems to be a bit buggy in those replays. Could be sdk issue.
Fix PR: #86414
LukasMod commentedon Mar 27, 2026
@fabioh8010
I checked flows again. No new issues (diff) with masking vs current version. I checked web and iOS. Mask seems to be respected as before.
iOS:
Web:
I saw only one issue in one test try, quite random or I moved too fast between screens. One of address field was not masked (street), but in next test rounds it was. I checked that property MASK is set there correctly in our code.
Not working street address (version with fix): https://fsty.io/v/SX5MEabG
Working street address (same fixed version): https://fsty.io/v/hXTaVbpS
I guess its just not super stable feature for native mobile like on web
LukasMod commentedon Apr 8, 2026
@dylanexpensify Could you assign another reviewer to unblock this one? #86414
mkhutornyi commentedon Apr 8, 2026
I can review
4 remaining items
[-]iOS FullStory redaction is too aggressive (regression)[/-][+][Due for payment 2026-04-20] iOS FullStory redaction is too aggressive (regression)[/+]melvin-bot commentedon Apr 13, 2026
Reviewinglabel has been removed, please complete the "BugZero Checklist".melvin-bot commentedon Apr 13, 2026
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.3.58-9 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2026-04-20. 🎊
For reference, here are some details about the assignees on this issue:
LukasMod commentedon Apr 16, 2026
Looks fine, example session where self dm is hidden and onboarding is visible: https://fsty.io/v/eLGpAbsN
melvin-bot commentedon Apr 16, 2026
@fabioh8010 Whoops! This issue is 2 days overdue. Let's get this updated quick!
melvin-bot commentedon Apr 19, 2026
Triggered auto assignment to @mallenexpensify (
Awaiting Payment)mkhutornyi commentedon Apr 20, 2026
As performance issue, we can skip regression test.
melvin-bot commentedon Apr 20, 2026
Skipping the payment summary for this issue since all the assignees are employees or vendors. If this is incorrect, please manually add the payment summary SO.
mallenexpensify commentedon Apr 21, 2026
Payment Summary
Contributor+: @mkhutornyi due $250 via NewDot
trjExpensify commentedon May 6, 2026
approved $250 for @mkhutornyi