Repository navigation
[NoQA] fix: add default forwardedFSClass unmask in ScreenWrapperContainer - #86414
Conversation
|
@thesahindia Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
heyjennahay
left a comment
There was a problem hiding this comment.
Product review not required
|
I was asked to double check all tests scenarios, I will do it a bit later today |
|
Retested again, shared results here. I didn't find any difference regarding masking inputs/chats/composer. |
|
@thesahindia Hi, can I ask you to review this small PR? |
|
Sahil is OOO for 2 weeks. I can help if needed. |
|
Oh thanks, I'll go ahead and proceed review as 👍 was given to above comment. |
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppandroid.mp4Android: mWeb Chromemchrome.moviOS: HybridAppios.moviOS: mWeb Safarimsafari.mov |
@LukasMod web is recorded and shown on fullstory but not mobile. Am I missing anything? What I did is just return true here: App/src/libs/Fullstory/common.ts Line 67 in b42aaf7 |
|
@mkhutornyi I did the same thing, just return true there. Multiple manual page refresh and few minutes later its there: iOS example https://app.fullstory.com/ui/o-1WN56P-na1/segments/everyone/people:search:1G3opK6ziUl4/user/6771056667028830442?completeSessions=false |
|
@mkhutornyi Its seems like something already existing for some time https://expensify.sentry.io/issues/7296678181/?environment=production&project=4510228107427840&query=is%3Aunresolved%20capture&referrer=issue-stream&statsPeriod=90d Can you try again and check with android/ios native? |
|
Native platforms work fine. Just not appearing on fullstory dashboard. Let's not block on this. |
|
We did not find an internal engineer to review this PR, trying to assign a random engineer to #86103 as well as to this PR... Please reach out for help on Slack if no one gets assigned! |
|
🚧 @MonilBhavsar has triggered a test Expensify/App build. You can view the workflow run here. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🚀 Deployed to staging by https://github.com/MonilBhavsar in version: 9.3.58-0 🚀
Bundle Size Analysis (Sentry): |
|
No help site changes are required for this PR. This PR makes a single-line change to set a default FullStory masking class ( |
|
🚀 Deployed to production by https://github.com/AndrewGable in version: 9.3.58-9 🚀
|
|
🚀 Deployed to production by https://github.com/AndrewGable in version: 9.3.58-9 🚀
|


Explanation of Change
Fixed Issues
$ #86103
PROPOSAL:
Tests
What’s expected to be masked in Fullstory sessions
Self DMs
DMs, Groups and Rooms which Concierge is not a member of
Bank account flows, Fields related to sensitive or personal data
Wallet flows, Fields related to sensitive or personal data
Payment card flows, Fields related to sensitive or personal data
Composer, Self DMs, DMs, Groups and Rooms which Concierge is not a member of
Two-factor authentication codes
LHN chat previews of the masked chats
Verify that no errors appear in the JS console
Offline tests
QA Steps
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectioncanBeMissingparam foruseOnyxtoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
https://app.fullstory.com/ui/o-1WN56P-na1/session/1969698075856184818:8947218487723865843!4431239268733487529
Android: mWeb Chrome
iOS: Native
https://app.fullstory.com/ui/o-1WN56P-na1/session/1969698075856184818:5287275656602069721!2502516871995116593
iOS: mWeb Safari
onboarding
https://app.fullstory.com/ui/o-1WN56P-na1/session/6687072203223665583:6687072203223665583!147318032165518976
rest
https://app.fullstory.com/ui/o-1WN56P-na1/session/2546930961932620947:4245928092708236771!979910399309336126
MacOS: Chrome / Safari
(same as before)
https://app.fullstory.com/ui/o-1WN56P-na1/session/2546930961932620947:2546930961932620947!5677128412528478245