You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[Due for payment 2026-05-13] [$250] Reports - "No results found" opens when month list is opened #87452
Version Number: 9.3.55-0 Reproducible in staging?: Yes Reproducible in production?: N/A - new feature, doesn't exist in prod If this was caught during regression testing, add the test name, ID and link from BrowserStack:#85107 Email or phone of affected tester (no customers):jsiodjniodsnjiosdnjdsoj@gmail.com Issue reported by: Applause Internal Team Bug source: Exploratory - Significant User Experience Deterioration Device used: Mac 26.2 / Chrome App Component: Search
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
Identify the pull request that introduced this issue and revert it.
The new MonthPickerModal introduced in #85107 uses DateUtils.getFilteredMonthItems() to build the month list. This function filters out any month where the month's start is after maxDate or the month's end is before minDate.
In the Search custom date range picker (RangeDatePicker.tsx), the From calendar's maxDate is set to the selected To date. When the user selects a To date in 2025 but the calendar is currently viewing 2026 (the current year), every month in 2026 falls after the maxDate — so getFilteredMonthItems returns an empty array, and the modal shows "No results found".
The bug is in src/libs/DateUtils.ts — getFilteredMonthItems(): it completely removes months outside the min/max range instead of just marking them disabled or ensuring the viewed year is clamped to the valid range.
What changes do you think we should make in order to solve the problem?
In MonthPickerModal.tsx, clamp the currentYear to the valid range before passing it to getFilteredMonthItems. If maxDate is defined and currentYear > maxDate.getFullYear(), use maxDate.getFullYear() instead. Similarly, if minDate is defined and currentYear < minDate.getFullYear(), use minDate.getFullYear(). This ensures the month list is always generated for a year that has valid months, regardless of what year the calendar happens to be viewing.
What alternative solutions did you explore?
An alternative would be to modify getFilteredMonthItems to always show all 12 months but mark out-of-range ones as disabled (non-selectable) rather than filtering them out entirely. This would avoid the empty-list problem but would change the UX to show greyed-out months. The clamping approach is simpler and keeps the existing filtering behavior intact.
Next Steps for Contributor+ team: Reply with @MelvinBot implement this to create a draft PR, @MelvinBot <your feedback> to refine this analysis, or explain why you are rejecting Melvin's proposal.
Investigation Summary: Frontend bug. Causing PR: #85107 (New datepicker layout by @mukhrr, High confidence). Recommendation: REVERT. PR 85107 introduced MonthPickerModal and getFilteredMonthItems in DateUtils.ts. The month picker showing No results found is a direct regression. When the To date is in 2025 and the From calendar displays year 2026 (today), getFilteredMonthItems returns an empty list because all 2026 months exceed the 2025 maxDate. Both MonthPickerModal and getFilteredMonthItems are new code from this PR. Assigned: @mukhrr (author), @Ollyws and @cead22 (approving reviewers). DeployBlockerCash kept. DeployBlocker to be removed (no backend cause).
1a. Result of the original design (eg. a case wasn't considered)
1b. Mistake during implementation
1c. Backend bug
1z. Other:
Where bug was reported:
2a. Reported on production
2b. Reported on staging (deploy blocker)
2c. Reported on both staging and production
2d. Reported on a PR
2z. Other:
Who reported the bug:
3a. Expensify user
3b. Expensify employee
3c. Contributor
3d. QA
3z. Other:
[Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.
Link to comment: N/A
[Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.
Link to discussion:
[Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.
Regression Test Proposal Template
[BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.
The fix for this issue (#88119) caused #102227. It moved every date picker's year list and arrows to the fixed ±100-year range instead of only the Search custom range, so date of birth and incorporation date listed years outside their limits. Fixed in #103246.
Activity
melvin-bot commentedon Apr 9, 2026
You have been assigned to this deploy blocker because you recently merged this PR: #85107
melvin-bot commentedon Apr 9, 2026
💬 A slack conversation has been started in #expensify-open-source
github-actions commentedon Apr 9, 2026
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
MelvinBot commentedon Apr 9, 2026
Proposal
What is the root cause of that problem?
The new
MonthPickerModalintroduced in #85107 usesDateUtils.getFilteredMonthItems()to build the month list. This function filters out any month where the month's start is aftermaxDateor the month's end is beforeminDate.In the Search custom date range picker (
RangeDatePicker.tsx), the From calendar'smaxDateis set to the selected To date. When the user selects a To date in 2025 but the calendar is currently viewing 2026 (the current year), every month in 2026 falls after the maxDate — sogetFilteredMonthItemsreturns an empty array, and the modal shows "No results found".The bug is in
src/libs/DateUtils.ts—getFilteredMonthItems(): it completely removes months outside the min/max range instead of just marking them disabled or ensuring the viewed year is clamped to the valid range.What changes do you think we should make in order to solve the problem?
In
MonthPickerModal.tsx, clamp thecurrentYearto the valid range before passing it togetFilteredMonthItems. IfmaxDateis defined andcurrentYear > maxDate.getFullYear(), usemaxDate.getFullYear()instead. Similarly, ifminDateis defined andcurrentYear < minDate.getFullYear(), useminDate.getFullYear(). This ensures the month list is always generated for a year that has valid months, regardless of what year the calendar happens to be viewing.What alternative solutions did you explore?
An alternative would be to modify
getFilteredMonthItemsto always show all 12 months but mark out-of-range ones as disabled (non-selectable) rather than filtering them out entirely. This would avoid the empty-list problem but would change the UX to show greyed-out months. The clamping approach is simpler and keeps the existing filtering behavior intact.Next Steps for Contributor+ team: Reply with
@MelvinBot implement thisto create a draft PR,@MelvinBot <your feedback>to refine this analysis, or explain why you are rejecting Melvin's proposal.OSBotify commentedon Apr 9, 2026
Investigation Summary: Frontend bug. Causing PR: #85107 (New datepicker layout by @mukhrr, High confidence). Recommendation: REVERT. PR 85107 introduced MonthPickerModal and getFilteredMonthItems in DateUtils.ts. The month picker showing No results found is a direct regression. When the To date is in 2025 and the From calendar displays year 2026 (today), getFilteredMonthItems returns an empty list because all 2026 months exceed the 2025 maxDate. Both MonthPickerModal and getFilteredMonthItems are new code from this PR. Assigned: @mukhrr (author), @Ollyws and @cead22 (approving reviewers). DeployBlockerCash kept. DeployBlocker to be removed (no backend cause).
46 remaining items
Ollyws commentedon May 13, 2026
BugZero Checklist:
Bug classification
Source of bug:
Where bug was reported:
Who reported the bug:
[Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.
Link to comment: N/A
[Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.
Link to discussion:
[Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.
[BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.
Link to issue: https://github.com/Expensify/Expensify/issues/637575
Regression Test Proposal
Precondition:
Test:
Do we agree 👍 or 👎
Zapier Logs
Run ID: 00040eee-2367-aa31-2bc4-53939bcd8a44melvin-bot commentedon May 13, 2026
Payment Summary
Upwork Job
BugZero Checklist (@mallenexpensify)
mallenexpensify commentedon May 15, 2026
Payment Summary
Contributor: @mukhrr paid $250 via Upwork
Contributor+: @Ollyws due $250 via NewDot
@mukhrr can you please accept the job below? Please reply here and tag me once you have.
https://www.upwork.com/jobs/~022055414248797642720
^ Test case created
mukhrr commentedon May 15, 2026
Accepted. Thanks
Ollyws commentedon May 18, 2026
Requested on ND.
mallenexpensify commentedon May 19, 2026
@mukhrr paid, summary updated above. Thx.
flaviadefaria commentedon May 20, 2026
$250 approved @Ollyws
TaduJR commentedon Oct 23, 2026
The fix for this issue (#88119) caused #102227. It moved every date picker's year list and arrows to the fixed ±100-year range instead of only the Search custom range, so date of birth and incorporation date listed years outside their limits. Fixed in #103246.