Skip to content

[Due for payment 2026-05-13] [$250] Reports - "No results found" opens when month list is opened #87452

Closed

Description

@mitarachim

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 9.3.55-0
Reproducible in staging?: Yes
Reproducible in production?: N/A - new feature, doesn't exist in prod
If this was caught during regression testing, add the test name, ID and link from BrowserStack: #85107
Email or phone of affected tester (no customers): jsiodjniodsnjiosdnjdsoj@gmail.com
Issue reported by: Applause Internal Team
Bug source: Exploratory - Significant User Experience Deterioration
Device used: Mac 26.2 / Chrome
App Component: Search

Action Performed:

  1. Go to staging.new.expensify.com
  2. Go to Reports > Expenses.
  3. Click Date quick filter.
  4. Click Custom range.
  5. Select any To date in 2025.
  6. Click on the month in From field.

Expected Result:

A list of months will appear in the list.

Actual Result:

The list with "No results found" opens.

Workaround:

Unknown

Platforms:

  • Android: App
  • Android: mWeb Chrome
  • iOS: App
  • iOS: mWeb Safari
  • iOS: mWeb Chrome
  • Windows: Chrome
  • MacOS: Chrome / Safari

Screenshots/Videos

Bug7125404_1775698994695.10.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~022044511911136687709
  • Upwork Job ID: 2044511911136687709
  • Last Price Increase: 2026-04-15
Issue OwnerCurrent Issue Owner: @mallenexpensify

Activity

  1. added
    DeployBlockerCashThis issue or pull request should block deployment
    BugSomething is broken. Auto assigns a BugZero manager.
    DeployBlockerIndicates it should block deploying the API
    on Apr 9, 2026
  2. melvin-bot commented on Apr 9, 2026

    @melvin-bot

    You have been assigned to this deploy blocker because you recently merged this PR: #85107

  3. melvin-bot commented on Apr 9, 2026

    @melvin-bot

    💬 A slack conversation has been started in #expensify-open-source

  4. github-actions commented on Apr 9, 2026

    @github-actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  5. MelvinBot commented on Apr 9, 2026

    @MelvinBot
    Contributor

    Proposal

    What is the root cause of that problem?

    The new MonthPickerModal introduced in #85107 uses DateUtils.getFilteredMonthItems() to build the month list. This function filters out any month where the month's start is after maxDate or the month's end is before minDate.

    In the Search custom date range picker (RangeDatePicker.tsx), the From calendar's maxDate is set to the selected To date. When the user selects a To date in 2025 but the calendar is currently viewing 2026 (the current year), every month in 2026 falls after the maxDate — so getFilteredMonthItems returns an empty array, and the modal shows "No results found".

    The bug is in src/libs/DateUtils.ts — getFilteredMonthItems(): it completely removes months outside the min/max range instead of just marking them disabled or ensuring the viewed year is clamped to the valid range.

    What changes do you think we should make in order to solve the problem?

    In MonthPickerModal.tsx, clamp the currentYear to the valid range before passing it to getFilteredMonthItems. If maxDate is defined and currentYear > maxDate.getFullYear(), use maxDate.getFullYear() instead. Similarly, if minDate is defined and currentYear < minDate.getFullYear(), use minDate.getFullYear(). This ensures the month list is always generated for a year that has valid months, regardless of what year the calendar happens to be viewing.

    What alternative solutions did you explore?

    An alternative would be to modify getFilteredMonthItems to always show all 12 months but mark out-of-range ones as disabled (non-selectable) rather than filtering them out entirely. This would avoid the empty-list problem but would change the UX to show greyed-out months. The clamping approach is simpler and keeps the existing filtering behavior intact.


    Next Steps for Contributor+ team: Reply with @MelvinBot implement this to create a draft PR, @MelvinBot <your feedback> to refine this analysis, or explain why you are rejecting Melvin's proposal.

  6. OSBotify commented on Apr 9, 2026

    @OSBotify
    Contributor

    Investigation Summary: Frontend bug. Causing PR: #85107 (New datepicker layout by @mukhrr, High confidence). Recommendation: REVERT. PR 85107 introduced MonthPickerModal and getFilteredMonthItems in DateUtils.ts. The month picker showing No results found is a direct regression. When the To date is in 2025 and the From calendar displays year 2026 (today), getFilteredMonthItems returns an empty list because all 2026 months exceed the 2025 maxDate. Both MonthPickerModal and getFilteredMonthItems are new code from this PR. Assigned: @mukhrr (author), @Ollyws and @cead22 (approving reviewers). DeployBlockerCash kept. DeployBlocker to be removed (no backend cause).

  7. removed
    DeployBlockerIndicates it should block deploying the API
    on Apr 9, 2026
  8. 46 remaining items

  9. Ollyws commented on May 13, 2026

    @Ollyws
    Contributor

    BugZero Checklist:

    • [Contributor] Classify the bug:
    Bug classification

    Source of bug:

    • 1a. Result of the original design (eg. a case wasn't considered)
    • 1b. Mistake during implementation
    • 1c. Backend bug
    • 1z. Other:

    Where bug was reported:

    • 2a. Reported on production
    • 2b. Reported on staging (deploy blocker)
    • 2c. Reported on both staging and production
    • 2d. Reported on a PR
    • 2z. Other:

    Who reported the bug:

    • 3a. Expensify user
    • 3b. Expensify employee
    • 3c. Contributor
    • 3d. QA
    • 3z. Other:
    • [Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.

      Link to comment: N/A

    • [Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.

      Link to discussion:

    • [Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.

    Regression Test Proposal Template

    Regression Test Proposal

    Precondition:

    Test:

    1. Go to Reports > Expenses.
    2. Click Date quick filter.
    3. Click Custom range.
    4. Select any To date in 2025.
    5. Click on the month in From field.
    6. Verify you see months in list
    7. Go to 100 years ago and 100 years after from today
    8. Verify you cannot go to the 101th year. Navigations are disabled

    Do we agree 👍 or 👎

    Zapier Logs Run ID: 00040eee-2367-aa31-2bc4-53939bcd8a44
  10. melvin-bot commented on May 13, 2026

    @melvin-bot

    Payment Summary

    Upwork Job

    • Reviewer: @Ollyws owed $250 via NewDot
    • ROLE: @mukhrr paid $(AMOUNT) via Upwork (LINK)

    BugZero Checklist (@mallenexpensify)

    • (if NewFeature) I have created a PR for any necessary HelpDot updates, or I confirmed no updates are necessary.
    • I have verified the correct assignees and roles are listed above and updated the necessary manual offers
    • I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants/2044511911136687709/hired)
    • I have verified the PR was not reverted
    • I have applied any discounts due to bugs/regressions introduced by this PR
    • I have paid out the Upwork contracts or cancelled the ones that are incorrect
    • I have verified the payment summary above is correct
  11. mallenexpensify commented on May 15, 2026

    @mallenexpensify
    Contributor

    Payment Summary

    Contributor: @mukhrr paid $250 via Upwork
    Contributor+: @Ollyws due $250 via NewDot

    @mukhrr can you please accept the job below? Please reply here and tag me once you have.
    https://www.upwork.com/jobs/~022055414248797642720

    ^ Test case created

  12. mukhrr commented on May 15, 2026

    @mukhrr
    Contributor

    can you please accept the job below? Please reply here and tag me once you have.
    https://www.upwork.com/jobs/~022055414

    Accepted. Thanks

  13. Ollyws commented on May 18, 2026

    @Ollyws
    Contributor

    Requested on ND.

  14. mallenexpensify commented on May 19, 2026

    @mallenexpensify
    Contributor

    @mukhrr paid, summary updated above. Thx.

  15. flaviadefaria commented on May 20, 2026

    @flaviadefaria
    Contributor

    $250 approved @Ollyws

  16. TaduJR commented on Oct 23, 2026

    @TaduJR
    Contributor

    The fix for this issue (#88119) caused #102227. It moved every date picker's year list and arrows to the fixed ±100-year range instead of only the Search custom range, so date of birth and incorporation date listed years outside their limits. Fixed in #103246.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2EngineeringExternalAdded to denote the issue can be worked on by a contributor

Type

No type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions