Skip to content

Limit calendar year and month navigation to minDate and maxDate - #103246

Merged
luacmartins merged 9 commits into
mainfrom
claude-calendarYearsFollowMinMaxDate
Oct 13, 2026
Merged

luacmartins merged 9 commits into
mainfrom
claude-calendarYearsFollowMinMaxDate

Conversation

@MelvinBot

@MelvinBot MelvinBot commented Oct 6, 2026 •

Copy link
Copy Markdown
Contributor

Explanation of Change

The calendar built its year list from a fixed range, the current year ±100 (1926 to 2126), and ignored each picker's minDate and maxDate. The month and year arrows used the same range, so only the days followed the limits. As a result, date of birth listed years up to 2126 but couldn't reach birth years before 1926, and incorporation date listed years far in the future.

Now minDate and maxDate limit the whole calendar:

  • The year list runs from the year of minDate to the year of maxDate.
  • The arrows stop at the months of minDate and maxDate.
  • In the first and last year, months outside the limits are greyed out.
  • The month and year buttons are disabled when there is only one option.

Search date pickers keep free navigation from 1926 to 2126, as #87452 needs: in the custom range, each calendar's limit is the date picked in the other one. They limit only which days can be picked, through a new isDateSelectable prop. Schedule a call now uses that prop too, in place of selectableDates.

Also in this PR:

  • In the custom range, picking one end first moves the other, empty calendar to that month. Before, it stayed on a month where every day could be disabled.
  • An empty date field opens the calendar with no day selected. Before, today showed as selected.
  • CalendarPicker now takes and returns Date values. Callers read stored dates with the new DateUtils.parseCalendarDate, which replaces the copies in RangeDatePicker and ChronosUtils, and still save them as yyyy-MM-dd.

Year lists before and after, as of October 2026:

Picker Before After
Date of birth 1926–2126 1876–2008
Incorporation date 1926–2126 1926–2026
Report field date 1926–2126 2006–2027
Expense date 1926–2126 1926–2027
Expensify Card start and expiration dates 1926–2126 2026–2027
Custom status date 1926–2126 2026–2126
Search date filters 1926–2126 1926–2126 (unchanged)

Fixed Issues

$ #102227
PROPOSAL: #102227 (comment)

Tests

Years assume testing in 2026 (add 1 in 2027). "Greyed out" means shown but can't be picked.

Test 1: Date of birth (use an account with no date of birth saved)

  1. Go to Account > Profile > Private > Date of birth and tap the Date field.
  2. Verify the calendar opens on this month of 2008 with no day selected, and the next-month and next-year arrows are disabled.
  3. Tap the year. Search 2009 and verify "No results found". Search 1876 and pick it.
  4. Verify the previous-month and previous-year arrows are disabled. Tap the month and verify the months before this month are greyed out.

Test 2: Expense date

  1. Tap + > Create expense > Manual and tap the Date field. Verify today is selected.
  2. Tap the year. Verify 1926 and 2027 are listed, and 1925 and 2028 show "No results found".
  3. Pick 2027 and verify the next-month and next-year arrows are disabled.

Test 3: Custom status date

  1. Go to Account > Profile > Status > Clear after > Custom > Date and tap the Date field.
  2. On this month, verify the previous-month and previous-year arrows are disabled.
  3. Tap the year. Verify 2025 shows "No results found" and 2126 is listed.

Test 4: Search single date

  1. Go to Spend > Expenses > Filters > Date > Custom date. Tap the year and verify 1926 and 2126 are both listed.
  2. Pick 2100. Verify every day is greyed out and the month list has all 12 months enabled.

Test 5: Search custom range

  1. Go to Spend > Expenses > Filters > Date > Custom range.
  2. In To, tap the year, pick 2020, then pick the 15th. Verify From moves to the same month and year.
  3. In From, verify the days after the 15th are greyed out and the month list has all 12 months enabled.
  4. In From, press the next-year arrow (it moves to 2021), then the previous-year arrow to come back.
  5. In From, pick the 10th and press the next-month arrow. Then pick the 20th in To. Verify From stays on the month you moved to.
  6. Tap Apply (on mobile, then Confirm and Apply filters). Verify the Date filter shows "Oct 10, 2020 - Oct 20, 2020".
  7. Tap Reset.

Test 6: Keyboard (web, desktop width)

  1. Go to Spend > Expenses > Filters > Date and pick This month. Close the Filters panel, click the "Date: This month" filter, then Custom range.
  2. Press Tab until a day in From is focused, then press Enter.
  3. Verify the day is selected and focus stays on it: the next Tab moves to the next day.
  4. Tap Reset.

Test 7: Empty scanned date

  1. Tap + > Create expense > Scan, upload a receipt, then tap Show more.
  2. Verify Date is empty and shows "Automatic". Tap it and verify this month opens with no day selected.

Test 8: Incorporation date (needs a USD workspace)

  1. Go to Workspaces > [workspace] > Workflows > Payments > Add bank account and continue to "What's your company's incorporation date?".
  2. Tap the field, then the year. Verify 2026 is the latest year.
  • Verify that no errors appear in the JS console

Offline tests

Same as tests

QA Steps

Same as tests

  • Verify that no errors appear in the JS console

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I followed proper code patterns (see Reviewing the code)
    • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I followed the guidelines as stated in the Review Guidelines
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • If any new file was added I verified that:
    • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
  • If new assets were added or existing ones were modified, I verified that:
    • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
    • The assets load correctly across all supported platforms.
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native
Android-Native.mp4
Android: mWeb Chrome
Android-mWeb.mp4
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari

Fixed-range date pickers such as date of birth and incorporation date now list only the years between minDate and maxDate, and the arrows and month list stop at those limits. Search date pickers keep free navigation and limit selectable days through a new isDateSelectable rule. Adds DateUtils.parseCalendarDate and DateUtils.isWithinCalendarPickerRange.

Co-authored-by: TaduJR <TaduJR@users.noreply.github.com>
@MelvinBot
MelvinBot requested a review from a team October 6, 2026 21:48
@melvin-bot

melvin-bot Bot commented Oct 6, 2026

Copy link
Copy Markdown

Hey! I see that you made changes to our Form component. Make sure to update the docs in FORMS.md accordingly. Cheers!

@melvin-bot melvin-bot Bot added Melvin-Test-Android Melvin-Test-Web Triggers Melvin to run the testing steps of the PR on web labels Oct 6, 2026
@MelvinBot

Copy link
Copy Markdown
Contributor Author

I created this PR from an upstream branch since I don't have push access to your fork.

To take ownership of this branch and be able to push updates, run:

git remote add upstream https://github.com/Expensify/App.git
git fetch upstream claude-calendarYearsFollowMinMaxDate
git checkout -b claude-calendarYearsFollowMinMaxDate upstream/claude-calendarYearsFollowMinMaxDate
git push -u origin claude-calendarYearsFollowMinMaxDate

Then you can close this PR and open a new one from your fork.

@MelvinBot

MelvinBot commented Oct 6, 2026 •

Copy link
Copy Markdown
Contributor Author

🤖 Android test steps verification results: ⚠️ partial

The PR's Tests section is still empty, so I ran the issue's reproduction steps plus the expected results from the PR description. The Date of birth picker now limits years, months, and days to 1876–2008, and steps 1–5 passed. I couldn't confirm the save in step 6 because saving Private details opens a required email security-code screen that the test account can't get past. This blocker is not related to the PR.

Security code screen blocking save

Step Status
Open Settings > Profile > Private > Date of birth calendar picker; opens without errorsTapping 'Date of birth' opened a 'Personal details' screen with a Date field; tapping it opened a calendar defaulting to October 2008 (today minus 18 years) with no error banners.
Calendar picker opened at October 2008
✅
Year field's latest year is 2008; no future years appearThe year list's top entry is 2008 (selected), descending to 2007, 2006, and so on. No year after 2008 appears.
Year list top showing 2008
✅
Scrolling the year list to its earliest end reaches 1876The bottom of the year list ends at 1876. No earlier year is reachable.
Year list bottom showing 1876
✅
With year 2008 selected, months/days after October 2008 are disabled and forward navigation is blocked'Next month' and 'Next year' are disabled. October 7–31, 2008 are disabled and October 1–6 are enabled. In the month list, November and December are disabled, October is selected, and January–September are enabled.
Calendar picker opened at October 2008
Month list 2008 with November and December disabled
✅
With year 1876 selected, back arrow cannot go before min month and earlier months are disabled'Previous month' and 'Previous year' are disabled. October 1–5, 1876 are disabled (October 6, 1876 is the minimum date) and October 6–31 are enabled. In the month list, January–September are disabled, October is selected, and November and December are enabled.
Month list 1876 with January to September disabled
✅
Pick a valid date (15 March 1990) and save; Date of birth field shows the chosen dateAfter picking 1990, March, and 15, the field showed 1990-03-15. This build's Date of birth screen is a combined Personal details form, so the tester also filled in legal name, phone, and address. Tapping Save opened a required "Let's make sure it's you" email security-code screen. The test account can't get past that screen, so the saved date on the Profile page could not be checked. The blocker is not related to the CalendarPicker change.
Date field showing 1990-03-15
Security code screen blocking save
⚠️

view run · view recording

@codecov

codecov Bot commented Oct 6, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.

Files with missing lines Coverage Δ
...nts/DatePicker/CalendarPicker/MonthPickerModal.tsx 100.00% <100.00%> (+3.84%) ⬆️
...ents/DatePicker/CalendarPicker/YearPickerModal.tsx 100.00% <100.00%> (ø)
src/components/DatePicker/CalendarPicker/index.tsx 96.63% <100.00%> (-0.03%) ⬇️
src/components/DatePicker/index.tsx 63.55% <ø> (+11.33%) ⬆️
...s/Search/FilterComponents/DatePresetFilterBase.tsx 70.62% <100.00%> (+0.20%) ⬆️
...onents/Search/FilterComponents/RangeDatePicker.tsx 100.00% <100.00%> (+100.00%) ⬆️
...components/Search/SearchList/ListItem/DateCell.tsx 85.00% <ø> (ø)
src/libs/ChronosUtils.ts 98.52% <100.00%> (-0.11%) ⬇️
src/libs/DateUtils.ts 79.83% <100.00%> (+0.38%) ⬆️
src/components/DatePicker/DatePickerModal.tsx 96.00% <80.00%> (-4.00%) ⬇️
... and 2 more
... and 14 files with indirect coverage changes

@MelvinBot

MelvinBot commented Oct 6, 2026 •

Copy link
Copy Markdown
Contributor Author

🤖 Web test steps verification results: ❌ fail

The test browser couldn't sign in to the dev web app, so none of the calendar picker steps ran. The sign-in "Continue" button did nothing: the screen didn't change and no sign-in request was sent. This is a test environment problem, not a sign of a bug in this PR. The PR's Tests section is still empty, so I planned to run the issue's reproduction steps and the expected results from the PR description, plus one Search date filter regression check.

Stuck on sign-in screen after Continue tap

Step Status
Settings > Profile > Private > Date of birth calendar picker opens without errorsBlocked: could not sign in to reach Settings.
Stuck on sign-in screen after Continue tap
❌
Year list latest year is 2008, no future years (2026/2126)Blocked: not signed in.
❌
Year list earliest year is 1876Blocked: not signed in.
❌
Year 2008 selected: months after Oct 2008 disabled, days after max date disabled, next month/year arrows disabledBlocked: not signed in.
❌
Year 1876 selected: months before Oct 1876 disabled, days before min date disabled, previous month/year arrows disabledBlocked: not signed in.
❌
Pick 15 March 1990, save, Date of birth field reflects itBlocked: not signed in.
❌
Regression: Search Date filter (On/After/Before) calendar year list still spans ~1926–2126 and day selection worksBlocked: not signed in.
❌

view run · view recording

@TaduJR

TaduJR commented Oct 10, 2026

Copy link
Copy Markdown
Contributor

@MelvinBot Please merge main

Co-authored-by: TaduJR <TaduJR@users.noreply.github.com>
@MelvinBot

Copy link
Copy Markdown
Contributor Author

I merged main into this branch and pushed the merge commit (1dc668be84d).

The merge had no conflicts. DateUtils.ts, DatePresetFilterBase.tsx, and DateUtilsTest.ts merged automatically. I couldn't run the tests locally, so please check CI.

@TaduJR

TaduJR commented Oct 10, 2026

Copy link
Copy Markdown
Contributor

@MelvinBot please make the PR ready for review

@MelvinBot
MelvinBot marked this pull request as ready for review October 10, 2026 14:35
@MelvinBot
MelvinBot requested a review from a team as a code owner October 10, 2026 14:35
@MelvinBot

Copy link
Copy Markdown
Contributor Author

I marked this PR as ready for review.

@melvin-bot
melvin-bot Bot requested review from TaduJR and joekaufmanexpensify and removed request for a team October 10, 2026 14:35
@melvin-bot

melvin-bot Bot commented Oct 10, 2026

Copy link
Copy Markdown

@TaduJR Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@melvin-bot
melvin-bot Bot removed the request for review from a team October 10, 2026 14:35
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 10, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-12T10:33:40.223359Z 8ae8d6d Manual request
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@TaduJR

TaduJR commented Oct 10, 2026

Copy link
Copy Markdown
Contributor

@MelvinBot Please address the above bot comments and mark them as resolved after resolving

…tences

Co-authored-by: TaduJR <TaduJR@users.noreply.github.com>
@MelvinBot
MelvinBot requested a review from a team as a code owner October 10, 2026 14:46
@melvin-bot
melvin-bot Bot requested a review from luacmartins October 10, 2026 14:46
@TaduJR

TaduJR commented Oct 12, 2026 •

Copy link
Copy Markdown
Contributor

Reviewer Checklist

  • I have verified the author checklist is complete (all boxes are checked off).
  • I verified the correct issue is linked in the ### Fixed Issues section above
  • I verified testing steps are clear and they cover the changes made in this PR
    • I verified the steps for local testing are in the Tests section
    • I verified the steps for Staging and/or Production testing are in the QA steps section
    • I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • I checked that screenshots or videos are included for tests on all platforms
  • I included screenshots or videos for tests on all platforms
  • I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
  • I verified tests pass on all platforms & I tested again on:
    • Android: HybridApp
    • Android: mWeb Chrome
    • iOS: HybridApp
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
  • I verified proper code patterns were followed (see Reviewing the code)
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I verified that this PR follows the guidelines as stated in the Review Guidelines
  • I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
  • If a new component is created I verified that:
    • A similar component doesn't exist in the codebase
    • All props are defined accurately
    • The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
    • The only data being stored in the state is data necessary for rendering and nothing else
    • The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • If the PR adds or modifies the UI:
    • I asked an AI agent to review the changes for accessibility issues and addressed its findings.
    • I tested with a screen reader (VoiceOver on macOS) and verified all new/changed elements are reachable with a logical focus order.
    • I verified all new/changed elements have meaningful accessible names and roles.
    • I verified state changes are announced (e.g. checked/unchecked, expanded/collapsed, selected).
  • For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
  • I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp
Android-Native.mp4
Android: mWeb Chrome
Android-mWeb.mp4
iOS: HybridApp
iOS: mWeb Safari
MacOS: Chrome / Safari
Mac-Chrome.mp4

@MelvinBot

Copy link
Copy Markdown
Contributor Author

I replaced the steps in the Tests section of the PR description with your Tests 1–8. The rest of the description is unchanged.

Two notes:

  • I left out the QA dropdown and the extra ### Tests heading, since the steps already sit under the section's own heading.
  • I removed the old intro line that said the years assume 2026 testing and explained "greyed out." Let me know if you want it back.

@TaduJR

TaduJR commented Oct 12, 2026

Copy link
Copy Markdown
Contributor

@MelvinBot Please make two changes to the PR description:

Changes: 1. Under "Year lists before and after, as of October 2026:", add this table:
Picker Before After
Date of birth 1926–2126 1876–2008
Incorporation date 1926–2126 1926–2026
Report field date 1926–2126 2006–2027
Expense date 1926–2126 1926–2027
Expensify Card start and expiration dates 1926–2126 2026–2027
Custom status date 1926–2126 2026–2126
Search date filters 1926–2126 1926–2126 (unchanged)
  1. In the Tests section, add this line right before Test 1:

Years assume testing in 2026 (add 1 in 2027). "Greyed out" means shown but can't be picked.

@MelvinBot

Copy link
Copy Markdown
Contributor Author

I updated the PR description with both changes:

  1. Added the before-and-after year table under "Year lists before and after, as of October 2026:".
  2. Added the testing-year and "Greyed out" note in the Tests section, right before Test 1.

I left the rest of the description unchanged.

@TaduJR TaduJR left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@TaduJR

TaduJR commented Oct 12, 2026

Copy link
Copy Markdown
Contributor

cc @joekaufmanexpensify for product

@joekaufmanexpensify

Copy link
Copy Markdown
Contributor

Is there a specific reason to stop expense picker, expensify card start/end date, and report field date at 2027? Not necessarily opposed to that, but would like to understand more about where the logic came from

@TaduJR

TaduJR commented Oct 12, 2026

Copy link
Copy Markdown
Contributor

@joekaufmanexpensify

This PR doesn't add those limits. They were already there: the expense date, report field date and Expensify Card date pickers all pass maxDate={CONST.CALENDAR_PICKER.MAX_DATE}, which is today plus one year. On staging the year list goes up to 2126, but every day after October 2027 is greyed out, so those years can't be used. This PR only stops the list at the last year where you can actually pick a day. Any date you could pick before, you can still pick.

Screenshot 2026-10-12 at 5 54 40 PM

@joekaufmanexpensify joekaufmanexpensify left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good for product

@TaduJR

TaduJR commented Oct 12, 2026

Copy link
Copy Markdown
Contributor

All yours @luacmartins

@TaduJR

TaduJR commented Oct 13, 2026

Copy link
Copy Markdown
Contributor

@MelvinBot

Please resolve conflicts and merge main.

Co-authored-by: TaduJR <TaduJR@users.noreply.github.com>
@MelvinBot

Copy link
Copy Markdown
Contributor Author

I merged main into this branch, resolved the conflict, and pushed the merge commit (4efb06bdb9d).

The only conflict was in src/components/DatePicker/CalendarPicker/index.tsx. main moved the day grid into a calendarWeeks variable and now renders it in a View on small screens and an Animated.View otherwise. I kept that layout and moved this PR's day logic into calendarWeeks without changing it. That logic covers minDay/maxDay, isDateSelectable, an optional value, and onDayPressed(Date).

main didn't change any CalendarPicker callers. I couldn't run typecheck or tests locally, so please check CI.

@TaduJR

TaduJR commented Oct 13, 2026

Copy link
Copy Markdown
Contributor

@MelvinBot

Please merge main

Co-authored-by: TaduJR <TaduJR@users.noreply.github.com>
@MelvinBot

Copy link
Copy Markdown
Contributor Author

I merged the latest main into this branch and pushed the merge commit (5b1433539b1).

The merge had no conflicts. None of the files changed on main since the last merge overlap with this PR's changes.

@luacmartins luacmartins left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@luacmartins
luacmartins merged commit 2949902 into main Oct 13, 2026
42 of 43 checks passed
@luacmartins
luacmartins deleted the claude-calendarYearsFollowMinMaxDate branch October 13, 2026 16:35
@OSBotify

Copy link
Copy Markdown
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@github-actions

Copy link
Copy Markdown
Contributor

🚧 luacmartins has triggered a test Expensify/App build. You can view the workflow run here.

@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to staging by https://github.com/luacmartins in version: 9.5.9-0 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

@MelvinBot

Copy link
Copy Markdown
Contributor Author

No help site update needed. This PR limits the calendar's year list and arrows to the dates each field already allows, and no article in docs/articles describes calendar year ranges or navigation.

@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to production by https://github.com/cristipaval in version: 9.5.9-4 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

Bundle Size Analysis (Sentry):

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Melvin-Test-Android Melvin-Test-Web Triggers Melvin to run the testing steps of the PR on web

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants