You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Reports - Pressing Enter does not save the filter when editing from quick filter #88039
Version Number: 9.3.60-0 Reproducible in staging?: Yes Reproducible in production?: N/A - new feature, doesn't exist in prod If this was caught during regression testing, add the test name, ID and link from BrowserStack:#86297 Email or phone of affected tester (no customers):soidnjsoidjoisjdiosj@gmail.com Issue reported by: Applause Internal Team Bug source: Exploratory - Significant User Experience Deterioration Device used: Mac 26.2 / Chrome App Component: Search
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
Identify the pull request that introduced this issue and revert it.
The quick filter's AmountInput component in AmountPopup.tsx renders AmountWithoutCurrencyInput directly inside a BasePopup — which is just a plain View with Apply/Reset buttons. There is no FormProvider wrapper and no onSubmitEditing handler on the input, so pressing Enter does nothing.
In contrast, the full-page filter (SearchFiltersAmountBase.tsx) wraps the same AmountWithoutCurrencyInput in a FormProvider, which automatically attaches onSubmitEditing to call submit() when Enter is pressed. The quick filter popup lacks this mechanism entirely.
What changes do you think we should make in order to solve the problem?
Add an onSubmitEditing prop to the AmountWithoutCurrencyInput in the AmountInput subcomponent of AmountPopup.tsx that calls onSave(amount) — the same callback triggered by clicking the Apply button. This makes Enter behave identically to clicking Apply.
What alternative solutions did you explore? (Optional)
An alternative would be to enhance BasePopup to globally capture Enter key presses and trigger onApply. However, this would be a broader change affecting all popup types and could introduce unintended side effects in popups where Enter should not auto-submit (e.g., multi-field popups). The targeted fix on the specific input is safer and more consistent with how the full-page filter handles it.
Next Steps for Contributor+ team: Reply with @MelvinBot implement this to create a draft PR, @MelvinBot <your feedback> to refine this analysis, or explain why you are rejecting Melvin's proposal.
Classification: Frontend bug
Causing PR: #86297 - "[Wiring the UI] Revamp search page actions bar" by @bernhardoj (High confidence), built on top of #86906 - "[No QA] Create new filter popups" by @bernhardoj
Related Issues: N/A
Recommendation: ROLL FORWARD
The AmountInput sub-component inside AmountPopup.tsx is missing an onSubmitEditing prop wired to the save callback. A targeted fix adding onSubmitEditing to the AmountWithoutCurrencyInput in AmountPopup.tsx is simpler than reverting two interdependent PRs.
Assigned: @bernhardoj (PR author), @JS00001, @aimane-chnaif, @luacmartins (approving reviewers)
Labels: No label changes needed - DeployBlockerCash is correctly applied (this is a staging-only frontend bug in a new feature).
Evidence:
The bug is staging-only and does not exist in production - confirmed by the reporter (N/A - new feature, does not exist in prod).
PR 86297 (merged April 15) introduced the new inline search filter chips (quick filters), which uses popup components from src/components/Search/FilterDropdowns/.
PR 86906 (merged April 9) created the AmountPopup.tsx file and the rest of the FilterDropdowns components. It was a prerequisite for PR 86297.
Both PRs are authored by @bernhardoj and approved by the same reviewers.
The AmountInput sub-component (lines 29-56) renders an AmountWithoutCurrencyInput with no onSubmitEditing handler. Without this, pressing Enter on the web does not trigger the onSave callback.
By contrast, the legacy SearchFiltersAmountBase.tsx wraps the same AmountWithoutCurrencyInput inside a FormProvider, which automatically handles Enter key submission via its onSubmit handler. The new popup bypasses FormProvider and so loses this behavior.
useSearchFiltersBar.tsx confirms AmountPopup is imported and rendered as the inline quick-filter chip for the Amount filter.
PR 86297 is present in the StagingDeployCash checklist, confirming it is part of this staging release.
Root Cause:
In AmountPopup.tsx, the AmountInput sub-component renders AmountWithoutCurrencyInput but does not pass an onSubmitEditing prop pointing to the onSave function. On web/desktop, the browser fires a submit event when Enter is pressed in a text input, but this event only triggers something if onSubmitEditing is wired up. The fix is to add onSubmitEditing={() => onSave(amount)} to the AmountWithoutCurrencyInput usage inside AmountInput.
The quick filteru0027s AmountInput component in AmountPopup.tsx renders AmountWithoutCurrencyInput. When the user types a value and presses Enter, the onSubmit handler is not properly wired to trigger the filter save action. The component needs to call the parent handleru0027s save function on Enter key press.
What is the fix?
In src/components/Search/FilterDropdowns/AmountPopup.tsx, ensure the AmountWithoutCurrencyInput componentu0027s onSubmit prop is connected to the parent onApply handler. Add a onSubmitEditing handler that calls the same function as the Apply button.
📣 @ypeng1620-beep! 📣
Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
Please follow these steps:
Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.
Format:
Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>
Do we want to update it so the filter is applied by pressing Enter?
As we don't support it already, enter just focuses or blurs the text input, I'm fine with just leaving this as it is. We can iterate if we get real feedback about it. 👍
Activity
melvin-bot commentedon Apr 16, 2026
Triggered auto assignment to @cead22 (
DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.melvin-bot commentedon Apr 16, 2026
💬 A slack conversation has been started in #expensify-open-source
github-actions commentedon Apr 16, 2026
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
MelvinBot commentedon Apr 16, 2026
Proposal
What is the root cause of that problem?
The quick filter's
AmountInputcomponent inAmountPopup.tsxrendersAmountWithoutCurrencyInputdirectly inside aBasePopup— which is just a plainViewwith Apply/Reset buttons. There is noFormProviderwrapper and noonSubmitEditinghandler on the input, so pressing Enter does nothing.In contrast, the full-page filter (
SearchFiltersAmountBase.tsx) wraps the sameAmountWithoutCurrencyInputin aFormProvider, which automatically attachesonSubmitEditingto callsubmit()when Enter is pressed. The quick filter popup lacks this mechanism entirely.What changes do you think we should make in order to solve the problem?
Add an
onSubmitEditingprop to theAmountWithoutCurrencyInputin theAmountInputsubcomponent ofAmountPopup.tsxthat callsonSave(amount)— the same callback triggered by clicking the Apply button. This makes Enter behave identically to clicking Apply.What alternative solutions did you explore? (Optional)
An alternative would be to enhance
BasePopupto globally capture Enter key presses and triggeronApply. However, this would be a broader change affecting all popup types and could introduce unintended side effects in popups where Enter should not auto-submit (e.g., multi-field popups). The targeted fix on the specific input is safer and more consistent with how the full-page filter handles it.Next Steps for Contributor+ team: Reply with
@MelvinBot implement thisto create a draft PR,@MelvinBot <your feedback>to refine this analysis, or explain why you are rejecting Melvin's proposal.OSBotify commentedon Apr 16, 2026
Investigation Summary
Classification: Frontend bug
Causing PR: #86297 - "[Wiring the UI] Revamp search page actions bar" by @bernhardoj (High confidence), built on top of #86906 - "[No QA] Create new filter popups" by @bernhardoj
Related Issues: N/A
Recommendation: ROLL FORWARD
The AmountInput sub-component inside AmountPopup.tsx is missing an onSubmitEditing prop wired to the save callback. A targeted fix adding onSubmitEditing to the AmountWithoutCurrencyInput in AmountPopup.tsx is simpler than reverting two interdependent PRs.
Assigned: @bernhardoj (PR author), @JS00001, @aimane-chnaif, @luacmartins (approving reviewers)
Labels: No label changes needed - DeployBlockerCash is correctly applied (this is a staging-only frontend bug in a new feature).
Evidence:
Verification:
Root Cause:
In AmountPopup.tsx, the AmountInput sub-component renders AmountWithoutCurrencyInput but does not pass an onSubmitEditing prop pointing to the onSave function. On web/desktop, the browser fires a submit event when Enter is pressed in a text input, but this event only triggers something if onSubmitEditing is wired up. The fix is to add onSubmitEditing={() => onSave(amount)} to the AmountWithoutCurrencyInput usage inside AmountInput.
trjExpensify commentedon Apr 16, 2026
This is the same on production for all of the existing exposed quick filters, so not a blocker.
2026-04-16_10-17-52.mp4
(Just imagine me smashing the enter button on my keyboard).
bernhardoj commentedon Apr 16, 2026
Do we want to update it so the filter is applied by pressing Enter?
ypeng1620-beep commentedon Apr 16, 2026
Proposal
What is the root cause of that problem?
The quick filteru0027s
AmountInputcomponent inAmountPopup.tsxrendersAmountWithoutCurrencyInput. When the user types a value and presses Enter, theonSubmithandler is not properly wired to trigger the filter save action. The component needs to call the parent handleru0027s save function on Enter key press.What is the fix?
In
src/components/Search/FilterDropdowns/AmountPopup.tsx, ensure theAmountWithoutCurrencyInputcomponentu0027sonSubmitprop is connected to the parentonApplyhandler. Add aonSubmitEditinghandler that calls the same function as the Apply button.What testing is needed?
ypeng1620-beep commentedon Apr 16, 2026
Contributor details:
melvin-bot commentedon Apr 16, 2026
📣 @ypeng1620-beep! 📣
Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
Please follow these steps:
Format:
trjExpensify commentedon Apr 17, 2026
As we don't support it already, enter just focuses or blurs the text input, I'm fine with just leaving this as it is. We can iterate if we get real feedback about it. 👍
JS00001 commentedon Apr 20, 2026
Sounds like we're keeping the current behavior, closing
melvin-bot commentedon May 26, 2026
If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.
If a regression has occurred and you are the assigned CM follow the instructions here.
If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.