Skip to content

Nothing happens when user taps ENTER on keyboard in filters #91690

Closed

Description

@applause-bot

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 9.3.82-0
Reproducible in staging?: Yes
Reproducible in production?: No
If this was caught during regression testing, add the test name, ID and link from BrowserStack: #90029
Email or phone of affected tester (no customers): applausetester+en@applause.expensifail.com
Issue reported by: Applause Internal Team
Bug source: Exploratory - Significant User Experience Deterioration
Device used: Macbook Pro 2023 / Tahoe 26.4.1
App Component: Other

Action Performed:

  1. Access staging.new.expensify.com
  2. Sign into a beta account
  3. Go to Spend > Filter > merchant
  4. Type anything and hit the Enter key from native keyboard

Expected Result:

Filter should be applied as happens when you hit the confirm button

Actual Result:

Nothing happens when tapping Enter

Workaround:

Unknown

Platforms:

  • Android: App
  • Android: mWeb Chrome
  • iOS: App
  • iOS: mWeb Safari
  • iOS: mWeb Chrome
  • Windows: Chrome
  • MacOS: Chrome Safari

Screenshots/Videos

Bug7163126_1779764366469.Enter_key_does_not_work.mp4

View all open jobs on GitHub

Applause Internal Information
Exported by: Julia Ponikarchuk
Bug ID: 7163126

Activity

  1. added
    DeployBlockerCashThis issue or pull request should block deployment
    BugSomething is broken. Auto assigns a BugZero manager.
    on May 26, 2026
  2. applause-bot commented on May 26, 2026

    @applause-bot
    Author

    While Applause doesn't embed attachments for this bug, here are the links for quick view:
    https://platform.applause.com/services/links/v1/external/226e8ca073fc80171310ef64b205f85ed699cd49fa2e10d0dc9e51b1a80c8550

  3. melvin-bot commented on May 26, 2026

    @melvin-bot

    You have been assigned to this deploy blocker because you recently merged this PR: #90029

  4. melvin-bot commented on May 26, 2026

    @melvin-bot

    💬 A slack conversation has been started in #expensify-open-source

  5. github-actions commented on May 26, 2026

    @github-actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  6. MelvinBot commented on May 26, 2026

    @MelvinBot
    Contributor

    Proposal

    What is the root cause of that problem?

    PR #90029 replaced the old fullscreen filter pages with popover-based dropdowns. The old text filter pages (merchant, keyword, description, etc.) used FormProvider + InputWrapper, which automatically wired onSubmitEditing on single-line TextInputs to call submit() — giving Enter-to-apply for free (FormProvider.tsx:394-400).

    The new implementation renders plain TextInput components without FormProvider, so there is no onSubmitEditing handler — pressing Enter does nothing. This affects all text-input-based filters: merchant, description, report ID, keyword, title, and withdrawal ID.

    What changes do you think we should make in order to solve the problem?

    Two locations need onSubmitEditing wired up:

    1. TextInputFilterComponents — Add an onSubmitEditing prop to this component and pass it through to the TextInput. The parent TextInputFilterContent should pass a handler that calls onChange({[filterKey]: value}) (the same action the Confirm button triggers).

    2. TextInputPopup — Add onSubmitEditing={applyChanges} to the TextInput. The applyChanges function already exists at line 22 but is only connected to the Apply button.


    Next Steps for Contributor+ team: Reply with @MelvinBot implement this to create a draft PR, @MelvinBot <your feedback> to refine this analysis, or explain why you are rejecting Melvin's proposal.

  7. bernhardoj commented on May 26, 2026

    @bernhardoj
    Contributor

    Similar to #88039

    cc: @trjExpensify

  8. JS00001 commented on May 26, 2026

    @JS00001
    Contributor

    I think this should have the 'enter' behavior

  9. trjExpensify commented on May 26, 2026

    @trjExpensify
    Contributor

    Clicking Enter blurs the text input. Isn't that how it works already? Down to change it, but that was the understanding here, so NAB based on that.

  10. JS00001 commented on May 26, 2026

    @JS00001
    Contributor

    Fixed by CP, popup no longer exists. We can keep this one the same as prod in the follow up

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

BugSomething is broken. Auto assigns a BugZero manager.EngineeringHourlyKSv2

Type

No type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions