You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Nothing happens when user taps ENTER on keyboard in filters #91690
Version Number: 9.3.82-0 Reproducible in staging?: Yes Reproducible in production?: No If this was caught during regression testing, add the test name, ID and link from BrowserStack:#90029 Email or phone of affected tester (no customers):applausetester+en@applause.expensifail.com Issue reported by: Applause Internal Team Bug source: Exploratory - Significant User Experience Deterioration Device used: Macbook Pro 2023 / Tahoe 26.4.1 App Component: Other
Action Performed:
Access staging.new.expensify.com
Sign into a beta account
Go to Spend > Filter > merchant
Type anything and hit the Enter key from native keyboard
Expected Result:
Filter should be applied as happens when you hit the confirm button
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
Identify the pull request that introduced this issue and revert it.
PR #90029 replaced the old fullscreen filter pages with popover-based dropdowns. The old text filter pages (merchant, keyword, description, etc.) used FormProvider + InputWrapper, which automatically wired onSubmitEditing on single-line TextInputs to call submit() — giving Enter-to-apply for free (FormProvider.tsx:394-400).
The new implementation renders plain TextInput components without FormProvider, so there is no onSubmitEditing handler — pressing Enter does nothing. This affects all text-input-based filters: merchant, description, report ID, keyword, title, and withdrawal ID.
What changes do you think we should make in order to solve the problem?
Two locations need onSubmitEditing wired up:
TextInputFilterComponents — Add an onSubmitEditing prop to this component and pass it through to the TextInput. The parent TextInputFilterContent should pass a handler that calls onChange({[filterKey]: value}) (the same action the Confirm button triggers).
TextInputPopup — Add onSubmitEditing={applyChanges} to the TextInput. The applyChanges function already exists at line 22 but is only connected to the Apply button.
Next Steps for Contributor+ team: Reply with @MelvinBot implement this to create a draft PR, @MelvinBot <your feedback> to refine this analysis, or explain why you are rejecting Melvin's proposal.
Activity
applause-bot commentedon May 26, 2026
While Applause doesn't embed attachments for this bug, here are the links for quick view:
https://platform.applause.com/services/links/v1/external/226e8ca073fc80171310ef64b205f85ed699cd49fa2e10d0dc9e51b1a80c8550
melvin-bot commentedon May 26, 2026
You have been assigned to this deploy blocker because you recently merged this PR: #90029
melvin-bot commentedon May 26, 2026
💬 A slack conversation has been started in #expensify-open-source
github-actions commentedon May 26, 2026
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
MelvinBot commentedon May 26, 2026
Proposal
What is the root cause of that problem?
PR #90029 replaced the old fullscreen filter pages with popover-based dropdowns. The old text filter pages (merchant, keyword, description, etc.) used
FormProvider+InputWrapper, which automatically wiredonSubmitEditingon single-lineTextInputs to callsubmit()— giving Enter-to-apply for free (FormProvider.tsx:394-400).The new implementation renders plain
TextInputcomponents withoutFormProvider, so there is noonSubmitEditinghandler — pressing Enter does nothing. This affects all text-input-based filters: merchant, description, report ID, keyword, title, and withdrawal ID.What changes do you think we should make in order to solve the problem?
Two locations need
onSubmitEditingwired up:TextInputFilterComponents— Add anonSubmitEditingprop to this component and pass it through to theTextInput. The parentTextInputFilterContentshould pass a handler that callsonChange({[filterKey]: value})(the same action the Confirm button triggers).TextInputPopup— AddonSubmitEditing={applyChanges}to theTextInput. TheapplyChangesfunction already exists at line 22 but is only connected to the Apply button.Next Steps for Contributor+ team: Reply with
@MelvinBot implement thisto create a draft PR,@MelvinBot <your feedback>to refine this analysis, or explain why you are rejecting Melvin's proposal.bernhardoj commentedon May 26, 2026
Similar to #88039
cc: @trjExpensify
JS00001 commentedon May 26, 2026
I think this should have the 'enter' behavior
trjExpensify commentedon May 26, 2026
Clicking
Enterblurs the text input. Isn't that how it works already? Down to change it, but that was the understanding here, so NAB based on that.JS00001 commentedon May 26, 2026
Fixed by CP, popup no longer exists. We can keep this one the same as prod in the follow up