You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[Due for payment 2026-05-07] Reports - group-by, view and limit do not appear as applied filters #88044
Version Number: 9.3.60-0 Reproducible in staging?: Yes Reproducible in production?: N/A - new feature, doesn't exist in prod If this was caught during regression testing, add the test name, ID and link from BrowserStack:#86297 Email or phone of affected tester (no customers):soidnjsoidjoisjdiosj@gmail.com Issue reported by: Applause Internal Team Bug source: Exploratory - Significant User Experience Deterioration Device used: Mac 26.2 / Chrome App Component: Search
Action Performed:
Go to staging.new.expensify.com
Go to Reports > Expenses.
Click Display.
Apply any group-by and Limit results filter.
Click Save.
Expected Result:
group-by, view and limit will appear as applied filters.
Actual Result:
group-by, view and limit do not appear as applied filters.
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
Identify the pull request that introduced this issue and revert it.
Classification: Frontend bug Causing PR: #86297 - "[Wiring the UI] Revamp search page actions bar" by @bernhardoj (High confidence) Related Issues: None
Recommendation: REVERT
The causing PR is clearly identified, it is a new feature not yet in production, and the issue is a direct result of its implementation. Reverting is the cleanest path.
Assigned: @bernhardoj (PR author), @aimane-chnaif@JS00001@luacmartins (approving reviewers) Labels: DeployBlockerCash kept (Frontend bug from App PR). DeployBlocker not present, no change.
The PR description item 7 explicitly states: "Remove Group by, View, Limit, and Save search button from the filters page."
As part of this, the constants GROUP_BY, VIEW, and LIMIT were added to a SKIPPED_FILTERS set in useSearchFiltersBar.tsx (line 54) to prevent them from rendering as filter chips in the filters bar.
However, these three keys were never added to FILTER_LABEL_MAP in SearchUIUtils.ts (lines 4748-4777), which is used by mapFiltersFormToLabelValueList to determine what label to display.
The Save Search page (SearchSavePage.tsx, line 108) calls mapFiltersFormToLabelValueList without SKIPPED_FILTERS specifically so that all applied filters (including Group by, View, Limit) are shown — but since GROUP_BY, VIEW, and LIMIT have no entry in FILTER_LABEL_MAP, the condition on line 5023 (if (label && value ...)) fails silently and they are never added to the appliedFilters list.
Affected file: src/pages/Search/SearchSavePage.tsx (line 108) — confirmed the call to mapFiltersFormToLabelValueList passes undefined for skipFilters, intending to show all filters including display options.
Bug is staging-only (new feature not in production).
Root Cause
FILTER_LABEL_MAP in SearchUIUtils.ts was not updated to include translation keys for GROUP_BY, VIEW, and LIMIT when PR #86297 moved those options from the filters bar to the Display dropdown. The mapFiltersFormToLabelValueList function relies on FILTER_LABEL_MAP to produce display labels; without entries for these three keys, they are silently excluded from the applied filters list shown on the Save Search page, even though they are semantically part of the saved search query.
changed the title [-]Reports - group-by, view and limit do not appear as applied filters[/-][+][Due for payment 2026-05-07] Reports - group-by, view and limit do not appear as applied filters[/+]on Apr 30, 2026
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.3.64-31 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
@bernhardoj / @aimane-chnaif The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]
Activity
melvin-bot commentedon Apr 16, 2026
You have been assigned to this deploy blocker because you recently merged this PR: #86297
melvin-bot commentedon Apr 16, 2026
💬 A slack conversation has been started in #expensify-open-source
github-actions commentedon Apr 16, 2026
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
OSBotify commentedon Apr 16, 2026
Investigation Summary
Classification: Frontend bug
Causing PR: #86297 - "[Wiring the UI] Revamp search page actions bar" by @bernhardoj (High confidence)
Related Issues: None
Recommendation: REVERT
The causing PR is clearly identified, it is a new feature not yet in production, and the issue is a direct result of its implementation. Reverting is the cleanest path.
Assigned: @bernhardoj (PR author), @aimane-chnaif @JS00001 @luacmartins (approving reviewers)
Labels:
DeployBlockerCashkept (Frontend bug from App PR).DeployBlockernot present, no change.Detailed Analysis
Evidence
if (label && value ...)) fails silently and they are never added to the appliedFilters list.Verification
Root Cause
FILTER_LABEL_MAP in SearchUIUtils.ts was not updated to include translation keys for GROUP_BY, VIEW, and LIMIT when PR #86297 moved those options from the filters bar to the Display dropdown. The mapFiltersFormToLabelValueList function relies on FILTER_LABEL_MAP to produce display labels; without entries for these three keys, they are silently excluded from the applied filters list shown on the Save Search page, even though they are semantically part of the saved search query.
23 remaining items
melvin-bot commentedon Apr 24, 2026
If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.
If a regression has occurred and you are the assigned CM follow the instructions here.
If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.
[-]Reports - group-by, view and limit do not appear as applied filters[/-][+][Due for payment 2026-05-07] Reports - group-by, view and limit do not appear as applied filters[/+]melvin-bot commentedon Apr 30, 2026
Reviewinglabel has been removed, please complete the "BugZero Checklist".melvin-bot commentedon Apr 30, 2026
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.3.64-31 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2026-05-07. 🎊
For reference, here are some details about the assignees on this issue:
melvin-bot commentedon Apr 30, 2026
@bernhardoj / @aimane-chnaif The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]
bernhardoj commentedon May 1, 2026
We can close this one
trjExpensify commentedon May 1, 2026
Done!