You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[Due for payment 2026-05-11] Spend - Applied columns are not shown when saving search #88712
Version Number: 9.3.62-1 Reproducible in staging?: Yes Reproducible in production?: N/A - new feature, doesn't exist in prod If this was caught during regression testing, add the test name, ID and link from BrowserStack:#88448 Email or phone of affected tester (no customers):oijdsojsonjsosdosd@gmail.com Issue reported by: Applause Internal Team Bug source: Exploratory - Significant User Experience Deterioration Device used: Mac 26.2 / Chrome App Component: Search
Action Performed:
Go to staging.new.expensify.com
Go to Spend > All expenses.
Click Save.
→ Applied columns are not shown.
Click Display > Edit columns.
Check/uncheck any column > Save.
Click Display > Edit columns.
Click Reset columns > Save.
Click Save.
→ Applied columns are shown.
Expected Result:
In Step 3, applied columns should be shown when saving search.
Actual Result:
In Step 3, applied columns is not shown when saving search.
In Step 8, the same applied columns are only shown after changing and resetting columns.
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
Identify the pull request that introduced this issue and revert it.
Classification: Frontend bug Causing PR: #88448 - "Add displays section in save search page" by @bernhardoj (High confidence) Related Issues: #88044
Recommendation: REVERT
PR #88448 introduced the displays section in the Save Search page but has a bug where columns are not shown unless the user has explicitly modified and reset columns at least once. Reverting this PR would eliminate the broken behavior.
Assigned: @bernhardoj (PR author), @aimane-chnaif and @JS00001 (approving reviewers) from highest-confidence causing PR only Labels: DeployBlockerCash kept (frontend App bug). No label changes were needed — DeployBlocker (web/backend) was not present, and DeployBlockerCash should remain.
PR Add displays section in save search page #88448 adds a new "Display" section to SearchSavePage.tsx that is supposed to show the applied display options (groupBy, columns, sortBy, etc.) when a user opens the Save Search dialog.
The bug occurs in the specific case of going to "All expenses" and immediately clicking Save, without first interacting with the Display > Edit columns flow.
After the user edits and resets columns (triggering applyChanges in SearchColumnsPage.tsx), the columns field is explicitly written into the Onyx form (ONYXKEYS.FORMS.SEARCH_ADVANCED_FILTERS_FORM), and then it is visible in the Save dialog. This explains why the workaround (check/uncheck any column > save > reset columns > save) causes columns to appear.
The new getAppliedDisplays function (lines 94-125 of SearchSavePage.tsx) reads searchAdvancedFiltersForm.columns from Onyx to build the display list.
Root Cause
The getAppliedDisplays function reads searchAdvancedFiltersForm.columns from the Onyx form to populate the columns display in the Save Search dialog. However, when a user navigates to "All expenses" and clicks Save without having interacted with the Edit columns flow, searchAdvancedFiltersForm.columns is undefined or empty — the default columns are not pre-populated into the Onyx form. Columns only get written to the form when the user explicitly applies a column selection via applyChanges in SearchColumnsPage.tsx.
As a result, the applied columns section always shows "None" on first save, even though columns are being used. The user sees columns only after explicitly going through the Edit columns and Reset columns flow, which forces the form to be updated. This is a significant user experience deterioration for a new feature in this staging release (does not exist in production yet).
Hmm, when we haven't edited the columns yet, the form data won't contain the column list. After we edit the columns, the column list is added to the form data, and even if we reset the columns to the default, the default column list will still be in the form data.
Should we show the default column list when the column list isn't available in the form data? Or should we hide it if the column list in the form data is the same as the default column list?
changed the title [-]Spend - Applied columns are not shown when saving search[/-][+][Due for payment 2026-05-11] Spend - Applied columns are not shown when saving search[/+]on May 4, 2026
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.3.65-6 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
@bernhardoj / @aimane-chnaif The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]
Activity
melvin-bot commentedon Apr 24, 2026
You have been assigned to this deploy blocker because you recently merged this PR: #88448
melvin-bot commentedon Apr 24, 2026
💬 A slack conversation has been started in #expensify-open-source
github-actions commentedon Apr 24, 2026
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
OSBotify commentedon Apr 24, 2026
Investigation Summary
Classification: Frontend bug
Causing PR: #88448 - "Add displays section in save search page" by @bernhardoj (High confidence)
Related Issues: #88044
Recommendation: REVERT
PR #88448 introduced the displays section in the Save Search page but has a bug where columns are not shown unless the user has explicitly modified and reset columns at least once. Reverting this PR would eliminate the broken behavior.
Assigned: @bernhardoj (PR author), @aimane-chnaif and @JS00001 (approving reviewers) from highest-confidence causing PR only
Labels:
DeployBlockerCashkept (frontend App bug). No label changes were needed —DeployBlocker(web/backend) was not present, andDeployBlockerCashshould remain.Detailed Analysis
Evidence
Fixed Issueslink in the PR matching the reported regression).SearchSavePage.tsxthat is supposed to show the applied display options (groupBy, columns, sortBy, etc.) when a user opens the Save Search dialog.applyChangesinSearchColumnsPage.tsx), thecolumnsfield is explicitly written into the Onyx form (ONYXKEYS.FORMS.SEARCH_ADVANCED_FILTERS_FORM), and then it is visible in the Save dialog. This explains why the workaround (check/uncheck any column > save > reset columns > save) causes columns to appear.Verification
src/pages/Search/SearchSavePage.tsx,src/components/Search/SearchPageHeader/useSearchFiltersBar.tsx,src/libs/SearchUIUtils.tsgetAppliedDisplaysfunction (lines 94-125 ofSearchSavePage.tsx) readssearchAdvancedFiltersForm.columnsfrom Onyx to build the display list.Root Cause
The
getAppliedDisplaysfunction readssearchAdvancedFiltersForm.columnsfrom the Onyx form to populate the columns display in the Save Search dialog. However, when a user navigates to "All expenses" and clicks Save without having interacted with the Edit columns flow,searchAdvancedFiltersForm.columnsisundefinedor empty — the default columns are not pre-populated into the Onyx form. Columns only get written to the form when the user explicitly applies a column selection viaapplyChangesinSearchColumnsPage.tsx.As a result, the applied columns section always shows "None" on first save, even though columns are being used. The user sees columns only after explicitly going through the Edit columns and Reset columns flow, which forces the form to be updated. This is a significant user experience deterioration for a new feature in this staging release (does not exist in production yet).
bernhardoj commentedon Apr 24, 2026
Hmm, when we haven't edited the columns yet, the form data won't contain the column list. After we edit the columns, the column list is added to the form data, and even if we reset the columns to the default, the default column list will still be in the form data.
Should we show the default column list when the column list isn't available in the form data? Or should we hide it if the column list in the form data is the same as the default column list?
JS00001 commentedon Apr 27, 2026
@trjExpensify tbh I dont think I'd expect the default columns to be shown when saving a search w/ no changed columns, thoughts?
15 remaining items
[-]Spend - Applied columns are not shown when saving search[/-][+][Due for payment 2026-05-11] Spend - Applied columns are not shown when saving search[/+]melvin-bot commentedon May 4, 2026
Reviewinglabel has been removed, please complete the "BugZero Checklist".melvin-bot commentedon May 4, 2026
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.3.65-6 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2026-05-11. 🎊
For reference, here are some details about the assignees on this issue:
melvin-bot commentedon May 4, 2026
@bernhardoj / @aimane-chnaif The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]
melvin-bot commentedon May 7, 2026
@bernhardoj Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!
melvin-bot commentedon May 10, 2026
Triggered auto assignment to @mallenexpensify (
Awaiting Payment)bernhardoj commentedon May 11, 2026
We can close this