You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Onboarding - Onboarding background is showing solid #88091
Version Number: v9.3.60-0 Reproducible in staging?: Yes Reproducible in production?: No If this was caught during regression testing, add the test name, ID and link from BrowserStack:#87176 Email or phone of affected tester (no customers): Any new email account Issue reported by: Applause Internal Team Bug source: Exploratory - Significant User Experience Deterioration Device used: Macbook Pro 2023 / Tahoe 26.4.1 App Component: Chat Report View
Action Performed:
Access staging.new.expensify.com on a normal browser (NOT incognito)
Enter an email that has never had an account before and start the onboarding flow
Observe the background
Expected Result:
The background behind the onboarding module should show the homepage
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
Identify the pull request that introduced this issue and revert it.
Classification: Frontend bug Causing PR: #87176 - "fix: checkbox alignment and the padding of last item in onboarding interested features page" by @samranahm (Medium confidence) Related Issues: #82910 (original issue that #87176 fixed)
Recommendation: REVERT
PR #87176 is the most recent App PR touching the onboarding flow and was auto-assigned by melvin-bot to this issue. The bug is staging-only and not reproducible in production, which is consistent with a newly merged staging PR being the cause.
Assigned: @samranahm (PR author), @abzokhattab (approving reviewer), @Julesssss (approving reviewer) Labels: No label changes made. DeployBlockerCash is kept since this is a frontend (web) bug affecting the App deploy.
Detailed Analysis
Evidence
The bug was reported at version v9.3.60-0 and is reproducible on staging only, not production.
The PR touches the onboarding code path that runs when a new user goes through the onboarding flow.
Root Cause
PR #87176 made layout changes to BaseOnboardingInterestedFeatures: it removed the onLayout callback from the ScrollView (which was used to measure container width), removed flexBasis: '35%' from the onboardingInterestedFeaturesItem style, and switched from a calculated maxWidth to a percentage-based flexBasis: '48.5%' for each item.
The connection between these layout changes and the "solid color background behind the onboarding module" symptom is not immediately obvious from the diff alone. The background rendering is controlled by the Overlay component, navigation card styles (basicModalNavigator uses backgroundColor: transparent and position: fixed), and the OnboardingNavigatorInnerView style. None of these were directly modified by the PR.
However, it is possible that a side effect of the ScrollView layout changes or the style modification causes an unexpected rendering behavior on web that affects how the background content is displayed. Given the staging-only reproduction and the timing of the merge, this PR is the most likely candidate.
If reverting #87176 does not resolve the issue, further investigation into other recently merged PRs affecting the navigation or modal rendering would be warranted.
PR #87176 is not the root cause. Its changes (removing flexBasis: '35%' from onboardingInterestedFeaturesItem and adjusting list item layout) only affect items inside the onboarding modal — the inline styles at BaseOnboardingInterestedFeatures.tsx:339-341 already override flexBasis with 48.5% or 100%, making the removal a no-op for the background.
The real issue is that the HOME screen renders behind the onboarding modal (via getAdaptedStateFromPath.ts:316), but for a brand-new user during onboarding, the HOME screen has virtually no visible content:
ForYouSection shows a skeleton loader or empty state (ForYouSection/index.tsx:127-134) because isLoadingApp defaults to true and the user has no todos
Most other sections (GettingStartedSection, AssignedCardsSection, SpendOverTimeSection, UpcomingTravelSection, FreeTrialSection, TimeSensitiveSection) return null for new users with no policies, cards, or data
DiscoverSection returns null when onboarding data is still undefined
This mostly-empty HOME screen (just appBG = dark green #061B09) is then covered by the Overlay component (BaseOverlay.tsx:36) at 72% opacity with theme.overlay color. Dark green background + dark overlay = appears as a solid color.
This is the same code in both production (9.3.59-4) and staging — the getAdaptedStateFromPath, OnboardingModalNavigator, Overlay, and HomePage are identical. The "solid background" is likely a pre-existing behavior for new accounts that became more noticeable during regression testing, or there may be a subtle rendering timing difference from one of the other PRs in this release (e.g., PR #83899 TransitionTracker V2 or PR #88014 onboarding navigation guard).
What changes do you think we should make in order to solve the problem?
Add a visually meaningful background state to the HOME screen when viewed behind the onboarding modal, so new users see homepage chrome instead of a solid color. Two options:
Quick fix: In OnboardingNavigatorInnerView style (styles/index.ts:6044), set backgroundColor: theme.appBG on the inner view and reduce the overlay opacity slightly, so the distinction between the modal and the background is clearer even when the homepage has minimal content.
Better fix: Ensure the HOME screen renders its structural chrome (TopBar, NavigationTabBar, section headers/skeletons) even during the initial loading state for new users. The TopBar already renders, but the ForYouSkeleton is subtle. Making the skeleton more visually prominent or ensuring at least the section containers render with card backgrounds would make the homepage content visible through the overlay.
What alternative solutions did you explore? (Optional)
Replacing SCREENS.HOME with NAVIGATORS.REPORTS_SPLIT_NAVIGATOR in getAdaptedStateFromPath.ts:316 to show the inbox behind onboarding instead — but this would be inconsistent with the app's current HOME-first navigation model.
Making the overlay fully opaque — but this defeats the purpose of the transparent modal design.
Investigation details
Evidence chain:
getAdaptedStateFromPath.ts:316: Navigation state during onboarding is [{name: SCREENS.HOME}, adaptedOnboardingNavigator]
useRootNavigatorScreenOptions.ts:87-101: Onboarding modal uses TRANSPARENT_MODAL presentation with backgroundColor: 'transparent' and position: 'fixed'
AuthScreens.tsx:190-196: HOME is in persistentScreens, preventing detachment — confirmed to render via display: flex
BaseOverlay.tsx:36: Overlay uses overlayBackground style (theme.overlay) with animated opacity 0→0.72
variables.ts:130: overlayOpacity: 0.72
HomePage.tsx:35: isLoadingApp defaults to true, keeping ForYouSection in skeleton state
Production tag 9.3.59-4 has identical code for all these files — confirmed via GitHub API content comparison
Next Steps for Contributor+ team: Reply with @MelvinBot implement this to create a draft PR, @MelvinBot <your feedback> to refine this analysis, or explain why you are rejecting Melvin's proposal.
⏱️ Ran out of time before I could finish. This usually means the task was too complex or I got stuck exploring. Please try again with a more specific request or post in #melvinbot-ai.
Activity
melvin-bot commentedon Apr 16, 2026
You have been assigned to this deploy blocker because you recently merged this PR: #87176
melvin-bot commentedon Apr 16, 2026
💬 A slack conversation has been started in #expensify-open-source
github-actions commentedon Apr 16, 2026
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
OSBotify commentedon Apr 16, 2026
Investigation Summary
Classification: Frontend bug
Causing PR: #87176 - "fix: checkbox alignment and the padding of last item in onboarding interested features page" by @samranahm (Medium confidence)
Related Issues: #82910 (original issue that #87176 fixed)
Recommendation: REVERT
PR #87176 is the most recent App PR touching the onboarding flow and was auto-assigned by melvin-bot to this issue. The bug is staging-only and not reproducible in production, which is consistent with a newly merged staging PR being the cause.
Assigned: @samranahm (PR author), @abzokhattab (approving reviewer), @Julesssss (approving reviewer)
Labels: No label changes made.
DeployBlockerCashis kept since this is a frontend (web) bug affecting the App deploy.Detailed Analysis
Evidence
Verification
Root Cause
PR #87176 made layout changes to BaseOnboardingInterestedFeatures: it removed the onLayout callback from the ScrollView (which was used to measure container width), removed flexBasis: '35%' from the onboardingInterestedFeaturesItem style, and switched from a calculated maxWidth to a percentage-based flexBasis: '48.5%' for each item.
The connection between these layout changes and the "solid color background behind the onboarding module" symptom is not immediately obvious from the diff alone. The background rendering is controlled by the Overlay component, navigation card styles (basicModalNavigator uses backgroundColor: transparent and position: fixed), and the OnboardingNavigatorInnerView style. None of these were directly modified by the PR.
However, it is possible that a side effect of the ScrollView layout changes or the style modification causes an unexpected rendering behavior on web that affects how the background content is displayed. Given the staging-only reproduction and the timing of the merge, this PR is the most likely candidate.
If reverting #87176 does not resolve the issue, further investigation into other recently merged PRs affecting the navigation or modal rendering would be warranted.
MelvinBot commentedon Apr 16, 2026
Proposal
What is the root cause of that problem?
PR #87176 is not the root cause. Its changes (removing
flexBasis: '35%'fromonboardingInterestedFeaturesItemand adjusting list item layout) only affect items inside the onboarding modal — the inline styles at BaseOnboardingInterestedFeatures.tsx:339-341 already overrideflexBasiswith48.5%or100%, making the removal a no-op for the background.The real issue is that the HOME screen renders behind the onboarding modal (via
getAdaptedStateFromPath.ts:316), but for a brand-new user during onboarding, the HOME screen has virtually no visible content:ForYouSection/index.tsx:127-134) becauseisLoadingAppdefaults totrueand the user has no todosnullfor new users with no policies, cards, or datanullwhenonboardingdata is still undefinedThis mostly-empty HOME screen (just
appBG= dark green#061B09) is then covered by the Overlay component (BaseOverlay.tsx:36) at 72% opacity withtheme.overlaycolor. Dark green background + dark overlay = appears as a solid color.This is the same code in both production (
9.3.59-4) and staging — thegetAdaptedStateFromPath,OnboardingModalNavigator,Overlay, andHomePageare identical. The "solid background" is likely a pre-existing behavior for new accounts that became more noticeable during regression testing, or there may be a subtle rendering timing difference from one of the other PRs in this release (e.g., PR #83899 TransitionTracker V2 or PR #88014 onboarding navigation guard).What changes do you think we should make in order to solve the problem?
Add a visually meaningful background state to the HOME screen when viewed behind the onboarding modal, so new users see homepage chrome instead of a solid color. Two options:
Quick fix: In
OnboardingNavigatorInnerViewstyle (styles/index.ts:6044), setbackgroundColor: theme.appBGon the inner view and reduce the overlay opacity slightly, so the distinction between the modal and the background is clearer even when the homepage has minimal content.Better fix: Ensure the HOME screen renders its structural chrome (TopBar, NavigationTabBar, section headers/skeletons) even during the initial loading state for new users. The TopBar already renders, but the ForYouSkeleton is subtle. Making the skeleton more visually prominent or ensuring at least the section containers render with card backgrounds would make the homepage content visible through the overlay.
What alternative solutions did you explore? (Optional)
SCREENS.HOMEwithNAVIGATORS.REPORTS_SPLIT_NAVIGATORingetAdaptedStateFromPath.ts:316to show the inbox behind onboarding instead — but this would be inconsistent with the app's current HOME-first navigation model.Investigation details
Evidence chain:
getAdaptedStateFromPath.ts:316: Navigation state during onboarding is[{name: SCREENS.HOME}, adaptedOnboardingNavigator]useRootNavigatorScreenOptions.ts:87-101: Onboarding modal usesTRANSPARENT_MODALpresentation withbackgroundColor: 'transparent'andposition: 'fixed'AuthScreens.tsx:190-196: HOME is inpersistentScreens, preventing detachment — confirmed to render viadisplay: flexBaseOverlay.tsx:36: Overlay usesoverlayBackgroundstyle (theme.overlay) with animated opacity 0→0.72variables.ts:130:overlayOpacity: 0.72HomePage.tsx:35:isLoadingAppdefaults totrue, keeping ForYouSection in skeleton state9.3.59-4has identical code for all these files — confirmed via GitHub API content comparisonPRs investigated and ruled out as root cause:
flexBasisinside the modal, inline styles override itNext Steps for Contributor+ team: Reply with
@MelvinBot implement thisto create a draft PR,@MelvinBot <your feedback>to refine this analysis, or explain why you are rejecting Melvin's proposal.samranahm commentedon Apr 16, 2026
This issue in not related to #87176
Julesssss commentedon Apr 16, 2026
Yep agree.
Julesssss commentedon Apr 16, 2026
@MelvinBot investigate again and figure out how this regression occured, locating the PR/PRs that introduced this.
MelvinBot commentedon Apr 16, 2026
⏱️ Ran out of time before I could finish. This usually means the task was too complex or I got stuck exploring. Please try again with a more specific request or post in #melvinbot-ai.
Run details
mountiny commentedon Apr 16, 2026
Confirming its not this PR either #88014
Julesssss commentedon Apr 17, 2026
Ruled out these candidates from web AdHoc testing:
Julesssss commentedon Apr 17, 2026
Wait I can no longer reproduce this on staging 😕 Requesting retest
mountiny commentedon Apr 17, 2026
@Julesssss Looks like this is just some LeanConvert A/B test actually
m-natarajan commentedon Apr 17, 2026
@Julesssss Please refer to this video
Recording.2720.mp4
mountiny commentedon Apr 17, 2026
Thread here https://expensify.slack.com/archives/C9YU7BX5M/p1776379665464509
mountiny commentedon Apr 17, 2026
I believe we can close since its ab test
Julesssss commentedon Apr 17, 2026
How did you figure this out?
mountiny commentedon Apr 19, 2026
From the linked thread in Slack, QA raised this is from LC test case, they missed that previously