Repository navigation
Add trackExpensesWithConcierge onboarding RHP variant - #85762
Conversation
Track workspace admins land on Home page with Concierge side panel (desktop) or Concierge DM chat (mobile) for onboarding tasks. Co-authored-by: Jayesh Mangwani <jayeshmangwani@users.noreply.github.com>
|
I created this PR from an upstream branch since I don't have push access to your fork. To take ownership of this branch and be able to push updates, run: Then you can close this PR and open a new one from your fork. |
|
The failing check is unrelated to this PR. Analysis: The only failing check is
This PR only modifies onboarding RHP variant files ( Evidence:
Retrying the CI run should resolve this. |
|
@MelvinBot merge main and fix conflicts. |
Resolved conflicts in CONST/index.ts, RHPVariantTest/index.ts, and OnboardingRHPVariant.ts to preserve the trackExpensesWithConcierge variant additions while incorporating upstream changes. Co-authored-by: Jayesh Mangwani <jayeshmangwani@users.noreply.github.com>
|
Merged main and resolved conflicts in:
|
Co-authored-by: Jayesh Mangwani <jayeshmangwani@users.noreply.github.com>
…com/Expensify/App into claude-trackOnboardingHomeConcierge Co-authored-by: Jayesh Mangwani <jayeshmangwani@users.noreply.github.com>
This comment has been minimized.
This comment has been minimized.
…matting Co-authored-by: Jayesh Mangwani <jayeshmangwani@users.noreply.github.com>
|
Fixed the failing checks:
|
This comment has been minimized.
This comment has been minimized.
|
The previous ESLint and Prettier failures were already resolved by the latest commit ( The older test failure in |
|
I have failed to help you. I let you down and for that I am sorry. Please try again later. This may be due to a Claude outage (check here). Failure details: https://github.com/Expensify/Expensify/actions/runs/23528473149 |
…rOnboarding Co-authored-by: Jayesh Mangwani <jayeshmangwani@users.noreply.github.com>
|
Fixed the failing typecheck and test (job 6) checks: |
Co-authored-by: Jayesh Mangwani <jayeshmangwani@users.noreply.github.com>
|
Fixed the failing Prettier check: corrected import ordering in |
Codecov Report❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.
|
|
@MelvinBot {
"key": "nvp_onboardingRHPVariant",
"onyxMethod": "set",
"value": "trackExpensesWithConcierge"
}
|
The variantOverride parameter was added to shouldOpenRHPVariant and handleRHPVariantNavigation but no call site was passing it. This caused the variant to be undefined because the Onyx callback hadn't fired yet when the functions were called immediately after CompleteGuidedSetup. Changes: - Capture completeOnboarding response and extract nvp_onboardingRHPVariant in BaseOnboardingInterestedFeatures and useAutoCreateTrackWorkspace - Thread variantOverride through navigateAfterOnboarding and its microtask wrapper - Fix shouldOpenRHPVariant to use the variant local (which respects the override) for all checks, not just TRACK_EXPENSES_WITH_CONCIERGE Co-authored-by: Jayesh Mangwani <jayeshmangwani@users.noreply.github.com>
|
Good catch! The Root cause: Fix pushed (4 files):
|
The server response may include onyx keys not present in the request's optimistic/success/failure data, causing TypeScript to report no overlap. Co-authored-by: Jayesh Mangwani <jayeshmangwani@users.noreply.github.com>
|
Fixed the failing typecheck: cast |
|
Just pinging here too, when you have a sec please update the copy/translations in this PR to match the ones in this now-closed PR which is more recent (in that respect only - yours is much more accurate in all other parts haha) |
|
@MelvinBot Please update onboardingTrackWorkspaceMessage: 'To make the most of your 30-day free trial, follow the remaining steps below:', |
|
@dangrous, conflicts resolved and comment updated. |
joekaufmanexpensify
left a comment
There was a problem hiding this comment.
Design doc issue
dangrous
left a comment
There was a problem hiding this comment.
Alright, let's do it! @dylanexpensify I know we're making a couple changes to the design doc, etc - is it okay to merge this or should we hold?
|
Getting caught up to speed on our revisions to the design doc today, we might need a few updates to this, sorry! |
|
Hey @jayeshmangwani, I think these are the only relevant changes for this PR - can you update for the following:
So we're removing the "Create a workspace" task entirely. Navigation I believe is still what you have listed, and then we'll need to cut down the onboarding steps as described. Do you need more details on that? I think we already have a model for different flows through that modal depending on onboarding choices. EDIT: really autocomplete? not gonna message the person who is assigned to this PR? |
|
@dangrous , regarding the first section of the comment of cut down the onboarding steps, we are reducing the steps from seven to three. This change applies only to |
|
@MelvinBot merge the latest main, remove the |
…gHomeConcierge Co-authored-by: Jayesh Mangwani <jayeshmangwani@users.noreply.github.com>
Track Intent users no longer see the "Create a workspace (auto-completed)" task in their onboarding flow. Co-authored-by: Jayesh Mangwani <jayeshmangwani@users.noreply.github.com>
158ebe1
|
Done! Here's what I did:
|
Yep! just for track intent, so sounds like we're good to go here once this is tested! I'll review today and we can get moving. |
|
🚧 @dangrous has triggered a test Expensify/App build. You can view the workflow run here. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🚀 Deployed to staging by https://github.com/dangrous in version: 9.3.60-0 🚀
Bundle Size Analysis (Sentry): |
|
After reviewing the PR changes and searching all help site articles under The PR modifies internal onboarding behavior (post-onboarding navigation, Concierge welcome message text, and onboarding task list for Track workspace admins). None of the existing help articles document these internals — the closest articles (Track Personal Expenses and Configure a Company Workspace) cover workspace setup steps and general Concierge functionality, but don't reference specific onboarding tasks, Concierge message content, or RHP variant navigation behavior. |
|
🚀 Deployed to production by https://github.com/mountiny in version: 9.3.60-22 🚀
|
| // with the CompleteGuidedSetup response and side panel isn't supported on native. | ||
| let rhpVariant: OnboardingRHPVariant | undefined = isSidePanelReportSupported ? undefined : CONST.ONBOARDING_RHP_VARIANT.TRACK_EXPENSES_WITH_CONCIERGE; | ||
| try { | ||
| const response = await completeOnboarding({ |
There was a problem hiding this comment.
This change introduced a regression, fixed in #89904. While awaiting completeOnboarding here, the user can still click Continue again, so completeOnboarding gets called multiple times and causes the duplicated task.
Explanation of Change
Adds the
trackExpensesWithConciergeonboarding RHP variant for Track workspace admins. When the backend sets this variant, Track-intent admins (newDotTrackWorkspace) will:Unlike the existing RHP variants (which require micro company size), this variant applies regardless of company size.
The Concierge welcome message for Track users displays:
With exactly 3 onboarding tasks:
Note: Task
parentReportIDfor Track workspace users already points to the Concierge DM (existing behavior inisPostingTasksInAdminsRoom), so onboarding tasks already appear in the Concierge chat — no change needed there.Fixed Issues
$ #85226
Tests
ONBOARDING_RHP_VARIANTNVP totrackExpensesWithConciergefor a new Track workspace adminnewDotTrackWorkspacechoicerhpConciergeDm,rhpAdminsRoom,rhpHomePage) still work as before (still gated by micro company size)controlvariant still navigates to last accessed report / Home as beforeOffline tests
N/A — This change only affects post-onboarding navigation, which happens after an API response.
QA Steps
trackExpensesWithConciergeas the RHP variantPR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari