Skip to content

[Due for payment 2026-05-11] [Due for payment 2026-05-07] Android - Spend - Tags are not visible on expense preview on "Expenses" section on "Spend" #89089

Closed

Description

@jponikarchuk

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 9.3.64-0
Reproducible in staging?: Yes
Reproducible in production?: No
If this was caught during regression testing, add the test name, ID and link from BrowserStack: #87742
Email or phone of affected tester (no customers): ibellicotest+2250@gmail.com
Issue reported by: Applause Internal Team
Bug source: Exploratory - Significant User Experience Deterioration
Device used: Motorola MotoG60 / Android 12 (Hybrid app)
App Component: Search

Action Performed:

Prerequisite: Account has at least one workspace.
Prerequisite 2: Tags enabled and at least on tag created.

  1. Open the Expensify app.
  2. Open any workspace chat.
  3. Create a manual expense that contains a tag.
  4. Note that selected tag is visible on expense preview on chat.
  5. Navigate to "Spend" > "Expenses"
  6. Note that tag is not visible on expense preview.

Expected Result:

Selected tag should be visible on expense preview on chat and also on preview on "Expenses" section on "Spend".

Actual Result:

Selected tag is visible on expense preview on chat but is not displayed on preview on "Expenses" section on "Spend".

Workaround:

Unknown

Platforms:

  • Android: App
  • Android: mWeb Chrome
  • iOS: App
  • iOS: mWeb Safari
  • iOS: mWeb Chrome
  • Windows: Chrome
  • MacOS: Chrome / Safari

Screenshots/Videos

Video.mp4

View all open jobs on GitHub

Issue OwnerCurrent Issue Owner: @Krishna2323

Activity

  1. added
    DeployBlockerCashThis issue or pull request should block deployment
    BugSomething is broken. Auto assigns a BugZero manager.
    on Apr 28, 2026
  2. melvin-bot commented on Apr 28, 2026

    @melvin-bot

    You have been assigned to this deploy blocker because you recently merged this PR: #87742

  3. melvin-bot commented on Apr 28, 2026

    @melvin-bot

    💬 A slack conversation has been started in #expensify-open-source

  4. github-actions commented on Apr 28, 2026

    @github-actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  5. OSBotify commented on Apr 28, 2026

    @OSBotify
    Contributor

    Investigation Summary

    Classification: Frontend bug
    Causing PR: #87742 - "Update table and row styles for mobile search pages" by @Krishna2323 (High confidence)
    Related Issues: #87460 (the issue this PR was fixing)

    Recommendation: REVERT

    PR #87742 redesigned the narrow/mobile layout of TransactionItemRow and in doing so removed the TagCell from the narrow layout entirely. The tag is now missing from expense previews in the "Expenses" section (Spend > Expenses) on mobile. The fix requires reverting or patching this App PR.

    Assigned: @Krishna2323 (PR author), @JS00001, @luacmartins, @shawnborton, @situchan (approving reviewers)
    Labels: DeployBlockerCash kept (Frontend bug in App). No label changes made.

    Detailed Analysis

    Evidence

    Verification

    • Affected file: src/components/TransactionItemRow/index.tsx
    • PR Update table and row styles for mobile search pages #87742 modifies this file directly (confirmed via gh pr diff).
    • The old narrow layout code in TransactionItemRow included:
      const hasCategoryOrTag = !isCategoryMissing(transactionItem?.category) || !!transactionItem.tag;
      // ...
      {hasCategoryOrTag && !isIOUReport(report) && (
          <View ...>
              <CategoryCell ... />
              <TagCell ... />
          </View>
      )}
    • After PR Update table and row styles for mobile search pages #87742, hasCategoryOrTag was removed, the TagCell rendering block was deleted entirely from the narrow layout, and only the category is now shown (as a suffix text in DateCell via categoryForDisplay). The tag field is no longer rendered in the narrow/mobile layout.

    Root Cause

    PR #87742 redesigned the compact/narrow layout for the TransactionItemRow component to match a new Figma design. During this redesign, the second detail row that previously showed CategoryCell and TagCell side by side was eliminated. The category was preserved as a suffix appended to the date string in DateCell (suffixText={categoryForDisplay}), but the tag was not preserved in any part of the new narrow layout. This omission causes tags to be invisible in the Spend > Expenses section on mobile devices.

  6. MelvinBot commented on Apr 28, 2026

    @MelvinBot
    Contributor

    Proposal

    What is the root cause of that problem?

    PR #87742 restructured the narrow/mobile layout in TransactionItemRow from a 3-row design to a 2-row compact card. During this restructure, the block that rendered CategoryCell and TagCell together was removed entirely. Category was partially preserved by inlining it as suffix text on the DateCell (e.g., "Apr 28 · Food"), but TagCell was dropped with no replacement.

    The narrow layout path (line 683) hardcodes its cells — ReceiptCell, MerchantOrDescriptionCell, ChatBubbleCell, TotalCell, DateCell, TypeCell — and never renders TagCell. The wide/desktop layout still renders tags via columns?.map(renderColumn), which is why tags appear on desktop but not on mobile.

    What changes do you think we should make in order to solve the problem?

    Add the tag to the DateCell suffix text alongside the category, similar to how category is already displayed. In TransactionItemRow/index.tsx, compute a combined suffix that includes both the category and tag (e.g., "Apr 28 · Food · Project-A"), and pass it as the suffixText prop to DateCell.

    Alternatively, re-add TagCell as a separate element in the narrow layout below the date row, but the inline suffix approach is more consistent with how category is already handled in the new compact design.

    What alternative solutions did you explore? (Optional)

    Reverting the entire PR #87742 would restore tags but undo all the mobile search styling improvements. The suffix approach is a targeted fix that preserves the new compact design.


    Next Steps for Contributor+ team: Reply with @MelvinBot implement this to create a draft PR, @MelvinBot <your feedback> to refine this analysis, or explain why you are rejecting Melvin's proposal.

  7. 4 remaining items

  8. dannymcclain commented on Apr 28, 2026

    @dannymcclain
    Contributor

    Same 👍

  9. shawnborton commented on Apr 28, 2026

    @shawnborton
    Contributor

    JUDGES HAVE RULED: NO BLOCKER 🙅

  10. trjExpensify commented on Apr 29, 2026

    @trjExpensify
    Contributor

    Si si. @jponikarchuk if there's an existing test case that calls out expecting that, can you update it please? Thanks!

  11. melvin-bot commented on Apr 29, 2026

    @melvin-bot

    ⚠️ Looks like this issue was linked to a Deploy Blocker here

    If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

    If a regression has occurred and you are the assigned CM follow the instructions here.

    If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

  12. changed the title [-]Android - Spend - Tags are not visible on expense preview on "Expenses" section on "Spend"[/-] [+][Due for payment 2026-05-07] Android - Spend - Tags are not visible on expense preview on "Expenses" section on "Spend"[/+] on Apr 30, 2026
  13. melvin-bot commented on Apr 30, 2026

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 9.3.64-31 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2026-05-07. 🎊

    For reference, here are some details about the assignees on this issue:

    • @Krishna2323 requires payment through NewDot Manual Requests
    • @situchan requires payment through NewDot Manual Requests
  14. melvin-bot commented on Apr 30, 2026

    @melvin-bot

    @Krishna2323 / @situchan The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

  15. changed the title [-][Due for payment 2026-05-07] Android - Spend - Tags are not visible on expense preview on "Expenses" section on "Spend"[/-] [+][Due for payment 2026-05-11] [Due for payment 2026-05-07] Android - Spend - Tags are not visible on expense preview on "Expenses" section on "Spend"[/+] on May 4, 2026
  16. melvin-bot commented on May 4, 2026

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 9.3.65-6 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2026-05-11. 🎊

    For reference, here are some details about the assignees on this issue:

    • @Krishna2323 requires payment through NewDot Manual Requests
    • @situchan requires payment through NewDot Manual Requests
  17. melvin-bot commented on May 4, 2026

    @melvin-bot

    @Krishna2323 / @situchan The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

BugSomething is broken. Auto assigns a BugZero manager.DailyKSv2Engineering

Type

No type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions