Skip to content

[Due for payment 2026-05-13] [Due for payment 2026-05-12] Android - Spend - Blank row at the end of the table #89520

Closed

Description

@mitarachim

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 9.3.66-0
Reproducible in staging?: Yes
Reproducible in production?: No
If this was caught during regression testing, add the test name, ID and link from BrowserStack: #88296
Email or phone of affected tester (no customers): jsosdjosjndosjodnjno@gmail.com
Issue reported by: Applause Internal Team
Bug source: Exploratory - Significant User Experience Deterioration
Device used: Samsung Galaxy S25 FE / Android 16
App Component: Money Requests

Action Performed:

Precondition:

  • Have many expenses.
  1. Launch Expensify app.
  2. Go to Spend > Expenses.
  3. Scroll to the bottom.

Expected Result:

The last row will show the expense.

Actual Result:

The last row is blank.

Workaround:

Unknown

Platforms:

  • Android: App
  • Android: mWeb Chrome
  • iOS: App
  • iOS: mWeb Safari
  • iOS: mWeb Chrome
  • Windows: Chrome
  • MacOS: Chrome / Safari

Screenshots/Videos

Bug7144274_1777908057029.Screen_Recording_20260504_223307_Expensify.mp4

View all open jobs on GitHub

Issue OwnerCurrent Issue Owner: @Krishna2323

Activity

  1. added
    DeployBlockerCashThis issue or pull request should block deployment
    BugSomething is broken. Auto assigns a BugZero manager.
    on May 4, 2026
  2. melvin-bot commented on May 4, 2026

    @melvin-bot

    You have been assigned to this deploy blocker because you recently merged this PR: #88296

  3. melvin-bot commented on May 4, 2026

    @melvin-bot

    You have been assigned to this deploy blocker because you recently merged this PR: #88296

  4. melvin-bot commented on May 4, 2026

    @melvin-bot

    💬 A slack conversation has been started in #expensify-open-source

  5. JS00001 commented on May 4, 2026

    @JS00001
    Contributor

    @Krishna2323 can you take a look?

  6. OSBotify commented on May 4, 2026

    @OSBotify
    Contributor

    Investigation Summary

    Classification: Frontend bug
    Causing PR: #88296 - "Update report details view to use compact desktop table styles" by @Krishna2323 (High confidence)
    Related Issues: #86203 (the issue this PR was fixing)

    Recommendation: REVERT

    PR #88296 introduced layout changes to the MoneyRequestReportTransactionList and related components specifically for a compact desktop table view. The changes introduced a blank row at the bottom of the expenses list on Android, which is reproducible on staging but not production, confirming it was introduced by this staging-only PR.

    Assigned: @Krishna2323 (PR author), @JS00001, @luacmartins, @situchan (approving reviewers)
    Labels: DeployBlockerCash kept (frontend App PR caused the issue). DeployBlocker removed (no backend involvement).

    Detailed Analysis

    Evidence

    Verification

    • Affected file: src/components/MoneyRequestReportView/MoneyRequestReportTransactionList.tsx
    • Affected file: src/components/MoneyRequestReportView/MoneyRequestReportTransactionItem.tsx
    • PR Update report details view to use compact desktop table styles #88296 modifies both of these files directly (confirmed via gh pr view 88296 --json files)
    • The PR significantly refactored how the last transaction item is identified and styled — lastTransactionID logic was changed, isLastItem prop usage was updated, and bottom-radius styles were applied differently for desktop vs narrow layouts

    Root Cause

    The PR introduced a renderTransactionItem helper function and changed the narrowListWrapper behavior. On narrow layout (which applies to Android native), the isLastItem flag now controls overflowHidden and searchTableBottomRadius styles via the OfflineWithFeedback style prop only when !shouldUseNarrowLayout && isLastItem. However, the wrapperStyle on PressableWithFeedback (line 154 of MoneyRequestReportTransactionItem.tsx) applies getSelectedBorderBottomStyle only when shouldUseNarrowLayout && !isLastItem, which means the last item on Android still has its narrow-layout styles affected. Combined with the removed gap2 spacing between grouped views (the styles.gap2 was removed from the grouped transaction View), and the outer View style changes (removing styles.mb2 and styles.gap2 from transactionListContent), the bottom of the list ends up rendering an extra blank space that appears as a blank row, particularly visible when scrolling to the end of a long list on Android.

  7. removed
    DeployBlockerIndicates it should block deploying the API
    on May 4, 2026
  8. MelvinBot commented on May 4, 2026

    @MelvinBot
    Contributor

    Issue Analysis

    ⚠️ Medium confidence — code analysis is thorough but needs runtime confirmation on-device.

    Root Cause: PR #88296 does not modify the narrow-layout rendering path for the search expenses list (Spend > Expenses). The search view uses SearchList → BaseSearchList (FlashList) → TransactionListItem → TransactionItemRow, and the only shared file changed by the PR (TransactionItemRow) has a no-op change on narrow layout (shouldRemoveTotalColumnFlex only affects desktop column rendering). The blank row is most likely in the report detail view, not the main search expenses list.

    If the blank row is in the report detail view (opened by tapping an expense from search), the PR made meaningful changes to MoneyRequestReportTransactionItem.tsx — specifically, the animatedHighlightStyle borderRadius was swapped from 0 → 8 on narrow layout (line 120). Combined with the narrowListWrapper's overflowHidden + searchTableBottomRadius, this new border radius on each item's wrapper could create a visible gap below the last transaction where the rounded corners expose the container background.

    Recommended Fix: Clarify via the video which view shows the blank row — if it's the report detail view, revert the borderRadius swap in MoneyRequestReportTransactionItem.tsx:120 back to borderRadius: shouldUseNarrowLayout ? 0 : variables.componentBorderRadius for the narrow layout path.

    Investigation details

    Search expenses list (Spend > Expenses) — NOT affected by PR

    The rendering path on mobile is:

    1. SearchPage.tsx:135 → SearchPageNarrow
    2. Search/index.tsx:1664 → SearchList with FlashList
    3. TransactionListItem → TransactionItemRow (narrow layout, lines 715-824)

    MoneyRequestReportTransactionList is never used in the search view — it's only used in the report detail view via MoneyRequestReportActionsList.tsx:721 as a ListHeaderComponent.

    Report detail view — affected by PR

    Key narrow-layout changes from PR #88296:

    1. animatedHighlightStyle borderRadius swapped (line 120): shouldUseNarrowLayout ? 0 : 8 → shouldUseNarrowLayout ? 8 : 0 — each item's wrapper now has rounded corners on mobile
    2. isLastItem now checks showPendingExpensePlaceholder (line 595) — but showPendingExpensePlaceholder requires isReportOpenInSuperWideRHP() which is always false on Android phone, so this is a no-op on mobile
    3. Other style changes (OfflineWithFeedback style, getSearchTableRowPressableStyle, container gap2/mb2 removal) are all gated by !shouldUseNarrowLayout — no effect on mobile

    Alternative explanations considered

    • FlashList overscroll artifact on Android — possible but would be pre-existing, not caused by the PR
    • pb2 (8px) bottom padding on the transaction list container — exists but is too small to look like a full blank row
    • showPendingExpensePlaceholder rendering a desktop skeleton on mobile — requires isReportOpenInSuperWideRHP() which is false on Android phone

    Possibly related issues


    Next Steps: Could someone confirm from the video whether the blank row appears in the main search expenses list or in a specific report detail view opened from search? This will determine whether the fix is in TransactionItemRow (search list) or MoneyRequestReportTransactionItem (report detail view). Reply with @MelvinBot implement this to create a draft PR, or @MelvinBot <your feedback> to refine this analysis.

  9. 3 remaining items

  10. m-natarajan commented on May 5, 2026

    @m-natarajan

    Issue no longer reproducible on build 9.3.66-5. Retested on Motorola Moto G60 - Android 12

    screen-20260504-221327.mp4
  11. added and removed
    ReviewingHas a PR in review
    on May 5, 2026
  12. changed the title [-]Android - Spend - Blank row at the end of the table[/-] [+][Due for payment 2026-05-12] Android - Spend - Blank row at the end of the table[/+] on May 5, 2026
  13. melvin-bot commented on May 5, 2026

    @melvin-bot

    Reviewing label has been removed, please complete the "BugZero Checklist".

  14. melvin-bot commented on May 5, 2026

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 9.3.66-7 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2026-05-12. 🎊

    For reference, here are some details about the assignees on this issue:

    • @Krishna2323 requires payment through NewDot Manual Requests
    • @situchan requires payment through NewDot Manual Requests
  15. melvin-bot commented on May 5, 2026

    @melvin-bot

    @Krishna2323 / @situchan The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

  16. changed the title [-][Due for payment 2026-05-12] Android - Spend - Blank row at the end of the table[/-] [+][Due for payment 2026-05-13] [Due for payment 2026-05-12] Android - Spend - Blank row at the end of the table[/+] on May 6, 2026
  17. melvin-bot commented on May 6, 2026

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 9.3.67-13 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2026-05-13. 🎊

    For reference, here are some details about the assignees on this issue:

    • @Krishna2323 requires payment through NewDot Manual Requests
    • @situchan requires payment through NewDot Manual Requests
  18. melvin-bot commented on May 6, 2026

    @melvin-bot

    @Krishna2323 / @situchan The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

BugSomething is broken. Auto assigns a BugZero manager.DailyKSv2Engineering

Type

No type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions