You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[Due for payment 2026-05-13] [Due for payment 2026-05-12] Android - Spend - Blank row at the end of the table #89520
Version Number: 9.3.66-0 Reproducible in staging?: Yes Reproducible in production?: No If this was caught during regression testing, add the test name, ID and link from BrowserStack:#88296 Email or phone of affected tester (no customers):jsosdjosjndosjodnjno@gmail.com Issue reported by: Applause Internal Team Bug source: Exploratory - Significant User Experience Deterioration Device used: Samsung Galaxy S25 FE / Android 16 App Component: Money Requests
Classification: Frontend bug Causing PR: #88296 - "Update report details view to use compact desktop table styles" by @Krishna2323 (High confidence) Related Issues: #86203 (the issue this PR was fixing)
Recommendation: REVERT
PR #88296 introduced layout changes to the MoneyRequestReportTransactionList and related components specifically for a compact desktop table view. The changes introduced a blank row at the bottom of the expenses list on Android, which is reproducible on staging but not production, confirming it was introduced by this staging-only PR.
The PR is titled "Update report details view to use compact desktop table styles" and modifies the transaction list layout in MoneyRequestReportTransactionList.tsx, MoneyRequestReportTransactionItem.tsx, and related files — exactly the components responsible for the Expenses list rendering
The bug manifests as a blank row at the bottom of the Expenses list on Android
The PR significantly refactored how the last transaction item is identified and styled — lastTransactionID logic was changed, isLastItem prop usage was updated, and bottom-radius styles were applied differently for desktop vs narrow layouts
Root Cause
The PR introduced a renderTransactionItem helper function and changed the narrowListWrapper behavior. On narrow layout (which applies to Android native), the isLastItem flag now controls overflowHidden and searchTableBottomRadius styles via the OfflineWithFeedbackstyle prop only when !shouldUseNarrowLayout && isLastItem. However, the wrapperStyle on PressableWithFeedback (line 154 of MoneyRequestReportTransactionItem.tsx) applies getSelectedBorderBottomStyle only when shouldUseNarrowLayout && !isLastItem, which means the last item on Android still has its narrow-layout styles affected. Combined with the removed gap2 spacing between grouped views (the styles.gap2 was removed from the grouped transaction View), and the outer View style changes (removing styles.mb2 and styles.gap2 from transactionListContent), the bottom of the list ends up rendering an extra blank space that appears as a blank row, particularly visible when scrolling to the end of a long list on Android.
⚠️Medium confidence — code analysis is thorough but needs runtime confirmation on-device.
Root Cause: PR #88296 does not modify the narrow-layout rendering path for the search expenses list (Spend > Expenses). The search view uses SearchList → BaseSearchList (FlashList) → TransactionListItem → TransactionItemRow, and the only shared file changed by the PR (TransactionItemRow) has a no-op change on narrow layout (shouldRemoveTotalColumnFlex only affects desktop column rendering). The blank row is most likely in the report detail view, not the main search expenses list.
If the blank row is in the report detail view (opened by tapping an expense from search), the PR made meaningful changes to MoneyRequestReportTransactionItem.tsx — specifically, the animatedHighlightStyleborderRadius was swapped from 0 → 8 on narrow layout (line 120). Combined with the narrowListWrapper's overflowHidden + searchTableBottomRadius, this new border radius on each item's wrapper could create a visible gap below the last transaction where the rounded corners expose the container background.
Recommended Fix: Clarify via the video which view shows the blank row — if it's the report detail view, revert the borderRadius swap in MoneyRequestReportTransactionItem.tsx:120 back to borderRadius: shouldUseNarrowLayout ? 0 : variables.componentBorderRadius for the narrow layout path.
Investigation details
Search expenses list (Spend > Expenses) — NOT affected by PR
MoneyRequestReportTransactionList is never used in the search view — it's only used in the report detail view via MoneyRequestReportActionsList.tsx:721 as a ListHeaderComponent.
animatedHighlightStyle borderRadius swapped (line 120): shouldUseNarrowLayout ? 0 : 8 → shouldUseNarrowLayout ? 8 : 0 — each item's wrapper now has rounded corners on mobile
isLastItem now checks showPendingExpensePlaceholder (line 595) — but showPendingExpensePlaceholder requires isReportOpenInSuperWideRHP() which is always false on Android phone, so this is a no-op on mobile
Other style changes (OfflineWithFeedback style, getSearchTableRowPressableStyle, container gap2/mb2 removal) are all gated by !shouldUseNarrowLayout — no effect on mobile
Alternative explanations considered
FlashList overscroll artifact on Android — possible but would be pre-existing, not caused by the PR
pb2 (8px) bottom padding on the transaction list container — exists but is too small to look like a full blank row
showPendingExpensePlaceholder rendering a desktop skeleton on mobile — requires isReportOpenInSuperWideRHP() which is false on Android phone
Next Steps: Could someone confirm from the video whether the blank row appears in the main search expenses list or in a specific report detail view opened from search? This will determine whether the fix is in TransactionItemRow (search list) or MoneyRequestReportTransactionItem (report detail view). Reply with @MelvinBot implement this to create a draft PR, or @MelvinBot <your feedback> to refine this analysis.
changed the title [-]Android - Spend - Blank row at the end of the table[/-][+][Due for payment 2026-05-12] Android - Spend - Blank row at the end of the table[/+]on May 5, 2026
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.3.66-7 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
@Krishna2323 / @situchan The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]
changed the title [-][Due for payment 2026-05-12] Android - Spend - Blank row at the end of the table[/-][+][Due for payment 2026-05-13] [Due for payment 2026-05-12] Android - Spend - Blank row at the end of the table[/+]on May 6, 2026
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.3.67-13 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
@Krishna2323 / @situchan The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]
Activity
melvin-bot commentedon May 4, 2026
You have been assigned to this deploy blocker because you recently merged this PR: #88296
melvin-bot commentedon May 4, 2026
You have been assigned to this deploy blocker because you recently merged this PR: #88296
melvin-bot commentedon May 4, 2026
💬 A slack conversation has been started in #expensify-open-source
JS00001 commentedon May 4, 2026
@Krishna2323 can you take a look?
OSBotify commentedon May 4, 2026
Investigation Summary
Classification: Frontend bug
Causing PR: #88296 - "Update report details view to use compact desktop table styles" by @Krishna2323 (High confidence)
Related Issues: #86203 (the issue this PR was fixing)
Recommendation: REVERT
PR #88296 introduced layout changes to the
MoneyRequestReportTransactionListand related components specifically for a compact desktop table view. The changes introduced a blank row at the bottom of the expenses list on Android, which is reproducible on staging but not production, confirming it was introduced by this staging-only PR.Assigned: @Krishna2323 (PR author), @JS00001, @luacmartins, @situchan (approving reviewers)
Labels:
DeployBlockerCashkept (frontend App PR caused the issue).DeployBlockerremoved (no backend involvement).Detailed Analysis
Evidence
melvin-botauto-assigned the PR's contributors to this deploy blocker, corroborating the attributionpathandkeyPatternare next to each other #30 in the chronological list in issue Deploy Checklist: New Expensify 2026-05-04 #89508)MoneyRequestReportTransactionList.tsx,MoneyRequestReportTransactionItem.tsx, and related files — exactly the components responsible for the Expenses list renderingVerification
src/components/MoneyRequestReportView/MoneyRequestReportTransactionList.tsxsrc/components/MoneyRequestReportView/MoneyRequestReportTransactionItem.tsxgh pr view 88296 --json files)lastTransactionIDlogic was changed,isLastItemprop usage was updated, and bottom-radius styles were applied differently for desktop vs narrow layoutsRoot Cause
The PR introduced a
renderTransactionItemhelper function and changed thenarrowListWrapperbehavior. On narrow layout (which applies to Android native), theisLastItemflag now controlsoverflowHiddenandsearchTableBottomRadiusstyles via theOfflineWithFeedbackstyleprop only when!shouldUseNarrowLayout && isLastItem. However, thewrapperStyleonPressableWithFeedback(line 154 ofMoneyRequestReportTransactionItem.tsx) appliesgetSelectedBorderBottomStyleonly whenshouldUseNarrowLayout && !isLastItem, which means the last item on Android still has its narrow-layout styles affected. Combined with the removedgap2spacing between grouped views (thestyles.gap2was removed from the grouped transactionView), and the outerViewstyle changes (removingstyles.mb2andstyles.gap2fromtransactionListContent), the bottom of the list ends up rendering an extra blank space that appears as a blank row, particularly visible when scrolling to the end of a long list on Android.MelvinBot commentedon May 4, 2026
Issue Analysis
Root Cause: PR #88296 does not modify the narrow-layout rendering path for the search expenses list (
Spend > Expenses). The search view usesSearchList→BaseSearchList(FlashList) →TransactionListItem→TransactionItemRow, and the only shared file changed by the PR (TransactionItemRow) has a no-op change on narrow layout (shouldRemoveTotalColumnFlexonly affects desktop column rendering). The blank row is most likely in the report detail view, not the main search expenses list.If the blank row is in the report detail view (opened by tapping an expense from search), the PR made meaningful changes to
MoneyRequestReportTransactionItem.tsx— specifically, theanimatedHighlightStyleborderRadiuswas swapped from0→8on narrow layout (line 120). Combined with thenarrowListWrapper'soverflowHidden+searchTableBottomRadius, this new border radius on each item's wrapper could create a visible gap below the last transaction where the rounded corners expose the container background.Recommended Fix: Clarify via the video which view shows the blank row — if it's the report detail view, revert the
borderRadiusswap inMoneyRequestReportTransactionItem.tsx:120back toborderRadius: shouldUseNarrowLayout ? 0 : variables.componentBorderRadiusfor the narrow layout path.Investigation details
Search expenses list (Spend > Expenses) — NOT affected by PR
The rendering path on mobile is:
SearchPage.tsx:135→SearchPageNarrowSearch/index.tsx:1664→SearchListwith FlashListTransactionListItem→TransactionItemRow(narrow layout, lines 715-824)MoneyRequestReportTransactionListis never used in the search view — it's only used in the report detail view viaMoneyRequestReportActionsList.tsx:721as aListHeaderComponent.Report detail view — affected by PR
Key narrow-layout changes from PR #88296:
animatedHighlightStyleborderRadius swapped (line 120):shouldUseNarrowLayout ? 0 : 8→shouldUseNarrowLayout ? 8 : 0— each item's wrapper now has rounded corners on mobileisLastItemnow checksshowPendingExpensePlaceholder(line 595) — butshowPendingExpensePlaceholderrequiresisReportOpenInSuperWideRHP()which is always false on Android phone, so this is a no-op on mobileOfflineWithFeedbackstyle,getSearchTableRowPressableStyle, containergap2/mb2removal) are all gated by!shouldUseNarrowLayout— no effect on mobileAlternative explanations considered
pb2(8px) bottom padding on the transaction list container — exists but is too small to look like a full blank rowshowPendingExpensePlaceholderrendering a desktop skeleton on mobile — requiresisReportOpenInSuperWideRHP()which is false on Android phonePossibly related issues
Next Steps: Could someone confirm from the video whether the blank row appears in the main search expenses list or in a specific report detail view opened from search? This will determine whether the fix is in
TransactionItemRow(search list) orMoneyRequestReportTransactionItem(report detail view). Reply with@MelvinBot implement thisto create a draft PR, or@MelvinBot <your feedback>to refine this analysis.3 remaining items
m-natarajan commentedon May 5, 2026
Issue no longer reproducible on build 9.3.66-5. Retested on Motorola Moto G60 - Android 12
screen-20260504-221327.mp4
[-]Android - Spend - Blank row at the end of the table[/-][+][Due for payment 2026-05-12] Android - Spend - Blank row at the end of the table[/+]melvin-bot commentedon May 5, 2026
Reviewinglabel has been removed, please complete the "BugZero Checklist".melvin-bot commentedon May 5, 2026
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.3.66-7 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2026-05-12. 🎊
For reference, here are some details about the assignees on this issue:
melvin-bot commentedon May 5, 2026
@Krishna2323 / @situchan The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]
[-][Due for payment 2026-05-12] Android - Spend - Blank row at the end of the table[/-][+][Due for payment 2026-05-13] [Due for payment 2026-05-12] Android - Spend - Blank row at the end of the table[/+]melvin-bot commentedon May 6, 2026
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.3.67-13 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2026-05-13. 🎊
For reference, here are some details about the assignees on this issue:
melvin-bot commentedon May 6, 2026
@Krishna2323 / @situchan The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]