Repository navigation
Closed
Labels
DailyKSv2KSv2StagingDeployCash🔐 LockCashDeploys 🔐Prevent new code from being deployed to stagingPrevent new code from being deployed to staging
Description
Release Version: 9.3.66-7
Compare Changes: production...staging
Mobile-Expensify Changes: https://github.com/Expensify/Mobile-Expensify/compare/production...staging
This release contains changes from the following pull requests:
- Show report actions in the main window when a report is selected in LHN #25
- Implement live report actions with pusher so that comments made to the report on www show up automatically #27
- Fix Screen Reader issue preventing bottom sheet from closing without selection #81536
- fix: can save vacation delegate that isn't associated with an account #83608
- [NoQA][Change Approver] reassign approver #85233
- feat: Update option missing for Personal Bank Accounts in ND compared to Classic #87141
- [Payment due @brunovjk] Add Export option to Expensify Card Bulk Selection in Workspace settings #87491
- Pass activePolicy to buildPolicyData and remove policy onyx connection in actions/Policy.ts #87715
- [No QA] Add new span for FAB add report to Scan Page #87765
- Fix: Prevent Onyx.clear() from removing unsynced PERSISTED_REQUESTS data #87874
- refactor createChildReport to use isSelfTourViewed from useOnyx #87914
- feat: Added role filter to workspace members list #88293
- Update report details view to use compact desktop table styles #88296
- decompose ReportActionsList: 1 #88392
- [Home Page] Add Locked VBA (Verified Bank Account) widget to Time Sensitive #88429
- Fix category tax value not syncing on expense creation #88477
- Part 4: Remove Onyx.connect() for the key: ONYXKEYS.PERSONAL_DETAILS_LIST #88521
- Update search input height on narrow to be the same as in wide #88526
- Fix blank space when sending a message #88529
- Add support for "Require company cards for all purchases" policy changelog report action #88542
- fix: Mark as paid on Reports pays the full amount without asking paying option #88569
- Migrate CategorySelectorModal to be nav RHP #88576
- Refactor: clean up submit-to-destination-visible code to conform to coding standards #88581
- [NO QA] Add support for optional path parameters in dynamic routes #88589
- Fix: "Waiting for you to pay expenses" shown incorrectly for $0.00 reports without Pay button #88612
- refactor: PureReportActionItem, IouReportActionMessage #88691
- [Domain Control] [Release 4] Add Strictly Enforce Workspace Rules Toggle to DomainGroupDetailsPage #88699
- Improve chart label alignment and spacing #88718
- "Ask Concierge" option in the search router #88727
- BT - Migrate Workspace Categories #88842
- fix: Remove Onyx.connect() for the key: ONYXKEYS.COLLECTION.POLICY (part 6) #88843
- Show Unreported status badge for expenses without a report #88851
- fix: Remove Onyx.connect() for the key: ONYXKEYS.COLLECTION.POLICY (part 7) #88857
- Migrate ExpenseLimitTypeSelectorModal to nav RHP #88915
- fix: right label and badge style in menu item #88920
- Fall back to Onyx when search snapshot is missing report data #88957
- Update odometer error message to include missing 'to continue' suffix #89034
- [no qa] perf: decompose OptionRowLHN avatar/delegate logic into a separate component #89087
- [Payment due @Pujan92] Trickle Concierge suggested response #89146
- refactor: PureReportActionItem, push down 5 wrapper subscriptions into action leaves #89160
- [No QA] jest: ignore .worktrees/ in haste-map indexing #89161
- [No QA] Add tests for SearchMoneyRequestReportPage dismiss-on-removal logic #89247
- Fix doubled OpenApp on delegate (copilot) account switch #89254
- Don't fire duplicate ReconnectApp on delegate account switch #89262
- Fix freeze when opening "Add approval workflow" on workspaces with many members #89268
- Refactor: migrate convertToDisplayString to useCurrencyListActions hook (part 8) #89282
- Refactor: migrate convertToDisplayString to useCurrencyListActions hook (part 9) #89285
- feat: Add Agents feature with corresponding UI and translations #89304
- feat: Add Withdrawal ID column to Expenses search and in report view. #89307
- Fix header border color when items are selected #89353
- Encode query param in saved search rename route #89394
- Pass splitExpensesTotal in useDeleteTransactions to fix offline split deletion total #89403
- [No QA] Allow __esModule in naming-convention rule, drop ~120 suppressions #89412
- Preserve introSelected.choice in onboarding failureData #89423
- [No QA] Fix typecheck in main: remove leftover personalPolicyID prop from tests #89474
- [No QA] perf: replace lodashMapKeys with native loop in WorkflowUtils #89477
- [CP Staging] fixed tax rate and tax visibility and negative IOU expense #89514
- [CP Staging] Fix unreported badge invisible when expense row selected #89521
- [CP Staging] Update SPEND_CATEGORY_SELECTOR entryScreens to use renamed screen #89544
- [cp staging] Revert https://github.com/Expensify/App/pull/88296 #89550
- [CP Staging] Revert "Fix header border color when items are selected" #89552
- [CP Staging] Trim whitespace-only search input to prevent empty Ask Concierge messages #89563
Mobile-Expensify PRs:
Internal QA:
Deploy Blockers:
- Expense - IOU expenses show negative amount #89490
- [Due for payment 2026-05-13] [Due for payment 2026-05-12] [$250] Expense - Unreported badge background is not visible when expense is selected #89519
- [Due for payment 2026-05-13] [Due for payment 2026-05-12] Android - Spend - Blank row at the end of the table #89520
- [Due for payment 2026-05-13] [Due for payment 2026-05-12] Search - "No content to add" error after clicking Ask Concierge with just a space #89522
- [Due for payment 2026-05-13] [Due for payment 2026-05-12] Android - Spend - Created expense is blank #89523
- 89508 Search - "No content to add" error after clicking Ask Concierge with just a space #89524
- [Due for payment 2026-05-13] [Due for payment 2026-05-12] Categories - Spend category list opens not here page #89526
- [Due for payment 2026-05-13] [Due for payment 2026-05-12] Android - Spend - Report becomes blank after deleting other report #89527
- [Due for payment 2026-05-13] [Due for payment 2026-05-12] Expense - Category, tag, tax, total column are not aligned correctly #89529
- [Due for payment 2026-05-15] Search - Blank RHP opens on the right, request not sent to Concierge when app loading #89535
- Expenses - "Tax rate was modified" error is displayed after creating scan expense #89541
- [Due for payment 2026-05-20] Members - Empty state screen is not scrollable on landscape mode when applying role filter. #89554
Chronologically ordered merged PRs (oldest first)
- Show report actions in the main window when a report is selected in LHN #25
- Implement live report actions with pusher so that comments made to the report on www show up automatically #27
- [No QA] jest: ignore .worktrees/ in haste-map indexing #89161
- feat: Update option missing for Personal Bank Accounts in ND compared to Classic #87141
- "Ask Concierge" option in the search router #88727
- Fix doubled OpenApp on delegate (copilot) account switch #89254
- Fix freeze when opening "Add approval workflow" on workspaces with many members #89268
- Fix blank space when sending a message #88529
- Mobile-Expensify submodule update to
933a3e4— Adhoc Build
↳ https://github.com/Expensify/Mobile-Expensify/pull/13926 - fix: Mark as paid on Reports pays the full amount without asking paying option #88569
- Migrate CategorySelectorModal to be nav RHP #88576
- [Payment due @brunovjk] Add Export option to Expensify Card Bulk Selection in Workspace settings #87491
- Part 4: Remove Onyx.connect() for the key: ONYXKEYS.PERSONAL_DETAILS_LIST #88521
- Mobile-Expensify submodule update to
9.3.65-1— Adhoc Build - [No QA] Add new span for FAB add report to Scan Page #87765
- Fix: "Waiting for you to pay expenses" shown incorrectly for $0.00 reports without Pay button #88612
- Mobile-Expensify submodule update to
9.3.65-2— Adhoc Build - Report OpenReport new account creation to fraud protection backend #89194
- [no qa] perf: decompose OptionRowLHN avatar/delegate logic into a separate component #89087
- Fix Screen Reader issue preventing bottom sheet from closing without selection #81536
- Fix category tax value not syncing on expense creation #88477
- Refactor: migrate convertToDisplayString to useCurrencyListActions hook (part 9) #89285
- Refactor: migrate convertToDisplayString to useCurrencyListActions hook (part 8) #89282
- Fall back to Onyx when search snapshot is missing report data #88957
- Mobile-Expensify submodule update to
9.3.65-3— Adhoc Build - Encode query param in saved search rename route #89394
- fix: Remove Onyx.connect() for the key: ONYXKEYS.COLLECTION.POLICY (part 6) #88843
- fix: Remove Onyx.connect() for the key: ONYXKEYS.COLLECTION.POLICY (part 7) #88857
- decompose ReportActionsList: 1 #88392
- Update report details view to use compact desktop table styles #88296
- Mobile-Expensify submodule update to
9.3.65-4— Adhoc Build - feat: Add Agents feature with corresponding UI and translations #89304
- Mobile-Expensify submodule update to
9.3.65-5— Adhoc Build - Update odometer error message to include missing 'to continue' suffix #89034
- Mobile-Expensify submodule update to
9.3.65-6— Adhoc Build - [NoQA][Change Approver] reassign approver #85233
- Show Unreported status badge for expenses without a report #88851
- Preserve introSelected.choice in onboarding failureData #89423
- Add support for "Require company cards for all purchases" policy changelog report action #88542
- feat: Added role filter to workspace members list #88293
- Improve chart label alignment and spacing #88718
- BT - Migrate Workspace Categories #88842
- [No QA] Allow __esModule in naming-convention rule, drop ~120 suppressions #89412
- [NO QA] Add support for optional path parameters in dynamic routes #88589
- refactor: PureReportActionItem, push down 5 wrapper subscriptions into action leaves #89160
- fix: right label and badge style in menu item #88920
- [No QA] Fix typecheck in main: remove leftover personalPolicyID prop from tests #89474
- fix: can save vacation delegate that isn't associated with an account #83608
- Refactor: clean up submit-to-destination-visible code to conform to coding standards #88581
- Pass activePolicy to buildPolicyData and remove policy onyx connection in actions/Policy.ts #87715
- refactor createChildReport to use isSelfTourViewed from useOnyx #87914
- [Home Page] Add Locked VBA (Verified Bank Account) widget to Time Sensitive #88429
- Fix: Prevent Onyx.clear() from removing unsynced PERSISTED_REQUESTS data #87874
- Pass splitExpensesTotal in useDeleteTransactions to fix offline split deletion total #89403
- [Domain Control] [Release 4] Add Strictly Enforce Workspace Rules Toggle to DomainGroupDetailsPage #88699
- [No QA] perf: replace lodashMapKeys with native loop in WorkflowUtils #89477
- Update search input height on narrow to be the same as in wide #88526
- refactor: PureReportActionItem, IouReportActionMessage #88691
- feat: Add Withdrawal ID column to Expenses search and in report view. #89307
- [Payment due @Pujan92] Trickle Concierge suggested response #89146
- Fix header border color when items are selected #89353
- [No QA] Add tests for SearchMoneyRequestReportPage dismiss-on-removal logic #89247
- Don't fire duplicate ReconnectApp on delegate account switch #89262
- Migrate ExpenseLimitTypeSelectorModal to nav RHP #88915
- Mobile-Expensify submodule update to
9.3.66-0— Adhoc Build - Mobile-Expensify submodule update to
9.3.66-1— Adhoc Build - [CP Staging] Update SPEND_CATEGORY_SELECTOR entryScreens to use renamed screen #89544
- Mobile-Expensify submodule update to
9.3.66-2— 3a8ec96 - Mobile-Expensify submodule update to
9.3.66-3— 233fca1 - [CP Staging] Revert "Fix header border color when items are selected" #89552
- [cp staging] Revert https://github.com/Expensify/App/pull/88296 #89550
- Mobile-Expensify submodule update to
9.3.66-4— 63c62b7 - [CP Staging] Trim whitespace-only search input to prevent empty Ask Concierge messages #89563
- Mobile-Expensify submodule update to
9.3.66-5— ac2f848 - [CP Staging] fixed tax rate and tax visibility and negative IOU expense #89514
- Mobile-Expensify submodule update to
9.3.66-6— 24deeb1 - [CP Staging] Fix unreported badge invisible when expense row selected #89521
- Mobile-Expensify submodule update to
9.3.66-7— 51a6550
Deployer verifications:
- I checked Sentry for this release version and verified that this release does not introduce any new crashes. More detailed instructions on this verification can be found here.
- I checked Sentry for the previous release version and verified that the release did not introduce any new crashes. Because mobile deploys use a phased rollout, completing this checklist will deploy the previous release version to 100% of users. More detailed instructions on this verification can be found here.
- I checked GitHub Status and verified there is no reported incident with Actions.
cc @Expensify/applauseleads
Metadata
Metadata
Assignees
Labels
DailyKSv2KSv2StagingDeployCash🔐 LockCashDeploys 🔐Prevent new code from being deployed to stagingPrevent new code from being deployed to staging
Activity
mvtglobally commentedon May 4, 2026
@francoisl Can we just check this off? #25 and #27
francoisl commentedon May 4, 2026
Yes not sure how they showed up in the checklist, checking them off.
mvtglobally commentedon May 4, 2026
Regression is at 50%
srikarparsi commentedon May 4, 2026
Demoted #89554
mvtglobally commentedon May 4, 2026
Regression progress is at 93%
PRs Failing:
#88576 on Web & Android (#89526)
#88842 on Web & Android (#89098)
#89423 on All (#88482)
PRs Untested:
#88392 pending validation on Android and iOS
#88429 pending validation on Web
#88477 pending validation on iOS
#88526 pending validation on iOS
#88529 pending validation on iOS
#88576 pending validation on iOS
#88581 pending validation on iOS
#88699 pending validation on iOS
#88718 pending validation on iOS
#88727 pending validation on iOS
#88851 pending validation on iOS
#88857 pending validation on Android and iOS
#88920 pending validation on iOS
#88957 pending validation on iOS
#89146 pending validation on iOS
#89160 pending validation on iOS
#89307 pending validation on Web, Android, iOS
#89353 pending validation on Android and iOS
mvtglobally commentedon May 4, 2026
#87141 (comment) - can you please QA this PR internally as we have no easy way to setup such account.
francoisl commentedon May 4, 2026
#87141 - discussed internally, checking it
#89541 - backend issue, demoting as NAB
#89535 - demoting, edge case
#89526 - fix tested on staging
#89522 - fix tested on staging
#89529 - confirmed on staging
#89523 - confirmed on staging
#89527 - confirmed on staging
mvtglobally commentedon May 5, 2026
Regression progress is at 99%
PRs Failing:
#88296 is failing with #89529, #89527, #89523, #89520
#88392 is failing on Native apps
#88477 is failing with #89541
#88576 on Web & Android (#89526)
#88842 on Web & Android (#89098), #89526, #83831
#88920 is failing on Android with Original issue
#89160 is failing on All with #89546. Repro in PROD, checking off
#89353 is failing with #89066. repro in PROD. checking off
#89423 on All (#88482), failing with the original issue #89423 (comment)
PRs Untested:
#88429 (comment) - Can you please help us to preset the account? Is this Internal QA?
#88718 pending validation on iOS
#89307 pending validation on Web and IOS
#89403 pending validation on All
mvtglobally commentedon May 5, 2026
Checking off #89403, Issue repro in PROD #89497
mvtglobally commentedon May 5, 2026
Regression progress is Complete in TR
PRs Failing:
#88296 is failing with #89529, #89527, #89523, #89520
#88392 is failing on Native apps
#88477 is failing with #89541
#88576 on Web & Android (#89526)
#88842 on Web & Android (#89098), #89526, #83831
#88920 is failing on Android with Original issue
#89423 on All (#88482), failing with the original issue #89423 (comment)
PRs Untested:
#88429 (comment) - Can you please help us to preset the personal account? Is this Internal QA?
Critical test cases that are failing:
Onboarding with #87851
SAML with #85937
Critical Viral Path with #48727
Expensify Card with #86885 (comment)
Scan receipt with #89523
Login with #89545
francoisl commentedon May 5, 2026
#89519 – tested internally
#88576 – can't repro issue anymore, checking off
#88477 – backend issue
#88392 – there's a comment to follow up in the issue. Not going to block on this
#88296 – we retested yesterday, going to check off
#89423 – there's a comment to follow up in the issue
francoisl commentedon May 5, 2026
There was this incident with actions earlier but it's allegedly resolved, going to try a deploy and hope for the best
francoisl commentedon May 5, 2026