Skip to content

[Due for payment 2026-07-21] [$250] The “There’s a report awaiting action” UI is pushing other content out, leaving blank space displayed. #89528

Closed

Description

@m-natarajan

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 9.3.66-1
Reproducible in staging?: Y
Reproducible in production?: N (Debug option N/A)
If this was caught during regression testing, add the test name, ID and link from BrowserStack:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @quinthar @blimpich @brianlee-expensify
Slack conversation (hyperlinked to channel name): #Expensify Bugs #quality

Action Performed:

Precondition:
Have at least a report with GBR or RBR in LHN

  1. Go to staging.new.expensify.com
  2. Press CMD+D
  3. Enable Debug mode
  4. Navigate to LHN

Expected Result:

LHN menu displayed without any visual issues

Actual Result:

"There's a report awaiting action" UI is pushing LHN and blank space displayed

Workaround:

Unknown

Platforms:

Select the officially supported platforms where the issue was reproduced:

  • Android: App
  • Android: mWeb Chrome
  • iOS: App
  • iOS: mWeb Safari
  • iOS: mWeb Chrome
  • Windows: Chrome
  • MacOS: Chrome / Safari

Screenshots/Videos

Image

View all open jobs on GitHub

Issue OwnerCurrent Issue Owner: @mallenexpensify
Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~022051335767738333893
  • Upwork Job ID: 2051335767738333893
  • Last Price Increase: 2026-05-04

Activity

  1. added
    BugSomething is broken. Auto assigns a BugZero manager.
    on May 4, 2026
  2. MelvinBot commented on May 4, 2026

    @MelvinBot
    Contributor

    Proposal

    What is the root cause of that problem?

    The DebugTabView banner is rendered as a sibling before the tab bar container inside NavigationTabBar. On narrow/desktop layouts, the parent TabNavigatorBar uses a negative marginTop of -(bottomTabHeight + safeAreaPaddingBottom) via getTabBarNarrowStyle to overlay the tab bar on content with zero layout impact. This margin only accounts for the fixed 72px tab bar height — it does not account for the extra height added by DebugTabView. The uncompensated height pushes the LHN content and creates the visible blank space.

    On wide layout, a similar issue occurs: DebugTabView is a sibling of leftNavigationTabBarContainer (which has height: '100%') inside an overflowHidden parent, causing layout displacement.

    What changes do you think we should make in order to solve the problem?

    Move the DebugTabView to use absolute positioning so it overlays on top of the tab bar instead of participating in the normal layout flow. In NavigationTabBar/index.tsx, render the DebugTabView inside a wrapper with position: 'absolute' anchored above the tab bar (e.g., bottom: 100%, left: 0, right: 0). This way it does not add any height to the tab bar container and will not affect the negative margin calculation or push any content.

    What alternative solutions did you explore? (Optional)

    An alternative would be to dynamically measure the DebugTabView height and add it to the negative marginTop in getTabBarNarrowStyle. However, this is fragile — it couples the margin calculation to a dynamic element's height and would need different handling for wide vs narrow layouts. Absolute positioning is simpler and avoids affecting the layout math entirely.

    Investigation details

    Key code locations:

    Data flow: Debug mode enabled → NavigationTabBar renders DebugTabView above tab bar → banner takes ~40-50px of layout space → narrow layout's fixed negative margin (-72px) doesn't compensate → content pushed / blank space appears.


    Next Steps for Contributor+ team: Reply with @MelvinBot implement this to create a draft PR, @MelvinBot <your feedback> to refine this analysis, or explain why you are rejecting Melvin's proposal.

  3. added
    ExternalAdded to denote the issue can be worked on by a contributor
    on May 4, 2026
  4. added
    Help WantedApply this label when an issue is open to proposals by contributors
    on May 4, 2026
  5. melvin-bot commented on May 4, 2026

    @melvin-bot

    Triggered auto assignment to Contributor-plus team member for initial proposal review - @abzokhattab (External)

  6. MobileMage commented on May 4, 2026

    @MobileMage
    Contributor

    Proposal

    Please re-state the problem that we are trying to solve in this issue.

    When debug mode is enabled and there is a report with GBR or RBR in the LHN, the "There's a report awaiting action" debug banner appears above the navigation tab bar but pushes LHN content upward, leaving blank space at the bottom of the list.

    What is the root cause of that problem?

    NavigationTabBar renders DebugTabView and the actual tab items as siblings in a React fragment. On narrow layout, TabNavigatorBar wraps the entire NavigationTabBar with a negative marginTop (via getTabBarNarrowStyle) that is sized to exactly bottomTabHeight + safeAreaPaddingBottom. This offset is hardcoded to the height of the tab items alone — it does not account for the additional height of the DebugTabView banner. When the banner is present, the overall fragment is taller than bottomTabHeight, but the negative margin only pulls up by the tab bar height, so the extra banner height remains as unreserved vertical space that displaces the LHN list content above it.

    On wide layout the situation is similar: the <View style={styles.overflowHidden}> container in TabNavigatorBar grows to include both DebugTabView and leftNavigationTabBarContainer, but leftNavigationTabBarContainer has height: '100%' relative to its parent. Adding the banner as a sibling changes the flow of the containing column, pushing the tab container below its expected position and causing a layout gap.

    if (shouldUseNarrowLayout) {
    // Negative marginTop overlays the tab bar on content (zero flex space) to prevent layout shifts.
    return (
    <View
    style={[StyleUtils.getTabBarNarrowStyle(safeAreaPaddingBottom), isHidden && styles.opacity0]}
    pointerEvents={isHidden ? 'none' : 'auto'}
    >
    <NavigationTabBar
    selectedTab={selectedTab}
    shouldShowFloatingButtons={!isHidden}
    />
    </View>
    );

    What changes do you think we should make in order to solve the problem?

    The fix should ensure the debug banner does not contribute to the document flow in a way that displaces surrounding content. The cleanest approach is to render DebugTabView with position: 'absolute' and anchored to the top of its containing View (with a negative top offset equal to the banner's height, or using bottom: '100%'). This way the banner floats above the tab bar without adding any height to the tab bar's layout footprint, so the negative marginTop trick in TabNavigatorBar continues to work as intended for both the narrow and wide layouts.

    Concretely, in DebugTabView.tsx, the root <View> should receive position: 'absolute', bottom: '100%' (or equivalently top with a negative offset computed from the banner's measured height using onLayout), and width: '100%' so it spans the full tab bar width and rises above it without occupying any space in the normal layout flow. The parent views in NavigationTabBar/index.tsx that currently wrap DebugTabView alongside the tab items may need overflow: 'visible' (narrow layout already has this via getTabBarNarrowStyle) to prevent clipping the absolutely-positioned banner.

    return (
    <View
    testID="DebugTabView"
    style={[StyleUtils.getBackgroundColorStyle(theme.cardBG), styles.p3, styles.flexRow, styles.justifyContentBetween, styles.alignItemsCenter]}
    >
    <View style={[styles.flexRow, styles.gap2, styles.flex1, styles.alignItemsCenter]}>
    <Icon
    src={icons.DotIndicator}
    fill={indicator}
    />
    {!!message && <Text style={[StyleUtils.getColorStyle(theme.text), styles.lh20]}>{translate(message)}</Text>}
    </View>
    <Button
    text={translate('common.view')}
    onPress={navigateTo}
    />
    </View>
    );
    }

    What alternative solutions did you explore? (Optional)

    An alternative would be to make getTabBarNarrowStyle dynamically measure and account for the banner height by passing it as a parameter, adjusting the negative marginTop to -(bottomTabHeight + debugBannerHeight + safeAreaPaddingBottom). This would work on narrow layout but requires wiring onLayout measurements through multiple layers. The absolute-positioning approach is simpler, self-contained within DebugTabView, and naturally handles both narrow and wide layouts without touching the margin calculations.

  7. changed the title [-]The “There’s a report awaiting action” UI is pushing other content out, leaving blank space displayed.[/-] [+][$250] The “There’s a report awaiting action” UI is pushing other content out, leaving blank space displayed.[/+] on May 4, 2026
  8. melvin-bot commented on May 4, 2026

    @melvin-bot
  9. nabi-ebrahimi commented on May 4, 2026

    @nabi-ebrahimi

    Proposal

    What is the root cause of that problem?

    DebugTabView is rendered as a normal-flow sibling of the actual navigation tab bar in both layouts.

    On wide layout, NavigationTabBar renders DebugTabView before leftNavigationTabBarContainer:

    if (!shouldUseNarrowLayout) {
    return (
    <>
    {shouldRenderDebugTabViewOnWideLayout && (
    <DebugTabView
    selectedTab={selectedTab}
    chatTabBrickRoad={chatTabBrickRoad}
    />
    )}
    <View
    style={styles.leftNavigationTabBarContainer}
    testID="NavigationTabBar"
    >

    The vertical tab bar itself has a fixed width but the debug banner does not:

    App/src/styles/index.ts

    Lines 719 to 725 in 29928fd

    leftNavigationTabBarContainer: {
    height: '100%',
    width: variables.navigationTabBarSize,
    justifyContent: 'space-between',
    borderRightWidth: 1,
    borderRightColor: theme.border,
    backgroundColor: theme.appBG,

    Because the wide tab bar wrapper currently uses the rendered children to determine its layout footprint, the banner’s text/button row makes the whole tab bar area wider than the 64px rail, pushing the LHN to the right and leaving the blank space shown in the screenshot:

    return (
    <View style={styles.overflowHidden}>
    <NavigationTabBar selectedTab={selectedTab} />
    </View>

    On narrow layout, the same component is rendered before the bottom tab bar:

    return (
    <>
    {!!isDebugModeEnabled && (
    <DebugTabView
    selectedTab={selectedTab}
    chatTabBrickRoad={chatTabBrickRoad}
    />
    )}
    <View
    style={styles.navigationTabBarContainer}
    testID="NavigationTabBar"

    The narrow wrapper intentionally offsets only bottomTabHeight + safeAreaPaddingBottom, so the extra DebugTabView height is not part of that layout calculation:

    App/src/styles/utils/index.ts

    Lines 2301 to 2306 in 29928fd

    getTabBarNarrowStyle: (safeAreaPaddingBottom: number): ViewStyle => ({
    overflow: 'visible',
    marginTop: -(variables.bottomTabHeight + safeAreaPaddingBottom),
    paddingBottom: safeAreaPaddingBottom,
    backgroundColor: theme.appBG,
    }),

    What changes do you think we should make in order to solve the problem?

    Render DebugTabView out of normal layout flow so it can still be visible in debug mode without changing the tab bar’s measured width or height.

    Required changes:

    • Add an optional style prop to DebugTabView and apply it to the root view.
    • For wide layout, render the banner as position: absolute at top: 0, left: 0.
    • For narrow layout, render the banner as position: absolute with bottom: '100%', left: 0, and right: 0, so it sits above the bottom tab bar.
    • Make the tab bar wrapper position: relative so the absolute banner is anchored to the tab bar wrapper.
    • Use overflowVisible for the wide tab bar wrapper so the absolute debug banner can paint outside the 64px rail without increasing the rail’s layout width.

    Tests that should be added:

    • Update the NavigationTabBar UI tests to verify DebugTabView is rendered with absolute positioning when debug mode is enabled.
    • Add coverage for the wide-layout render path so the debug banner can render without changing the tab bar container’s normal layout footprint.

    The existing proposals correctly identify that the banner must not participate in normal layout flow. The missing detail is that wide and narrow layouts need different anchors: bottom: '100%' is right for the bottom tab bar, but the wide vertical rail needs a top/left absolute anchor plus visible overflow on the wide wrapper. That is why this proposal keeps the same root-cause fix but makes the layout handling explicit for both tab bar orientations.

    What alternative solutions did you explore? (Optional)

    Fixed Demo:

    Screencast.From.2026-05-05.00-13-27.mp4
  10. github-actions commented on May 4, 2026

    @github-actions
    Contributor

    ⚠️ @nabi-ebrahimi Thanks for your proposal. Please update it to follow the proposal template, as proposals are only reviewed if they follow that format (note the mandatory sections).

  11. 42 remaining items

  12. melvin-bot commented on Jul 21, 2026

    @melvin-bot

    Triggered auto assignment to @mallenexpensify (Awaiting Payment)

  13. changed the title [-][$250] The “There’s a report awaiting action” UI is pushing other content out, leaving blank space displayed.[/-] [+][Due for payment 2026-07-21] [$250] The “There’s a report awaiting action” UI is pushing other content out, leaving blank space displayed.[/+] on Jul 21, 2026
  14. melvin-bot commented on Jul 21, 2026

    @melvin-bot

    Payment Summary

    Upwork Job

    BugZero Checklist (@mallenexpensify)

    • I have verified the correct assignees and roles are listed above and updated the necessary manual offers
    • I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants/2051335767738333893/hired)
    • I have verified the PR was not reverted
    • I have applied any discounts due to bugs/regressions introduced by this PR
    • I have paid out the Upwork contracts or cancelled the ones that are incorrect
    • I have verified the payment summary above is correct
  15. mallenexpensify commented on Jul 23, 2026

    @mallenexpensify
    Contributor

    @MelvinBot payment-review
    MODE: <closed-no-pr | payment-due>
    JOB_PRICE: 250 # override if the title bounty differs

    Run the C+ payment framework for this issue and post a structured, evidence-cited
    recommendation. Rules:

    • Suggest only — never auto-pay. A human confirms.
    • Every point / adjustment MUST cite a specific comment permalink. No permalink → no point.
    • Round every %→$ result up to the nearest $25: amount = ceil((pct × JOB_PRICE) / 25) × 25.

    If MODE = closed-no-pr:

    1. Run the eligibility gate; if it fails, or the token-saving skip-gate trips
      (<~8 non-bot comments AND no C+ engagement markers, or closed <48h, or spam/invalid),
      return "$0 — skipped" with a one-line reason and STOP.
    2. Bucket the close reason (A/B/C), score the 5 factors 0–10 with permalinks.
    3. Payout = 25% of JOB_PRICE if score ≥ 8, else $0.

    If MODE = payment-due:

    1. Start at 100% of JOB_PRICE.
    2. Decreases: for any regression, read the offending PR + issue and decide if it's
      truly attributable to this author/reviewer. If yes, −50% per verified regression.
      If fault is unclear, DO NOT deduct — flag for human review.
    3. Increases: evaluate the C+ increase framework (multiple PRs, additional fixes,
      scope expansion, core-flow changes, deploy blockers audited, performance,
      test coverage, files touched), each backed by a permalink.

    Output: recommended $ amount, per-line reasoning with permalinks, confidence
    (High/Med/Low), and any manual-review flags.

  16. MelvinBot commented on Jul 23, 2026

    @MelvinBot
    Contributor

    💰 Payment Review — C+ (payment-due)

    Recommended: $125 (50% of $250) — matches the C+'s own self-assessment. Suggestion only; a human confirms.

    Being paid: abzokhattab (reviewer) — owed $250 via NewDot per the Payment Summary.

    Calculation

    Step % $
    Base (title bounty) 100% $250
    −1 verified regression (deploy blockers) −50% −$125
    Increases — $0
    Total (rounded up to nearest $25) 50% $125

    Reasoning (per line, with permalinks)

    Confidence: Medium

    The recommendation ($125) is high-confidence because it matches the reviewer's own assessment and there is a documented deploy-blocker regression tied to the DebugTabView work. Confidence is held at Medium only on the strict framework attribution, because of the item flagged below.

    🚩 Manual-review flags

    1. Possible double-counting of the penalty. The regression fixes are formally linked to separate paid jobs ([Due for payment 2026-06-29] LHN - Left navigation bar is replaced by back button after returning to home page #92327, [Due for payment 2026-06-22] Home - Left navigation bar disappears after completing onboarding #92409, and upstream [Due for payment 2026-06-09] [$250] Back button is not showing on "Hmm... it's not here" page #91831 → PR #91856), each carrying its own Awaiting Payment. If abzokhattab is already being penalized/handled for these regressions on those jobs, applying −50% here as well would double-count. Please confirm the discount is applied once.
    2. One vs. two regressions. Two distinct deploy-blocker issues ([Due for payment 2026-06-29] LHN - Left navigation bar is replaced by back button after returning to home page #92327, [Due for payment 2026-06-22] Home - Left navigation bar disappears after completing onboarding #92409) were opened. I treated them as one regression (shared root cause + single fix PR Fix fullScreenBlockingView bleeding over navigationTabBar (deploy blockers after debugTabView update) #93078 → −50% → $125). If BugZero counts them separately, it would be −100% → $0. The C+'s own read supports the single-regression / $125 outcome.

    cc @mallenexpensify

  17. mallenexpensify commented on Jul 23, 2026

    @mallenexpensify
    Contributor

    Payment Summary

    Contributor+: @abzokhattab due $125 via NewDot

    Think we're good to close

  18. quinthar commented on Aug 19, 2026

    @quinthar
    Contributor

    Approved $125 to @abzokhattab

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2ExternalAdded to denote the issue can be worked on by a contributor

Type

No type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions