Repository navigation
Deploy Checklist: New Expensify 2022-05-13 #8991
Description
Release Version: 1.1.60-2
Compare Changes: production...staging
This release contains changes from the following pull requests:
-
Use oldPolicyName report field for archived workspace chats #8436
- QA
- Accessibility
-
7486 reduce tooltip over group #8494
- QA
- Accessibility
-
Revert iOS Safari auto scrollback #8571
- QA
- Accessibility
-
Long lines in code blocks should not wrap issue (#7497) is fixed #8790
- QA
- Accessibility
-
remove hyphens, brackets from phone number #8845
- QA
- Accessibility
-
validate password complexity in the front end #8876
- QA
- Accessibility
-
Return response to fix
signInWithShortLivedToken()#8886- QA
- Accessibility
-
- QA
- Accessibility
-
Fix android navigation back #8897
- QA
- Accessibility
-
update domain room avatar and welcome-message #8898
- QA
- Accessibility
-
- QA
- Accessibility
-
Testing no dots and assistance button #8906
- QA
- Accessibility
-
Revert 3 dots and change flex styles #8909
- QA
- Accessibility
-
Revert "trying different styles" and updating react-navigation #8912
- QA
- Accessibility
-
Revert "Updating navigation packages" #8916
- QA
- Accessibility
-
Offline/Online toggle data fetch for workspace settings page #8921
- QA
- Accessibility
-
Fix unresponsive "forgot" link #8940
- QA
- Accessibility
-
Use latest expensify-common #8948
- QA
- Accessibility
-
Revert "Open old dot links with openOldDotLink() function" #8952
- QA
- Accessibility
-
Revert "Keep focus on textinput field after pressing enter when button is disabled" #8953
- QA
- Accessibility
-
[CP Staging] bind scrollToBottomAndUpdateLastRead to "this" #8957
- QA
- Accessibility
-
[No QA] Remove Permissions.canUseFreePlan #8966
- QA
- Accessibility
-
Fix connect with Plaid on mobile #8969
- QA
- Accessibility
-
- QA
- Accessibility
-
[No QA] add "Posting Ideas" section #8976
- QA
- Accessibility
-
Move Pusher to Use Encrypted Channels #8982
- QA
- Accessibility
-
Remove left over Permissions.canUseFreePlan #8993
- QA
- Accessibility
-
- QA
- Accessibility
Internal QA:
Deploy Blockers:
- Android - VBA - App is crashed after tap Connect bank account #8992
- Older report comments are not loaded once we scroll to the top - reported by @santhosh-sellavel #8994
- Web - Profile - App is crashing when hit the Enter key after searching the user #8996
- Group Chat - Unable to create group chat, app crashed #8997
- Web - Group - When user selects "Message a group user" the app will crash #9004
Deployer verifications:
- I checked the App Timing Dashboard and verified this release does not cause a noticeable performance regression.
- I checked Firebase Crashlytics and verified that this release does not introduce any new crashes.
cc @Expensify/applauseleads
Activity
neil-marcellini commentedon May 13, 2022
@thesahindia reported that #8966 breaks the bank account pages. #8993 will fix it.
chiragsalian commentedon May 13, 2022
Looks like we found a really nasty bug on production - #8994.
@Expensify/applauseleads i'm not sure how this bug was missed in the regression testing but if there is no check for this in the regression testing would you guys be able to add one now. Additionally is it possible to work on this checklist with a bit of urgency? Only because the sooner we get the checklist cleared, the sooner we can get the fix for the production issue deployed.
mvtglobally commentedon May 13, 2022
@chiragsalian We are seeing a lot of issues right now and logging them in a few min.
I will check on #8994. in a few
isagoico commentedon May 13, 2022
@chiragsalian Checked the deploy blocker issue above and we currently don't haven any regression steps that cover scrolling to the top of the conversation and verifying everything load as expected. I'm creating a ticket to add this scenario to TestRail ASAP
OSBotify commentedon May 13, 2022
👏 Heads up @Expensify/applauseleads 👏
A new pull request has been 🍒 cherry-picked 🍒 to staging, and will be deployed to staging in version
1.1.60-2🚀OSBotify commentedon May 13, 2022
🎉 All set?…You bet! @Expensify/applauseleads https://github.com/Expensify/App/releases/tag/1.1.60-2 has been deployed to staging 🎉
chiragsalian commentedon May 13, 2022
Update, the fixes for these two have been deployed to staging. Can you test and check it off the checklist when you get the chance? 🙇♂️
roryabraham commentedon May 14, 2022
Just CP'd #8998, which actually fixes three deploy blockers:
I think the common thread between all three is that you're trying to open a new chat, and when it first renders, it doesn't have a name yet, which causes a crash.
h/t @Santhosh-Sellavel
roryabraham commentedon May 14, 2022
I was able to verify #7620 on staging, checking it off
mvtglobally commentedon May 14, 2022
@chiragsalian @roryabraham Regression is complete. We are finishing up CP retests now
Deploy Blockers
#8992
#8996
#8997
#9004
PR #8436 is failing due to #9004, #9009, #9005
PR #8494 is failing due to #8997. We are retesting
PR #8948 is failing due to #9008. Not a blocker checking off
Issues logged
#8995
#9003
#9005
#9008
#9009
#9010
#9013
#9014
#9015
#9016
#9017
#9018
#9019
mvtglobally commentedon May 15, 2022
Checking off #8994, #8993, #9002
#8996
Tested #8998 and its Pass
roryabraham commentedon May 15, 2022
Looks like we may need to retest:
mvtglobally commentedon May 16, 2022
#8436 was failing due to #9004. Since its resolved, I think we can check off. Let me know what do you think @roryabraham #9009, #9005 are not blockers (same PR)
#8992 is pass, checking off
AndrewGable commentedon May 16, 2022
Looks like only one QA remains before deploying? Let me know!
mvtglobally commentedon May 16, 2022
@AndrewGable, its done.
#8436 was failing due to #9004. Since its resolved, I think we can check off. Let me know what do you think as #9009, #9005 are not blockers
AndrewGable commentedon May 16, 2022
I agree, mind checking it off and I will start the deploy? Thanks!
mvtglobally commentedon May 16, 2022
Done 🚀
AndrewGable commentedon May 16, 2022
SumitDiyora commentedon May 17, 2022
Checked all PRs on Production / Staging and created accessibility issues for all PRs where accessibility issues were found.
The non-applicable PRs are - #8571, #8886, #8898, #8901, #8909, #8912, #8916, #8966, #8976
Logged Issues - #8524 ,#8388, #8546, #8418, #8667,#8620, #8393, #8616, #8671, #8388, #8624, #8478, #8555, #8618, #8560, #8555, #8387, #8385, #8385, #8387, #8625, #8554, #8484, #8385, #8620, #8418, #8524, #8527, #8387, #8388, #8387,#8669, #8624, #8555,#8618,#8624,#8485, #8668, #8555, #8624, #8618, #8621, #8522, #8667, #8668, #8385, #8618, #8669, #8525, #8620, #8579, #8625, #8554, #8484, #8624, #8622, #8618, #8546, #8669