You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[Due for payment 2026-05-22] [Due for payment 2026-05-20] Chat - Message in expense report cannot be edited #90430
Version Number: 9.3.73-0 Reproducible in staging?: Yes Reproducible in production?: No If this was caught during regression testing, add the test name, ID and link from BrowserStack:#76741 Email or phone of affected tester (no customers):sdiosjdnjdsoidjiosj@gmail.com Issue reported by: Applause Internal Team Bug source: Exploratory - Significant User Experience Deterioration Device used: Mac 26.2 / Chrome App Component: Chat Report View
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
Identify the pull request that introduced this issue and revert it.
Classification: Frontend bug Causing PR: #76741 - "New editing mechanism for small screens" by @Kureev (High confidence) Related Issues: None
Recommendation: REVERT
PR #76741 introduced a major refactor of the message editing mechanism. The bug report describes that messages in an expense report cannot be edited (right-click > Edit message does nothing visible). The PR fundamentally changed how editing is triggered — switching from Onyx-draft-based inline editing to a new ReportActionEditMessageContext + composer-based approach on narrow layouts. This is the only PR in the StagingDeployCash that touches message editing behavior, and the symptom (edit action not working) is a direct consequence of the changed edit initiation flow. The issue is staging-only and not reproducible in production, confirming it was introduced by this staging PR.
Assigned: @Kureev (PR author), @adhorodyski@mountiny (approving reviewers from PR #76741) Labels: Keeping DeployBlockerCash (Frontend App bug). Removing DeployBlocker since this is a frontend issue requiring an App fix, not a backend fix.
The bug is reproducible on staging only (not production), confirming it was introduced in this staging deploy cycle.
The PR title is "New editing mechanism for small screens" — it directly changes message editing behavior, which is exactly what the bug report describes as broken.
The bug steps reproduce on MacOS/Chrome, which is treated as a "wide layout" by the app. However, PR New editing mechanism for small screens #76741 changed multiple shared paths including ContextMenuActions.tsx (the right-click context menu), ReportActionEditMessageContext.tsx (new context provider for edit state), ComposerProvider.tsx, and ComposerWithSuggestions.tsx, all of which are involved in the edit flow on all screen sizes.
Verification
Affected files in the codebase: src/pages/inbox/report/ContextMenu/ContextMenuActions.tsx, src/pages/inbox/report/ReportActionEditMessageContext.tsx, src/pages/inbox/report/ReportActionCompose/ComposerProvider.tsx
ContextMenuActions.tsx line 569-580: The editAction function now calls saveReportActionDraft which writes a draft to Onyx, relying on the new ReportActionEditMessageContext to pick it up and display the edit UI. If this context or the draft detection logic has a bug, the edit silently fails to display.
ReportActionEditMessageContext.tsx: New file introduced by this PR. It reads drafts from Onyx and drives the edit state. Any issue with how it reads the current report's drafts would prevent the edit mode from activating.
Root Cause
The PR replaced the previous inline editing mechanism (which directly set edit mode on the ReportActionItemMessageEdit component) with an indirect flow: right-clicking "Edit" now saves a draft to Onyx, and a new context provider (ReportActionEditMessageContext) detects that draft and populates the composer edit state. If the context provider fails to detect the draft for the current report (e.g., due to a bug in the reportDrafts lookup, the ancestorWithDraft logic, or the editingState state machine), the edit mode never activates — which is the observed symptom (message cannot be edited). The bug appears to affect expense report messages specifically, suggesting the isMoneyRequestAction check or the ancestor/child report ID lookup has a regression.
changed the title [-]Chat - Message in expense report cannot be edited[/-][+][Due for payment 2026-05-20] Chat - Message in expense report cannot be edited[/+]on May 13, 2026
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.3.73-4 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
@hungvu193 The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]
changed the title [-][Due for payment 2026-05-20] Chat - Message in expense report cannot be edited[/-][+][Due for payment 2026-05-22] [Due for payment 2026-05-20] Chat - Message in expense report cannot be edited[/+]on May 15, 2026
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.3.74-7 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
@hungvu193 The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]
Activity
melvin-bot commentedon May 13, 2026
You have been assigned to this deploy blocker because you recently merged this PR: #76741
melvin-bot commentedon May 13, 2026
💬 A slack conversation has been started in #expensify-open-source
github-actions commentedon May 13, 2026
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
OSBotify commentedon May 13, 2026
Investigation Summary
Classification: Frontend bug
Causing PR: #76741 - "New editing mechanism for small screens" by @Kureev (High confidence)
Related Issues: None
Recommendation: REVERT
PR #76741 introduced a major refactor of the message editing mechanism. The bug report describes that messages in an expense report cannot be edited (right-click > Edit message does nothing visible). The PR fundamentally changed how editing is triggered — switching from Onyx-draft-based inline editing to a new
ReportActionEditMessageContext+ composer-based approach on narrow layouts. This is the only PR in the StagingDeployCash that touches message editing behavior, and the symptom (edit action not working) is a direct consequence of the changed edit initiation flow. The issue is staging-only and not reproducible in production, confirming it was introduced by this staging PR.Assigned: @Kureev (PR author), @adhorodyski @mountiny (approving reviewers from PR #76741)
Labels: Keeping
DeployBlockerCash(Frontend App bug). RemovingDeployBlockersince this is a frontend issue requiring an App fix, not a backend fix.Detailed Analysis
Evidence
ContextMenuActions.tsx(the right-click context menu),ReportActionEditMessageContext.tsx(new context provider for edit state),ComposerProvider.tsx, andComposerWithSuggestions.tsx, all of which are involved in the edit flow on all screen sizes.Verification
src/pages/inbox/report/ContextMenu/ContextMenuActions.tsx,src/pages/inbox/report/ReportActionEditMessageContext.tsx,src/pages/inbox/report/ReportActionCompose/ComposerProvider.tsxContextMenuActions.tsxline 569-580: TheeditActionfunction now callssaveReportActionDraftwhich writes a draft to Onyx, relying on the newReportActionEditMessageContextto pick it up and display the edit UI. If this context or the draft detection logic has a bug, the edit silently fails to display.ReportActionEditMessageContext.tsx: New file introduced by this PR. It reads drafts from Onyx and drives the edit state. Any issue with how it reads the current report's drafts would prevent the edit mode from activating.Root Cause
The PR replaced the previous inline editing mechanism (which directly set edit mode on the
ReportActionItemMessageEditcomponent) with an indirect flow: right-clicking "Edit" now saves a draft to Onyx, and a new context provider (ReportActionEditMessageContext) detects that draft and populates the composer edit state. If the context provider fails to detect the draft for the current report (e.g., due to a bug in thereportDraftslookup, theancestorWithDraftlogic, or theeditingStatestate machine), the edit mode never activates — which is the observed symptom (message cannot be edited). The bug appears to affect expense report messages specifically, suggesting theisMoneyRequestActioncheck or the ancestor/child report ID lookup has a regression.18 remaining items
[-]Chat - Message in expense report cannot be edited[/-][+][Due for payment 2026-05-20] Chat - Message in expense report cannot be edited[/+]melvin-bot commentedon May 13, 2026
Reviewinglabel has been removed, please complete the "BugZero Checklist".melvin-bot commentedon May 13, 2026
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.3.73-4 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2026-05-20. 🎊
For reference, here are some details about the assignees on this issue:
melvin-bot commentedon May 13, 2026
@hungvu193 The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]
[-][Due for payment 2026-05-20] Chat - Message in expense report cannot be edited[/-][+][Due for payment 2026-05-22] [Due for payment 2026-05-20] Chat - Message in expense report cannot be edited[/+]melvin-bot commentedon May 15, 2026
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.3.74-7 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2026-05-22. 🎊
For reference, here are some details about the assignees on this issue:
melvin-bot commentedon May 15, 2026
@hungvu193 The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]
melvin-bot commentedon May 15, 2026
If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.
If a regression has occurred and you are the assigned CM follow the instructions here.
If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.
lanitochka17 commentedon May 15, 2026
Deploy Blocker ##90841 was identified to be related to the PR ##90516 that attempted to fix this issue.
melvin-bot commentedon May 15, 2026
If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.
If a regression has occurred and you are the assigned CM follow the instructions here.
If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.
melvin-bot commentedon May 16, 2026
If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.
If a regression has occurred and you are the assigned CM follow the instructions here.
If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.
melvin-bot commentedon May 16, 2026
If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.
If a regression has occurred and you are the assigned CM follow the instructions here.
If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.
jponikarchuk commentedon May 16, 2026
Deploy Blocker #90889 was identified to be related to the PR #90516 that attempted to fix this issue.
melvin-bot commentedon May 16, 2026
If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.
If a regression has occurred and you are the assigned CM follow the instructions here.
If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.
lanitochka17 commentedon May 16, 2026
Deploy Blocker ##90891 was identified to be related to the PR ##90516 that attempted to fix this issue