Skip to content

[Due for payment 2026-05-26] [Due for payment 2026-05-26] iOS - Chat - Main composer contains the edited message after editing message with typo #90851

Closed

Description

@mitarachim

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 9.3.74-7
Reproducible in staging?: Yes
Reproducible in production?: N/A - new feature, doesn't exist in prod
If this was caught during regression testing, add the test name, ID and link from BrowserStack: #90516
Email or phone of affected tester (no customers): sdsdjoijdoisnjodis@gmail.com
Issue reported by: Applause Internal Team
Bug source: Exploratory - Significant User Experience Deterioration
Device used: iPhone 15 Pro Max / iOS 26.4.2
App Component: Chat Report View

Action Performed:

  1. Launch Expensify app.
  2. Go to any chat.
  3. Send a message.
  4. Long tap on the message > Edit comment.
  5. Type a wrong word that will trigger autocorrect (eg, therr).
  6. Tap Send button.

Expected Result:

Main composer will not contain the edited message after editing message with typo.

Actual Result:

Main composer contains the edited message after editing message with typo.

Workaround:

Unknown

Platforms:

  • Android: App
  • Android: mWeb Chrome
  • iOS: App
  • iOS: mWeb Safari
  • iOS: mWeb Chrome
  • Windows: Chrome
  • MacOS: Chrome / Safari

Screenshots/Videos

Bug7155322_1778867607137.ScreenRecording_05-16-2026_2.mp4

View all open jobs on GitHub

Issue OwnerCurrent Issue Owner: @hungvu193

Activity

  1. added
    DeployBlockerCashThis issue or pull request should block deployment
    BugSomething is broken. Auto assigns a BugZero manager.
    on May 16, 2026
  2. melvin-bot commented on May 16, 2026

    @melvin-bot

    @mountiny recently merged #90516, but they are OOO right now, so I'll auto-assign someone else.

  3. melvin-bot commented on May 16, 2026

    @melvin-bot

    Triggered auto assignment to @deetergp (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

  4. melvin-bot commented on May 16, 2026

    @melvin-bot

    💬 A slack conversation has been started in #expensify-open-source

  5. github-actions commented on May 16, 2026

    @github-actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  6. OSBotify commented on May 16, 2026

    @OSBotify
    Contributor

    🔍 Investigation Summary

    Classification: Frontend bug
    Causing PR: #90516 - "Allow editing messages in Composer on narrow screens V2" by @chrispader (High confidence)
    Related Issues: #64085, #90512, #90444, #90492, #90435, #90433, #90431, #90430

    Recommendation: REVERT

    PR #90516 is the second attempt at this feature (V2) and has already produced a fresh deploy blocker; reverting it will unblock the staging deploy while the iOS autocorrect race condition is investigated and fixed properly.

    Assigned: @chrispader (PR author), @hungvu193, @mountiny (approving reviewers)
    Labels: DeployBlockerCash retained — this is a frontend bug introduced by an App PR; no label changes needed.

    📋 Detailed Analysis

    Evidence

    Verification

    Root Cause

    PR #90516 routes message editing through the main bottom composer on narrow (mobile) layouts. When the user taps Send after typing a word that will be autocorrected by iOS, the send button handler fires first (submitDraftAndClearComposer in useComposerSubmit.ts), submitting the pre-autocorrect text and returning early — without calling clearComposer() — because isFinishingComposerEdit is true. The edit state transitions to SUBMITTED/OFF, which causes useEditComposerToggle to restore the previous draft comment value. However, iOS autocorrect fires its onChangeText callback asynchronously after this sequence, overwriting the restored draft with the autocorrected text from the just-completed edit session. The result is that the main composer ends up populated with the corrected editing message instead of the user's original draft (or empty state).

  7. 5 remaining items

  8. m-natarajan commented on May 18, 2026

    @m-natarajan

    Not repro, iPhone 13 / iOS 26.5, v9.3.75-2

    typo.MP4
  9. added and removed
    DeployBlockerCashThis issue or pull request should block deployment
    on May 18, 2026
  10. changed the title [-]iOS - Chat - Main composer contains the edited message after editing message with typo[/-] [+][Due for payment 2026-05-26] iOS - Chat - Main composer contains the edited message after editing message with typo[/+] on May 19, 2026
  11. melvin-bot commented on May 19, 2026

    @melvin-bot

    Reviewing label has been removed, please complete the "BugZero Checklist".

  12. melvin-bot commented on May 19, 2026

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 9.3.75-14 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2026-05-26. 🎊

    For reference, here are some details about the assignees on this issue:

    • @hungvu193 requires payment through NewDot Manual Requests
    • @chrispader does not require payment (Contractor)
  13. melvin-bot commented on May 19, 2026

    @melvin-bot

    @hungvu193 The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

  14. changed the title [-][Due for payment 2026-05-26] iOS - Chat - Main composer contains the edited message after editing message with typo[/-] [+][Due for payment 2026-05-26] [Due for payment 2026-05-26] iOS - Chat - Main composer contains the edited message after editing message with typo[/+] on May 19, 2026
  15. melvin-bot commented on May 19, 2026

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 9.3.77-3 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2026-05-26. 🎊

    For reference, here are some details about the assignees on this issue:

    • @hungvu193 requires payment through NewDot Manual Requests
    • @chrispader does not require payment (Contractor)
  16. melvin-bot commented on May 19, 2026

    @melvin-bot

    @hungvu193 The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

BugSomething is broken. Auto assigns a BugZero manager.DailyKSv2Engineering

Type

No type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions