You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[Due for payment 2026-05-26] [Due for payment 2026-05-26] iOS - Chat - Main composer contains the edited message after editing message with typo #90851
Version Number: 9.3.74-7 Reproducible in staging?: Yes Reproducible in production?: N/A - new feature, doesn't exist in prod If this was caught during regression testing, add the test name, ID and link from BrowserStack:#90516 Email or phone of affected tester (no customers):sdsdjoijdoisnjodis@gmail.com Issue reported by: Applause Internal Team Bug source: Exploratory - Significant User Experience Deterioration Device used: iPhone 15 Pro Max / iOS 26.4.2 App Component: Chat Report View
Action Performed:
Launch Expensify app.
Go to any chat.
Send a message.
Long tap on the message > Edit comment.
Type a wrong word that will trigger autocorrect (eg, therr).
Tap Send button.
Expected Result:
Main composer will not contain the edited message after editing message with typo.
Actual Result:
Main composer contains the edited message after editing message with typo.
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
Identify the pull request that introduced this issue and revert it.
PR #90516 is the second attempt at this feature (V2) and has already produced a fresh deploy blocker; reverting it will unblock the staging deploy while the iOS autocorrect race condition is investigated and fixed properly.
Assigned: @chrispader (PR author), @hungvu193, @mountiny (approving reviewers) Labels: DeployBlockerCash retained — this is a frontend bug introduced by an App PR; no label changes needed.
📋 Detailed Analysis
Evidence
The issue body directly references PR Allow editing messages in Composer on narrow screens V2 #90516 as the related PR, and the melvin-bot auto-comment confirms @mountiny recently merged https://github.com/Expensify/App/pull/90516.
The bug is marked "N/A - new feature, doesn't exist in prod", meaning it is staging-only and directly tied to changes in this PR.
This PR is explicitly described as a re-application of PR New editing mechanism for small screens #76741 (which was previously reverted due to deploy blockers) with fixes for those blockers. It is now producing a new deploy blocker.
PR Allow editing messages in Composer on narrow screens V2 #90516 modifies src/pages/inbox/report/ReportActionCompose/useEditComposerToggle.ts (157 additions, new file), src/pages/inbox/report/ReportActionCompose/useComposerSubmit.ts (63 additions), and src/pages/inbox/report/ReportActionCompose/ComposerWithSuggestions.tsx (265 additions / 167 deletions) — exactly the files responsible for the reported behavior.
PR Allow editing messages in Composer on narrow screens V2 #90516 also introduces src/pages/inbox/report/ReportActionCompose/updateNativeTextInputValue/index.ios.ts, which calls setNativeProps({text}) on the iOS text input — a mechanism that can interact with iOS autocorrect.
Root Cause
PR #90516 routes message editing through the main bottom composer on narrow (mobile) layouts. When the user taps Send after typing a word that will be autocorrected by iOS, the send button handler fires first (submitDraftAndClearComposer in useComposerSubmit.ts), submitting the pre-autocorrect text and returning early — without calling clearComposer() — because isFinishingComposerEdit is true. The edit state transitions to SUBMITTED/OFF, which causes useEditComposerToggle to restore the previous draft comment value. However, iOS autocorrect fires its onChangeText callback asynchronously after this sequence, overwriting the restored draft with the autocorrected text from the just-completed edit session. The result is that the main composer ends up populated with the corrected editing message instead of the user's original draft (or empty state).
changed the title [-]iOS - Chat - Main composer contains the edited message after editing message with typo[/-][+][Due for payment 2026-05-26] iOS - Chat - Main composer contains the edited message after editing message with typo[/+]on May 19, 2026
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.3.75-14 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
@hungvu193 The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]
changed the title [-][Due for payment 2026-05-26] iOS - Chat - Main composer contains the edited message after editing message with typo[/-][+][Due for payment 2026-05-26] [Due for payment 2026-05-26] iOS - Chat - Main composer contains the edited message after editing message with typo[/+]on May 19, 2026
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.3.77-3 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
@hungvu193 The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]
Activity
melvin-bot commentedon May 16, 2026
@mountiny recently merged #90516, but they are OOO right now, so I'll auto-assign someone else.
melvin-bot commentedon May 16, 2026
Triggered auto assignment to @deetergp (
DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.melvin-bot commentedon May 16, 2026
💬 A slack conversation has been started in #expensify-open-source
github-actions commentedon May 16, 2026
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
OSBotify commentedon May 16, 2026
🔍 Investigation Summary
Classification: Frontend bug
Causing PR: #90516 - "Allow editing messages in Composer on narrow screens V2" by @chrispader (High confidence)
Related Issues: #64085, #90512, #90444, #90492, #90435, #90433, #90431, #90430
Recommendation: REVERT
PR #90516 is the second attempt at this feature (V2) and has already produced a fresh deploy blocker; reverting it will unblock the staging deploy while the iOS autocorrect race condition is investigated and fixed properly.
Assigned: @chrispader (PR author), @hungvu193, @mountiny (approving reviewers)
Labels:
DeployBlockerCashretained — this is a frontend bug introduced by an App PR; no label changes needed.📋 Detailed Analysis
Evidence
@mountiny recently merged https://github.com/Expensify/App/pull/90516.9.3.74-7.StagingDeployCashchecklist (chronological position Add unread message indicator to browser tab #91 of 106).Verification
ComposerWithSuggestions.tsx,useEditComposerToggle.ts,useComposerSubmit.ts) — all of which are heavily modified by PR Allow editing messages in Composer on narrow screens V2 #90516.src/pages/inbox/report/ReportActionCompose/useEditComposerToggle.ts(157 additions, new file),src/pages/inbox/report/ReportActionCompose/useComposerSubmit.ts(63 additions), andsrc/pages/inbox/report/ReportActionCompose/ComposerWithSuggestions.tsx(265 additions / 167 deletions) — exactly the files responsible for the reported behavior.src/pages/inbox/report/ReportActionCompose/updateNativeTextInputValue/index.ios.ts, which callssetNativeProps({text})on the iOS text input — a mechanism that can interact with iOS autocorrect.Root Cause
PR #90516 routes message editing through the main bottom composer on narrow (mobile) layouts. When the user taps Send after typing a word that will be autocorrected by iOS, the send button handler fires first (
submitDraftAndClearComposerinuseComposerSubmit.ts), submitting the pre-autocorrect text and returning early — without callingclearComposer()— becauseisFinishingComposerEditis true. The edit state transitions toSUBMITTED/OFF, which causesuseEditComposerToggleto restore the previous draft comment value. However, iOS autocorrect fires itsonChangeTextcallback asynchronously after this sequence, overwriting the restored draft with the autocorrected text from the just-completed edit session. The result is that the main composer ends up populated with the corrected editing message instead of the user's original draft (or empty state).5 remaining items
m-natarajan commentedon May 18, 2026
Not repro, iPhone 13 / iOS 26.5, v9.3.75-2
typo.MP4
[-]iOS - Chat - Main composer contains the edited message after editing message with typo[/-][+][Due for payment 2026-05-26] iOS - Chat - Main composer contains the edited message after editing message with typo[/+]melvin-bot commentedon May 19, 2026
Reviewinglabel has been removed, please complete the "BugZero Checklist".melvin-bot commentedon May 19, 2026
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.3.75-14 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2026-05-26. 🎊
For reference, here are some details about the assignees on this issue:
melvin-bot commentedon May 19, 2026
@hungvu193 The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]
[-][Due for payment 2026-05-26] iOS - Chat - Main composer contains the edited message after editing message with typo[/-][+][Due for payment 2026-05-26] [Due for payment 2026-05-26] iOS - Chat - Main composer contains the edited message after editing message with typo[/+]melvin-bot commentedon May 19, 2026
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.3.77-3 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2026-05-26. 🎊
For reference, here are some details about the assignees on this issue:
melvin-bot commentedon May 19, 2026
@hungvu193 The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]