You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[Due for payment 2026-05-22] [Due for payment 2026-05-20] Chat - When editing message for second time, Create button is shown instead of Cancel button #90435
Version Number: 9.3.73-0 Reproducible in staging?: Yes Reproducible in production?: No If this was caught during regression testing, add the test name, ID and link from BrowserStack:#76741 Email or phone of affected tester (no customers):sdiosjdnjdsoidjiosj@gmail.com Issue reported by: Applause Internal Team Bug source: Exploratory - Significant User Experience Deterioration Device used: Mac 26.2 / Chrome App Component: Chat Report View
Action Performed:
Go to staging.new.expensify.com
Go to workspace chat.
Send the message.
Resize screen to narrow (skip this step on narrow screen such as mweb and native apps).
Right click on the message > Edit message.
Click Send button.
Right click on the message > Edit message.
Expected Result:
Cancel button will be shown on the edit composer.
Actual Result:
When editing message for the second time, Create button is shown instead of Cancel button.
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
Identify the pull request that introduced this issue and revert it.
Classification: Frontend bug Causing PR: #76741 - "Adapt message editing behavior based on screen size (Slack-style UX)" by @Kureev (High confidence) Related Issues: None
Recommendation: REVERT
PR #76741 introduced a significant refactor of the message editing flow, and the state management for isEditingInComposer does not correctly handle the wide-screen second-edit scenario, causing the Send/Create button to appear in place of the Cancel button.
Assigned: @Kureev (PR author), @hungvu193@adhorodyski@mountiny (approving reviewers) from PR #76741 only Labels: DeployBlockerCash kept (frontend App PR is the cause). DeployBlocker not present, no change needed.
src/pages/inbox/report/ReportActionCompose/ComposerProvider.tsx — introduced isEditingInComposer logic and didResetComposerHeight state
src/pages/inbox/report/ReportActionCompose/ReportActionCompose.tsx — conditionally renders ComposerEditingButtons (Cancel) vs ComposerActionMenu (Create/Send) based on isEditingInComposer
src/pages/inbox/report/ReportActionCompose/ComposerEditingButtons.tsx — new file, only shown when isEditingInComposer is true
src/pages/inbox/report/ReportActionCompose/useEditComposerToggle.ts — new file, manages edit state transitions in the composer
src/pages/inbox/report/ReportActionEditMessageContext.tsx — modified to track editingState as 'off' | 'editing' | 'submitted'
Root Cause
In ComposerProvider.tsx, isEditingInComposer is computed as:
On wide screens (desktop Chrome/Mac), shouldUseNarrowLayout is false, so isEditingInComposer is always false. In ReportActionCompose.tsx, the Cancel button row (ComposerEditingButtons) is only rendered when isEditingInComposer is true:
This means on wide layouts the Cancel button is never shown via the main composer — intentionally, as wide layout is supposed to use inline editing in the message list. However, the PR introduced a state leak: after the first edit completes and the inline editor closes, the editingState in ReportActionEditMessageContext (which is driven by Onyx draft state) does not fully reset between the first and second edit invocation for the second right-click. As a result, on the second right-click > Edit message, the main composer ends up displaying the Send button (the ActionMenu path) rather than the Cancel button, because the inline message edit component (ReportActionItemMessageEdit) either is not rendered or does not show its own Cancel button in the second-edit scenario.
The refactor in PR #76741 fundamentally changed how wide-screen editing state is managed — removing the per-message inline draft from driving the compose input visibility, and introducing a centralized editingState machine. The second-edit bug is a regression in this state machine where editingState becomes 'editing' in a path that renders the main composer's Send button rather than the inline Cancel button.
changed the title [-]Chat - When editing message for second time, Create button is shown instead of Cancel button[/-][+][Due for payment 2026-05-20] Chat - When editing message for second time, Create button is shown instead of Cancel button[/+]on May 13, 2026
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.3.73-4 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
@hungvu193 The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]
changed the title [-][Due for payment 2026-05-20] Chat - When editing message for second time, Create button is shown instead of Cancel button[/-][+][Due for payment 2026-05-22] [Due for payment 2026-05-20] Chat - When editing message for second time, Create button is shown instead of Cancel button[/+]on May 15, 2026
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.3.74-7 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
@hungvu193 The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]
Activity
melvin-bot commentedon May 13, 2026
You have been assigned to this deploy blocker because you recently merged this PR: #76741
melvin-bot commentedon May 13, 2026
💬 A slack conversation has been started in #expensify-open-source
github-actions commentedon May 13, 2026
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
mountiny commentedon May 13, 2026
@MelvinBot Can you investigate this bug and propose minimal fix
OSBotify commentedon May 13, 2026
Investigation Summary
Classification: Frontend bug
Causing PR: #76741 - "Adapt message editing behavior based on screen size (Slack-style UX)" by @Kureev (High confidence)
Related Issues: None
Recommendation: REVERT
PR #76741 introduced a significant refactor of the message editing flow, and the state management for
isEditingInComposerdoes not correctly handle the wide-screen second-edit scenario, causing the Send/Create button to appear in place of the Cancel button.Assigned: @Kureev (PR author), @hungvu193 @adhorodyski @mountiny (approving reviewers) from PR #76741 only
Labels:
DeployBlockerCashkept (frontend App PR is the cause).DeployBlockernot present, no change needed.Details
Evidence
StagingDeployCashfor version9.3.73-0, which matches the version in the bug report.isEditingInComposer.Verification
Affected files modified by PR #76741:
src/pages/inbox/report/ReportActionCompose/ComposerProvider.tsx— introducedisEditingInComposerlogic anddidResetComposerHeightstatesrc/pages/inbox/report/ReportActionCompose/ReportActionCompose.tsx— conditionally rendersComposerEditingButtons(Cancel) vsComposerActionMenu(Create/Send) based onisEditingInComposersrc/pages/inbox/report/ReportActionCompose/ComposerEditingButtons.tsx— new file, only shown whenisEditingInComposeris truesrc/pages/inbox/report/ReportActionCompose/useEditComposerToggle.ts— new file, manages edit state transitions in the composersrc/pages/inbox/report/ReportActionEditMessageContext.tsx— modified to trackeditingStateas'off' | 'editing' | 'submitted'Root Cause
In
ComposerProvider.tsx,isEditingInComposeris computed as:On wide screens (desktop Chrome/Mac),
shouldUseNarrowLayoutisfalse, soisEditingInComposeris alwaysfalse. InReportActionCompose.tsx, the Cancel button row (ComposerEditingButtons) is only rendered whenisEditingInComposeristrue:This means on wide layouts the Cancel button is never shown via the main composer — intentionally, as wide layout is supposed to use inline editing in the message list. However, the PR introduced a state leak: after the first edit completes and the inline editor closes, the
editingStateinReportActionEditMessageContext(which is driven by Onyx draft state) does not fully reset between the first and second edit invocation for the second right-click. As a result, on the second right-click > Edit message, the main composer ends up displaying the Send button (the ActionMenu path) rather than the Cancel button, because the inline message edit component (ReportActionItemMessageEdit) either is not rendered or does not show its own Cancel button in the second-edit scenario.The refactor in PR #76741 fundamentally changed how wide-screen editing state is managed — removing the per-message inline draft from driving the compose input visibility, and introducing a centralized
editingStatemachine. The second-edit bug is a regression in this state machine whereeditingStatebecomes'editing'in a path that renders the main composer's Send button rather than the inline Cancel button.10 remaining items
m-natarajan commentedon May 13, 2026
Passed, Chrome / v9.3.73-3 PR:90516
REC-20260513225314.mp4
[-]Chat - When editing message for second time, Create button is shown instead of Cancel button[/-][+][Due for payment 2026-05-20] Chat - When editing message for second time, Create button is shown instead of Cancel button[/+]melvin-bot commentedon May 13, 2026
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.3.73-4 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2026-05-20. 🎊
For reference, here are some details about the assignees on this issue:
melvin-bot commentedon May 13, 2026
@hungvu193 The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]
[-][Due for payment 2026-05-20] Chat - When editing message for second time, Create button is shown instead of Cancel button[/-][+][Due for payment 2026-05-22] [Due for payment 2026-05-20] Chat - When editing message for second time, Create button is shown instead of Cancel button[/+]melvin-bot commentedon May 15, 2026
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.3.74-7 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2026-05-22. 🎊
For reference, here are some details about the assignees on this issue:
melvin-bot commentedon May 15, 2026
@hungvu193 The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]
melvin-bot commentedon May 15, 2026
If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.
If a regression has occurred and you are the assigned CM follow the instructions here.
If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.
lanitochka17 commentedon May 15, 2026
Deploy Blocker ##90841 was identified to be related to the PR ##90516 that attempted to fix this issue.
melvin-bot commentedon May 15, 2026
If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.
If a regression has occurred and you are the assigned CM follow the instructions here.
If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.
melvin-bot commentedon May 16, 2026
If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.
If a regression has occurred and you are the assigned CM follow the instructions here.
If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.
melvin-bot commentedon May 16, 2026
If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.
If a regression has occurred and you are the assigned CM follow the instructions here.
If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.
jponikarchuk commentedon May 16, 2026
Deploy Blocker #90889 was identified to be related to the PR #90516 that attempted to fix this issue.
melvin-bot commentedon May 16, 2026
If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.
If a regression has occurred and you are the assigned CM follow the instructions here.
If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.
lanitochka17 commentedon May 16, 2026
Deploy Blocker ##90891 was identified to be related to the PR ##90516 that attempted to fix this issue