You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[Due for payment 2026-05-26] [Due for payment 2026-05-22] [Due for payment 2026-05-20] [$250] iOS - Login - Onboarding does not appear after creating a new account #90440
Version Number: 9.3.73-0 Reproducible in staging?: Yes Reproducible in production?: No If this was caught during regression testing, add the test name, ID and link from BrowserStack:#89927 Email or phone of affected tester (no customers):sdsdjoijdoisnjodis@gmail.com Issue reported by: Applause Internal Team Bug source: Exploratory - Significant User Experience Deterioration Device used: iPhone 15 Pro Max / iOS 26.4.2 App Component: Other
Action Performed:
Launch Expensify app.
Log in.
Log out.
Log in with a new Gmail account.
Expected Result:
Onboarding will show up.
Actual Result:
Onboarding does not show up.
It only shows up after tapping New workspace on workspaces tab or relaunching the app.
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
Identify the pull request that introduced this issue and revert it.
PR #89927 replaced InteractionManager.runAfterInteractions with TransitionTracker.runAfterTransitions in useOnboardingFlow.ts. These two APIs have a critical behavioral difference:
InteractionManager.runAfterInteractions: Always schedules callbacks asynchronously (at minimum next microtask), even when no interactions are pending. This means the callback can be reliably cancelled by the useEffect cleanup before it executes, and only fires once values have stabilized.
TransitionTracker.runAfterTransitions: Fires callbacks synchronously when no transitions are active (TransitionTracker.ts:143-145). The callback executes during every useEffect run and returns a no-op cancel handle.
Additionally, ScreenLayout does not call endTransition when a screen unmounts — it only removes the event listeners. If transitionStart fired before unmount, the transition handle becomes orphaned in activeTransitions until the 1000ms safety timeout. During this window, runAfterTransitions queues callbacks that get repeatedly cancelled and re-queued as the useEffect re-runs due to Onyx value changes.
On iOS during the logout→login flow, this timing mismatch means the onboarding callback either (a) fires synchronously during early effect runs when guard conditions (isLoadingApp, isOnboardingCompleted) haven't settled, or (b) gets queued behind an orphaned transition and flushed with stale closure values. Either way, startOnboardingFlow is never called.
What changes do you think we should make in order to solve the problem?
Revert the InteractionManager → TransitionTracker change in useOnboardingFlow.ts, restoring the original InteractionManager.runAfterInteractions call. The onboarding hook depends on the async scheduling behavior to work correctly with the cancel-and-requeue pattern in its useEffect.
Additionally, fix ScreenLayout.tsx cleanup to end any active transition on unmount:
What alternative solutions did you explore? (Optional)
Making TransitionTracker.runAfterTransitions always asynchronous (wrapping the immediate callback in queueMicrotask) to match InteractionManager's behavior. This would fix this hook but could change behavior for other callers.
Only reverting the useOnboardingFlow.ts change while keeping the BaseOnboardingInterestedFeatures.tsx change (which uses waitForUpcomingTransition: true and may not have the same issue).
TransitionTracker.runAfterTransitions fires synchronously when activeTransitions.size === 0 (line 143), unlike InteractionManager which always defers
ScreenLayout registers transitionStart → startTransition() but cleanup only removes listeners without calling endTransition() — orphaning the transition handle
The useOnboardingFlow useEffect has ~20 dependencies that change during login, causing rapid re-runs where callbacks are cancelled and re-created
The symptom ("shows after tapping New workspace or relaunching") matches: a user action triggers a new effect run that resolves correctly, and a relaunch gives a clean slate
Possibly related issue:#84436 (onboarding modal not showing for invited members who haven't completed onboarding)
Next Steps for Contributor+ team: Reply with @MelvinBot implement this to create a draft PR, @MelvinBot <your feedback> to refine this analysis, or explain why you are rejecting Melvin's proposal.
changed the title [-][$250] iOS - Login - Onboarding does not appear after creating a new account[/-][+][Due for payment 2026-05-20] [$250] iOS - Login - Onboarding does not appear after creating a new account[/+]on May 13, 2026
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.3.73-4 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
@eh2077 The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]
changed the title [-][Due for payment 2026-05-20] [$250] iOS - Login - Onboarding does not appear after creating a new account[/-][+][Due for payment 2026-05-22] [Due for payment 2026-05-20] [$250] iOS - Login - Onboarding does not appear after creating a new account[/+]on May 15, 2026
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.3.74-7 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
@eh2077 The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]
changed the title [-][Due for payment 2026-05-22] [Due for payment 2026-05-20] [$250] iOS - Login - Onboarding does not appear after creating a new account[/-][+][Due for payment 2026-05-26] [Due for payment 2026-05-22] [Due for payment 2026-05-20] [$250] iOS - Login - Onboarding does not appear after creating a new account[/+]on May 19, 2026
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.3.77-3 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
@eh2077 The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]
Activity
melvin-bot commentedon May 13, 2026
You have been assigned to this deploy blocker because you recently merged this PR: #89927
melvin-bot commentedon May 13, 2026
💬 A slack conversation has been started in #expensify-open-source
github-actions commentedon May 13, 2026
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
MelvinBot commentedon May 13, 2026
Proposal
What is the root cause of that problem?
PR #89927 replaced
InteractionManager.runAfterInteractionswithTransitionTracker.runAfterTransitionsinuseOnboardingFlow.ts. These two APIs have a critical behavioral difference:InteractionManager.runAfterInteractions: Always schedules callbacks asynchronously (at minimum next microtask), even when no interactions are pending. This means the callback can be reliably cancelled by theuseEffectcleanup before it executes, and only fires once values have stabilized.TransitionTracker.runAfterTransitions: Fires callbacks synchronously when no transitions are active (TransitionTracker.ts:143-145). The callback executes during everyuseEffectrun and returns a no-op cancel handle.Additionally,
ScreenLayoutdoes not callendTransitionwhen a screen unmounts — it only removes the event listeners. IftransitionStartfired before unmount, the transition handle becomes orphaned inactiveTransitionsuntil the 1000ms safety timeout. During this window,runAfterTransitionsqueues callbacks that get repeatedly cancelled and re-queued as theuseEffectre-runs due to Onyx value changes.On iOS during the logout→login flow, this timing mismatch means the onboarding callback either (a) fires synchronously during early effect runs when guard conditions (
isLoadingApp,isOnboardingCompleted) haven't settled, or (b) gets queued behind an orphaned transition and flushed with stale closure values. Either way,startOnboardingFlowis never called.What changes do you think we should make in order to solve the problem?
Revert the
InteractionManager→TransitionTrackerchange inuseOnboardingFlow.ts, restoring the originalInteractionManager.runAfterInteractionscall. The onboarding hook depends on the async scheduling behavior to work correctly with the cancel-and-requeue pattern in itsuseEffect.Additionally, fix
ScreenLayout.tsxcleanup to end any active transition on unmount:What alternative solutions did you explore? (Optional)
TransitionTracker.runAfterTransitionsalways asynchronous (wrapping the immediate callback inqueueMicrotask) to matchInteractionManager's behavior. This would fix this hook but could change behavior for other callers.useOnboardingFlow.tschange while keeping theBaseOnboardingInterestedFeatures.tsxchange (which useswaitForUpcomingTransition: trueand may not have the same issue).Investigation details
Evidence chain:
InteractionManagerwithTransitionTrackerin two filesTransitionTracker.runAfterTransitionsfires synchronously whenactiveTransitions.size === 0(line 143), unlikeInteractionManagerwhich always defersScreenLayoutregisterstransitionStart→startTransition()but cleanup only removes listeners without callingendTransition()— orphaning the transition handleuseOnboardingFlowuseEffect has ~20 dependencies that change during login, causing rapid re-runs where callbacks are cancelled and re-createdPossibly related issue: #84436 (onboarding modal not showing for invited members who haven't completed onboarding)
Next Steps for Contributor+ team: Reply with
@MelvinBot implement thisto create a draft PR,@MelvinBot <your feedback>to refine this analysis, or explain why you are rejecting Melvin's proposal.29 remaining items
[-][$250] iOS - Login - Onboarding does not appear after creating a new account[/-][+][Due for payment 2026-05-20] [$250] iOS - Login - Onboarding does not appear after creating a new account[/+]melvin-bot commentedon May 13, 2026
Reviewinglabel has been removed, please complete the "BugZero Checklist".melvin-bot commentedon May 13, 2026
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.3.73-4 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2026-05-20. 🎊
For reference, here are some details about the assignees on this issue:
melvin-bot commentedon May 13, 2026
@eh2077 The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]
[-][Due for payment 2026-05-20] [$250] iOS - Login - Onboarding does not appear after creating a new account[/-][+][Due for payment 2026-05-22] [Due for payment 2026-05-20] [$250] iOS - Login - Onboarding does not appear after creating a new account[/+]melvin-bot commentedon May 15, 2026
Reviewinglabel has been removed, please complete the "BugZero Checklist".melvin-bot commentedon May 15, 2026
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.3.74-7 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2026-05-22. 🎊
For reference, here are some details about the assignees on this issue:
melvin-bot commentedon May 15, 2026
@eh2077 The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]
melvin-bot commentedon May 18, 2026
If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.
If a regression has occurred and you are the assigned CM follow the instructions here.
If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.
[-][Due for payment 2026-05-22] [Due for payment 2026-05-20] [$250] iOS - Login - Onboarding does not appear after creating a new account[/-][+][Due for payment 2026-05-26] [Due for payment 2026-05-22] [Due for payment 2026-05-20] [$250] iOS - Login - Onboarding does not appear after creating a new account[/+]melvin-bot commentedon May 19, 2026
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.3.77-3 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2026-05-26. 🎊
For reference, here are some details about the assignees on this issue:
melvin-bot commentedon May 19, 2026
@eh2077 The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]