You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[Due for payment 2026-06-10] Expensify Card - Manually add your bank account opens after selecting Log into your bank #91882
Version Number: 9.3.84-0 Reproducible in staging?: Yes Reproducible in production?: No If this was caught during regression testing, add the test name, ID and link from BrowserStack:#90302 Email or phone of affected tester (no customers):applausetester+ssndjois2jd1@applause.expensifail.com Issue reported by: Applause Internal Team Bug source: Exploratory - Significant User Experience Deterioration Device used: Mac 26.5 / Chrome App Component: Workspace Settings
Action Performed:
Precondition:
Enable Expensify Card in workspace settings.
Go to staging.new.expensify.com
Go to workspace settings > Expensify Card.
Click Issue new card.
Click Connect manually.
Click Confirm.
Enter account numbers > Next.
Click outside RHP to close it.
Click Issue new card.
Click Continue setup.
Click RHP back button 3 times to return to initial page.
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
Identify the pull request that introduced this issue and revert it.
PR #90302 refactored the USD bank account flow to use URL-based sub-page routing via the useSubPage hook. However, BankInfo.tsx was not updated to use this new pattern. It still reads reimbursementAccount.achData.subStep from Onyx to decide between Plaid and Manual:
When the user clicks "Start over", resetUSDBankAccount clears achData to DEFAULT_DATA which has no subStep field. Then when the user clicks "Log into your bank", prepareNextStep('plaid') sets achData.subStep asynchronously via Onyx.merge, but the navigation to BankInfo happens before the Onyx update resolves. BankInfo reads an empty subStep, which defaults to Manual.
Meanwhile, the parent USDVerifiedBankAccountFlowPage correctly defines firstSubPage: BANK_INFO_SUB_PAGES.PLAID and passes currentSubPage to BankInfo at line 124 — but BankInfo ignores this prop entirely because its BankInfoProps type doesn't include currentSubPage.
What changes do you think we should make in order to solve the problem?
Update BankInfo to accept and use the currentSubPage prop for determining the setup type (Plaid vs Manual), similar to how other steps like BusinessInfo use URL-based routing:
Add currentSubPage to BankInfoProps
Use currentSubPage as the primary source for setupType, falling back to achData.subStep for backward compatibility
This ensures the URL-driven routing (which correctly carries subPage=plaid) is respected, eliminating the race condition with asynchronous Onyx updates.
What alternative solutions did you explore?
An alternative would be to make setBankAccountSubStep synchronous or await it before navigating in prepareNextStep. However, this would be a workaround rather than completing the intended refactor — BankInfo should use URL-based sub-page routing like the other steps in the flow.
Next Steps for Contributor+ team: Reply with @MelvinBot implement this to create a draft PR, @MelvinBot <your feedback> to refine this analysis, or explain why you are rejecting Melvin's proposal.
Hmm I cannot reproduce this from the Wallet, Payments or Expensify Card entry points. I think this is worth taking a second look at, but in the meantime, the repro steps are quite complicated so I think it's okay to demote. cc @MrMuzyk
changed the title [-]Expensify Card - Manually add your bank account opens after selecting Log into your bank[/-][+][Due for payment 2026-06-10] Expensify Card - Manually add your bank account opens after selecting Log into your bank[/+]on Jun 3, 2026
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.3.97-1 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
@dukenv0307 The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]. If no checklist is needed for this issue, you can click: [no checklist button]
Activity
applause-bot commentedon May 27, 2026
While Applause doesn't embed attachments for this bug, here are the links for quick view:
https://platform.applause.com/services/links/v1/external/c8f5470a892e8052d10ada4d58983f67312f094ecc0929a82789cb7a34b1fd4a
melvin-bot commentedon May 27, 2026
You have been assigned to this deploy blocker because you recently merged this PR: #90302
melvin-bot commentedon May 27, 2026
💬 A slack conversation has been started in #expensify-open-source
github-actions commentedon May 27, 2026
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
MelvinBot commentedon May 27, 2026
Proposal
What is the root cause of that problem?
PR #90302 refactored the USD bank account flow to use URL-based sub-page routing via the
useSubPagehook. However,BankInfo.tsxwas not updated to use this new pattern. It still readsreimbursementAccount.achData.subStepfrom Onyx to decide between Plaid and Manual:When the user clicks "Start over",
resetUSDBankAccountclearsachDatatoDEFAULT_DATAwhich has nosubStepfield. Then when the user clicks "Log into your bank",prepareNextStep('plaid')setsachData.subStepasynchronously viaOnyx.merge, but the navigation to BankInfo happens before the Onyx update resolves. BankInfo reads an emptysubStep, which defaults to Manual.Meanwhile, the parent
USDVerifiedBankAccountFlowPagecorrectly definesfirstSubPage: BANK_INFO_SUB_PAGES.PLAIDand passescurrentSubPageto BankInfo at line 124 — but BankInfo ignores this prop entirely because itsBankInfoPropstype doesn't includecurrentSubPage.What changes do you think we should make in order to solve the problem?
Update
BankInfoto accept and use thecurrentSubPageprop for determining the setup type (Plaid vs Manual), similar to how other steps likeBusinessInfouse URL-based routing:currentSubPagetoBankInfoPropscurrentSubPageas the primary source forsetupType, falling back toachData.subStepfor backward compatibilityThis ensures the URL-driven routing (which correctly carries
subPage=plaid) is respected, eliminating the race condition with asynchronous Onyx updates.What alternative solutions did you explore?
An alternative would be to make
setBankAccountSubStepsynchronous or await it before navigating inprepareNextStep. However, this would be a workaround rather than completing the intended refactor — BankInfo should use URL-based sub-page routing like the other steps in the flow.Next Steps for Contributor+ team: Reply with
@MelvinBot implement thisto create a draft PR,@MelvinBot <your feedback>to refine this analysis, or explain why you are rejecting Melvin's proposal.arosiclair commentedon May 27, 2026
Hmm I cannot reproduce this from the Wallet, Payments or Expensify Card entry points. I think this is worth taking a second look at, but in the meantime, the repro steps are quite complicated so I think it's okay to demote. cc @MrMuzyk
13 remaining items
VickyStash commentedon Jun 1, 2026
PR is ready for review: #92100
[-]Expensify Card - Manually add your bank account opens after selecting Log into your bank[/-][+][Due for payment 2026-06-10] Expensify Card - Manually add your bank account opens after selecting Log into your bank[/+]melvin-bot commentedon Jun 3, 2026
Reviewinglabel has been removed, please complete the "BugZero Checklist".melvin-bot commentedon Jun 3, 2026
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.3.97-1 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2026-06-10. 🎊
For reference, here are some details about the assignees on this issue:
melvin-bot commentedon Jun 3, 2026
@dukenv0307 The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]. If no checklist is needed for this issue, you can click: [no checklist button]
arosiclair commentedon Jun 3, 2026
Done
melvin-bot commentedon Jun 5, 2026
If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.
If a regression has occurred and you are the assigned CM follow the instructions here.
If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.