Skip to content

[Due for payment 2026-06-10] Expensify Card - Manually add your bank account opens after selecting Log into your bank #91882

Closed

Description

@applause-bot

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 9.3.84-0
Reproducible in staging?: Yes
Reproducible in production?: No
If this was caught during regression testing, add the test name, ID and link from BrowserStack: #90302
Email or phone of affected tester (no customers): applausetester+ssndjois2jd1@applause.expensifail.com
Issue reported by: Applause Internal Team
Bug source: Exploratory - Significant User Experience Deterioration
Device used: Mac 26.5 / Chrome
App Component: Workspace Settings

Action Performed:

Precondition:

  • Enable Expensify Card in workspace settings.
  1. Go to staging.new.expensify.com
  2. Go to workspace settings > Expensify Card.
  3. Click Issue new card.
  4. Click Connect manually.
  5. Click Confirm.
  6. Enter account numbers > Next.
  7. Click outside RHP to close it.
  8. Click Issue new card.
  9. Click Continue setup.
  10. Click RHP back button 3 times to return to initial page.
  11. Click Start over > Yes, start over.
  12. Click Log into your bank.
  13. Click Confirm.

Expected Result:

Plaid flow will open.

Actual Result:

Manually add your bank account opens.

Workaround:

Unknown

Platforms:

  • Android: App
  • Android: mWeb Chrome
  • iOS: App
  • iOS: mWeb Safari
  • iOS: mWeb Chrome
  • Windows: Chrome
  • MacOS: Chrome Safari

Screenshots/Videos

Bug7164535_1779906154606.7.mp4

View all open jobs on GitHub

Applause Internal Information
Exported by: Julia Ponikarchuk
Bug ID: 7164535

Issue OwnerCurrent Issue Owner: @dukenv0307

Activity

  1. added
    DeployBlockerCashThis issue or pull request should block deployment
    BugSomething is broken. Auto assigns a BugZero manager.
    on May 27, 2026
  2. applause-bot commented on May 27, 2026

    @applause-bot
    Author

    While Applause doesn't embed attachments for this bug, here are the links for quick view:
    https://platform.applause.com/services/links/v1/external/c8f5470a892e8052d10ada4d58983f67312f094ecc0929a82789cb7a34b1fd4a

  3. melvin-bot commented on May 27, 2026

    @melvin-bot

    You have been assigned to this deploy blocker because you recently merged this PR: #90302

  4. melvin-bot commented on May 27, 2026

    @melvin-bot

    💬 A slack conversation has been started in #expensify-open-source

  5. github-actions commented on May 27, 2026

    @github-actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  6. MelvinBot commented on May 27, 2026

    @MelvinBot
    Contributor

    Proposal

    What is the root cause of that problem?

    PR #90302 refactored the USD bank account flow to use URL-based sub-page routing via the useSubPage hook. However, BankInfo.tsx was not updated to use this new pattern. It still reads reimbursementAccount.achData.subStep from Onyx to decide between Plaid and Manual:

    let setupType = reimbursementAccount?.achData?.subStep ?? '';
    const BankInfoPage = setupType === CONST.BANK_ACCOUNT.SETUP_TYPE.PLAID ? Plaid : Manual;
    

    When the user clicks "Start over", resetUSDBankAccount clears achData to DEFAULT_DATA which has no subStep field. Then when the user clicks "Log into your bank", prepareNextStep('plaid') sets achData.subStep asynchronously via Onyx.merge, but the navigation to BankInfo happens before the Onyx update resolves. BankInfo reads an empty subStep, which defaults to Manual.

    Meanwhile, the parent USDVerifiedBankAccountFlowPage correctly defines firstSubPage: BANK_INFO_SUB_PAGES.PLAID and passes currentSubPage to BankInfo at line 124 — but BankInfo ignores this prop entirely because its BankInfoProps type doesn't include currentSubPage.

    What changes do you think we should make in order to solve the problem?

    Update BankInfo to accept and use the currentSubPage prop for determining the setup type (Plaid vs Manual), similar to how other steps like BusinessInfo use URL-based routing:

    1. Add currentSubPage to BankInfoProps
    2. Use currentSubPage as the primary source for setupType, falling back to achData.subStep for backward compatibility

    This ensures the URL-driven routing (which correctly carries subPage=plaid) is respected, eliminating the race condition with asynchronous Onyx updates.

    What alternative solutions did you explore?

    An alternative would be to make setBankAccountSubStep synchronous or await it before navigating in prepareNextStep. However, this would be a workaround rather than completing the intended refactor — BankInfo should use URL-based sub-page routing like the other steps in the flow.


    Next Steps for Contributor+ team: Reply with @MelvinBot implement this to create a draft PR, @MelvinBot <your feedback> to refine this analysis, or explain why you are rejecting Melvin's proposal.

  7. arosiclair commented on May 27, 2026

    @arosiclair
    Contributor

    Hmm I cannot reproduce this from the Wallet, Payments or Expensify Card entry points. I think this is worth taking a second look at, but in the meantime, the repro steps are quite complicated so I think it's okay to demote. cc @MrMuzyk

  8. 13 remaining items

  9. VickyStash commented on Jun 1, 2026

    @VickyStash
    Contributor

    PR is ready for review: #92100

  10. added and removed
    ReviewingHas a PR in review
    on Jun 3, 2026
  11. changed the title [-]Expensify Card - Manually add your bank account opens after selecting Log into your bank[/-] [+][Due for payment 2026-06-10] Expensify Card - Manually add your bank account opens after selecting Log into your bank[/+] on Jun 3, 2026
  12. melvin-bot commented on Jun 3, 2026

    @melvin-bot

    Reviewing label has been removed, please complete the "BugZero Checklist".

  13. melvin-bot commented on Jun 3, 2026

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 9.3.97-1 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2026-06-10. 🎊

    For reference, here are some details about the assignees on this issue:

    • @VickyStash does not require payment (Contractor)
    • @MrMuzyk requires payment (Needs manual offer from BZ)
    • @dukenv0307 requires payment through NewDot Manual Requests
  14. melvin-bot commented on Jun 3, 2026

    @melvin-bot

    @dukenv0307 The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]. If no checklist is needed for this issue, you can click: [no checklist button]

  15. arosiclair commented on Jun 3, 2026

    @arosiclair
    Contributor

    Done

  16. melvin-bot commented on Jun 5, 2026

    @melvin-bot

    ⚠️ Looks like this issue was linked to a Deploy Blocker here

    If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

    If a regression has occurred and you are the assigned CM follow the instructions here.

    If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

BugSomething is broken. Auto assigns a BugZero manager.DailyKSv2

Type

No type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions