You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[Due for payment 2026-06-09] Expensify Card - "Set card rules" title is not shown when Rules are disabled #91887
Version Number: 9.3.84-0 Reproducible in staging?: Yes Reproducible in production?: N/A - new feature, doesn't exist in prod If this was caught during regression testing, add the test name, ID and link from BrowserStack:#89205 Email or phone of affected tester (no customers):applausetester+ssndjois2jd1@applause.expensifail.com Issue reported by: Applause Internal Team Bug source: Exploratory - Significant User Experience Deterioration Device used: Mac 26.5 / Chrome App Component: Workspace Settings
Action Performed:
Precondition:
Log in with Expensifail account.
Set up workspace with bank account and enable Expensify Card feature.
Do not enable Rules.
Go to staging.new.expensify.com
Go to workspace settings > Expensify Card.
Click Issue card.
Proceed to Step 4 of Issue card flow.
Expected Result:
"Set card rules" title will be shown when Rules are disabled.
Actual Result:
"Set card rules" title is not shown when Rules are disabled.
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
Identify the pull request that introduced this issue and revert it.
The "Set card rules" title at line 233-235 is gated behind this flag, so it's hidden when Rules are disabled.
However, LimitTypeStep.tsx:59 always navigates virtual cards to the SPEND_RULES step regardless of the Rules feature (isSpendRuleAvailable || cardType === VIRTUAL). This creates a mismatch: the step renders (for expiration date options) but the heading is hidden.
What changes do you think we should make in order to solve the problem?
Move the "Set card rules" title (translate('workspace.card.issueNewCard.setCardRules')) outside the isSpendRuleVisible conditional in SetSpendRulesStep.tsx so it always renders when this step is shown. The spend rule toggle and configuration UI should remain gated behind isSpendRuleVisible.
Next Steps for Contributor+ team: Reply with @MelvinBot implement this to create a draft PR, @MelvinBot <your feedback> to refine this analysis, or explain why you are rejecting Melvin's proposal.
changed the title [-]Expensify Card - "Set card rules" title is not shown when Rules are disabled[/-][+][Due for payment 2026-06-09] Expensify Card - "Set card rules" title is not shown when Rules are disabled[/+]on Jun 2, 2026
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.3.94-0 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
@luacmartins / @JS00001 The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]. If no checklist is needed for this issue, you can click: [no checklist button]
Activity
applause-bot commentedon May 27, 2026
While Applause doesn't embed attachments for this bug, here are the links for quick view:
https://platform.applause.com/services/links/v1/external/8d552d39284174048982286ea5168df9d1156ee709900105539cfc4c7674442c
melvin-bot commentedon May 27, 2026
You have been assigned to this deploy blocker because you recently merged this PR: #89205
melvin-bot commentedon May 27, 2026
💬 A slack conversation has been started in #expensify-open-source
github-actions commentedon May 27, 2026
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
MelvinBot commentedon May 27, 2026
Proposal
What is the root cause of that problem?
In
SetSpendRulesStep.tsx:62,isSpendRuleVisiblerequires the Rules feature to be enabled:The "Set card rules" title at line 233-235 is gated behind this flag, so it's hidden when Rules are disabled.
However,
LimitTypeStep.tsx:59always navigates virtual cards to theSPEND_RULESstep regardless of the Rules feature (isSpendRuleAvailable || cardType === VIRTUAL). This creates a mismatch: the step renders (for expiration date options) but the heading is hidden.What changes do you think we should make in order to solve the problem?
Move the "Set card rules" title (
translate('workspace.card.issueNewCard.setCardRules')) outside theisSpendRuleVisibleconditional inSetSpendRulesStep.tsxso it always renders when this step is shown. The spend rule toggle and configuration UI should remain gated behindisSpendRuleVisible.Next Steps for Contributor+ team: Reply with
@MelvinBot implement thisto create a draft PR,@MelvinBot <your feedback>to refine this analysis, or explain why you are rejecting Melvin's proposal.luacmartins commentedon May 27, 2026
Feature is behind a beta. NAB.
4 remaining items
jponikarchuk commentedon Jun 2, 2026
Deploy Blocker #92391 was identified to be related to the PR #92009 that attempted to fix this issue.
[-]Expensify Card - "Set card rules" title is not shown when Rules are disabled[/-][+][Due for payment 2026-06-09] Expensify Card - "Set card rules" title is not shown when Rules are disabled[/+]melvin-bot commentedon Jun 2, 2026
Reviewinglabel has been removed, please complete the "BugZero Checklist".melvin-bot commentedon Jun 2, 2026
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.3.94-0 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2026-06-09. 🎊
melvin-bot commentedon Jun 2, 2026
@luacmartins / @JS00001 The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]. If no checklist is needed for this issue, you can click: [no checklist button]