Skip to content

[Due for payment 2026-06-09] Expensify Card - "Set card rules" title is not shown when Rules are disabled #91887

Closed

Description

@applause-bot

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 9.3.84-0
Reproducible in staging?: Yes
Reproducible in production?: N/A - new feature, doesn't exist in prod
If this was caught during regression testing, add the test name, ID and link from BrowserStack: #89205
Email or phone of affected tester (no customers): applausetester+ssndjois2jd1@applause.expensifail.com
Issue reported by: Applause Internal Team
Bug source: Exploratory - Significant User Experience Deterioration
Device used: Mac 26.5 / Chrome
App Component: Workspace Settings

Action Performed:

Precondition:

  • Log in with Expensifail account.
  • Set up workspace with bank account and enable Expensify Card feature.
  • Do not enable Rules.
  1. Go to staging.new.expensify.com
  2. Go to workspace settings > Expensify Card.
  3. Click Issue card.
  4. Proceed to Step 4 of Issue card flow.

Expected Result:

"Set card rules" title will be shown when Rules are disabled.

Actual Result:

"Set card rules" title is not shown when Rules are disabled.

Workaround:

Unknown

Platforms:

  • Android: App
  • Android: mWeb Chrome
  • iOS: App
  • iOS: mWeb Safari
  • iOS: mWeb Chrome
  • Windows: Chrome
  • MacOS: Chrome Safari

Screenshots/Videos

Bug7164553_1779907183312.9.mp4

View all open jobs on GitHub

Applause Internal Information
Exported by: Svetlana Lazutkina
Bug ID: 7164553

Issue OwnerCurrent Issue Owner: @JS00001

Activity

  1. added
    BugSomething is broken. Auto assigns a BugZero manager.
    on May 27, 2026
  2. applause-bot commented on May 27, 2026

    @applause-bot
    Author

    While Applause doesn't embed attachments for this bug, here are the links for quick view:
    https://platform.applause.com/services/links/v1/external/8d552d39284174048982286ea5168df9d1156ee709900105539cfc4c7674442c

  3. melvin-bot commented on May 27, 2026

    @melvin-bot

    You have been assigned to this deploy blocker because you recently merged this PR: #89205

  4. melvin-bot commented on May 27, 2026

    @melvin-bot

    💬 A slack conversation has been started in #expensify-open-source

  5. github-actions commented on May 27, 2026

    @github-actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  6. MelvinBot commented on May 27, 2026

    @MelvinBot
    Contributor

    Proposal

    What is the root cause of that problem?

    In SetSpendRulesStep.tsx:62, isSpendRuleVisible requires the Rules feature to be enabled:

    const isSpendRuleVisible = !isProduction && isPolicyFeatureEnabled(policy, CONST.POLICY.MORE_FEATURES.ARE_RULES_ENABLED);

    The "Set card rules" title at line 233-235 is gated behind this flag, so it's hidden when Rules are disabled.

    However, LimitTypeStep.tsx:59 always navigates virtual cards to the SPEND_RULES step regardless of the Rules feature (isSpendRuleAvailable || cardType === VIRTUAL). This creates a mismatch: the step renders (for expiration date options) but the heading is hidden.

    What changes do you think we should make in order to solve the problem?

    Move the "Set card rules" title (translate('workspace.card.issueNewCard.setCardRules')) outside the isSpendRuleVisible conditional in SetSpendRulesStep.tsx so it always renders when this step is shown. The spend rule toggle and configuration UI should remain gated behind isSpendRuleVisible.


    Next Steps for Contributor+ team: Reply with @MelvinBot implement this to create a draft PR, @MelvinBot <your feedback> to refine this analysis, or explain why you are rejecting Melvin's proposal.

  7. luacmartins commented on May 27, 2026

    @luacmartins
    Contributor

    Feature is behind a beta. NAB.

  8. 4 remaining items

  9. jponikarchuk commented on Jun 2, 2026

    @jponikarchuk

    Deploy Blocker #92391 was identified to be related to the PR #92009 that attempted to fix this issue.

  10. added and removed
    ReviewingHas a PR in review
    on Jun 2, 2026
  11. changed the title [-]Expensify Card - "Set card rules" title is not shown when Rules are disabled[/-] [+][Due for payment 2026-06-09] Expensify Card - "Set card rules" title is not shown when Rules are disabled[/+] on Jun 2, 2026
  12. melvin-bot commented on Jun 2, 2026

    @melvin-bot

    Reviewing label has been removed, please complete the "BugZero Checklist".

  13. melvin-bot commented on Jun 2, 2026

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 9.3.94-0 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2026-06-09. 🎊

  14. melvin-bot commented on Jun 2, 2026

    @melvin-bot

    @luacmartins / @JS00001 The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]. If no checklist is needed for this issue, you can click: [no checklist button]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

BugSomething is broken. Auto assigns a BugZero manager.DailyKSv2Engineering

Type

No type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions