Repository navigation
Description
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Version Number: 9.3.91-4
Reproducible in staging?: Yes
Reproducible in production?: N/A - new feature, doesn't exist in prod
If this was caught during regression testing, add the test name, ID and link from BrowserStack: #92009
Email or phone of affected tester (no customers): #92009
Issue reported by: Applause Internal Team
Bug source: Exploratory - Significant User Experience Deterioration
Device used: Mac 26.5 / Chrome
App Component: Workspace Settings
Action Performed:
Precondition:
- Log in with Expensifail account.
- Set up workspace with bank account and enable Expensify Card feature.
- Enable Rules.
- Go to staging.new.expensify.com
- Go to workspace settings > Expensify Card.
- Click Issue card.
- Select user.
- Select Virtual card.
- Select limit type and enter amount > Next.
- Enable Spend rule, then enter any rule details.
- Enable Expiration date, then add dates.
- Proceed to confirm page.
- On confirm page, click Card type and select Physical card.
- Click outside RHP to close the RHp.
- Go to workspace settings > More features.
- Disable Rules.
- Go to workspace settings > Expensify Card.
- Click Issue card.
- On confirm page, click Restriction.
Expected Result:
When Rules are disabled and physical card is selected, Confirm page will no longer show Restriction field.
Actual Result:
When Rules are disabled and physical card is selected, Confirm page shows Restriction field, which opens blank Set card rules page.
Workaround:
Unknown
Platforms:
- Android: App
- Android: mWeb Chrome
- iOS: App
- iOS: mWeb Safari
- iOS: mWeb Chrome
- Windows: Chrome
- MacOS: Chrome Safari
Screenshots/Videos
Bug7169702_1780413635917.15.mp4
Applause Internal Information
Exported by: Julia Ponikarchuk
Bug ID: 7169702
Upwork Automation - Do Not Edit
- Upwork Job URL: https://www.upwork.com/jobs/~022061861361060511942
- Upwork Job ID: 2061861361060511942
- Last Price Increase: 2026-06-23
Issue Owner
Current Issue Owner: @mallenexpensifyMetadata
Metadata
Assignees
Labels
Type
Projects
- StatusShow more project fieldsDone
Activity
applause-bot commentedon Jun 2, 2026
While Applause doesn't embed attachments for this bug, here are the links for quick view:
https://platform.applause.com/services/links/v1/external/bb6dd6399a7d179b57d5202b14faa0fe2631077048a04370458e709cbaa795d9
melvin-bot commentedon Jun 2, 2026
You have been assigned to this deploy blocker because you recently merged this PR: #92009
melvin-bot commentedon Jun 2, 2026
💬 A slack conversation has been started in #expensify-open-source
github-actions commentedon Jun 2, 2026
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
JS00001 commentedon Jun 2, 2026
demoting, locked behind staging
MelvinBot commentedon Jun 2, 2026
Proposal
What is the root cause of that problem?
The Confirmation step shows the Restriction field based only on the persisted
spendRuleEnabledflag — it never checks whether the Rules feature is still enabled on the workspace.In
ConfirmationStep.tsx:55:This flag drives the Restriction menu item at
ConfirmationStep.tsx:209-216.The repro chain:
spendRuleEnabled: trueinto the RAM-only issue-new-card Onyx data.CONFIRMATIONstep.spendRuleEnabled === true, so it keeps rendering the Restriction field.SetSpendRulesStep, which correctly gates all of its content on the Rules feature viaisSpendRuleVisible(SetSpendRulesStep.tsx:62) — nowfalse— so only the header renders and the page looks blank.So the two pages are inconsistent:
SetSpendRulesStephides the spend‑rule UI when Rules is off, butConfirmationStepdoes not.What changes do you think we should make in order to solve the problem?
Gate the Restriction field on the Rules feature using the same check
SetSpendRulesStepalready uses (isPolicyFeatureEnabled(policy, CONST.POLICY.MORE_FEATURES.ARE_RULES_ENABLED)), soisSpendRuleAppliedis onlytruewhen both the persisted flag is set and the feature is currently enabled.This hides the Restriction field whenever Rules is disabled and makes the blank
Set card rulespage unreachable from confirm.policyis already available in the component, so no new data is needed.What alternative solutions did you explore? (Optional)
Clearing
spendRuleEnabledfrom the issue-new-card data when the Rules feature is toggled off (or resetting the abandoned flow on re-entry). This addresses the stale-data source directly but is a larger change; the display gate above is the minimal fix and keeps the two pages consistent.Confidence & evidence
Confidence: High — code-only repro, mechanism fully traced, and the fix mirrors an existing pattern in the same flow. Introduced alongside the Confirmation-step Restriction field added in #92009.
Next Steps for Contributor+ team:
To accept:
@MelvinBot implement [this](https://github.com/Expensify/App/issues/92391)to create a draft PR.To refine:
@MelvinBot <your feedback>To reject: Explain why you are rejecting Melvin's proposal.
40 remaining items
sobitneupane commentedon Jun 15, 2026
@JS00001 Payment for the issue is still pending. #92391 (comment)
sobitneupane commentedon Jun 22, 2026
@JS00001 Payment for the issue is still pending. #92391 (comment)
JS00001 commentedon Jun 22, 2026
@sobitneupane this was a regression right, not the main tracking issue?
melvin-bot commentedon Jun 22, 2026
Triggered auto assignment to @mallenexpensify (
Awaiting Payment)melvin-bot commentedon Jun 22, 2026
Payment Summary
Upwork Job
BugZero Checklist (@mallenexpensify)
sobitneupane commentedon Jun 23, 2026
@JS00001 It seems like it is. I didn't review the PR assicated with the blocker, though. So, I believe payment is due here.
sobitneupane commentedon Jun 23, 2026
BugZero Checklist:
[Contributor] The offending PR and associated issue have been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.
Link to the comment on the PR: Fix card rule issuing blockers #92009 (comment)
Link to the comment on the Issue: [Due for payment 2026-06-09] Expensify Card - Spend rule row does not appear on confirm page when it is enabled #91894 (comment)
[Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.
Link to discussion:
[Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.
[BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.
Link to issue: https://github.com/Expensify/Expensify/issues/651611
Regression Test Proposal
Test:
Do we agree 👍 or 👎
Zapier Logs
Run ID: 00040eee-8a1c-ac09-b97f-79e54ac55ae4JS00001 commentedon Jun 23, 2026
Right, sounds good!
melvin-bot commentedon Jun 23, 2026
📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸
mallenexpensify commentedon Jun 23, 2026
Payment Summary
Contributor+: @sobitneupane due $250 via NewDot
^ Test case created. Thx
JmillsExpensify commentedon Jul 28, 2026
$250 approved for @sobitneupane