Skip to content

[Due for payment 2026-06-09] Expensify Card - Spend rule row does not appear on confirm page when it is enabled #91894

Closed

Description

@applause-bot

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 9.3.84-0
Reproducible in staging?: Yes
Reproducible in production?: N/A - new feature, doesn't exist in prod
If this was caught during regression testing, add the test name, ID and link from BrowserStack: #89205
Email or phone of affected tester (no customers): applausetester+ssndjois2jd1@applause.expensifail.com
Issue reported by: Applause Internal Team
Bug source: Exploratory - Significant User Experience Deterioration
Device used: Mac 26.5 / Chrome
App Component: Workspace Settings

Action Performed:

Precondition:

  • Log in with Expensifail account.
  • Set up workspace with bank account and set up Expensify Card.
  • Enable Rules.
  1. Go to staging.new.expensify.com
  2. Go to workspace settings > Expensify Card.
  3. Click Issue card.
  4. Proceed to Step 4 of Issue card flow.
  5. Enable Add spend rule.
  6. Click Create new.
  7. Enter the new rule info.
  8. Click Next.
  9. Enter name > Next.

Expected Result:

Spend rule row will appear on confirm page so user can click on it to edit the rule.

Actual Result:

Spend rule row does not appear on confirm page when it is enabled.

Workaround:

Unknown

Platforms:

  • Android: App
  • Android: mWeb Chrome
  • iOS: App
  • iOS: mWeb Safari
  • iOS: mWeb Chrome
  • Windows: Chrome
  • MacOS: Chrome Safari

Screenshots/Videos

11.mp4

View all open jobs on GitHub

Applause Internal Information
Exported by: Svetlana Lazutkina
Bug ID: 7164562

Issue OwnerCurrent Issue Owner: @JS00001

Activity

  1. applause-bot commented on May 27, 2026

    @applause-bot
    Author

    While Applause doesn't embed attachments for this bug, here are the links for quick view:
    https://platform.applause.com/services/links/v1/external/95487833ccb474373fdb7f0f6557884d9ce40933d7b58ff5e199bc22d4d9d738

  2. added
    BugSomething is broken. Auto assigns a BugZero manager.
    on May 27, 2026
  3. melvin-bot commented on May 27, 2026

    @melvin-bot

    You have been assigned to this deploy blocker because you recently merged this PR: #89205

  4. melvin-bot commented on May 27, 2026

    @melvin-bot

    💬 A slack conversation has been started in #expensify-open-source

  5. github-actions commented on May 27, 2026

    @github-actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  6. MelvinBot commented on May 27, 2026

    @MelvinBot
    Contributor

    Proposal

    What is the root cause of that problem?

    The ConfirmationStep.tsx component never renders a row for spend rules. The spend rule data (spendRuleEnabled, spendRuleValue, spendRuleOption, spendRuleID) is correctly stored in the RAM_ONLY_ISSUE_NEW_EXPENSIFY_CARD Onyx key by the SetSpendRulesStep, and ConfirmationStep reads from that same key (line 45-49), but no MenuItemWithTopDescription was ever added to display the spend rule information. The confirmation page only renders rows for cardholder, card type, limit, limit type, expiration date, and card name.

    What changes do you think we should make in order to solve the problem?

    Add a conditionally-rendered MenuItemWithTopDescription for spend rules in ConfirmationStep.tsx, shown when data?.spendRuleEnabled is true. It should display a summary of the configured spend rule (e.g., rule name or restriction details) and navigate to CONST.EXPENSIFY_CARD.STEP.SPEND_RULES on press to allow editing — similar to how the expiration date row already references that step (line 175). The row should be placed between the expiration date and card name rows, and gated behind the same rules-enabled feature flag used in SetSpendRulesStep.


    Next Steps for Contributor+ team: Reply with @MelvinBot implement this to create a draft PR, @MelvinBot <your feedback> to refine this analysis, or explain why you are rejecting Melvin's proposal.

  7. luacmartins commented on May 27, 2026

    @luacmartins
    Contributor

    Feature is behind a beta. NAB.

  8. 7 remaining items

  9. JS00001 commented on Jun 2, 2026

    @JS00001
    Contributor

    This is fixed on staging

  10. JmillsExpensify commented on Jun 2, 2026

    @JmillsExpensify
    Contributor

    Nice, thanks!

  11. jponikarchuk commented on Jun 2, 2026

    @jponikarchuk

    Deploy Blocker #92391 was identified to be related to the PR #92009 that attempted to fix this issue.

  12. added and removed
    ReviewingHas a PR in review
    on Jun 2, 2026
  13. changed the title [-]Expensify Card - Spend rule row does not appear on confirm page when it is enabled[/-] [+][Due for payment 2026-06-09] Expensify Card - Spend rule row does not appear on confirm page when it is enabled[/+] on Jun 2, 2026
  14. melvin-bot commented on Jun 2, 2026

    @melvin-bot

    Reviewing label has been removed, please complete the "BugZero Checklist".

  15. melvin-bot commented on Jun 2, 2026

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 9.3.94-0 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2026-06-09. 🎊

  16. melvin-bot commented on Jun 2, 2026

    @melvin-bot

    @luacmartins / @JS00001 The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]. If no checklist is needed for this issue, you can click: [no checklist button]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

BugSomething is broken. Auto assigns a BugZero manager.DailyKSv2Engineering

Type

No type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions