You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[Due for payment 2026-06-09] Expensify Card - Spend rule row does not appear on confirm page when it is enabled #91894
Version Number: 9.3.84-0 Reproducible in staging?: Yes Reproducible in production?: N/A - new feature, doesn't exist in prod If this was caught during regression testing, add the test name, ID and link from BrowserStack:#89205 Email or phone of affected tester (no customers):applausetester+ssndjois2jd1@applause.expensifail.com Issue reported by: Applause Internal Team Bug source: Exploratory - Significant User Experience Deterioration Device used: Mac 26.5 / Chrome App Component: Workspace Settings
Action Performed:
Precondition:
Log in with Expensifail account.
Set up workspace with bank account and set up Expensify Card.
Enable Rules.
Go to staging.new.expensify.com
Go to workspace settings > Expensify Card.
Click Issue card.
Proceed to Step 4 of Issue card flow.
Enable Add spend rule.
Click Create new.
Enter the new rule info.
Click Next.
Enter name > Next.
Expected Result:
Spend rule row will appear on confirm page so user can click on it to edit the rule.
Actual Result:
Spend rule row does not appear on confirm page when it is enabled.
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
Identify the pull request that introduced this issue and revert it.
The ConfirmationStep.tsx component never renders a row for spend rules. The spend rule data (spendRuleEnabled, spendRuleValue, spendRuleOption, spendRuleID) is correctly stored in the RAM_ONLY_ISSUE_NEW_EXPENSIFY_CARD Onyx key by the SetSpendRulesStep, and ConfirmationStep reads from that same key (line 45-49), but no MenuItemWithTopDescription was ever added to display the spend rule information. The confirmation page only renders rows for cardholder, card type, limit, limit type, expiration date, and card name.
What changes do you think we should make in order to solve the problem?
Add a conditionally-rendered MenuItemWithTopDescription for spend rules in ConfirmationStep.tsx, shown when data?.spendRuleEnabled is true. It should display a summary of the configured spend rule (e.g., rule name or restriction details) and navigate to CONST.EXPENSIFY_CARD.STEP.SPEND_RULES on press to allow editing — similar to how the expiration date row already references that step (line 175). The row should be placed between the expiration date and card name rows, and gated behind the same rules-enabled feature flag used in SetSpendRulesStep.
Next Steps for Contributor+ team: Reply with @MelvinBot implement this to create a draft PR, @MelvinBot <your feedback> to refine this analysis, or explain why you are rejecting Melvin's proposal.
changed the title [-]Expensify Card - Spend rule row does not appear on confirm page when it is enabled[/-][+][Due for payment 2026-06-09] Expensify Card - Spend rule row does not appear on confirm page when it is enabled[/+]on Jun 2, 2026
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.3.94-0 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
@luacmartins / @JS00001 The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]. If no checklist is needed for this issue, you can click: [no checklist button]
Activity
applause-bot commentedon May 27, 2026
While Applause doesn't embed attachments for this bug, here are the links for quick view:
https://platform.applause.com/services/links/v1/external/95487833ccb474373fdb7f0f6557884d9ce40933d7b58ff5e199bc22d4d9d738
melvin-bot commentedon May 27, 2026
You have been assigned to this deploy blocker because you recently merged this PR: #89205
melvin-bot commentedon May 27, 2026
💬 A slack conversation has been started in #expensify-open-source
github-actions commentedon May 27, 2026
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
MelvinBot commentedon May 27, 2026
Proposal
What is the root cause of that problem?
The
ConfirmationStep.tsxcomponent never renders a row for spend rules. The spend rule data (spendRuleEnabled,spendRuleValue,spendRuleOption,spendRuleID) is correctly stored in theRAM_ONLY_ISSUE_NEW_EXPENSIFY_CARDOnyx key by theSetSpendRulesStep, andConfirmationStepreads from that same key (line 45-49), but noMenuItemWithTopDescriptionwas ever added to display the spend rule information. The confirmation page only renders rows for cardholder, card type, limit, limit type, expiration date, and card name.What changes do you think we should make in order to solve the problem?
Add a conditionally-rendered
MenuItemWithTopDescriptionfor spend rules inConfirmationStep.tsx, shown whendata?.spendRuleEnabledis true. It should display a summary of the configured spend rule (e.g., rule name or restriction details) and navigate toCONST.EXPENSIFY_CARD.STEP.SPEND_RULESon press to allow editing — similar to how the expiration date row already references that step (line 175). The row should be placed between the expiration date and card name rows, and gated behind the same rules-enabled feature flag used inSetSpendRulesStep.Next Steps for Contributor+ team: Reply with
@MelvinBot implement thisto create a draft PR,@MelvinBot <your feedback>to refine this analysis, or explain why you are rejecting Melvin's proposal.luacmartins commentedon May 27, 2026
Feature is behind a beta. NAB.
7 remaining items
JS00001 commentedon Jun 2, 2026
This is fixed on staging
JmillsExpensify commentedon Jun 2, 2026
Nice, thanks!
jponikarchuk commentedon Jun 2, 2026
Deploy Blocker #92391 was identified to be related to the PR #92009 that attempted to fix this issue.
[-]Expensify Card - Spend rule row does not appear on confirm page when it is enabled[/-][+][Due for payment 2026-06-09] Expensify Card - Spend rule row does not appear on confirm page when it is enabled[/+]melvin-bot commentedon Jun 2, 2026
Reviewinglabel has been removed, please complete the "BugZero Checklist".melvin-bot commentedon Jun 2, 2026
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.3.94-0 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2026-06-09. 🎊
melvin-bot commentedon Jun 2, 2026
@luacmartins / @JS00001 The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]. If no checklist is needed for this issue, you can click: [no checklist button]