You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[Due for payment 2026-06-09] Expensify Card - Choose a rule page is blank after refreshing the page #91898
Version Number: 9.3.84-0 Reproducible in staging?: Yes Reproducible in production?: N/A - new feature, doesn't exist in prod If this was caught during regression testing, add the test name, ID and link from BrowserStack:#89205 Email or phone of affected tester (no customers):applausetester+ssndjois2jd1@applause.expensifail.com Issue reported by: Applause Internal Team Bug source: Exploratory - Significant User Experience Deterioration Device used: Mac 26.5 / Chrome App Component: Workspace Settings
Action Performed:
Precondition:
Log in with Expensifail account.
Set up workspace with bank account and set up Expensify Card.
Enable Rules.
Go to staging.new.expensify.com
Go to workspace settings > Expensify Card.
Click Issue card.
Proceed to Step 4 of Issue card flow.
Enable Add spend rule.
Click Choose a rule.
Expected Result:
Choose a rule page will show spend rule list after refreshing the page.
Actual Result:
Choose a rule page is blank after refreshing the page.
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
Identify the pull request that introduced this issue and revert it.
The issue-new-card flow stores all its data (including the selected currency) in a RAM-only Onyx key (RAM_ONLY_ISSUE_NEW_EXPENSIFY_CARD). On browser refresh, this key is wiped because it's explicitly excluded from persistence.
SpendRuleSelectionPage.tsx:48 filters rules by issueCardForm?.data?.currency. After refresh, issueCardForm is undefined, so the currency comparison becomes cardRule.currencyCode === undefined — filtering out all rules and producing an empty list.
Meanwhile, lines 96–97 check the unfilteredcardRules for the empty-state vs content decision. Since unfiltered rules exist, it renders the SelectionList — but with zero items, resulting in a blank page.
What changes do you think we should make in order to solve the problem?
The SpendRuleSelectionPage should detect when issueCardForm is missing (i.e., the RAM-only data was lost on refresh) and redirect the user back to the beginning of the issue-new-card flow, similar to how other multi-step flows in the app handle refresh. This ensures users don't land on a broken intermediate page with no data.
Specifically, add an early return in SpendRuleSelectionPage that checks if issueCardForm?.data?.currency is undefined and, if so, navigates back to the start of the flow (or uses Navigation.goBack).
What alternative solutions did you explore? (Optional)
An alternative would be to remove the currency filter when issueCardForm data is missing and show all rules. However, this breaks the intended business logic (cards and rules must share the same currency) and would allow invalid rule selection. Redirecting back to the flow start is the safer approach, consistent with how other multi-step flows handle data loss on refresh.
Next Steps for Contributor+ team: Reply with @MelvinBot implement this to create a draft PR, @MelvinBot <your feedback> to refine this analysis, or explain why you are rejecting Melvin's proposal.
changed the title [-]Expensify Card - Choose a rule page is blank after refreshing the page[/-][+][Due for payment 2026-06-09] Expensify Card - Choose a rule page is blank after refreshing the page[/+]on Jun 2, 2026
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.3.94-0 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
@luacmartins / @JS00001 The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]. If no checklist is needed for this issue, you can click: [no checklist button]
Activity
applause-bot commentedon May 27, 2026
While Applause doesn't embed attachments for this bug, here are the links for quick view:
https://platform.applause.com/services/links/v1/external/ab1a3108d77d4441a341de26e243852d6afee49e09a7e77915e5b64dd391c9fc
melvin-bot commentedon May 27, 2026
You have been assigned to this deploy blocker because you recently merged this PR: #89205
melvin-bot commentedon May 27, 2026
💬 A slack conversation has been started in #expensify-open-source
github-actions commentedon May 27, 2026
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
MelvinBot commentedon May 27, 2026
Proposal
What is the root cause of that problem?
The issue-new-card flow stores all its data (including the selected currency) in a RAM-only Onyx key (
RAM_ONLY_ISSUE_NEW_EXPENSIFY_CARD). On browser refresh, this key is wiped because it's explicitly excluded from persistence.SpendRuleSelectionPage.tsx:48filters rules byissueCardForm?.data?.currency. After refresh,issueCardFormisundefined, so the currency comparison becomescardRule.currencyCode === undefined— filtering out all rules and producing an empty list.Meanwhile, lines 96–97 check the unfiltered
cardRulesfor the empty-state vs content decision. Since unfiltered rules exist, it renders theSelectionList— but with zero items, resulting in a blank page.What changes do you think we should make in order to solve the problem?
The
SpendRuleSelectionPageshould detect whenissueCardFormis missing (i.e., the RAM-only data was lost on refresh) and redirect the user back to the beginning of the issue-new-card flow, similar to how other multi-step flows in the app handle refresh. This ensures users don't land on a broken intermediate page with no data.Specifically, add an early return in
SpendRuleSelectionPagethat checks ifissueCardForm?.data?.currencyis undefined and, if so, navigates back to the start of the flow (or usesNavigation.goBack).What alternative solutions did you explore? (Optional)
An alternative would be to remove the currency filter when
issueCardFormdata is missing and show all rules. However, this breaks the intended business logic (cards and rules must share the same currency) and would allow invalid rule selection. Redirecting back to the flow start is the safer approach, consistent with how other multi-step flows handle data loss on refresh.Next Steps for Contributor+ team: Reply with
@MelvinBot implement thisto create a draft PR,@MelvinBot <your feedback>to refine this analysis, or explain why you are rejecting Melvin's proposal.luacmartins commentedon May 27, 2026
Feature is behind a beta. NAB
2 remaining items
jponikarchuk commentedon Jun 2, 2026
Deploy Blocker #92391 was identified to be related to the PR #92009 that attempted to fix this issue.
melvin-bot commentedon Jun 2, 2026
Reviewinglabel has been removed, please complete the "BugZero Checklist".[-]Expensify Card - Choose a rule page is blank after refreshing the page[/-][+][Due for payment 2026-06-09] Expensify Card - Choose a rule page is blank after refreshing the page[/+]melvin-bot commentedon Jun 2, 2026
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.3.94-0 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2026-06-09. 🎊
melvin-bot commentedon Jun 2, 2026
@luacmartins / @JS00001 The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]. If no checklist is needed for this issue, you can click: [no checklist button]