Skip to content

[Due for payment 2026-06-09] Expensify Card - Choose a rule page is blank after refreshing the page #91898

Closed

Description

@applause-bot

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 9.3.84-0
Reproducible in staging?: Yes
Reproducible in production?: N/A - new feature, doesn't exist in prod
If this was caught during regression testing, add the test name, ID and link from BrowserStack: #89205
Email or phone of affected tester (no customers): applausetester+ssndjois2jd1@applause.expensifail.com
Issue reported by: Applause Internal Team
Bug source: Exploratory - Significant User Experience Deterioration
Device used: Mac 26.5 / Chrome
App Component: Workspace Settings

Action Performed:

Precondition:

  • Log in with Expensifail account.
  • Set up workspace with bank account and set up Expensify Card.
  • Enable Rules.
  1. Go to staging.new.expensify.com
  2. Go to workspace settings > Expensify Card.
  3. Click Issue card.
  4. Proceed to Step 4 of Issue card flow.
  5. Enable Add spend rule.
  6. Click Choose a rule.

Expected Result:

Choose a rule page will show spend rule list after refreshing the page.

Actual Result:

Choose a rule page is blank after refreshing the page.

Workaround:

Unknown

Platforms:

  • Android: App
  • Android: mWeb Chrome
  • iOS: App
  • iOS: mWeb Safari
  • iOS: mWeb Chrome
  • Windows: Chrome
  • MacOS: Chrome Safari

Screenshots/Videos

Bug7164580_1779909054045.14.mp4

View all open jobs on GitHub

Applause Internal Information
Exported by: Svetlana Lazutkina
Bug ID: 7164580

Issue OwnerCurrent Issue Owner: @JS00001

Activity

  1. applause-bot commented on May 27, 2026

    @applause-bot
    Author

    While Applause doesn't embed attachments for this bug, here are the links for quick view:
    https://platform.applause.com/services/links/v1/external/ab1a3108d77d4441a341de26e243852d6afee49e09a7e77915e5b64dd391c9fc

  2. added
    DeployBlockerCashThis issue or pull request should block deployment
    BugSomething is broken. Auto assigns a BugZero manager.
    on May 27, 2026
  3. melvin-bot commented on May 27, 2026

    @melvin-bot

    You have been assigned to this deploy blocker because you recently merged this PR: #89205

  4. melvin-bot commented on May 27, 2026

    @melvin-bot

    💬 A slack conversation has been started in #expensify-open-source

  5. github-actions commented on May 27, 2026

    @github-actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  6. MelvinBot commented on May 27, 2026

    @MelvinBot
    Contributor

    Proposal

    What is the root cause of that problem?

    The issue-new-card flow stores all its data (including the selected currency) in a RAM-only Onyx key (RAM_ONLY_ISSUE_NEW_EXPENSIFY_CARD). On browser refresh, this key is wiped because it's explicitly excluded from persistence.

    SpendRuleSelectionPage.tsx:48 filters rules by issueCardForm?.data?.currency. After refresh, issueCardForm is undefined, so the currency comparison becomes cardRule.currencyCode === undefined — filtering out all rules and producing an empty list.

    Meanwhile, lines 96–97 check the unfiltered cardRules for the empty-state vs content decision. Since unfiltered rules exist, it renders the SelectionList — but with zero items, resulting in a blank page.

    What changes do you think we should make in order to solve the problem?

    The SpendRuleSelectionPage should detect when issueCardForm is missing (i.e., the RAM-only data was lost on refresh) and redirect the user back to the beginning of the issue-new-card flow, similar to how other multi-step flows in the app handle refresh. This ensures users don't land on a broken intermediate page with no data.

    Specifically, add an early return in SpendRuleSelectionPage that checks if issueCardForm?.data?.currency is undefined and, if so, navigates back to the start of the flow (or uses Navigation.goBack).

    What alternative solutions did you explore? (Optional)

    An alternative would be to remove the currency filter when issueCardForm data is missing and show all rules. However, this breaks the intended business logic (cards and rules must share the same currency) and would allow invalid rule selection. Redirecting back to the flow start is the safer approach, consistent with how other multi-step flows handle data loss on refresh.


    Next Steps for Contributor+ team: Reply with @MelvinBot implement this to create a draft PR, @MelvinBot <your feedback> to refine this analysis, or explain why you are rejecting Melvin's proposal.

  7. luacmartins commented on May 27, 2026

    @luacmartins
    Contributor

    Feature is behind a beta. NAB

  8. added and removed
    DeployBlockerCashThis issue or pull request should block deployment
    on May 27, 2026
  9. 2 remaining items

  10. jponikarchuk commented on Jun 2, 2026

    @jponikarchuk

    Deploy Blocker #92391 was identified to be related to the PR #92009 that attempted to fix this issue.

  11. added and removed
    ReviewingHas a PR in review
    on Jun 2, 2026
  12. melvin-bot commented on Jun 2, 2026

    @melvin-bot

    Reviewing label has been removed, please complete the "BugZero Checklist".

  13. changed the title [-]Expensify Card - Choose a rule page is blank after refreshing the page[/-] [+][Due for payment 2026-06-09] Expensify Card - Choose a rule page is blank after refreshing the page[/+] on Jun 2, 2026
  14. melvin-bot commented on Jun 2, 2026

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 9.3.94-0 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2026-06-09. 🎊

  15. melvin-bot commented on Jun 2, 2026

    @melvin-bot

    @luacmartins / @JS00001 The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]. If no checklist is needed for this issue, you can click: [no checklist button]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

BugSomething is broken. Auto assigns a BugZero manager.DailyKSv2Engineering

Type

No type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions